On Fri, Jul 19, 2013 at 09:34 +0200, Marc Kleine-Budde wrote:
>
> On 07/18/2013 10:20 PM, Gerhard Sittig wrote:
> > extend the mscan(4) driver with alternative support for the COMMON_CLK
> > approach which is an option in the MPC512x platform, keep the existing
> > clock s
On Thu, Jul 18, 2013 at 21:33 +0100, Russell King - ARM Linux wrote:
>
> On Thu, Jul 18, 2013 at 10:20:52PM +0200, Gerhard Sittig wrote:
> > + /* enable clock for the I2C peripheral (non fatal) */
> > + clk = of_clk_get_by_name(node, "per&quo
transition to the COMMON_CLK framework has completed for the MPC512x
platform, remove the now obsolete code path of the mpc5xxx mscan
driver which accessed clock control module registers directly
Signed-off-by: Gerhard Sittig
---
drivers/net/can/mscan/mpc5xxx_can.c | 136
completely switch to, i.e. unconditionally use COMMON_CLK for the
MPC512x platform, and retire the PPC_CLOCK implementation for that
platform after the transition has completed
Signed-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/Kconfig | 14 +-
arch/powerpc/platforms/512x/Makefile
device tree based clock lookup, must prepare clocks before enabling
them, unprepare after disable, error check in the clock setup
Signed-off-by: Gerhard Sittig
---
drivers/media/platform/fsl-viu.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/media
ff-by: Gerhard Sittig
---
arch/powerpc/sysdev/fsl_pci.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
index 46ac1dd..cb2ed92 100644
--- a/arch/powerpc/sysdev/fsl_pci.c
+++ b/arch/powerpc/sysdev/fsl_pci.c
@@ -17,6
tree specs for clocks, but failure to enable a specified
clock is considered fatal
Signed-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/clock-commonclk.c |1 -
.../net/ethernet/freescale/fs_enet/fs_enet-main.c | 27 +++-
include/linux/fs_enet
device tree based clock lookup in the MPC512x initialization (lookup
'per' for register access), add error check in the clock setup, must
prepare clocks before they can get enabled, unprepare after disable
Signed-off-by: Gerhard Sittig
---
drivers/usb/host/fsl-mph-dr-o
make the MPC I2C driver prepare and enable the peripheral clock
('per' for register access) in the MPC512x setup routine,
make this clock setup non-fatal to allow for a migration period,
remove the pre-enabling hack in the platform's clock driver
Signed-off-by: Gerhard Sittig
--
shall succeed
upon first try in the usual case, will test a few less desirable yet
acceptable frequencies in edge cases, and will fallback to "best effort"
if none of the previously tried frequencies pass the test
Signed-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/clock
hange is that the CAN driver no longer needs to
access the SoC's clock control registers, which shall be the domain of
the platform's clock driver
Signed-off-by: Gerhard Sittig
---
drivers/net/can/mscan/mpc5xxx_can.c | 139 +++
1 file changed, 139 inse
add a comment about the magic of deriving an MSCAN component index
from the peripheral's physical address / register offset
Signed-off-by: Gerhard Sittig
---
drivers/net/can/mscan/mpc5xxx_can.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/can/
prepare and enable the FIFO clock upon PSC FIFO initialization,
disable and unprepare the FIFO clock upon PSC FIFO uninitialization,
remove the pre-enable workaround from the platform's clock driver
Signed-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/clock-commonclk.c |
ned-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/clock-commonclk.c | 12
1 file changed, 12 deletions(-)
diff --git a/arch/powerpc/platforms/512x/clock-commonclk.c
b/arch/powerpc/platforms/512x/clock-commonclk.c
index 6627957..b822469 100644
--- a/arch/powerpc/platforms/
after device tree based clock lookup became available, the peripheral
driver need no longer construct clock names which include the PSC index,
remove the "psc%d_mclk" template and unconditionally use "mclk"
Signed-off-by: Gerhard Sittig
---
drivers/tty/serial/mpc52xx_uart.
after device tree based clock lookup became available, the peripheral
driver need no longer construct clock names which include the PSC index,
remove the "psc%d_mclk" template and unconditionally use "mclk"
Signed-off-by: Gerhard Sittig
---
drivers/spi/spi-mpc512x-psc.c |
rivers to keep up compatibility, an alternative approach
would be to register clkdev items in the platform's clock driver for
the migration period
Signed-off-by: Gerhard Sittig
---
arch/powerpc/boot/dts/mpc5121.dtsi | 79
1 file changed, 79 insertion
lable
Signed-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/Kconfig | 14 +-
arch/powerpc/platforms/512x/Makefile |4 +-
arch/powerpc/platforms/512x/clock-commonclk.c | 778 +
include/linux/clk-provider.h | 16 +
4 files cha
SoC input (fixed frequency)
- provide default values with 33MHz oscillator frequency in the
common include (the 66MHz IPS bus already was there), add
override values for the ifm AC14xx board which deviates from
the reference design (25MHz xtal, 80MHz IPS bus)
Signed-off-by: Gerhard Sittig
-
introduce a dt-bindings/ header file for MPC512x clocks,
providing symbolic identifiers for those SoC clocks which
clients will reference from their device tree nodes
Signed-off-by: Gerhard Sittig
---
include/dt-bindings/clock/mpc512x-clock.h | 59 +
1 file changed
prepare C preprocessor support when processing MPC512x DTS files
- switch from DTS syntax to CPP syntax for include specs
- create a symlink such that DTS processing can reference includes
Signed-off-by: Gerhard Sittig
---
arch/powerpc/boot/dts/ac14xx.dts |2 +-
arch/powerpc/boot
the common clock drivers were motivated/initiated by ARM development
and apparently assume little endian peripherals
wrap register/peripherals access in the common code (div, gate, mux)
in preparation of adding COMMON_CLK support for other platforms
Signed-off-by: Gerhard Sittig
---
drivers
MSCAN CCR fields declared here aren't referenced anywhere
Signed-off-by: Gerhard Sittig
---
arch/powerpc/include/asm/mpc5121.h | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/arch/powerpc/include/asm/mpc5121.h
b/arch/powerpc/include/asm/mpc5121.h
ind
d upon allocation already
just in case the clock is not only required for bitrate generation but
for register access as well
Signed-off-by: Gerhard Sittig
---
drivers/tty/serial/mpc52xx_uart.c | 100 ++---
1 file changed, 83 insertions(+), 17 delet
must prepare clocks before enabling them, unprepare after disable
Signed-off-by: Gerhard Sittig
---
drivers/mtd/nand/mpc5121_nfc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c
index 3c9cdcb..eb7771d
n the clock handling previously went unnoticed, but will
become fatal in the common clock scenario
Signed-off-by: Gerhard Sittig
---
drivers/spi/spi-mpc512x-psc.c | 49 ++---
1 file changed, 31 insertions(+), 18 deletions(-)
diff --git a/drivers/spi/spi-mpc512x
t() routine
- remove the clkdev.h header file inclusion directive with the removal
of the clkdev registration call
Gerhard Sittig (24):
spi: mpc512x: cleanup clock API use
serial: mpc512x: cleanup clock API use
mtd: mpc5121_nfc: prepare clocks before enabling them
powerpc: mpc512x:
On Mon, Jul 15, 2013 at 21:38 +0200, Sascha Hauer wrote:
>
> On Mon, Jul 15, 2013 at 08:47:34PM +0200, Gerhard Sittig wrote:
> > diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
> > index 6d55eb2..2c07061 100644
> > --- a/drivers/clk/clk-divider.c
&
On Wed, Jul 17, 2013 at 13:07 +0100, Mark Brown wrote:
>
> On Wed, Jul 17, 2013 at 01:22:29PM +0200, Gerhard Sittig wrote:
> > On Mon, Jul 15, 2013 at 21:17 +0100, Mark Brown wrote:
> > > On Mon, Jul 15, 2013 at 08:47:30PM +0200, Gerhard Sittig wrote:
>
> > &
On Mon, Jul 15, 2013 at 21:38 +0200, Sascha Hauer wrote:
>
> On Mon, Jul 15, 2013 at 08:47:34PM +0200, Gerhard Sittig wrote:
> > diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
> > index 6d55eb2..2c07061 100644
> > --- a/drivers/clk/clk-divider.c
&
On Mon, Jul 15, 2013 at 23:54 +0200, Sascha Hauer wrote:
>
> On Mon, Jul 15, 2013 at 11:46:01PM +0200, Gerhard Sittig wrote:
> > with device tree based clock lookup, the MCLK name no longer
> > depends on the PSC index
> >
> > Signed-off-by: Gerhard Sittig
&
On Mon, Jul 15, 2013 at 21:17 +0100, Mark Brown wrote:
>
> On Mon, Jul 15, 2013 at 08:47:30PM +0200, Gerhard Sittig wrote:
> > clocks need to get prepared before they can get enabled,
> > fix the MPC512x PSC SPI master's initialization
>
> > Signed-off-by: Gerh
On Tue, Jul 16, 2013 at 12:37 +0200, Lars-Peter Clausen wrote:
>
> On 07/14/2013 02:01 PM, Gerhard Sittig wrote:
> > From: Alexander Popov
> >
> > introduce support for slave s/g transfer preparation and the associated
> > device control callback in the MPC512x DMA
transition to the COMMON_CLK framework has completed for the MPC512x
platform, remove the now obsolete code path of the mpc5xxx mscan
driver which accessed clock control module registers directly
Signed-off-by: Gerhard Sittig
---
drivers/net/can/mscan/mpc5xxx_can.c | 136
ff-by: Gerhard Sittig
---
arch/powerpc/sysdev/fsl_pci.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
index 46ac1dd..cb2ed92 100644
--- a/arch/powerpc/sysdev/fsl_pci.c
+++ b/arch/powerpc/sysdev/fsl_pci.c
@@ -17,6
completely switch to, i.e. unconditionally use COMMON_CLK for the
MPC512x platform, and retire the PPC_CLOCK implementation for that
platform after the transition has completed
Signed-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/Kconfig | 14 +-
arch/powerpc/platforms/512x/Makefile
device tree based clock lookup, must prepare clocks before enabling
them, unprepare after disable, error check in the clock setup
Signed-off-by: Gerhard Sittig
---
drivers/media/platform/fsl-viu.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/media
tree specs for clocks, but failure to enable a specified
clock is considered fatal
Signed-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/clock-commonclk.c |1 -
.../net/ethernet/freescale/fs_enet/fs_enet-main.c | 27 +++-
include/linux/fs_enet
device tree based clock lookup in the MPC512x initialization (lookup
'per' for register access), add error check in the clock setup, must
prepare clocks before they can get enabled, unprepare after disable
Signed-off-by: Gerhard Sittig
---
drivers/usb/host/fsl-mph-dr-o
make the MPC I2C driver prepare and enable the peripheral clock
('per' for register access) in the MPC512x setup routine,
make this clock setup non-fatal to allow for a migration period,
remove the pre-enabling hack in the platform's clock driver
Signed-off-by: Gerhard Sittig
--
prepare and enable the FIFO clock upon PSC FIFO initialization, disable
and unprepare the FIFO clock upon PSC FIFO uninitialization, remove the
pre-enable workaround from the platform's clock driver
Signed-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/clock-commonclk.c |
after the PSC drivers for UART and SPI mode got converted to device tree
based clock lookup, the former MCLK name which depends on the PSC index
isn't needed any longer -- remove the clk_register_clkdev() invocation
Signed-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/clock-common
with device tree based clock lookup, the MCLK name no longer
depends on the PSC index
Signed-off-by: Gerhard Sittig
---
drivers/tty/serial/mpc52xx_uart.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/tty/serial/mpc52xx_uart.c
b/drivers/tty/serial
shall succeed
upon first try in the usual case, will test a few less desirable yet
acceptable frequencies in edge cases, and will fallback to "best effort"
if none of the previously tried frequencies pass the test
Signed-off-by: Gerhard Sittig
---
arch/powerpc/platforms/512x/clock
hange is that the CAN driver no longer needs to
access the SoC's clock control registers, which shall be the domain of
the platform's clock driver
Signed-off-by: Gerhard Sittig
---
drivers/net/can/mscan/mpc5xxx_can.c | 139 +++
1 file changed, 139 inse
after PSC related clock specifiers were added to the device tree,
the former 'psc%d_mclk' isn't needed any longer to lookup clock items
Signed-off-by: Gerhard Sittig
---
drivers/spi/spi-mpc512x-psc.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/
viders
the previous PPC_CLOCK implementation is kept in place and resides in
parallel to the common clock implementation for test and comparison
during migration, a compile time option picks one of the two
alternatives (Kconfig switch, common clock used by default)
Signed-off-by: Gerhard Sitti
add a comment about the magic of deriving an MSCAN component index
from the peripheral's physical address / register offset
Signed-off-by: Gerhard Sittig
---
drivers/net/can/mscan/mpc5xxx_can.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/can/
rivers to keep up compatibility, an alternative approach
would be to register clkdev items in the platform's clock driver for
the migration period
Signed-off-by: Gerhard Sittig
---
arch/powerpc/boot/dts/mpc5121.dtsi | 79
1 file changed, 79 insertion
introduce a dt-bindings/ header file for MPC512x clocks,
providing symbolic identifiers for those SoC clocks which
clients will reference from their device tree nodes
Signed-off-by: Gerhard Sittig
---
include/dt-bindings/clock/mpc512x-clock.h | 59 +
1 file changed
SoC input (fixed frequency)
- provide default values with 33MHz oscillator frequency in the
common include (the 66MHz IPS bus already was there), add
override values for the ifm AC14xx board which deviates from
the reference design (25MHz xtal, 80MHz IPS bus)
Signed-off-by: Gerhard Sittig
-
prepare C preprocessor support when processing MPC512x DTS files
- switch from DTS syntax to CPP syntax for include specs
- create a symlink such that DTS processing can reference includes
Signed-off-by: Gerhard Sittig
---
arch/powerpc/boot/dts/ac14xx.dts |2 +-
arch/powerpc/boot
the common clock drivers were motivated/initiated by ARM development
and apparently assume little endian peripherals
wrap register/peripherals access in the common code (div, gate, mux)
in preparation of adding COMMON_CLK support for other platforms
Signed-off-by: Gerhard Sittig
---
drivers
clocks need to get prepared before they can get enabled, and after
disabling them they can get unprepared
Signed-off-by: Gerhard Sittig
---
drivers/tty/serial/mpc52xx_uart.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/mpc52xx_uart.c
b/drivers
must prepare clocks before enabling them, unprepare after disable
Signed-off-by: Gerhard Sittig
---
drivers/mtd/nand/mpc5121_nfc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c
index 3c9cdcb..eb7771d
MSCAN CCR fields declared here aren't referenced anywhere
Signed-off-by: Gerhard Sittig
---
arch/powerpc/include/asm/mpc5121.h | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/arch/powerpc/include/asm/mpc5121.h
b/arch/powerpc/include/asm/mpc5121.h
ind
equires a cast which shadows
real mismatches:
WARNING: static const char * array should probably be static const char *
const
#413: FILE: arch/powerpc/platforms/512x/clock-commonclk.c:335:
+static const char *parent_names_mux0[] = {
total: 0 errors, 1 warnings, 0 checks, 836 lines checked
clocks need to get prepared before they can get enabled,
fix the MPC512x PSC SPI master's initialization
Signed-off-by: Gerhard Sittig
---
drivers/spi/spi-mpc512x-psc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mp
register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees), provide
the '#dma-cells' property in the shared mpc5121.dtsi file, and introduce
a bindings document for the MPC512x DMA controller
Signed-off-by: Gerh
d DMA controller.
Signed-off-by: Lars-Peter Clausen
Signed-off-by: Gerhard Sittig
---
drivers/dma/of-dma.c | 47 +++
include/linux/of_dma.h |4
2 files changed, 51 insertions(+)
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
Q&D HACK to enable SD card support without correct COMMON_CLK support,
best viewed with 'git diff -w -b', NOT acceptable for mainline (NAKed)
Signed-off-by: Gerhard Sittig
---
drivers/mmc/host/mxcmmc.c | 41 +++--
1 file changed, 27 ins
of slave s/g preparation and device control ]
Signed-off-by: Alexander Popov
[ execute() start condition, mpc8308 compat, terminate all, s/g length check,
reworded commit msg ]
Signed-off-by: Gerhard Sittig
---
drivers/dma/mpc512x_dma.c | 168 +++--
1 file
hannel
count which in combination with the re-ordering obsoletes a comment
this modification only re-orders instructions but doesn't change behaviour
Signed-off-by: Gerhard Sittig
---
drivers/dma/mpc512x_dma.c | 48 +
1 file changed, 31 insert
r adjust the parts that I've contributed
Alexander Popov (1):
dma: mpc512x: add support for peripheral transfers
Gerhard Sittig (3):
dma: mpc512x: re-order mpc8308 specific instructions
dma: mpc512x: register for device tree channel lookup
HACK mmc: mxcmmc: enable clocks for the MPC512x
On Sun, Jul 14, 2013 at 12:05 +0200, Lars-Peter Clausen wrote:
>
> On 07/12/2013 05:26 PM, Gerhard Sittig wrote:
> [...]
> ]
> > + if (mchan->tcd_nunits)
> > + tcd->nbytes = mchan->tcd_nunits * 4;
> > + else
> > +
On Sun, Jul 14, 2013 at 10:50 +0200, Arnd Bergmann wrote:
>
> On Saturday 13 July 2013, Gerhard Sittig wrote:
> >
> > [ ... ]
> >
> > Thank you for the feedback.
> >
> > OK, so not adding the dt-bindings header leads to no change in
> > the DTS n
[ MPC8308 knowledge required, see below ]
On Sat, Jul 13, 2013 at 09:17 +0200, Arnd Bergmann wrote:
>
> On Friday 12 July 2013, Gerhard Sittig wrote:
> > +++ b/include/dt-bindings/dma/mpc512x-dma.h
> > @@ -0,0 +1,21 @@
> > +/*
> > + * This header file provid
Q&D HACK to enable SD card support without correct COMMON_CLK support,
best viewed with 'git diff -w -b', NOT acceptable for mainline (NAKed)
Signed-off-by: Gerhard Sittig
---
drivers/mmc/host/mxcmmc.c | 41 +++--
1 file changed, 27 ins
register the controller for device tree based lookup of DMA channels
(non-fatal for backwards compatibility with older device trees), provide
the '#dma-cells' property in the shared mpc5121.dtsi file, and introduce
a bindings document for the MPC512x DMA controller
Signed-off-by: Gerh
From: Lars-Peter Clausen
From: Lars-Peter Clausen
This patch adds a new common OF dma xlate callback function which will match a
channel by it's id. The binding expects one integer argument which it will use
to
lookup the channel by the id.
Unlike of_dma_simple_xlate this function is able to
the mpc5121.dtsi as well as the DMA engine driver
use those names instead of numbers
Signed-off-by: Gerhard Sittig
---
arch/powerpc/boot/dts/mpc5121.dtsi|6 +-
drivers/dma/mpc512x_dma.c |6 --
include/dt-bindings/dma/mpc512x-dma.h | 21 +
3
prepare C preprocessor support when processing MPC512x DTS files
- switch from DTS syntax to CPP syntax for include specs
- create a symlink such that DTS processing can reference includes
Signed-off-by: Gerhard Sittig
---
arch/powerpc/boot/dts/ac14xx.dts |2 +-
arch/powerpc/boot
device_control() routine's introduction)
Signed-off-by: Gerhard Sittig
---
drivers/dma/mpc512x_dma.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/mpc512x_dma.c b/drivers/dma/mpc512x_dma.c
index df10a48..0053ff8 100644
--- a/driver
adjust the conditions how submitted DMA jobs get started: memory transfers
need to get initiated by an explicit software request, all transfers which
involve peripherals need to reference the external requester line
Signed-off-by: Gerhard Sittig
---
drivers/dma/mpc512x_dma.c |4 +++-
1 file
From: Alexander Popov
From: Alexander Popov
Data transfers between memory and i/o memory require more delicate TCD
(Transfer Control Descriptor) configuration and DMA channel service requests
via hardware.
dma_device.device_control callback function is needed to configure
DMA channel to work w
blurb is below the stats
Alexander Popov (1):
powerpc: mpc512x_dma: add support for data transfers between memory
and i/o memory
Gerhard Sittig (6):
dma: mpc512x: fix start condition in execute()
dma: mpc512x: support 'terminate all' control request
dts: mpc512x: p
On Fri, Jun 28, 2013 at 11:25 -0700, Dmitry Torokhov wrote:
>
> On Fri, Jun 28, 2013 at 08:35:42AM -0600, Stephen Warren wrote:
> > On 06/28/2013 01:52 AM, Gerhard Sittig wrote:
> > >
> > > [ late reply, just catching up with the backlog ]
> > >
&g
On Fri, Jun 28, 2013 at 09:01 -0600, Stephen Warren wrote:
>
> On 06/28/2013 02:33 AM, Gerhard Sittig wrote:
> > On Mon, Jun 24, 2013 at 17:14 -0600, Stephen Warren wrote:
> >>
> >> [ active low pins, individually for sets or even single pins ]
> >>
> &g
atures which explicitly must get enabled before
changed behaviour will occur. So I need some more time to think
of which parts to change in which ways and how to make sure that
nothings breaks ...
virtually yours
Gerhard Sittig
--
DENX Software Engineering GmbH,
is fits with my observation that application drivers on top of
gpiolib often take care of such a property which actually looks
like it would belong to the physical attachment.
I understand that a chip's driver will hide when a SoC's pin is
inverted, but I cannot see where gpiolib pr
On Mon, Jun 24, 2013 at 16:00 -0600, Stephen Warren wrote:
>
> On 06/22/2013 03:23 AM, Gerhard Sittig wrote:
> ...
>
> [ device tree binding doc, discussing matrix hardware layouts ]
>
> I think both "simple" and "mechanical" should be removed. My r
(which may or
may not be expensive in "abolute" terms, but certainly is more
expensive than a keymap check), and eliminiates the issue of
emitting events which lack codes. Sounds like the appropriate
solution to the problem.
virtually yours
Gerhard Sittig
--
DENX Software Engineering Gm
On Fri, Jun 21, 2013 at 16:00 -0600, Stephen Warren wrote:
>
> On 06/21/2013 12:09 PM, Gerhard Sittig wrote:
> > querying keyboards isn't a time critical task and does not depend on
> > exact timing in the microseconds order -- the timeouts and delays are
> > arbitrar
On Fri, Jun 21, 2013 at 15:41 -0600, Stephen Warren wrote:
>
> On 06/21/2013 12:09 PM, Gerhard Sittig wrote:
>
> > diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> > b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
>
> >
On Fri, Jun 21, 2013 at 15:38 -0600, Stephen Warren wrote:
>
> On 06/21/2013 12:09 PM, Gerhard Sittig wrote:
> > detecting changes in the key press status may not work reliably in
> > interrupt driven mode (see the documentation part of the change for
> > details)
> >
On Fri, Jun 21, 2013 at 15:34 -0600, Stephen Warren wrote:
>
> On 06/21/2013 12:09 PM, Gerhard Sittig wrote:
> > extend the device tree adjustable hardware configuration:
> > - allow for differing polarity of the row and column GPIO pins
> > - optionally fully drive colum
comes available upon request, and all of it is documented.
On Fri, Jun 21, 2013 at 15:31 -0600, Stephen Warren wrote:
>
> On 06/21/2013 12:09 PM, Gerhard Sittig wrote:
> > update the device tree binding documentation for the GPIO matrix keypad
> > driver: mention the driver's
On Sat, Jun 22, 2013 at 04:28 +0200, Marek Vasut wrote:
>
> Dear Gerhard Sittig,
>
> > optionally dump relevant configuration of pins, matrix lines,
> > and delay/interval times at the very end of the probe routine
> > (development feature, silent by default)
>
or v2. Thank you for reviewing this.
virtually yours
Gerhard Sittig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-
gned-off-by: Gerhard Sittig
---
.../bindings/input/gpio-matrix-keypad.txt | 16 +++
drivers/input/keyboard/matrix_keypad.c | 50 ++--
include/linux/input/matrix_keypad.h|6 +++
3 files changed, 57 insertions(+), 15 deletions(-)
d
ost
Signed-off-by: Gerhard Sittig
---
.../bindings/input/gpio-matrix-keypad.txt |7 +++--
drivers/input/keyboard/matrix_keypad.c | 29 +---
include/linux/input/matrix_keypad.h|5
3 files changed, 35 insertions(+), 6 deletions(-
r more reliable detection of short lived key presses
(including a range spec to reduce timer management overhead) as well
as a slightly increased overall matrix poll frequency
- fix keymap comments, make the names match the codes
Signed-off-by: Gerhard Sittig
---
arch/powerpc/boot/dts/ac
introduce support to optionally run a binary column address bit pattern
on column GPIO pins in contrast to the formerly assumed one-out-of-N approach
Signed-off-by: Gerhard Sittig
---
.../bindings/input/gpio-matrix-keypad.txt | 46 ++--
drivers/input/keyboard
optionally dump relevant configuration of pins, matrix lines,
and delay/interval times at the very end of the probe routine
(development feature, silent by default)
Signed-off-by: Gerhard Sittig
---
drivers/input/keyboard/matrix_keypad.c | 18 ++
1 file changed, 18 insertions
de or configurations, and is an improvement in those
areas where the former implementations was restricted
Signed-off-by: Gerhard Sittig
---
.../bindings/input/gpio-matrix-keypad.txt | 18 +
arch/arm/mach-davinci/board-tnetv107x-evm.c|3 +-
arch/arm/mach-omap2/board
eflect that it takes
care of GPIO pins while its caller handles logical matrix lines
Signed-off-by: Gerhard Sittig
---
drivers/input/keyboard/matrix_keypad.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/input/keyboard/matrix_keypa
could be made to work appropriately in the polling case
Signed-off-by: Gerhard Sittig
---
.../bindings/input/gpio-matrix-keypad.txt | 17
drivers/input/keyboard/matrix_keypad.c | 92 ++--
include/linux/input/matrix_keypad.h|4 +-
3
update the device tree binding documentation for the GPIO matrix keypad
driver: mention the driver's selecting all columns at once, reword the
delay descriptions, add the missing active low GPIO pin level property
Signed-off-by: Gerhard Sittig
---
.../bindings/input/gpio-matrix-keypa
-off-by: Gerhard Sittig
---
drivers/input/keyboard/matrix_keypad.c | 43 ++--
1 file changed, 30 insertions(+), 13 deletions(-)
diff --git a/drivers/input/keyboard/matrix_keypad.c
b/drivers/input/keyboard/matrix_keypad.c
index 85e16a2..0b2599d 100644
--- a/drivers
- add comments about individual routines' purpose and their interaction,
pre-conditions and consequences
- mark a few spots which may need some more attention or clarification
- rephrase some diagnostics messages
Signed-off-by: Gerhard Sittig
---
drivers/input/keyboard/matrix_keypad.c |
1 - 100 of 102 matches
Mail list logo