Re: [PATCH 00/10] Orion Watchdog fixes

2013-07-16 Thread Andrew Lunn
On Mon, Jul 15, 2013 at 08:32:33PM -0300, Ezequiel Garcia wrote: This patchset introduces a bunch of fixes that removes the direct use of the shared timer control register, and also removes the need to include a mach-specific header. With this changes the driver can be included in

Re: [PATCH 00/10] Orion Watchdog fixes

2013-07-16 Thread Thomas Petazzoni
Dear Andrew Lunn, On Tue, 16 Jul 2013 08:59:52 +0200, Andrew Lunn wrote: Maybe i'm missing something here. You are making use of orion_timer_ctrl_clrset() from time-orion.c. How will this work on 370/XP which has a different clocksource driver? I *think* the idea is that the Armada 370/XP

Re: [PATCH 00/10] Orion Watchdog fixes

2013-07-16 Thread Andrew Lunn
On Tue, Jul 16, 2013 at 09:20:59AM +0200, Thomas Petazzoni wrote: Dear Andrew Lunn, On Tue, 16 Jul 2013 08:59:52 +0200, Andrew Lunn wrote: Maybe i'm missing something here. You are making use of orion_timer_ctrl_clrset() from time-orion.c. How will this work on 370/XP which has a

Re: [PATCH 00/10] Orion Watchdog fixes

2013-07-16 Thread Sebastian Hesselbarth
Andrew, Thomas, In the discussion about orion clocksource Russell was proposing a generic thread-safe write. That puts a single lock around all those writes. Of course, it will also blocked by totally unrelated thread-safe register accesses but should prevent us from having dozens of locks

Re: [PATCH 00/10] Orion Watchdog fixes

2013-07-16 Thread Ezequiel Garcia
Hi Thomas, Andrew: Thanks for looking at this! On Tue, Jul 16, 2013 at 09:31:01AM +0200, Andrew Lunn wrote: On Tue, Jul 16, 2013 at 09:20:59AM +0200, Thomas Petazzoni wrote: On Tue, 16 Jul 2013 08:59:52 +0200, Andrew Lunn wrote: Maybe i'm missing something here. You are making use of

Re: [PATCH 00/10] Orion Watchdog fixes

2013-07-16 Thread Ezequiel Garcia
Hi Sebastian, On Tue, Jul 16, 2013 at 09:48:56AM +0200, Sebastian Hesselbarth wrote: In the discussion about orion clocksource Russell was proposing a generic thread-safe write. That puts a single lock around all those writes. Of course, it will also blocked by totally unrelated

Re: [PATCH 00/10] Orion Watchdog fixes

2013-07-16 Thread Jason Cooper
On Tue, Jul 16, 2013 at 09:14:33AM -0300, Ezequiel Garcia wrote: On the other side, I'm much interested in knowing if you are OK with breaking the watchdog DT compatibility. If you NACK this, then I'll start preparing a different watchdog driver for 370/XP, since I don't want to extend a

Re: [PATCH 00/10] Orion Watchdog fixes

2013-07-16 Thread Ezequiel Garcia
On Tue, Jul 16, 2013 at 09:44:22AM -0400, Jason Cooper wrote: On Tue, Jul 16, 2013 at 09:14:33AM -0300, Ezequiel Garcia wrote: On the other side, I'm much interested in knowing if you are OK with breaking the watchdog DT compatibility. If you NACK this, then I'll start preparing a different