Re: [PATCH 4/5] net: mvmdio: allow Device Tree and platform device to coexist

2013-01-29 Thread Florian Fainelli
Le mardi 29 janvier 2013 18:59:12, Jason Gunthorpe a écrit : > On Tue, Jan 29, 2013 at 04:24:07PM +0100, Florian Fainelli wrote: > > - dev->err_interrupt = irq_of_parse_and_map(pdev->dev.of_node, 0); > > + if (pdev->dev.of_node) { > > + dev->regs = of_iomap(pdev->dev.of_node, 0); > >

Re: [PATCH 4/5] net: mvmdio: allow Device Tree and platform device to coexist

2013-01-29 Thread Jason Gunthorpe
On Tue, Jan 29, 2013 at 04:24:07PM +0100, Florian Fainelli wrote: > - dev->err_interrupt = irq_of_parse_and_map(pdev->dev.of_node, 0); > + if (pdev->dev.of_node) { > + dev->regs = of_iomap(pdev->dev.of_node, 0); > + if (!dev->regs) { > + dev_er

Re: [PATCH 4/5] net: mvmdio: allow Device Tree and platform device to coexist

2013-01-29 Thread Thomas Petazzoni
Dear Florian Fainelli, On Tue, 29 Jan 2013 16:24:07 +0100, Florian Fainelli wrote: > This patch changes the Marvell MDIO driver to be registered by using > both Device Tree and platform device methods. The driver voluntarily > does not use devm_ioremap() to share the same error path for Device Tre

[PATCH 4/5] net: mvmdio: allow Device Tree and platform device to coexist

2013-01-29 Thread Florian Fainelli
This patch changes the Marvell MDIO driver to be registered by using both Device Tree and platform device methods. The driver voluntarily does not use devm_ioremap() to share the same error path for Device Tree and non-Device Tree cases. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/m