Re: devicekit-power-gobject segfault

2009-12-22 Thread Richard Hughes
2009/12/22 Martin Koegler : > Here is the patch. On my system, gnome-session is starting up and > not printing any error messages besides a connection failure to the > system dbus: As promised, I've committed this. Thanks. Richard. p.s. next release is in two weeks time.

Re: devicekit-power-gobject segfault

2009-12-21 Thread Richard Hughes
2009/12/21 Martin Koegler : > I'm also in favour of returing an error to the user instead of aborting. Sure. I can look at this in the new year, or if you supply a patch, I can commit it tomorrow. :-) Richard. ___ devkit-devel mailing list devkit-devel@

Re: devicekit-power-gobject segfault

2009-12-21 Thread David Zeuthen
On Mon, 2009-12-21 at 15:54 +, Richard Hughes wrote: > 2009/12/19 Martin Koegler : > > I notice, that libdevkit-power-gobject will segfault in various > ways, > > if the connection to the system dbus fails > > (devkit-power-gobject/dkp-client.c): > > I think it's pretty fatal if we can't conne

Re: devicekit-power-gobject segfault

2009-12-21 Thread Richard Hughes
2009/12/19 Martin Koegler : > I notice, that libdevkit-power-gobject will segfault in various ways, > if the connection to the system dbus fails > (devkit-power-gobject/dkp-client.c): I think it's pretty fatal if we can't connect to the system DBus. I'm guessing we should just exit() if that's the