Re: udev-ish replacement for hal-cups-utils?

2009-07-23 Thread Tim Waugh
On Thu, 2009-07-23 at 00:10 +0200, Till Kamppeter wrote: > >> The very last change is to take into account that serial numbers can be > >> shorter than 12 characters. > > > > Serial numbers from the Device ID field can be any length, yes, but > > 'serial' in that context is the USB serial number.

Re: udev-ish replacement for hal-cups-utils?

2009-07-23 Thread Tim Waugh
On Thu, 2009-07-23 at 12:21 +0200, Till Kamppeter wrote: > "hp:/usb/HP_Color_LaserJet_CM3530_MFP?serial=CNFND01964" contains a USB > serial number, but this serial number has only 10 characters. OK, we'll have to be less strict about that then. That's a shame. Tim. */ signature.asc Descripti

Re: udev-ish replacement for hal-cups-utils?

2009-07-23 Thread Tim Waugh
On Thu, 2009-07-23 at 10:49 +0200, Till Kamppeter wrote: > You are missing the NULL check here (musb.c, line 2083): > > ieee1284_id = udev_device_get_sysattr_value (ddev, "ieee1284_id"); > strncpy (device_id, ieee1284_id, len); > device_id[len - 1] = '\0'; Thank you, fixed. > An addi

Re: udev-ish replacement for hal-cups-utils?

2009-07-23 Thread Tim Waugh
On Wed, 2009-07-22 at 22:11 +0200, Till Kamppeter wrote: > How do you handle the enabling and disabling the Fax queues when the > printer is connected or disconnected? I didn't, but I've added that. The way udev-configure-printer does it now is to identify the device URIs that match the device,

Re: udev-ish replacement for hal-cups-utils?

2009-07-23 Thread Tim Waugh
On Thu, 2009-07-23 at 17:02 +0200, Till Kamppeter wrote: > OK, have you already implemented that? Can you commit it to the git repo? I merged the udev branch in 1.1.x yesterday and further fixes have been going there. Tim. */ signature.asc Description: This is a digitally signed message part _

Re: udev-ish replacement for hal-cups-utils?

2009-07-23 Thread Ozan Çağlayan
Tim Waugh wrote: > On Thu, 2009-07-23 at 17:02 +0200, Till Kamppeter wrote: > >> OK, have you already implemented that? Can you commit it to the git repo? >> > > I merged the udev branch in 1.1.x yesterday and further fixes have been > going there. > I've tested it with an ML-1610 and it

Re: udev-ish replacement for hal-cups-utils?

2009-07-23 Thread Tim Waugh
On Thu, 2009-07-23 at 19:15 +0300, Ozan Çağlayan wrote: > I've tested it with an ML-1610 and it worked fine except it gets > configured two times because of the udev rule which triggers the helper > upon the low-level addition and the lp one. I think I know how that might have happened. I've just

Re: udev-ish replacement for hal-cups-utils?

2009-07-23 Thread Tim Waugh
On Thu, 2009-07-23 at 16:55 +0200, Till Kamppeter wrote: > I have applied it to our Ubuntu HPLIP package and now the segfault goes > away, but if there is no usblp kernel module, most device IDs do not get > read from the printers. See below. I have run the backend twice and on > both runs the s