Re: [PATCH] udisks: Avoid deprecated polkit_authority_get() function

2010-11-06 Thread Martin Pitt
Hello Marti, Marti Raudsepp [2010-10-20 21:33 +0300]: > Subject: [PATCH 2/2] udisks: Avoid deprecated polkit_authority_get() function > > Use polkit_authority_get_sync() instead. Applied with bumping the polkit version check. Thanks, and sorry for the delay! Martin -- Martin Pitt

Re: [PATCH] udisks: escape backslash for label string

2010-11-06 Thread Martin Pitt
Hello Jiro, Jiro SEKIBA [2010-10-15 13:48 +0900]: > > validate_and_escape_label will only escapes '"'. > However, string '\"' will be escaped to '\\"' which leads unmatched > double quote for shell string in result. > > This adds escaping '\' in validate_and_escape_label to avoid the problem. T

Re: [PATCH] udisks: escape backslash for label string

2010-11-06 Thread Martin Pitt
Martin Pitt [2010-11-06 13:06 -0400]: > It still falls over badly for VFAT (which doesn't support " in > labels at all, and thus just interactively hangs around asking what > to do), I'll care for that next. For the record, fixed in master now, also for NTFS. Testsuite now succees for all supporte