[PATCH 1/2] Linux: Fix warning in up_device_supply_get_design_voltage

2013-08-24 Thread Timothée Ravier
This avoids filling the logs with the unnecessary warning line: GLib-CRITICAL **: g_ascii_strcasecmp: assertion `s1 != NULL' failed as seen in https://bugzilla.redhat.com/show_bug.cgi?id=847874 and https://bugzilla.redhat.com/show_bug.cgi?id=863524 --- src/linux/up-device-supply.c | 2 +- 1 file c

[PATCH 2/2] Linux: More explicit warning when no voltage found

2013-08-24 Thread Timothée Ravier
Add device full path in warning if retrieving design voltage fails in up_device_supply_get_design_voltage(). Also helps diagnose bugs https://bugzilla.redhat.com/show_bug.cgi?id=847874 and https://bugzilla.redhat.com/show_bug.cgi?id=863524 --- src/linux/up-device-supply.c | 2 +- 1 file changed, 1

How should I diagnose "no voltage values" issues?

2013-08-26 Thread Timothée Ravier
Hi, I'm running an updated Arch Linux with Linux 3.10 / 3.11rc7, upower 0.9.21. My logs are filled with those lines: upowerd[927]: (upowerd:927): UPower-Linux-WARNING **: no voltage values, using 10V as approximation which I've tracked back to be about /org/freedesktop/UPower/devices/battery_BA

[PATCH] Linux: Only one warning if no valid voltage found

2013-08-29 Thread Timothée Ravier
Avoid filling the logs with repeated warning saying that no correct voltage value was found for a power device. Improves the situation with bugs https://bugzilla.redhat.com/show_bug.cgi?id=847874 and https://bugzilla.redhat.com/show_bug.cgi?id=863524 Signed-off-by: Timothée Ravier --- src/linux

[PATCH v2] Linux: Only one warning if no valid voltage found

2013-08-30 Thread Timothée Ravier
Avoid filling the logs with repeated warning saying that no correct voltage value was found for a power device. Improves the situation with bugs https://bugzilla.redhat.com/show_bug.cgi?id=847874 and https://bugzilla.redhat.com/show_bug.cgi?id=863524 Signed-off-by: Timothée Ravier --- src/linux

[PATCH v3] Linux: Only one warning if no valid voltage found

2013-08-30 Thread Timothée Ravier
Avoid filling the logs with repeated warning saying that no correct voltage value was found for a power device. Improves the situation with bugs https://bugzilla.redhat.com/show_bug.cgi?id=847874 and https://bugzilla.redhat.com/show_bug.cgi?id=863524 Signed-off-by: Timothée Ravier --- v3: Add a