Re: [PATCH] more fine-grained iDevice support in media-player-info

2011-06-12 Thread Tom Gundersen
Hi Christophe, On Sun, Jun 12, 2011 at 6:08 PM, Christophe Fergeau wrote: > Hmm, indeed, I didn't see the commit doing pass through, and imo all > these IDs shouldn't have been added at all. > >> >> The attached patches gives each iPhone/iPad its correct name, and also >> sets the iPod icon (mayb

Re: udisks and eSATA: a question about the meaning of "detachable"

2011-07-11 Thread Tom Gundersen
On Mon, Jul 11, 2011 at 12:58 AM, Ansgar Burchardt wrote: > I reported a bug in KDE [1] about eSATA drives not being seen as a > "removable" device (in KDE's device manager).  I believe this is a bug > in KDE's solid as they do not use the correct properties from udisks, > however they disagree.

[udisks1][PATCH] udev: remove redundant call to deprecated pci-db

2012-11-20 Thread Tom Gundersen
The binary is no longer shipped with systemd/udev. The functionality is taken over by a builtin, which is ran for all devices, rendering this rule superfluous. Cc: Jan de Groot Signed-off-by: Tom Gundersen --- data/80-udisks.rules | 4 1 file changed, 4 deletions(-) diff --git a/data/80

[udisks] moving shared mounts from /media to /run/media ?

2013-02-19 Thread Tom Gundersen
Hi David, I noticed your commit "Introduce UDISKS_FILESYSTEM_SHARED=1 to use /media for mounting". The feature makes sense in my opinion. However, I wonder if it would be even better to keep this in /run/media (or possibly in a subfolder to avoid name-clashes). With the move from udisks1 to udisk

[PATCH][UPower] build: detect udev rules dir

2013-03-19 Thread Tom Gundersen
Udev rules may live in either /lib/udev/rules.d or /usr/lib/udev/rules.d depending on the distro. Remove the heuristic for deciding the dir, use pkgconfig to detect the location and allow it to be set manually. --- configure.ac | 12 +--- rules/Makefile.am | 1 - 2 files changed, 5

Re: [udisks] moving shared mounts from /media to /run/media ?

2013-03-19 Thread Tom Gundersen
On Tue, Feb 19, 2013 at 10:49 PM, David Zeuthen wrote: > Yeah, please open a bug for this in bugzilla. Thanks. Sorry for the delay, but here it is: . -t ___ devkit-devel mailing list devkit-devel@list

Re: [PATCH][UPower] build: detect udev rules dir

2013-03-20 Thread Tom Gundersen
On Wed, Mar 20, 2013 at 1:55 PM, Richard Hughes wrote: > On 19 March 2013 12:33, Tom Gundersen wrote: >> Udev rules may live in either /lib/udev/rules.d or /usr/lib/udev/rules.d >> depending on the distro. >> Remove the heuristic for deciding the dir, use pkgconfig to de

Re: [PATCH][UPower] build: detect udev rules dir

2013-03-20 Thread Tom Gundersen
On Wed, Mar 20, 2013 at 1:59 PM, Tom Gundersen wrote: >> What distro uses /usr/lib/udev/rules.d? > > At least Arch does. PS Currently we do: <https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/u

Re: [PATCH][UPower] build: detect udev rules dir

2013-03-20 Thread Tom Gundersen
On Wed, Mar 20, 2013 at 3:00 PM, Dan Nicholson wrote: > > On Mar 19, 2013 5:31 AM, "Tom Gundersen" wrote: >> -# udev rules go in /lib, not /usr/lib >> -if test "$prefix" = "/usr" -o "$prefix" = "/usr/local" ; then >> - s

[PATCH v2][UPower] build: detect udev rules dir

2013-03-20 Thread Tom Gundersen
Udev rules may live in either /lib/udev/rules.d or /usr/lib/udev/rules.d depending on the distro. Remove the heuristic for deciding the dir, use pkgconfig to detect the location and allow it to be set manually. v2: fix specifying --with-udevrulesdir --- configure.ac | 12 +--- rule

Re: media-player-info 18 release

2013-07-18 Thread Tom Gundersen
Hi Martin, On Fri, Jul 5, 2013 at 7:04 AM, Martin Pitt wrote: > time to push out a new release of media-player-info: > > > http://www.freedesktop.org/software/media-player-info/media-player-info-18.tar.gz > sha256: 21f186714d8c90e9a78c861cfdbfc1c9ae7eada7b80152a82bec685e7b7fc565 I think you

[PATCH][media-player-info] mpi2*: add support for udev's hwdb

2013-07-18 Thread Tom Gundersen
hwdb.py b/tools/mpi2hwdb.py new file mode 100755 index 000..b7ceb2a --- /dev/null +++ b/tools/mpi2hwdb.py @@ -0,0 +1,74 @@ +#!/usr/bin/python +# Generate hwdb file from music player identification (.mpi) files +# +# (C) 2009 Canonical Ltd. +# (C) 2013 Tom Gundersen +# Author: Martin Pitt +# +

[PATCHv2] mpi2*: add support for udev's hwdb

2013-07-19 Thread Tom Gundersen
music player identification (.mpi) files +# +# (C) 2009 Canonical Ltd. +# Author: Martin Pitt +# (C) 2013 Tom Gundersen +# +# This program is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; eit

Re: [PATCHv2] mpi2*: add support for udev's hwdb

2013-07-23 Thread Tom Gundersen
Hi Martin, On Tue, Jul 23, 2013 at 8:58 AM, Martin Pitt wrote: > Hey Tom, > > thanks for your patch! I modified it (see below), the final result is > > http://cgit.freedesktop.org/media-player-info/commit/?id=d83dd01a0a Thanks for the corrections. It all looks good to me. Cheers, Tom ___

Re: New wip/gdbus branch for UPower

2013-10-11 Thread Tom Gundersen
On Fri, Oct 11, 2013 at 10:11 AM, Bastien Nocera wrote: > On Fri, 2013-10-11 at 06:56 +0200, Tomasz Torcz wrote: >> On Thu, Oct 10, 2013 at 11:34:15PM +0200, Bastien Nocera wrote: >> > - Restore brightness on boot (this might be done in systemd instead) >> >> Yes, since systemd 207. > > We discu

Re: New wip/gdbus branch for UPower

2013-10-11 Thread Tom Gundersen
On Thu, Oct 10, 2013 at 11:34 PM, Bastien Nocera wrote: > - Requesting suspend/hibernate/hybrid suspend on behalf of the session > on critical battery How do you envision this working? In particular, do you think it would make sense to allow some sort of collaboration with some system daemon? Th

Re: New wip/gdbus branch for UPower

2013-10-11 Thread Tom Gundersen
On Fri, Oct 11, 2013 at 1:29 PM, Bastien Nocera wrote: > On Fri, 2013-10-11 at 13:18 +0200, Tom Gundersen wrote: >> On Thu, Oct 10, 2013 at 11:34 PM, Bastien Nocera wrote: >> > - Requesting suspend/hibernate/hybrid suspend on behalf of the session >> > on critic