[freenet-dev] More work on packet format branch

2010-11-20 Thread Martin Nyhus
On Tuesday 9. November 2010 14:20:19 Matthew Toseland wrote: > > > 7b2a66a803688e1be8d70f3e8eb3854f7b900242 > > > - You should add and subtract the full overhead. Is HMAC_LENGTH the > > > totality of the overhead apart from what's already accounted for in > > > packet.getLength()? (I.e. the sequenc

Re: [freenet-dev] More work on packet format branch

2010-11-19 Thread Martin Nyhus
On Tuesday 9. November 2010 14:20:19 Matthew Toseland wrote: > > > 7b2a66a803688e1be8d70f3e8eb3854f7b900242 > > > - You should add and subtract the full overhead. Is HMAC_LENGTH the > > > totality of the overhead apart from what's already accounted for in > > > packet.getLength()? (I.e. the sequenc

[freenet-dev] More work on packet format branch

2010-11-09 Thread Matthew Toseland
On Saturday 16 October 2010 22:04:47 Matthew Toseland wrote: ... > > For this to achieve its promise and improve efficiency (as well as enabling > transport plugins with relatively small packets and enabling support for low > MTUs), we need a new padding rule. Either: > a) We always send the lar

[freenet-dev] More work on packet format branch

2010-11-09 Thread Matthew Toseland
Sorry for the long turnaround, great stuff, will try to merge it soonish - that is, after I finish, or perhaps pause, deploying big changes to load management... On Tuesday 19 October 2010 22:57:50 Martin Nyhus wrote: > On Saturday 16 October 2010 23:04:47 Matthew Toseland wrote: > > 132f4b34206

Re: [freenet-dev] More work on packet format branch

2010-11-09 Thread Matthew Toseland
On Saturday 16 October 2010 22:04:47 Matthew Toseland wrote: ... > > For this to achieve its promise and improve efficiency (as well as enabling > transport plugins with relatively small packets and enabling support for low > MTUs), we need a new padding rule. Either: > a) We always send the lar

Re: [freenet-dev] More work on packet format branch

2010-11-09 Thread Matthew Toseland
Sorry for the long turnaround, great stuff, will try to merge it soonish - that is, after I finish, or perhaps pause, deploying big changes to load management... On Tuesday 19 October 2010 22:57:50 Martin Nyhus wrote: > On Saturday 16 October 2010 23:04:47 Matthew Toseland wrote: > > 132f4b34206

[freenet-dev] More work on packet format branch

2010-10-19 Thread Martin Nyhus
On Saturday 16 October 2010 23:04:47 Matthew Toseland wrote: > 132f4b342068e2308d6ee27ad5d95ec82fb1be2e > - Please use /** Javadocs */ for the variables, Eclipse etc will take > advantage of them. Done (f10d41a) > aed60bea24a21db858ff784d95c3b9add2e99dad > - You need to synchronize when setting hi

Re: [freenet-dev] More work on packet format branch

2010-10-19 Thread Martin Nyhus
On Saturday 16 October 2010 23:04:47 Matthew Toseland wrote: > 132f4b342068e2308d6ee27ad5d95ec82fb1be2e > - Please use /** Javadocs */ for the variables, Eclipse etc will take > advantage of them. Done (f10d41a) > aed60bea24a21db858ff784d95c3b9add2e99dad > - You need to synchronize when setting hi

[freenet-dev] More work on packet format branch

2010-10-16 Thread Matthew Toseland
Looks like there's nothing really huge. If you can fix the remaining issues, that'd be great. We can merge it as soon as there is a window for a disruptive change (a couple of weeks probably, there are largish load management issues to deal with first). Thanks! Up to 5e276c838e13440f28016ead655

Re: [freenet-dev] More work on packet format branch

2010-10-16 Thread Matthew Toseland
Looks like there's nothing really huge. If you can fix the remaining issues, that'd be great. We can merge it as soon as there is a window for a disruptive change (a couple of weeks probably, there are largish load management issues to deal with first). Thanks! Up to 5e276c838e13440f28016ead655

[freenet-dev] More work on packet format branch

2010-08-19 Thread Martin Nyhus
On Monday 2010-08-16 19:55 Matthew Toseland wrote: > The Summer of Code firm pencils down deadline is about to expire. The > below is concerned with the question "what must be changed to get > this mergeable"... > NewPacketFormat.tryDecipherPacket: > - Should it be updated on every packet? Obvious

Re: [freenet-dev] More work on packet format branch

2010-08-19 Thread Martin Nyhus
On Monday 2010-08-16 19:55 Matthew Toseland wrote: > The Summer of Code firm pencils down deadline is about to expire. The > below is concerned with the question "what must be changed to get > this mergeable"... > NewPacketFormat.tryDecipherPacket: > - Should it be updated on every packet? Obvious

[freenet-dev] More work on packet format branch

2010-08-16 Thread Matthew Toseland
The Summer of Code firm pencils down deadline is about to expire. The below is concerned with the question "what must be changed to get this mergeable"... zidel/packetFormat branch: 6a1f69c42d0f013e77253a3eb1bb39cc27e75c95 to 08e909d0697b7bb7c282705fda40c42aee873c02 - Update the encrypted sequen

[freenet-dev] More work on packet format branch

2010-08-16 Thread Matthew Toseland
The Summer of Code firm pencils down deadline is about to expire. The below is concerned with the question "what must be changed to get this mergeable"... zidel/packetFormat branch: 6a1f69c42d0f013e77253a3eb1bb39cc27e75c95 to 08e909d0697b7bb7c282705fda40c42aee873c02 - Update the encrypted sequen