Re: [freenet-dev] Your release manager is overwhelmed
On 10/05/2014 04:24 PM, xor wrote: > On Sunday, October 05, 2014 05:09:54 PM Matthew Toseland wrote: >> How did you resolve the hosting problems? Please let me know if you move >> the binaries hosting to e.g. Github, since it should mean the upload >> scripts are not dependant on pip and thus I could do releases more >> easily? Thanks. > > AFAIK he did move the binaries to Github! I did, yes. Implemented in https://github.com/freenet/scripts/commit/04b57b6fd0083184735a269b6c65349fa83c1588 One will note that pip is no longer used. Python 3 now is. signature.asc Description: OpenPGP digital signature ___ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
Re: [freenet-dev] Your release manager is overwhelmed
On Sunday, October 05, 2014 05:09:54 PM Matthew Toseland wrote: > How did you resolve the hosting problems? Please let me know if you move > the binaries hosting to e.g. Github, since it should mean the upload > scripts are not dependant on pip and thus I could do releases more > easily? Thanks. AFAIK he did move the binaries to Github! signature.asc Description: This is a digitally signed message part. ___ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
Re: [freenet-dev] Your release manager is overwhelmed
On 25/09/14 02:25, Steve Dougherty wrote: > Hi everyone, > > I have too many tasks to do to be able complete them in the way I've > been approaching things thus far. The sheer magnitude of code I feel > obligated to review on top of other improvements I'd like to write for > 1466 makes this feel more like endless unpaid work than fun volunteering. > > I will try making a list of tasks to complete and going through them in > a more focused way instead of jumping around, and hopefully that will > help, but ultimately I think I need to have less fall to me for this to > be sustainable. One thing I would really appreciate is other people > reviewing and signing off on pull requests so that I can focus on other > aspects of releasing, at least for now. The purge-db4o pull request > alone (and there are others) changes ~100k LOC. This is more code than > I've ever reviewed at once, and I don't think I can do a good job on > reviewing all of it by myself in a timely manner. > > Is anyone willing to volunteer to help review code? When reviewers are > happy with a pull request (which I hope will include following the > coding standards) I will merge it. > > - Steve How did you resolve the hosting problems? Please let me know if you move the binaries hosting to e.g. Github, since it should mean the upload scripts are not dependant on pip and thus I could do releases more easily? Thanks. signature.asc Description: OpenPGP digital signature ___ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
Re: [freenet-dev] Your release manager is overwhelmed
On Saturday, September 27, 2014 06:46:05 PM xor wrote: > 8ee6f853#commitcomment-7927272 > > or simply want to continue where you left off on a page > > with hundreds of changed files. > > Just store the commit hash of the last commit you reviewed? > This is assuming you're reviewing on a per-commit base. > If you want to review a multi-commit diff, I would suggest you: > - do it locally by cloning > - if you want to commit on a particular line, use git blame to find out > which commit that line came from > - go to the page of that commit on Github and comment there. This also works > using the commit hash. Example - notice INSERT_HASH_HERE: > https://github.com/toad/fred-staging/commit/INSERT_HASH_HERE Sorry, forgot the important aspect here: The question was how to continue where one has left off. Well, if you do it locally, you can of course write down the filename and the line number, and use your editor's feature of jumping to a line :) Your editor will probably just also display the cursor at the same place when you restart it. You could even use Eclipse. signature.asc Description: This is a digitally signed message part. ___ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
Re: [freenet-dev] Your release manager is overwhelmed
On Thursday, September 25, 2014 06:36:30 AM David Roden wrote: > GitHub might get unwieldy if you try to locate a > specific comment It supports deep links to comments. The date in the comment display is the link. Example: https://github.com/toad/fred-staging/commit/19c442ef1a1dc904c314675c3a17ce9c8ee6f853#commitcomment-7927272 > or simply want to continue where you left off on a page > with hundreds of changed files. Just store the commit hash of the last commit you reviewed? This is assuming you're reviewing on a per-commit base. If you want to review a multi-commit diff, I would suggest you: - do it locally by cloning - if you want to commit on a particular line, use git blame to find out which commit that line came from - go to the page of that commit on Github and comment there. This also works using the commit hash. Example - notice INSERT_HASH_HERE: https://github.com/toad/fred-staging/commit/INSERT_HASH_HERE signature.asc Description: This is a digitally signed message part. ___ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
Re: [freenet-dev] Your release manager is overwhelmed
On 09/25/2014 12:36 AM, David Roden wrote: > Hey Steve, > > I offered to help you review stuff on IRC but apparently you missed > that. I also mentioned that we probably need some kind of tool to > discuss code that seems questionable. GitHub might get unwieldy if > you try to locate a specific comment or simply want to continue where > you left off on a page with hundreds of changed files. Indeed I had missed that. Thanks! Let me know if you'd like my help in setting up review tools more suited to changes of this magnitude. signature.asc Description: OpenPGP digital signature ___ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
Re: [freenet-dev] Your release manager is overwhelmed
Hey Steve, I offered to help you review stuff on IRC but apparently you missed that. I also mentioned that we probably need some kind of tool to discuss code that seems questionable. GitHub might get unwieldy if you try to locate a specific comment or simply want to continue where you left off on a page with hundreds of changed files. Greetings, -- * David ‘Bombe’ Roden On 25.09.2014, at 03:25, Steve Dougherty wrote: > Hi everyone, > > I have too many tasks to do to be able complete them in the way I've > been approaching things thus far. The sheer magnitude of code I feel > obligated to review on top of other improvements I'd like to write for > 1466 makes this feel more like endless unpaid work than fun volunteering. > > I will try making a list of tasks to complete and going through them in > a more focused way instead of jumping around, and hopefully that will > help, but ultimately I think I need to have less fall to me for this to > be sustainable. One thing I would really appreciate is other people > reviewing and signing off on pull requests so that I can focus on other > aspects of releasing, at least for now. The purge-db4o pull request > alone (and there are others) changes ~100k LOC. This is more code than > I've ever reviewed at once, and I don't think I can do a good job on > reviewing all of it by myself in a timely manner. > > Is anyone willing to volunteer to help review code? When reviewers are > happy with a pull request (which I hope will include following the > coding standards) I will merge it. > > - Steve > > ___ > Devl mailing list > Devl@freenetproject.org > https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl signature.asc Description: Message signed with OpenPGP using GPGMail ___ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
