[xwiki-devs] [Idea] Improving component unit testing setup

2010-01-15 Thread Vincent Massol
Hi, Just got an idea: Create an AbstractComponentTestCase implementation that does this in its setup/init() method: - automatically ask the Component Manager for the list of dependencies for the component under test (can be done with a generic for example to know which component class is under

[xwiki-devs] [proposal] Migrating the captcha plugin to a component

2010-01-15 Thread Caleb James DeLisle
Hello folks, I have a proposed method for migrating the captcha plugin to a component. I have posted a patch here: http://jira.xwiki.org/jira/browse/XWIKI-4741 which contains the core modifications which I am proposing. Though I have a patch, this is still in the design phase and I welcome anyone

Re: [xwiki-devs] [proposal] Migrating the captcha plugin to a component

2010-01-15 Thread Asiri Rathnayake
Hi, On Fri, Jan 15, 2010 at 2:35 PM, Caleb James DeLisle calebdeli...@lavabit.com wrote: Hello folks, I have a proposed method for migrating the captcha plugin to a component. I have posted a patch here: http://jira.xwiki.org/jira/browse/XWIKI-4741 which contains the core modifications

Re: [xwiki-devs] [proposal] Migrating the captcha plugin to a component

2010-01-15 Thread Caleb James DeLisle
Asiri Rathnayake wrote: Hi, On Fri, Jan 15, 2010 at 2:35 PM, Caleb James DeLisle calebdeli...@lavabit.com wrote: Hello folks, I have a proposed method for migrating the captcha plugin to a component. I have posted a patch here: http://jira.xwiki.org/jira/browse/XWIKI-4741 which

Re: [xwiki-devs] Documents pulled in through #includeInContext have {{html}} macro removed.

2010-01-15 Thread Thomas Mortagne
On Fri, Jan 15, 2010 at 10:14, Caleb James DeLisle calebdeli...@lavabit.com wrote: Is this wrong? The test case is: create a document, put this in it: {{html}} iitalics/i {{/html}} create another document, put in it: {{velocity}} #includeInContext(Test.FirstDocument) {{/velocity}}

Re: [xwiki-devs] [proposal] Migrating the captcha plugin to a component

2010-01-15 Thread Asiri Rathnayake
Hi, Not exactly, I think you are thinking of: $captchaservice.isAnswerCorrect($sessionId, $answer) Yes. I believe here sessionId is generated by the captcha service for each captcha displayed? Or is it something else? I'm asking because recaptcha generates a unque captchaId for each captcha

Re: [xwiki-devs] [proposal] Migrating the captcha plugin to a component

2010-01-15 Thread Caleb James DeLisle
Asiri Rathnayake wrote: Hi, Not exactly, I think you are thinking of: $captchaservice.isAnswerCorrect($sessionId, $answer) Yes. I believe here sessionId is generated by the captcha service for each captcha displayed? Or is it something else? I'm asking because recaptcha generates

Re: [xwiki-devs] [proposal] Migrating the captcha plugin to a component

2010-01-15 Thread Caleb James DeLisle
Whoops I made a mistake in my example: How about: #set($captcha = $captchaservice.getCaptcha(defaultImageCaptcha)) #set($servletId = $captcha.getServletId($request)) $captcha.isAnswerCorrect($answer) should be: $captcha.isAnswerCorrect($servletId, $answer) Caleb Caleb James DeLisle wrote:

Re: [xwiki-devs] [proposal] Migrating the captcha plugin to a component

2010-01-15 Thread Asiri Rathnayake
Hi Caleb, On Fri, Jan 15, 2010 at 4:21 PM, Caleb James DeLisle calebdeli...@lavabit.com wrote: Whoops I made a mistake in my example: How about: #set($captcha = $captchaservice.getCaptcha(defaultImageCaptcha)) #set($servletId = $captcha.getServletId($request))

Re: [xwiki-devs] [Idea] Improving component unit testing setup

2010-01-15 Thread Thomas Mortagne
On Fri, Jan 15, 2010 at 09:01, Vincent Massol vinc...@massol.net wrote: Hi, Just got an idea: Create an AbstractComponentTestCase implementation that does this in its setup/init() method: - automatically ask the Component Manager for the list of dependencies for the component under test

Re: [xwiki-devs] [proposal] Migrating the captcha plugin to a component

2010-01-15 Thread Caleb James DeLisle
I'm assuming you are referring to $captcha.getServletId($request) I said getServletId because I couldn't think of a way a request could yield any other type of id, maybe you can think of one? I do want to use captchaId for: $captcha.isAnswerCorrect($servletId, $answer) the method would look

Re: [xwiki-devs] [proposal][discussion]Object properties references

2010-01-15 Thread Vincent Massol
Hi Anca, On Jan 13, 2010, at 1:42 PM, Anca Luca wrote: Hi devs, Short story: 1/ add the CLASS, OBJECT, PROPERTY EntityTypes in the model +1 2/ serialization for referencing a property of an object a) wiki:Space.Page^className[objectNumber]#property b)

[xwiki-devs] [UX][Proposal] Annotation UI Improvements

2010-01-15 Thread Ecaterina Valica
Hi, I made some UI suggestions for the annotations. Overview: http://incubator.myxwiki.org/xwiki/bin/download/Improvements/Annotations/proposalAnn.png Details: http://incubator.myxwiki.org/xwiki/bin/view/Improvements/AnnotationsProposal Please let us (me and Anca) know what you think. Thanks,

Re: [xwiki-devs] [UX][Proposal] Annotation UI Improvements

2010-01-15 Thread Thibaut DEVERAUX
Hi Cathy, No time for visuals neither looking to much in it but did you think about a single button show annotations options ? *Button at start :* Show annotations options *Clicking on the button open a menu :* Show annotations options A line showing the users names by colors (if

Re: [xwiki-devs] [UX][Proposal] Annotation UI Improvements

2010-01-15 Thread Ludovic Dubost
I'm not sure if one button is better than showing upfront some information. It might be something we might have as an option in the Wiki. And we need a way to collapse it.. However one thing I'm quite sure of, is that it's enough blue bars.. so we need something less visible in the page..

[xwiki-devs] [ANN] XWiki Enterprise 2.2 Milestone 1 Released

2010-01-15 Thread Thomas Mortagne
The XWiki development team is pleased to announce the release of XWiki Enterprise 2.2 Milestone 1. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download This is first milestone of the XWiki Enterprise 2.2 version. This release mainly introduces new Model, the possibility to register

Re: [xwiki-devs] [UX][Proposal] Annotation UI Improvements

2010-01-15 Thread Thibaut DEVERAUX
I'm ok to the add button. This was only a very quick axis for reflexion. I agree to ludovic on the point there is a need on something less visible on the page. Imo we can also make it more simple in the toughts. As I can't sleep this morning I have made some more constructed UX about the