Re: [xwiki-devs] Proposal for Macro inline edition

2018-09-17 Thread Thomas Mortagne
On Mon, Sep 17, 2018 at 9:52 AM Vincent Massol wrote: > > Hi Simon and all, > > After thinking about this (and not being to sleep one night for some hours > about it ;)), I have the following problems with the proposal so far: > * It doesn’t address macro content types that are NOT in the current

Re: [xwiki-devs] [UX] XClass Picker

2018-09-17 Thread Ecaterina Moraru (Valica)
On Mon, Sep 17, 2018 at 10:32 AM Marius Dumitru Florea < mariusdumitru.flo...@xwiki.com> wrote: > Looks good. > > You have some screen shots with Add Class title and Add button while others > have Select Class title and Select button. I assume you propose the later, > because "Add Class" doesn't m

Re: [xwiki-devs] [UX] XClass Picker

2018-09-17 Thread Ecaterina Moraru (Valica)
On Fri, Sep 14, 2018 at 7:27 PM Vincent Massol wrote: > Hi Caty, > > Good work, I like it! :) > > One detail, I think the way to launch the class modal is not visible > enough. Also, wouldn’t it be better for general consistency if it were a > button rather than a link (it would also be more visi

Re: [xwiki-devs] Proposal for Macro inline edition

2018-09-17 Thread Vincent Massol
Hi Simon and all, After thinking about this (and not being to sleep one night for some hours about it ;)), I have the following problems with the proposal so far: * It doesn’t address macro content types that are NOT in the current document’s syntax. * The API is awkward since the proposal is t

Re: [xwiki-devs] [UX] XClass Picker

2018-09-17 Thread Marius Dumitru Florea
Looks good. You have some screen shots with Add Class title and Add button while others have Select Class title and Select button. I assume you propose the later, because "Add Class" doesn't make sense in this context. We'll need a Deprecated category at some point. Thanks, Marius On Fri, Sep 1