Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-24 Thread Thomas Mortagne
It's just a pity that BaseClass#addPageField was released already released (making page the default now would mean breaking ab API). On Sun, Sep 23, 2018 at 6:22 PM Adel Atallah wrote: > > Hello Vincent, > > On Sun, Sep 23, 2018 at 3:08 PM Vincent Massol wrote: > > > > Hi Adel, > > > > FTR the

Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-23 Thread Adel Atallah
Hello Vincent, On Sun, Sep 23, 2018 at 3:08 PM Vincent Massol wrote: > > Hi Adel, > > FTR the issue https://jira.xwiki.org/browse/XWIKI-15582 is missing several > piece of info: > * affects version > * component Thanks, I've updated the issue. > Regarding the topic, it seems that XWIKI-15582

Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-23 Thread Vincent Massol
Hi Adel, FTR the issue https://jira.xwiki.org/browse/XWIKI-15582 is missing several piece of info: * affects version * component Regarding the topic, it seems that XWIKI-15582 corresponds to what Thomas has suggested, right? Sounds good to me. Thanks -Vincent > On 7 Sep 2018, at 16:45, Adel

Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-07 Thread Adel Atallah
I've created a Jira issue, I would appreciate to have some feedback or changes if needed: https://jira.xwiki.org/browse/XWIKI-15582 Thanks, Adel On Fri, Sep 7, 2018 at 3:02 PM, Thomas Mortagne wrote: > On Thu, Sep 6, 2018 at 2:58 PM Adel Atallah wrote: >> >> Hi devs, >> >> Working on the

Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-07 Thread Thomas Mortagne
On Thu, Sep 6, 2018 at 2:58 PM Adel Atallah wrote: > > Hi devs, > > Working on the auto-suggestion feature [1], I've been integrating it > in xproperties holding a reference to a page. Those xproperties are of > type String and have been changed to the Page type so that the page > displayer is

Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-07 Thread Marius Dumitru Florea
On Thu, Sep 6, 2018 at 3:57 PM, Adel Atallah wrote: > Hi devs, > > Working on the auto-suggestion feature [1], I've been integrating it > in xproperties holding a reference to a page. Those xproperties are of > type String and have been changed to the Page type so that the page > displayer is

Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-06 Thread Ecaterina Moraru (Valica)
Spaces are a deprecated concept so we shouldn't create any type for them. The macros that provide such parameters should be rewritten and use only the Page param. Thanks, Caty On Thu, Sep 6, 2018 at 3:58 PM Adel Atallah wrote: > Hi devs, > > Working on the auto-suggestion feature [1], I've

[xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-06 Thread Adel Atallah
Hi devs, Working on the auto-suggestion feature [1], I've been integrating it in xproperties holding a reference to a page. Those xproperties are of type String and have been changed to the Page type so that the page displayer is used and shows the auto-suggestion when needed. I now need to