Re: [xwiki-devs] Proposal for Macro inline edition

On Mon, Oct 15, 2018 at 10:48 AM Marius Dumitru Florea wrote: > > On Tue, Oct 9, 2018 at 3:22 PM Thomas Mortagne > wrote: > > > On Tue, Oct 9, 2018 at 1:53 PM Marius Dumitru Florea > > wrote: > > > > > > On Mon, Oct 8, 2018 at 11:20 AM Thomas Mortagne < > > thomas.morta...@xwiki.com> > > >

Re: [xwiki-devs] Proposal for Macro inline edition

On Tue, Oct 9, 2018 at 3:22 PM Thomas Mortagne wrote: > On Tue, Oct 9, 2018 at 1:53 PM Marius Dumitru Florea > wrote: > > > > On Mon, Oct 8, 2018 at 11:20 AM Thomas Mortagne < > thomas.morta...@xwiki.com> > > wrote: > > > > > On Fri, Oct 5, 2018 at 6:05 PM Marius Dumitru Florea > > > wrote: >

Re: [xwiki-devs] Proposal for Macro inline edition

On Tue, Oct 9, 2018 at 1:53 PM Marius Dumitru Florea wrote: > > On Mon, Oct 8, 2018 at 11:20 AM Thomas Mortagne > wrote: > > > On Fri, Oct 5, 2018 at 6:05 PM Marius Dumitru Florea > > wrote: > > > > > > Thomas, I'm looking at how the editor can save the macro content edited > > > in-line and

Re: [xwiki-devs] Proposal for Macro inline edition

On Mon, Oct 8, 2018 at 11:20 AM Thomas Mortagne wrote: > On Fri, Oct 5, 2018 at 6:05 PM Marius Dumitru Florea > wrote: > > > > Thomas, I'm looking at how the editor can save the macro content edited > > in-line and there are two options I think: > > > > (1) The editor does a separate request to

Re: [xwiki-devs] Proposal for Macro inline edition

On Fri, Oct 5, 2018 at 6:05 PM Marius Dumitru Florea wrote: > > Thomas, I'm looking at how the editor can save the macro content edited > in-line and there are two options I think: > > (1) The editor does a separate request to a dedicated service to convert > the macro content from HTML, before

Re: [xwiki-devs] Proposal for Macro inline edition

Thomas, I'm looking at how the editor can save the macro content edited in-line and there are two options I think: (1) The editor does a separate request to a dedicated service to convert the macro content from HTML, before the entire page content is saved (2) The editor marks the macro calls

Re: [xwiki-devs] Proposal for Macro inline edition

Hi everyone, On 10/3/18 5:42 PM, Marius Dumitru Florea wrote: Hi everyone, I've started implementing this on the WYSIWYG editor side and there are two constraints that we need to be aware: (1) Macro#supportsInlineMode() must be false The CKEditor handles macros as widgets

Re: [xwiki-devs] Proposal for Macro inline edition

Hi everyone, I've started implementing this on the WYSIWYG editor side and there are two constraints that we need to be aware: (1) Macro#supportsInlineMode() must be false The CKEditor handles macros as widgets and

Re: [xwiki-devs] Proposal for Macro inline edition

Hi Thomas and all, > On 17 Sep 2018, at 12:22, Thomas Mortagne wrote: > > On Mon, Sep 17, 2018 at 9:52 AM Vincent Massol wrote: >> >> Hi Simon and all, >> >> After thinking about this (and not being to sleep one night for some hours >> about it ;)), I have the following problems with the

Re: [xwiki-devs] Proposal for Macro inline edition

On Mon, Sep 17, 2018 at 9:52 AM Vincent Massol wrote: > > Hi Simon and all, > > After thinking about this (and not being to sleep one night for some hours > about it ;)), I have the following problems with the proposal so far: > * It doesn’t address macro content types that are NOT in the

Re: [xwiki-devs] Proposal for Macro inline edition

Hi Simon and all, After thinking about this (and not being to sleep one night for some hours about it ;)), I have the following problems with the proposal so far: * It doesn’t address macro content types that are NOT in the current document’s syntax. * The API is awkward since the proposal is

Re: [xwiki-devs] Proposal for Macro inline edition

Hi everyone, I just edited the design page of the proposal after the meeting we had yesterday with Vincent, Thomas and Marius: https://design.xwiki.org/xwiki/bin/view/Main/MacroInlineEditingContent/ To quickly sum up the main parts are: - we allow to specify a type in the ContentDescriptor

Re: [xwiki-devs] Proposal for Macro inline edition

On Wed, Sep 12, 2018 at 5:56 PM Simon Urli wrote: > > > > On 9/12/18 5:45 PM, Thomas Mortagne wrote: > > Yeah I know, too many answer mails... > > > > On Wed, Sep 12, 2018 at 5:28 PM Thomas Mortagne > > wrote: > >> > >> On Wed, Sep 12, 2018 at 5:07 PM Simon Urli wrote: > >>> > >>> > >>> > >>>

Re: [xwiki-devs] Proposal for Macro inline edition

On 9/12/18 5:45 PM, Thomas Mortagne wrote: Yeah I know, too many answer mails... On Wed, Sep 12, 2018 at 5:28 PM Thomas Mortagne wrote: On Wed, Sep 12, 2018 at 5:07 PM Simon Urli wrote: On 9/12/18 5:02 PM, Marius Dumitru Florea wrote: On Wed, Sep 12, 2018 at 5:18 PM, Simon Urli

Re: [xwiki-devs] Proposal for Macro inline edition

Yeah I know, too many answer mails... On Wed, Sep 12, 2018 at 5:28 PM Thomas Mortagne wrote: > > On Wed, Sep 12, 2018 at 5:07 PM Simon Urli wrote: > > > > > > > > On 9/12/18 5:02 PM, Marius Dumitru Florea wrote: > > > On Wed, Sep 12, 2018 at 5:18 PM, Simon Urli wrote: > > > > > >> Hello

Re: [xwiki-devs] Proposal for Macro inline edition

On Wed, Sep 12, 2018 at 6:30 PM, Thomas Mortagne wrote: > On Wed, Sep 12, 2018 at 5:27 PM Marius Dumitru Florea > wrote: > > > > On Wed, Sep 12, 2018 at 6:20 PM, Thomas Mortagne < > thomas.morta...@xwiki.com> > > wrote: > > > > > On Wed, Sep 12, 2018 at 5:16 PM Marius Dumitru Florea > > >

Re: [xwiki-devs] Proposal for Macro inline edition

-- Denis Gervalle SOFTEC sa - CEO On 12 Sep 2018, 17:20 +0200, Thomas Mortagne , wrote: > On Wed, Sep 12, 2018 at 5:16 PM Marius Dumitru Florea > wrote: > > > > On Wed, Sep 12, 2018 at 6:02 PM, Marius Dumitru Florea < > > mariusdumitru.flo...@xwiki.com> wrote: > > > > > On Wed, Sep 12, 2018 at

Re: [xwiki-devs] Proposal for Macro inline edition

On Wed, Sep 12, 2018 at 5:27 PM Marius Dumitru Florea wrote: > > On Wed, Sep 12, 2018 at 6:20 PM, Thomas Mortagne > wrote: > > > On Wed, Sep 12, 2018 at 5:16 PM Marius Dumitru Florea > > wrote: > > > > > > On Wed, Sep 12, 2018 at 6:02 PM, Marius Dumitru Florea < > > >

Re: [xwiki-devs] Proposal for Macro inline edition

On Wed, Sep 12, 2018 at 5:07 PM Simon Urli wrote: > > > > On 9/12/18 5:02 PM, Marius Dumitru Florea wrote: > > On Wed, Sep 12, 2018 at 5:18 PM, Simon Urli wrote: > > > >> Hello everyone, > >> > >> as a follow up of this proposal and the discussion we had, I just created > >> the following design

Re: [xwiki-devs] Proposal for Macro inline edition

On Wed, Sep 12, 2018 at 6:20 PM, Thomas Mortagne wrote: > On Wed, Sep 12, 2018 at 5:16 PM Marius Dumitru Florea > wrote: > > > > On Wed, Sep 12, 2018 at 6:02 PM, Marius Dumitru Florea < > > mariusdumitru.flo...@xwiki.com> wrote: > > > > > On Wed, Sep 12, 2018 at 5:18 PM, Simon Urli > wrote: >

Re: [xwiki-devs] Proposal for Macro inline edition

On Wed, Sep 12, 2018 at 5:16 PM Marius Dumitru Florea wrote: > > On Wed, Sep 12, 2018 at 6:02 PM, Marius Dumitru Florea < > mariusdumitru.flo...@xwiki.com> wrote: > > > On Wed, Sep 12, 2018 at 5:18 PM, Simon Urli wrote: > > > >> Hello everyone, > >> > >> as a follow up of this proposal and the

Re: [xwiki-devs] Proposal for Macro inline edition

On Wed, Sep 12, 2018 at 6:02 PM, Marius Dumitru Florea < mariusdumitru.flo...@xwiki.com> wrote: > On Wed, Sep 12, 2018 at 5:18 PM, Simon Urli wrote: > >> Hello everyone, >> >> as a follow up of this proposal and the discussion we had, I just created >> the following design proposal: >> >>

Re: [xwiki-devs] Proposal for Macro inline edition

On 9/12/18 5:02 PM, Marius Dumitru Florea wrote: On Wed, Sep 12, 2018 at 5:18 PM, Simon Urli wrote: Hello everyone, as a follow up of this proposal and the discussion we had, I just created the following design proposal:

Re: [xwiki-devs] Proposal for Macro inline edition

On Wed, Sep 12, 2018 at 5:18 PM, Simon Urli wrote: > Hello everyone, > > as a follow up of this proposal and the discussion we had, I just created > the following design proposal: > > https://design.xwiki.org/xwiki/bin/view/Main/MacroInlineEditingContent/ > > Let me know what you think about it.

Re: [xwiki-devs] Proposal for Macro inline edition

Hello everyone, as a follow up of this proposal and the discussion we had, I just created the following design proposal: https://design.xwiki.org/xwiki/bin/view/Main/MacroInlineEditingContent/ Let me know what you think about it. Thanks, Simon On 9/10/18 6:46 PM, Thomas Mortagne wrote: On

Re: [xwiki-devs] Proposal for Macro inline edition

On Mon, Sep 10, 2018 at 3:47 PM Simon Urli wrote: > > > > On 9/10/18 3:24 PM, Marius Dumitru Florea wrote: > > On Mon, Sep 10, 2018 at 4:07 PM, Thomas Mortagne > > wrote: > > > >> On Mon, Sep 10, 2018 at 2:56 PM Marius Dumitru Florea > >> wrote: > >>> > >>> On Mon, Sep 10, 2018 at 3:42 PM,

Re: [xwiki-devs] Proposal for Macro inline edition

On 9/10/18 3:24 PM, Marius Dumitru Florea wrote: On Mon, Sep 10, 2018 at 4:07 PM, Thomas Mortagne wrote: On Mon, Sep 10, 2018 at 2:56 PM Marius Dumitru Florea wrote: On Mon, Sep 10, 2018 at 3:42 PM, Thomas Mortagne < thomas.morta...@xwiki.com> wrote: On Mon, Sep 10, 2018 at 2:13 PM

Re: [xwiki-devs] Proposal for Macro inline edition

On Mon, Sep 10, 2018 at 4:07 PM, Thomas Mortagne wrote: > On Mon, Sep 10, 2018 at 2:56 PM Marius Dumitru Florea > wrote: > > > > On Mon, Sep 10, 2018 at 3:42 PM, Thomas Mortagne < > thomas.morta...@xwiki.com> > > wrote: > > > > > On Mon, Sep 10, 2018 at 2:13 PM Simon Urli > wrote: > > > > > >

Re: [xwiki-devs] Proposal for Macro inline edition

On Mon, Sep 10, 2018 at 2:56 PM Marius Dumitru Florea wrote: > > On Mon, Sep 10, 2018 at 3:42 PM, Thomas Mortagne > wrote: > > > On Mon, Sep 10, 2018 at 2:13 PM Simon Urli wrote: > > > > > > > > > > > > On 9/10/18 1:35 PM, Vincent Massol wrote: > > > > Hi Simon, > > > > > > > >> On 10 Sep 2018,

Re: [xwiki-devs] Proposal for Macro inline edition

On Mon, Sep 10, 2018 at 3:42 PM, Thomas Mortagne wrote: > On Mon, Sep 10, 2018 at 2:13 PM Simon Urli wrote: > > > > > > > > On 9/10/18 1:35 PM, Vincent Massol wrote: > > > Hi Simon, > > > > > >> On 10 Sep 2018, at 13:05, Simon Urli wrote: > > >> > > >> Hi everyone, > > >> > > >> I'm working on

Re: [xwiki-devs] Proposal for Macro inline edition

On Mon, Sep 10, 2018 at 2:35 PM, Vincent Massol wrote: > Hi Simon, > > > On 10 Sep 2018, at 13:05, Simon Urli wrote: > > > > Hi everyone, > > > > I'm working on the roadmap issues related to the inline edition with > WYSIWYG editor for macro content and macro parameters. > > Cool :) We've been

Re: [xwiki-devs] Proposal for Macro inline edition

On Mon, Sep 10, 2018 at 2:13 PM Simon Urli wrote: > > > > On 9/10/18 1:35 PM, Vincent Massol wrote: > > Hi Simon, > > > >> On 10 Sep 2018, at 13:05, Simon Urli wrote: > >> > >> Hi everyone, > >> > >> I'm working on the roadmap issues related to the inline edition with > >> WYSIWYG editor for

Re: [xwiki-devs] Proposal for Macro inline edition

On 9/10/18 1:35 PM, Vincent Massol wrote: Hi Simon, On 10 Sep 2018, at 13:05, Simon Urli wrote: Hi everyone, I'm working on the roadmap issues related to the inline edition with WYSIWYG editor for macro content and macro parameters. Cool :) We've been waiting for a long time about

Re: [xwiki-devs] Proposal for Macro inline edition

Hi Simon, > On 10 Sep 2018, at 13:05, Simon Urli wrote: > > Hi everyone, > > I'm working on the roadmap issues related to the inline edition with WYSIWYG > editor for macro content and macro parameters. Cool :) We've been waiting for a long time about this feature! See below. > The first

[xwiki-devs] Proposal for Macro inline edition

Hi everyone, I'm working on the roadmap issues related to the inline edition with WYSIWYG editor for macro content and macro parameters. The first step is to add a flag to allow user specify that a content or a parameter can be edited inline with the WYSIWYG editor. The second step is to