Re: [xwiki-devs] Map Application - GSoC 19

2019-09-04 Thread Stéphane Laurière

Hi Fawad, Caty, hi all,

I tested the latest version on my side and the fix work fine with me as well, 
that's cool, so Fawad I'd say also that you can go ahead with the release 
indeed.

Cheers

Stéphane


Ecaterina Moraru (Valica):

Yes, please do :)

Thanks,
Caty

On Wed, Sep 4, 2019, 14:13 Fawad Ali mailto:m.fawaadal...@gmail.com>> wrote:

Hi all,

All the key issues pointed out by Stephane are fixed.
Should we move on to release the application?

Best,
Fawad




Re: [xwiki-devs] Map Application - GSoC 19

2019-09-04 Thread Ecaterina Moraru (Valica)
Yes, please do :)

Thanks,
Caty

On Wed, Sep 4, 2019, 14:13 Fawad Ali  wrote:

> Hi all,
>
> All the key issues pointed out by Stephane are fixed.
> Should we move on to release the application?
>
> Best,
> Fawad
>
> On Wed, Sep 4, 2019 at 1:39 PM Stéphane Laurière 
> wrote:
>
>> Yes, thumbs up for your involvement, Fawad.
>>
>> Collaborative maps have been burgeoning in many places in the last years,
>> I'm optimistic about the fact taat the app paves the way for nice usages
>> ahead.
>>
>> Regarding the review, bear in mind that part of the exercise consisted in
>> scratching our head to find some aspects that could get considered as
>> recommendations for improvement :-). I owe you an apology for testing the
>> latest version late in the process.
>>
>> Good luck with the 1.1 release,
>>
>> Cheers
>>
>> Stéphane
>>
>>
>> Ecaterina Moraru (Valica):
>> > Hi Fawad,
>> >
>> > Thank you also for your hard work and I'm glad you had a nice time
>> during GSOC.
>> >
>> > Thanks also for providing some status and I will be waiting to install
>> the latest version and see the feedback the others community members will
>> have.
>> >
>> > Caty
>> >
>> > On Tue, Sep 3, 2019 at 9:28 PM Fawad Ali > > wrote:
>> >
>> > Hi all,
>> > Hope you are doing good.
>> >
>> > I just received the mail from Google for the final evaluations.
>> Thanks for all the kind words. It is an absolutely wonderful experience to
>> work on this project!
>> >
>> > Regarding the release, I would like to inform you that the
>> documentation for releasing the second version was actually prepared during
>> the GSoC period. Due to several unprecedented issues like the leaflet
>> webjar not loading up (even with no change in dependencies) the release was
>> postponed as opposed to my plan to release the application on the last day
>> of GSoC. After that, several issues were opened by Stephane. It is a
>> mistake on my part for not taking these unprecedented circumstances into
>> account but the release will surely be done sometime around this week.
>> >
>> > Thanks,
>> > Fawad
>> >
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-09-04 Thread Fawad Ali
Hi all,

All the key issues pointed out by Stephane are fixed.
Should we move on to release the application?

Best,
Fawad

On Wed, Sep 4, 2019 at 1:39 PM Stéphane Laurière 
wrote:

> Yes, thumbs up for your involvement, Fawad.
>
> Collaborative maps have been burgeoning in many places in the last years,
> I'm optimistic about the fact taat the app paves the way for nice usages
> ahead.
>
> Regarding the review, bear in mind that part of the exercise consisted in
> scratching our head to find some aspects that could get considered as
> recommendations for improvement :-). I owe you an apology for testing the
> latest version late in the process.
>
> Good luck with the 1.1 release,
>
> Cheers
>
> Stéphane
>
>
> Ecaterina Moraru (Valica):
> > Hi Fawad,
> >
> > Thank you also for your hard work and I'm glad you had a nice time
> during GSOC.
> >
> > Thanks also for providing some status and I will be waiting to install
> the latest version and see the feedback the others community members will
> have.
> >
> > Caty
> >
> > On Tue, Sep 3, 2019 at 9:28 PM Fawad Ali  > wrote:
> >
> > Hi all,
> > Hope you are doing good.
> >
> > I just received the mail from Google for the final evaluations.
> Thanks for all the kind words. It is an absolutely wonderful experience to
> work on this project!
> >
> > Regarding the release, I would like to inform you that the
> documentation for releasing the second version was actually prepared during
> the GSoC period. Due to several unprecedented issues like the leaflet
> webjar not loading up (even with no change in dependencies) the release was
> postponed as opposed to my plan to release the application on the last day
> of GSoC. After that, several issues were opened by Stephane. It is a
> mistake on my part for not taking these unprecedented circumstances into
> account but the release will surely be done sometime around this week.
> >
> > Thanks,
> > Fawad
> >
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-09-04 Thread Stéphane Laurière

Yes, thumbs up for your involvement, Fawad.

Collaborative maps have been burgeoning in many places in the last years, I'm 
optimistic about the fact taat the app paves the way for nice usages ahead.

Regarding the review, bear in mind that part of the exercise consisted in 
scratching our head to find some aspects that could get considered as 
recommendations for improvement :-). I owe you an apology for testing the 
latest version late in the process.

Good luck with the 1.1 release,

Cheers

Stéphane


Ecaterina Moraru (Valica):

Hi Fawad,

Thank you also for your hard work and I'm glad you had a nice time during GSOC.

Thanks also for providing some status and I will be waiting to install the 
latest version and see the feedback the others community members will have.

Caty

On Tue, Sep 3, 2019 at 9:28 PM Fawad Ali mailto:m.fawaadal...@gmail.com>> wrote:

Hi all,
Hope you are doing good.

I just received the mail from Google for the final evaluations. Thanks for 
all the kind words. It is an absolutely wonderful experience to work on this 
project!

Regarding the release, I would like to inform you that the documentation 
for releasing the second version was actually prepared during the GSoC period. 
Due to several unprecedented issues like the leaflet webjar not loading up 
(even with no change in dependencies) the release was postponed as opposed to 
my plan to release the application on the last day of GSoC. After that, several 
issues were opened by Stephane. It is a mistake on my part for not taking these 
unprecedented circumstances into account but the release will surely be done 
sometime around this week.

Thanks,
Fawad





Re: [xwiki-devs] Map Application - GSoC 19

2019-09-03 Thread Ecaterina Moraru (Valica)
Hi Fawad,

Thank you also for your hard work and I'm glad you had a nice time during
GSOC.

Thanks also for providing some status and I will be waiting to install the
latest version and see the feedback the others community members will have.

Caty

On Tue, Sep 3, 2019 at 9:28 PM Fawad Ali  wrote:

> Hi all,
> Hope you are doing good.
>
> I just received the mail from Google for the final evaluations. Thanks for
> all the kind words. It is an absolutely wonderful experience to work on
> this project!
>
> Regarding the release, I would like to inform you that the documentation
> for releasing the second version was actually prepared during the GSoC
> period. Due to several unprecedented issues like the leaflet webjar not
> loading up (even with no change in dependencies) the release was postponed
> as opposed to my plan to release the application on the last day of GSoC.
> After that, several issues were opened by Stephane. It is a mistake on my
> part for not taking these unprecedented circumstances into account but the
> release will surely be done sometime around this week.
>
> Thanks,
> Fawad
>
>
> On Sun, Sep 1, 2019 at 10:51 PM Stéphane Laurière 
> wrote:
>
>> Caty, Fawad, all,
>>
>> > Hi,
>> >
>> > What I would like is a working version of the application that can be
>> installed, as a final version that can be linked and showed the work done.
>>
>> Indeed, it'd be a cool achievement.
>>
>> > On Sun, Sep 1, 2019 at 5:48 PM Stéphane Laurière > > wrote:
>> >
>> > Hi Caty, Fawad, all,
>> >
>> > There's been much progress on the app recently by Fawad, that's
>> great, I spotted a few issues that are likely to block the release indeed,
>> not many, most of the entries I created on Jira today are improvement
>> suggestions for upcoming releases. The three key ones imho are:
>> >
>> > - JavaScript instability on map at Demo.WebHome
>> https://jira.xwiki.org/browse/INTMAP-76 – In case this is too long to
>> fix, I'd suggest we remove the indoor feature from the demo for the release
>> itself, so that we get a 100% working demo, what do you think? Obviously
>> fixing it would be even better, let me know if you need help Fawad.
>> >
>> > - Leaflet configuration issue on installation
>> https://jira.xwiki.org/browse/INTMAP-74 – Removing the version number
>> seems to work fine with all recent XWiki versions and matches the
>> WebjarScriptService documentation, to be tested further, and we will need
>> to investigate what fails with the continuous integration, but not a
>> blocker issue imho.
>> >
>> > - JSON format errors on map at Demo.WebHome
>> https://jira.xwiki.org/browse/INTMAP-75
>> >
>> > Fixing the overflow issue would be nice as well since it would
>> enhance the first live contact of the user with the app:
>> https://jira.xwiki.org/browse/INTMAP-85 – Unsetting the "overflow" rule
>> of #xwikicontent fixes the issue but may introduce others. The Mozilla
>> documentation page
>> https://developer.mozilla.org/en-US/docs/Web/CSS/overflow states that
>> "overflow" is useful only when a height is set or "white-space" set to
>> "nowrap". I'm wondering in which cases the height of #xwikicontent needs to
>> be set, or the "white-space" option. Do you have any idea Caty, all?
>> >
>> >
>> > We should not remove the overflow from #xwikicontent. Make sure the map
>> is clearing the floats, but I find the issue to be minor.
>>
>> Sure, we don't want to remove the overflow, I was just wondering about
>> its exact role. I'm convinced it's there for a good reason. I also agree
>> with you the issue is minor. Thanks for your suggestion about clearing the
>> float, I gave it a try with no luck so far but I'm for from having a deep
>> understanding of CSS, just a humble admirer
>>
>> Chees
>>
>> Stéphane
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-09-03 Thread Fawad Ali
Hi all,
Hope you are doing good.

I just received the mail from Google for the final evaluations. Thanks for
all the kind words. It is an absolutely wonderful experience to work on
this project!

Regarding the release, I would like to inform you that the documentation
for releasing the second version was actually prepared during the GSoC
period. Due to several unprecedented issues like the leaflet webjar not
loading up (even with no change in dependencies) the release was postponed
as opposed to my plan to release the application on the last day of GSoC.
After that, several issues were opened by Stephane. It is a mistake on my
part for not taking these unprecedented circumstances into account but the
release will surely be done sometime around this week.

Thanks,
Fawad


On Sun, Sep 1, 2019 at 10:51 PM Stéphane Laurière 
wrote:

> Caty, Fawad, all,
>
> > Hi,
> >
> > What I would like is a working version of the application that can be
> installed, as a final version that can be linked and showed the work done.
>
> Indeed, it'd be a cool achievement.
>
> > On Sun, Sep 1, 2019 at 5:48 PM Stéphane Laurière  > wrote:
> >
> > Hi Caty, Fawad, all,
> >
> > There's been much progress on the app recently by Fawad, that's
> great, I spotted a few issues that are likely to block the release indeed,
> not many, most of the entries I created on Jira today are improvement
> suggestions for upcoming releases. The three key ones imho are:
> >
> > - JavaScript instability on map at Demo.WebHome
> https://jira.xwiki.org/browse/INTMAP-76 – In case this is too long to
> fix, I'd suggest we remove the indoor feature from the demo for the release
> itself, so that we get a 100% working demo, what do you think? Obviously
> fixing it would be even better, let me know if you need help Fawad.
> >
> > - Leaflet configuration issue on installation
> https://jira.xwiki.org/browse/INTMAP-74 – Removing the version number
> seems to work fine with all recent XWiki versions and matches the
> WebjarScriptService documentation, to be tested further, and we will need
> to investigate what fails with the continuous integration, but not a
> blocker issue imho.
> >
> > - JSON format errors on map at Demo.WebHome
> https://jira.xwiki.org/browse/INTMAP-75
> >
> > Fixing the overflow issue would be nice as well since it would
> enhance the first live contact of the user with the app:
> https://jira.xwiki.org/browse/INTMAP-85 – Unsetting the "overflow" rule
> of #xwikicontent fixes the issue but may introduce others. The Mozilla
> documentation page
> https://developer.mozilla.org/en-US/docs/Web/CSS/overflow states that
> "overflow" is useful only when a height is set or "white-space" set to
> "nowrap". I'm wondering in which cases the height of #xwikicontent needs to
> be set, or the "white-space" option. Do you have any idea Caty, all?
> >
> >
> > We should not remove the overflow from #xwikicontent. Make sure the map
> is clearing the floats, but I find the issue to be minor.
>
> Sure, we don't want to remove the overflow, I was just wondering about its
> exact role. I'm convinced it's there for a good reason. I also agree with
> you the issue is minor. Thanks for your suggestion about clearing the
> float, I gave it a try with no luck so far but I'm for from having a deep
> understanding of CSS, just a humble admirer
>
> Chees
>
> Stéphane
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-09-01 Thread Stéphane Laurière

Caty, Fawad, all,


Hi,

What I would like is a working version of the application that can be 
installed, as a final version that can be linked and showed the work done.


Indeed, it'd be a cool achievement.


On Sun, Sep 1, 2019 at 5:48 PM Stéphane Laurière mailto:slauri...@xwiki.com>> wrote:

Hi Caty, Fawad, all,

There's been much progress on the app recently by Fawad, that's great, I 
spotted a few issues that are likely to block the release indeed, not many, 
most of the entries I created on Jira today are improvement suggestions for 
upcoming releases. The three key ones imho are:

- JavaScript instability on map at Demo.WebHome 
https://jira.xwiki.org/browse/INTMAP-76 – In case this is too long to fix, I'd 
suggest we remove the indoor feature from the demo for the release itself, so 
that we get a 100% working demo, what do you think? Obviously fixing it would 
be even better, let me know if you need help Fawad.

- Leaflet configuration issue on installation 
https://jira.xwiki.org/browse/INTMAP-74 – Removing the version number seems to 
work fine with all recent XWiki versions and matches the WebjarScriptService 
documentation, to be tested further, and we will need to investigate what fails 
with the continuous integration, but not a blocker issue imho.

- JSON format errors on map at Demo.WebHome 
https://jira.xwiki.org/browse/INTMAP-75

Fixing the overflow issue would be nice as well since it would enhance the first live contact of the user with the app: 
https://jira.xwiki.org/browse/INTMAP-85 – Unsetting the "overflow" rule of #xwikicontent fixes the issue but may 
introduce others. The Mozilla documentation page https://developer.mozilla.org/en-US/docs/Web/CSS/overflow states that 
"overflow" is useful only when a height is set or "white-space" set to "nowrap". I'm wondering in 
which cases the height of #xwikicontent needs to be set, or the "white-space" option. Do you have any idea Caty, all?


We should not remove the overflow from #xwikicontent. Make sure the map is 
clearing the floats, but I find the issue to be minor.


Sure, we don't want to remove the overflow, I was just wondering about its 
exact role. I'm convinced it's there for a good reason. I also agree with you 
the issue is minor. Thanks for your suggestion about clearing the float, I gave 
it a try with no luck so far but I'm for from having a deep understanding of 
CSS, just a humble admirer

Chees

Stéphane



Re: [xwiki-devs] Map Application - GSoC 19

2019-09-01 Thread Stéphane Laurière

Hi Fawad,

Thank you for letting us know. I hope your new university session tomorrow will 
meet your expectations and I wish you a great training year ahead.

I don't want to add complexity to the process so I'm not touching anything in 
the code, but I'm at your disposal for any help or any code contributions you'd 
like to get toward the 1.1 release.

Thumbs up for your involvement in the project and good luck with the steps of 
this Google Summer of Code,

Stéphane




Hi Stephane, Ecaterina and all,

I will try solving the key issues as soon as possible so we can move on with 
the release. It might take some time because my summer break is over and the 
University opens tomorrow.
But I will make sure all of these are done soon.

Best,
Fawad





Re: [xwiki-devs] Map Application - GSoC 19

2019-09-01 Thread Fawad Ali
Hi Stephane, Ecaterina and all,

I will try solving the key issues as soon as possible so we can move on
with the release. It might take some time because my summer break is over
and the University opens tomorrow.
But I will make sure all of these are done soon.

Best,
Fawad


On Sun, Sep 1, 2019 at 7:54 PM Ecaterina Moraru (Valica) 
wrote:

> Hi,
>
> What I would like is a working version of the application that can be
> installed, as a final version that can be linked and showed the work done.
>
> On Sun, Sep 1, 2019 at 5:48 PM Stéphane Laurière 
> wrote:
>
>> Hi Caty, Fawad, all,
>>
>> There's been much progress on the app recently by Fawad, that's great, I
>> spotted a few issues that are likely to block the release indeed, not many,
>> most of the entries I created on Jira today are improvement suggestions for
>> upcoming releases. The three key ones imho are:
>>
>> - JavaScript instability on map at Demo.WebHome
>> https://jira.xwiki.org/browse/INTMAP-76 – In case this is too long to
>> fix, I'd suggest we remove the indoor feature from the demo for the release
>> itself, so that we get a 100% working demo, what do you think? Obviously
>> fixing it would be even better, let me know if you need help Fawad.
>>
>> - Leaflet configuration issue on installation
>> https://jira.xwiki.org/browse/INTMAP-74 – Removing the version number
>> seems to work fine with all recent XWiki versions and matches the
>> WebjarScriptService documentation, to be tested further, and we will need
>> to investigate what fails with the continuous integration, but not a
>> blocker issue imho.
>>
>> - JSON format errors on map at Demo.WebHome
>> https://jira.xwiki.org/browse/INTMAP-75
>>
>> Fixing the overflow issue would be nice as well since it would enhance
>> the first live contact of the user with the app:
>> https://jira.xwiki.org/browse/INTMAP-85 – Unsetting the "overflow" rule
>> of #xwikicontent fixes the issue but may introduce others. The Mozilla
>> documentation page
>> https://developer.mozilla.org/en-US/docs/Web/CSS/overflow states that
>> "overflow" is useful only when a height is set or "white-space" set to
>> "nowrap". I'm wondering in which cases the height of #xwikicontent needs to
>> be set, or the "white-space" option. Do you have any idea Caty, all?
>>
>
> We should not remove the overflow from #xwikicontent. Make sure the map is
> clearing the floats, but I find the issue to be minor.
>
> Thanks,
> Caty
>
>
>> Cheers
>>
>> Stéphane
>>
>>
>>
>> Fawad Ali:
>> > Hi Ecaterina,
>> > Hope you are well.
>> >
>> > I was waiting for a complete review from Stephane.
>> > There are some issues that he brought forward today. The application
>> will be released as soon as those issues are resolved.
>> >
>> > Thanks,
>> > Fawad
>> >
>> > On Sun, Sep 1, 2019, 6:59 PM Ecaterina Moraru (Valica) <
>> vali...@gmail.com > wrote:
>> >
>> > Fawad, can you make sure you've released the application on
>> Contrib? I don't see a new version on GitHub or on e.x.o.
>> >
>> > Thanks,
>> > Caty
>>
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-09-01 Thread Ecaterina Moraru (Valica)
Hi,

What I would like is a working version of the application that can be
installed, as a final version that can be linked and showed the work done.

On Sun, Sep 1, 2019 at 5:48 PM Stéphane Laurière 
wrote:

> Hi Caty, Fawad, all,
>
> There's been much progress on the app recently by Fawad, that's great, I
> spotted a few issues that are likely to block the release indeed, not many,
> most of the entries I created on Jira today are improvement suggestions for
> upcoming releases. The three key ones imho are:
>
> - JavaScript instability on map at Demo.WebHome
> https://jira.xwiki.org/browse/INTMAP-76 – In case this is too long to
> fix, I'd suggest we remove the indoor feature from the demo for the release
> itself, so that we get a 100% working demo, what do you think? Obviously
> fixing it would be even better, let me know if you need help Fawad.
>
> - Leaflet configuration issue on installation
> https://jira.xwiki.org/browse/INTMAP-74 – Removing the version number
> seems to work fine with all recent XWiki versions and matches the
> WebjarScriptService documentation, to be tested further, and we will need
> to investigate what fails with the continuous integration, but not a
> blocker issue imho.
>
> - JSON format errors on map at Demo.WebHome
> https://jira.xwiki.org/browse/INTMAP-75
>
> Fixing the overflow issue would be nice as well since it would enhance the
> first live contact of the user with the app:
> https://jira.xwiki.org/browse/INTMAP-85 – Unsetting the "overflow" rule
> of #xwikicontent fixes the issue but may introduce others. The Mozilla
> documentation page
> https://developer.mozilla.org/en-US/docs/Web/CSS/overflow states that
> "overflow" is useful only when a height is set or "white-space" set to
> "nowrap". I'm wondering in which cases the height of #xwikicontent needs to
> be set, or the "white-space" option. Do you have any idea Caty, all?
>

We should not remove the overflow from #xwikicontent. Make sure the map is
clearing the floats, but I find the issue to be minor.

Thanks,
Caty


> Cheers
>
> Stéphane
>
>
>
> Fawad Ali:
> > Hi Ecaterina,
> > Hope you are well.
> >
> > I was waiting for a complete review from Stephane.
> > There are some issues that he brought forward today. The application
> will be released as soon as those issues are resolved.
> >
> > Thanks,
> > Fawad
> >
> > On Sun, Sep 1, 2019, 6:59 PM Ecaterina Moraru (Valica) <
> vali...@gmail.com > wrote:
> >
> > Fawad, can you make sure you've released the application on Contrib?
> I don't see a new version on GitHub or on e.x.o.
> >
> > Thanks,
> > Caty
>
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-09-01 Thread Stéphane Laurière

Hi Caty, Fawad, all,

There's been much progress on the app recently by Fawad, that's great, I 
spotted a few issues that are likely to block the release indeed, not many, 
most of the entries I created on Jira today are improvement suggestions for 
upcoming releases. The three key ones imho are:

- JavaScript instability on map at Demo.WebHome 
https://jira.xwiki.org/browse/INTMAP-76 – In case this is too long to fix, I'd 
suggest we remove the indoor feature from the demo for the release itself, so 
that we get a 100% working demo, what do you think? Obviously fixing it would 
be even better, let me know if you need help Fawad.

- Leaflet configuration issue on installation 
https://jira.xwiki.org/browse/INTMAP-74 – Removing the version number seems to 
work fine with all recent XWiki versions and matches the WebjarScriptService 
documentation, to be tested further, and we will need to investigate what fails 
with the continuous integration, but not a blocker issue imho.

- JSON format errors on map at Demo.WebHome 
https://jira.xwiki.org/browse/INTMAP-75

Fixing the overflow issue would be nice as well since it would enhance the first live contact of the user with the app: 
https://jira.xwiki.org/browse/INTMAP-85 – Unsetting the "overflow" rule of #xwikicontent fixes the issue but may 
introduce others. The Mozilla documentation page https://developer.mozilla.org/en-US/docs/Web/CSS/overflow states that 
"overflow" is useful only when a height is set or "white-space" set to "nowrap". I'm wondering in 
which cases the height of #xwikicontent needs to be set, or the "white-space" option. Do you have any idea Caty, all?

Cheers

Stéphane



Fawad Ali:

Hi Ecaterina,
Hope you are well.

I was waiting for a complete review from Stephane.
There are some issues that he brought forward today. The application will be 
released as soon as those issues are resolved.

Thanks,
Fawad

On Sun, Sep 1, 2019, 6:59 PM Ecaterina Moraru (Valica) mailto:vali...@gmail.com>> wrote:

Fawad, can you make sure you've released the application on Contrib? I 
don't see a new version on GitHub or on e.x.o.

Thanks,
Caty





Re: [xwiki-devs] Map Application - GSoC 19

2019-09-01 Thread Fawad Ali
Hi Ecaterina,
Hope you are well.

I was waiting for a complete review from Stephane.
There are some issues that he brought forward today. The application will
be released as soon as those issues are resolved.

Thanks,
Fawad

On Sun, Sep 1, 2019, 6:59 PM Ecaterina Moraru (Valica) 
wrote:

> Fawad, can you make sure you've released the application on Contrib? I
> don't see a new version on GitHub or on e.x.o.
>
> Thanks,
> Caty
>
> On Sun, Aug 25, 2019 at 9:41 PM Fawad Ali  wrote:
>
>> Hi all,
>> Hope you are all well.
>>
>> Can I prepare my report on gist if that's all right?
>> The current application page feels more like a progress then a report.
>> I want to make the report minimal so that future readers can easily get
>> the idea without having to dive too much into details.
>> I will link all the necessary pages on the gist.
>>
>> Best,
>> Fawad
>>
>>
>> On Sun, Aug 25, 2019 at 1:49 AM Fawad Ali 
>> wrote:
>>
>>> Hi Ecaterina,
>>> Good to see you, hope you are doing well.
>>>
>>> Do you mean "org.webjars.bowergithub.9inpachi"? This is deployed on
>>> http://webjars.org
>>> I am not sure what could be wrong here. Even the leaflet dependency is
>>> not being installed in the latest tests. After installing Extension Manager
>>> Application into the test XWiki instance, I found that for Interactive Maps
>>> Application, the leaflet dependencies were labeled as "Provided" as opposed
>>> to "Installed" for other dependencies.
>>>
>>> The tests started failing around this commit
>>> https://github.com/xwiki-contrib/application-interactive-maps/commit/e3163a2552b9a900d4756867db336f0df43cc8f6
>>>
>>> I added leaflet-indoor.js as an attachment temporarily while I was
>>> waiting for the one deployed on webjars.org to function properly. I did
>>> remove it later on and added as a dependency but that doesn't seem to have
>>> solved the problem.
>>> I feel like this is some issue with the test itself and since I haven't
>>> made any changes to the test, the test frameworks might have been updated.
>>> I don't really know the cause since all was working fine before this.
>>>
>>> Best,
>>> Fawad
>>>
>>>
>>> On Sun, Aug 25, 2019 at 1:39 AM Ecaterina Moraru (Valica) <
>>> vali...@gmail.com> wrote:
>>>


 On Sat, Aug 24, 2019, 17:04 Fawad Ali  wrote:

> Hi all,
> Hoping you a great week-end.
>
> I am having trouble testing my application because of some
> dependencies.
> This is the POM:
> https://github.com/xwiki-contrib/application-interactive-maps/blob/master/application-interactive-maps-ui/pom.xml
>

 Maybe the repositories are not found. Are the dependencies available
 from Maven Central? I see you have your own group id. Is that artifact
 published on any public repository or just local on your machine? Also,
 make sure you publish everything for the Google requirements.

 Thanks,
 Caty


> Some of the leaflet dependencies are not being installed during
> testing. I am not sure why.
> When I open a page that uses leaflet libraries I get an error from
> requirejs that the library cannot be loaded. And there is no data when I 
> go
> to the url generated by $services.webjars.url() which leads me to believe
> that the dependency is not being installed as an extension.
>
> If I manually install the dependencies into my Wiki then it works fine.
>
> Do you think there is something missing within the POM?
>
> Best,
> Fawad
>
>
> On Fri, Aug 23, 2019 at 2:42 PM Fawad Ali 
> wrote:
>
>> Hi Stéphane, Ecaterina, all,
>>
>> Stephane, this is the report that I mentioned before.
>> According to XWiki standards, what I plan to submit is a report based
>> on the format documented at
>> https://dev.xwiki.org/xwiki/bin/view/GoogleSummerOfCode/DocumentingStudentProgress
>>  .
>> I updated this work progress halfway so half of it has to be done
>> still but I am positive I will be able to do it well before time. The
>> reason I chose to focus on the daily progress is that it gives more 
>> insight
>> to the daily activities performed on the project and the report can be
>> fairly easily created with using the daily progress as a reference.
>>
>> If you have any other specific formats that you think will be better
>> then please let me know, we can follow that as well.
>>
>> Best,
>> Fawad
>>
>>
>> On Fri, Aug 23, 2019 at 1:52 PM Stéphane Laurière <
>> slauri...@xwiki.com> wrote:
>>
>>> Hi Fawad, Hi Caty, Hi all,
>>>
>>> Since the GSoC deadline for work submission is approaching, I'm
>>> confident that all is in order for you Fawad but, also since it's my 
>>> first
>>> participatoin in the program, can I ask you to let us know what you 
>>> plan to
>>> publish, when and where, so that we make sure we're in tune and don't 
>>> miss
>>> any 

Re: [xwiki-devs] Map Application - GSoC 19

2019-09-01 Thread Ecaterina Moraru (Valica)
Fawad, can you make sure you've released the application on Contrib? I
don't see a new version on GitHub or on e.x.o.

Thanks,
Caty

On Sun, Aug 25, 2019 at 9:41 PM Fawad Ali  wrote:

> Hi all,
> Hope you are all well.
>
> Can I prepare my report on gist if that's all right?
> The current application page feels more like a progress then a report.
> I want to make the report minimal so that future readers can easily get
> the idea without having to dive too much into details.
> I will link all the necessary pages on the gist.
>
> Best,
> Fawad
>
>
> On Sun, Aug 25, 2019 at 1:49 AM Fawad Ali  wrote:
>
>> Hi Ecaterina,
>> Good to see you, hope you are doing well.
>>
>> Do you mean "org.webjars.bowergithub.9inpachi"? This is deployed on
>> http://webjars.org
>> I am not sure what could be wrong here. Even the leaflet dependency is
>> not being installed in the latest tests. After installing Extension Manager
>> Application into the test XWiki instance, I found that for Interactive Maps
>> Application, the leaflet dependencies were labeled as "Provided" as opposed
>> to "Installed" for other dependencies.
>>
>> The tests started failing around this commit
>> https://github.com/xwiki-contrib/application-interactive-maps/commit/e3163a2552b9a900d4756867db336f0df43cc8f6
>>
>> I added leaflet-indoor.js as an attachment temporarily while I was
>> waiting for the one deployed on webjars.org to function properly. I did
>> remove it later on and added as a dependency but that doesn't seem to have
>> solved the problem.
>> I feel like this is some issue with the test itself and since I haven't
>> made any changes to the test, the test frameworks might have been updated.
>> I don't really know the cause since all was working fine before this.
>>
>> Best,
>> Fawad
>>
>>
>> On Sun, Aug 25, 2019 at 1:39 AM Ecaterina Moraru (Valica) <
>> vali...@gmail.com> wrote:
>>
>>>
>>>
>>> On Sat, Aug 24, 2019, 17:04 Fawad Ali  wrote:
>>>
 Hi all,
 Hoping you a great week-end.

 I am having trouble testing my application because of some dependencies.
 This is the POM:
 https://github.com/xwiki-contrib/application-interactive-maps/blob/master/application-interactive-maps-ui/pom.xml

>>>
>>> Maybe the repositories are not found. Are the dependencies available
>>> from Maven Central? I see you have your own group id. Is that artifact
>>> published on any public repository or just local on your machine? Also,
>>> make sure you publish everything for the Google requirements.
>>>
>>> Thanks,
>>> Caty
>>>
>>>
 Some of the leaflet dependencies are not being installed during
 testing. I am not sure why.
 When I open a page that uses leaflet libraries I get an error from
 requirejs that the library cannot be loaded. And there is no data when I go
 to the url generated by $services.webjars.url() which leads me to believe
 that the dependency is not being installed as an extension.

 If I manually install the dependencies into my Wiki then it works fine.

 Do you think there is something missing within the POM?

 Best,
 Fawad


 On Fri, Aug 23, 2019 at 2:42 PM Fawad Ali 
 wrote:

> Hi Stéphane, Ecaterina, all,
>
> Stephane, this is the report that I mentioned before.
> According to XWiki standards, what I plan to submit is a report based
> on the format documented at
> https://dev.xwiki.org/xwiki/bin/view/GoogleSummerOfCode/DocumentingStudentProgress
>  .
> I updated this work progress halfway so half of it has to be done
> still but I am positive I will be able to do it well before time. The
> reason I chose to focus on the daily progress is that it gives more 
> insight
> to the daily activities performed on the project and the report can be
> fairly easily created with using the daily progress as a reference.
>
> If you have any other specific formats that you think will be better
> then please let me know, we can follow that as well.
>
> Best,
> Fawad
>
>
> On Fri, Aug 23, 2019 at 1:52 PM Stéphane Laurière 
> wrote:
>
>> Hi Fawad, Hi Caty, Hi all,
>>
>> Since the GSoC deadline for work submission is approaching, I'm
>> confident that all is in order for you Fawad but, also since it's my 
>> first
>> participatoin in the program, can I ask you to let us know what you plan 
>> to
>> publish, when and where, so that we make sure we're in tune and don't 
>> miss
>> any deadline or requirement?
>>
>> The reference page I'm aware of is the one below, do you have any
>> other?
>>
>>   https://developers.google.com/open-source/gsoc/help/work-product
>>
>> Are we in tune?
>>
>> Cheers
>>
>> Stéphane
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-25 Thread Fawad Ali
Hi all,
Hope you are all well.

Can I prepare my report on gist if that's all right?
The current application page feels more like a progress then a report.
I want to make the report minimal so that future readers can easily get the
idea without having to dive too much into details.
I will link all the necessary pages on the gist.

Best,
Fawad


On Sun, Aug 25, 2019 at 1:49 AM Fawad Ali  wrote:

> Hi Ecaterina,
> Good to see you, hope you are doing well.
>
> Do you mean "org.webjars.bowergithub.9inpachi"? This is deployed on
> http://webjars.org
> I am not sure what could be wrong here. Even the leaflet dependency is not
> being installed in the latest tests. After installing Extension Manager
> Application into the test XWiki instance, I found that for Interactive Maps
> Application, the leaflet dependencies were labeled as "Provided" as opposed
> to "Installed" for other dependencies.
>
> The tests started failing around this commit
> https://github.com/xwiki-contrib/application-interactive-maps/commit/e3163a2552b9a900d4756867db336f0df43cc8f6
>
> I added leaflet-indoor.js as an attachment temporarily while I was waiting
> for the one deployed on webjars.org to function properly. I did remove it
> later on and added as a dependency but that doesn't seem to have solved the
> problem.
> I feel like this is some issue with the test itself and since I haven't
> made any changes to the test, the test frameworks might have been updated.
> I don't really know the cause since all was working fine before this.
>
> Best,
> Fawad
>
>
> On Sun, Aug 25, 2019 at 1:39 AM Ecaterina Moraru (Valica) <
> vali...@gmail.com> wrote:
>
>>
>>
>> On Sat, Aug 24, 2019, 17:04 Fawad Ali  wrote:
>>
>>> Hi all,
>>> Hoping you a great week-end.
>>>
>>> I am having trouble testing my application because of some dependencies.
>>> This is the POM:
>>> https://github.com/xwiki-contrib/application-interactive-maps/blob/master/application-interactive-maps-ui/pom.xml
>>>
>>
>> Maybe the repositories are not found. Are the dependencies available from
>> Maven Central? I see you have your own group id. Is that artifact published
>> on any public repository or just local on your machine? Also, make sure you
>> publish everything for the Google requirements.
>>
>> Thanks,
>> Caty
>>
>>
>>> Some of the leaflet dependencies are not being installed during testing.
>>> I am not sure why.
>>> When I open a page that uses leaflet libraries I get an error from
>>> requirejs that the library cannot be loaded. And there is no data when I go
>>> to the url generated by $services.webjars.url() which leads me to believe
>>> that the dependency is not being installed as an extension.
>>>
>>> If I manually install the dependencies into my Wiki then it works fine.
>>>
>>> Do you think there is something missing within the POM?
>>>
>>> Best,
>>> Fawad
>>>
>>>
>>> On Fri, Aug 23, 2019 at 2:42 PM Fawad Ali 
>>> wrote:
>>>
 Hi Stéphane, Ecaterina, all,

 Stephane, this is the report that I mentioned before.
 According to XWiki standards, what I plan to submit is a report based
 on the format documented at
 https://dev.xwiki.org/xwiki/bin/view/GoogleSummerOfCode/DocumentingStudentProgress
  .
 I updated this work progress halfway so half of it has to be done still
 but I am positive I will be able to do it well before time. The reason I
 chose to focus on the daily progress is that it gives more insight to the
 daily activities performed on the project and the report can be fairly
 easily created with using the daily progress as a reference.

 If you have any other specific formats that you think will be better
 then please let me know, we can follow that as well.

 Best,
 Fawad


 On Fri, Aug 23, 2019 at 1:52 PM Stéphane Laurière 
 wrote:

> Hi Fawad, Hi Caty, Hi all,
>
> Since the GSoC deadline for work submission is approaching, I'm
> confident that all is in order for you Fawad but, also since it's my first
> participatoin in the program, can I ask you to let us know what you plan 
> to
> publish, when and where, so that we make sure we're in tune and don't miss
> any deadline or requirement?
>
> The reference page I'm aware of is the one below, do you have any
> other?
>
>   https://developers.google.com/open-source/gsoc/help/work-product
>
> Are we in tune?
>
> Cheers
>
> Stéphane
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-24 Thread Fawad Ali
Hi Ecaterina,
Good to see you, hope you are doing well.

Do you mean "org.webjars.bowergithub.9inpachi"? This is deployed on
http://webjars.org
I am not sure what could be wrong here. Even the leaflet dependency is not
being installed in the latest tests. After installing Extension Manager
Application into the test XWiki instance, I found that for Interactive Maps
Application, the leaflet dependencies were labeled as "Provided" as opposed
to "Installed" for other dependencies.

The tests started failing around this commit
https://github.com/xwiki-contrib/application-interactive-maps/commit/e3163a2552b9a900d4756867db336f0df43cc8f6

I added leaflet-indoor.js as an attachment temporarily while I was waiting
for the one deployed on webjars.org to function properly. I did remove it
later on and added as a dependency but that doesn't seem to have solved the
problem.
I feel like this is some issue with the test itself and since I haven't
made any changes to the test, the test frameworks might have been updated.
I don't really know the cause since all was working fine before this.

Best,
Fawad


On Sun, Aug 25, 2019 at 1:39 AM Ecaterina Moraru (Valica) 
wrote:

>
>
> On Sat, Aug 24, 2019, 17:04 Fawad Ali  wrote:
>
>> Hi all,
>> Hoping you a great week-end.
>>
>> I am having trouble testing my application because of some dependencies.
>> This is the POM:
>> https://github.com/xwiki-contrib/application-interactive-maps/blob/master/application-interactive-maps-ui/pom.xml
>>
>
> Maybe the repositories are not found. Are the dependencies available from
> Maven Central? I see you have your own group id. Is that artifact published
> on any public repository or just local on your machine? Also, make sure you
> publish everything for the Google requirements.
>
> Thanks,
> Caty
>
>
>> Some of the leaflet dependencies are not being installed during testing.
>> I am not sure why.
>> When I open a page that uses leaflet libraries I get an error from
>> requirejs that the library cannot be loaded. And there is no data when I go
>> to the url generated by $services.webjars.url() which leads me to believe
>> that the dependency is not being installed as an extension.
>>
>> If I manually install the dependencies into my Wiki then it works fine.
>>
>> Do you think there is something missing within the POM?
>>
>> Best,
>> Fawad
>>
>>
>> On Fri, Aug 23, 2019 at 2:42 PM Fawad Ali 
>> wrote:
>>
>>> Hi Stéphane, Ecaterina, all,
>>>
>>> Stephane, this is the report that I mentioned before.
>>> According to XWiki standards, what I plan to submit is a report based on
>>> the format documented at
>>> https://dev.xwiki.org/xwiki/bin/view/GoogleSummerOfCode/DocumentingStudentProgress
>>>  .
>>> I updated this work progress halfway so half of it has to be done still
>>> but I am positive I will be able to do it well before time. The reason I
>>> chose to focus on the daily progress is that it gives more insight to the
>>> daily activities performed on the project and the report can be fairly
>>> easily created with using the daily progress as a reference.
>>>
>>> If you have any other specific formats that you think will be better
>>> then please let me know, we can follow that as well.
>>>
>>> Best,
>>> Fawad
>>>
>>>
>>> On Fri, Aug 23, 2019 at 1:52 PM Stéphane Laurière 
>>> wrote:
>>>
 Hi Fawad, Hi Caty, Hi all,

 Since the GSoC deadline for work submission is approaching, I'm
 confident that all is in order for you Fawad but, also since it's my first
 participatoin in the program, can I ask you to let us know what you plan to
 publish, when and where, so that we make sure we're in tune and don't miss
 any deadline or requirement?

 The reference page I'm aware of is the one below, do you have any other?

   https://developers.google.com/open-source/gsoc/help/work-product

 Are we in tune?

 Cheers

 Stéphane




Re: [xwiki-devs] Map Application - GSoC 19

2019-08-24 Thread Ecaterina Moraru (Valica)
On Sat, Aug 24, 2019, 17:04 Fawad Ali  wrote:

> Hi all,
> Hoping you a great week-end.
>
> I am having trouble testing my application because of some dependencies.
> This is the POM:
> https://github.com/xwiki-contrib/application-interactive-maps/blob/master/application-interactive-maps-ui/pom.xml
>

Maybe the repositories are not found. Are the dependencies available from
Maven Central? I see you have your own group id. Is that artifact published
on any public repository or just local on your machine? Also, make sure you
publish everything for the Google requirements.

Thanks,
Caty


> Some of the leaflet dependencies are not being installed during testing. I
> am not sure why.
> When I open a page that uses leaflet libraries I get an error from
> requirejs that the library cannot be loaded. And there is no data when I go
> to the url generated by $services.webjars.url() which leads me to believe
> that the dependency is not being installed as an extension.
>
> If I manually install the dependencies into my Wiki then it works fine.
>
> Do you think there is something missing within the POM?
>
> Best,
> Fawad
>
>
> On Fri, Aug 23, 2019 at 2:42 PM Fawad Ali  wrote:
>
>> Hi Stéphane, Ecaterina, all,
>>
>> Stephane, this is the report that I mentioned before.
>> According to XWiki standards, what I plan to submit is a report based on
>> the format documented at
>> https://dev.xwiki.org/xwiki/bin/view/GoogleSummerOfCode/DocumentingStudentProgress
>>  .
>> I updated this work progress halfway so half of it has to be done still
>> but I am positive I will be able to do it well before time. The reason I
>> chose to focus on the daily progress is that it gives more insight to the
>> daily activities performed on the project and the report can be fairly
>> easily created with using the daily progress as a reference.
>>
>> If you have any other specific formats that you think will be better then
>> please let me know, we can follow that as well.
>>
>> Best,
>> Fawad
>>
>>
>> On Fri, Aug 23, 2019 at 1:52 PM Stéphane Laurière 
>> wrote:
>>
>>> Hi Fawad, Hi Caty, Hi all,
>>>
>>> Since the GSoC deadline for work submission is approaching, I'm
>>> confident that all is in order for you Fawad but, also since it's my first
>>> participatoin in the program, can I ask you to let us know what you plan to
>>> publish, when and where, so that we make sure we're in tune and don't miss
>>> any deadline or requirement?
>>>
>>> The reference page I'm aware of is the one below, do you have any other?
>>>
>>>   https://developers.google.com/open-source/gsoc/help/work-product
>>>
>>> Are we in tune?
>>>
>>> Cheers
>>>
>>> Stéphane
>>>
>>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-24 Thread Ecaterina Moraru (Valica)
On Fri, Aug 23, 2019, 12:43 Fawad Ali  wrote:

> Hi Stéphane, Ecaterina, all,
>
> Stephane, this is the report that I mentioned before.
> According to XWiki standards, what I plan to submit is a report based on
> the format documented at
> https://dev.xwiki.org/xwiki/bin/view/GoogleSummerOfCode/DocumentingStudentProgress
>  .
> I updated this work progress halfway so half of it has to be done still
> but I am positive I will be able to do it well before time. The reason I
> chose to focus on the daily progress is that it gives more insight to the
> daily activities performed on the project and the report can be fairly
> easily created with using the daily progress as a reference.
>

I have no preference regarding the progress report. It depends also on the
student's preference. The main purpose is that the mentors know the
evolution if the project.

Thanks,
Caty

>
> If you have any other specific formats that you think will be better then
> please let me know, we can follow that as well.
>
> Best,
> Fawad
>
>
> On Fri, Aug 23, 2019 at 1:52 PM Stéphane Laurière 
> wrote:
>
>> Hi Fawad, Hi Caty, Hi all,
>>
>> Since the GSoC deadline for work submission is approaching, I'm confident
>> that all is in order for you Fawad but, also since it's my first
>> participatoin in the program, can I ask you to let us know what you plan to
>> publish, when and where, so that we make sure we're in tune and don't miss
>> any deadline or requirement?
>>
>> The reference page I'm aware of is the one below, do you have any other?
>>
>>   https://developers.google.com/open-source/gsoc/help/work-product
>>
>> Are we in tune?
>>
>> Cheers
>>
>> Stéphane
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-24 Thread Ecaterina Moraru (Valica)
On Fri, Aug 23, 2019, 11:52 Stéphane Laurière  wrote:

> Hi Fawad, Hi Caty, Hi all,
>
> Since the GSoC deadline for work submission is approaching, I'm confident
> that all is in order for you Fawad but, also since it's my first
> participatoin in the program, can I ask you to let us know what you plan to
> publish, when and where, so that we make sure we're in tune and don't miss
> any deadline or requirement?
>
> The reference page I'm aware of is the one below, do you have any other?
>
>   https://developers.google.com/open-source/gsoc/help/work-product
>
> Are we in tune?
>

Hi,

Fawad should follow the instructions given by Google, since they aldo need
copies / links to the produced code.

Regarding XWiki's expectations, having the code public available on GitHub
and released on Contrib / extensions.xwiki.org is enought.

Thanks,
Caty

>
> Cheers
>
> Stéphane
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-24 Thread Fawad Ali
Hi all,
Hoping you a great week-end.

I am having trouble testing my application because of some dependencies.
This is the POM:
https://github.com/xwiki-contrib/application-interactive-maps/blob/master/application-interactive-maps-ui/pom.xml

Some of the leaflet dependencies are not being installed during testing. I
am not sure why.
When I open a page that uses leaflet libraries I get an error from
requirejs that the library cannot be loaded. And there is no data when I go
to the url generated by $services.webjars.url() which leads me to believe
that the dependency is not being installed as an extension.

If I manually install the dependencies into my Wiki then it works fine.

Do you think there is something missing within the POM?

Best,
Fawad


On Fri, Aug 23, 2019 at 2:42 PM Fawad Ali  wrote:

> Hi Stéphane, Ecaterina, all,
>
> Stephane, this is the report that I mentioned before.
> According to XWiki standards, what I plan to submit is a report based on
> the format documented at
> https://dev.xwiki.org/xwiki/bin/view/GoogleSummerOfCode/DocumentingStudentProgress
>  .
> I updated this work progress halfway so half of it has to be done still
> but I am positive I will be able to do it well before time. The reason I
> chose to focus on the daily progress is that it gives more insight to the
> daily activities performed on the project and the report can be fairly
> easily created with using the daily progress as a reference.
>
> If you have any other specific formats that you think will be better then
> please let me know, we can follow that as well.
>
> Best,
> Fawad
>
>
> On Fri, Aug 23, 2019 at 1:52 PM Stéphane Laurière 
> wrote:
>
>> Hi Fawad, Hi Caty, Hi all,
>>
>> Since the GSoC deadline for work submission is approaching, I'm confident
>> that all is in order for you Fawad but, also since it's my first
>> participatoin in the program, can I ask you to let us know what you plan to
>> publish, when and where, so that we make sure we're in tune and don't miss
>> any deadline or requirement?
>>
>> The reference page I'm aware of is the one below, do you have any other?
>>
>>   https://developers.google.com/open-source/gsoc/help/work-product
>>
>> Are we in tune?
>>
>> Cheers
>>
>> Stéphane
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-23 Thread Fawad Ali
Hi Stéphane, Ecaterina, all,

Stephane, this is the report that I mentioned before.
According to XWiki standards, what I plan to submit is a report based on
the format documented at
https://dev.xwiki.org/xwiki/bin/view/GoogleSummerOfCode/DocumentingStudentProgress
 .
I updated this work progress halfway so half of it has to be done still but
I am positive I will be able to do it well before time. The reason I chose
to focus on the daily progress is that it gives more insight to the daily
activities performed on the project and the report can be fairly easily
created with using the daily progress as a reference.

If you have any other specific formats that you think will be better then
please let me know, we can follow that as well.

Best,
Fawad


On Fri, Aug 23, 2019 at 1:52 PM Stéphane Laurière 
wrote:

> Hi Fawad, Hi Caty, Hi all,
>
> Since the GSoC deadline for work submission is approaching, I'm confident
> that all is in order for you Fawad but, also since it's my first
> participatoin in the program, can I ask you to let us know what you plan to
> publish, when and where, so that we make sure we're in tune and don't miss
> any deadline or requirement?
>
> The reference page I'm aware of is the one below, do you have any other?
>
>   https://developers.google.com/open-source/gsoc/help/work-product
>
> Are we in tune?
>
> Cheers
>
> Stéphane
>
>


[xwiki-devs] Map Application - GSoC 19

2019-08-23 Thread Stéphane Laurière

Hi Fawad, Hi Caty, Hi all,

Since the GSoC deadline for work submission is approaching, I'm confident that 
all is in order for you Fawad but, also since it's my first participatoin in 
the program, can I ask you to let us know what you plan to publish, when and 
where, so that we make sure we're in tune and don't miss any deadline or 
requirement?

The reference page I'm aware of is the one below, do you have any other?

 https://developers.google.com/open-source/gsoc/help/work-product

Are we in tune?

Cheers

Stéphane



Re: [xwiki-devs] Map Application - GSoC 19

2019-08-23 Thread Stéphane Laurière

Hi Fawad, Hi all,


Hi Stéphane, all,
Hope all of you are in good health.

I wanted to clarify how I should make the map editor so that we are on the same 
page.
What I have in mind is a map with tools for creating points, paths and shapes. 
The user will be able to set basic options like the title, style and popup 
content from the map editor. The user will define the xwiki space the map items 
will be created in and then each map item will be created with the given title 
and content. If no title is given, the map item will be numbered according to 
its type e.g. Point1, Point2 if there are 2 untitled points.

What do you think of this? Please let me know so I can start working on it.


yes, I think it would be useful indeed. For generating page names in case non 
is typed by the user, you could use the UIN Service:



+1 for making the editor available directly from the application home page.

Cheers

Stéphane



Thanks,
Fawad


On Wed, Aug 21, 2019 at 7:01 PM Fawad Ali mailto:m.fawaadal...@gmail.com>> wrote:

Stephane,

I think the users would require an editor.
Having to create each shape separately would be cumbersome for them. 
Especially with the case of indoor structures where potentially 10-20 shapes 
would be created for each level on average.

If an advance user does want to link marker icons with facet values he can 
use the same kind of images for points and attach a custom class object to 
categorize them. I don't think it should be prioritized above the editor.

Best,
Fawad

On Wed, Aug 21, 2019, 5:51 PM Stéphane Laurière mailto:slauri...@xwiki.com>> wrote:


 > Stéphane,
 > Thanks for the review.
 >
 > I understand that shapes should be separate objects.
 > Then, we need a way for users to easily create the large number of 
shapes required for each level of indoor structures.
 > Should I create a separate shape editor that will easily generate a 
number of shapes inside a specific space? How does that sound?

It would be useful indeed, it seems we're reaching the point where we 
consider doing a real map editor in addition to a map viewer. I'm just 
wondering how it goes in terms of priorities and preferences, since having a 
working structure for dealing with semi-advanced map styles (I have in mind in 
particular the capacity to associate marker icons with facet values) and also a 
full-fledged demo showcasing all the major features would be interesting as 
well. It depends on your inclination really, I feel like you prefer progressing 
on the editor? Do you still plan to write a small report by the end of the GSoC 
as well?

Stéphane




--
Stéphane Laurière
XWiki – https://xwiki.com



Re: [xwiki-devs] Map Application - GSoC 19

2019-08-22 Thread Fawad Ali
One thing to add is that the map editor will be available directly in the
Maps space just like the MapDataImporter.

Best,
Fawad


On Fri, Aug 23, 2019 at 4:01 AM Fawad Ali  wrote:

> Hi Stéphane, all,
> Hope all of you are in good health.
>
> I wanted to clarify how I should make the map editor so that we are on the
> same page.
> What I have in mind is a map with tools for creating points, paths and
> shapes. The user will be able to set basic options like the title, style
> and popup content from the map editor. The user will define the xwiki space
> the map items will be created in and then each map item will be created
> with the given title and content. If no title is given, the map item will
> be numbered according to its type e.g. Point1, Point2 if there are 2
> untitled points.
>
> What do you think of this? Please let me know so I can start working on it.
>
> Thanks,
> Fawad
>
>
> On Wed, Aug 21, 2019 at 7:01 PM Fawad Ali  wrote:
>
>> Stephane,
>>
>> I think the users would require an editor.
>> Having to create each shape separately would be cumbersome for them.
>> Especially with the case of indoor structures where potentially 10-20
>> shapes would be created for each level on average.
>>
>> If an advance user does want to link marker icons with facet values he
>> can use the same kind of images for points and attach a custom class object
>> to categorize them. I don't think it should be prioritized above the editor.
>>
>> Best,
>> Fawad
>>
>> On Wed, Aug 21, 2019, 5:51 PM Stéphane Laurière 
>> wrote:
>>
>>>
>>> > Stéphane,
>>> > Thanks for the review.
>>> >
>>> > I understand that shapes should be separate objects.
>>> > Then, we need a way for users to easily create the large number of
>>> shapes required for each level of indoor structures.
>>> > Should I create a separate shape editor that will easily generate a
>>> number of shapes inside a specific space? How does that sound?
>>>
>>> It would be useful indeed, it seems we're reaching the point where we
>>> consider doing a real map editor in addition to a map viewer. I'm just
>>> wondering how it goes in terms of priorities and preferences, since having
>>> a working structure for dealing with semi-advanced map styles (I have in
>>> mind in particular the capacity to associate marker icons with facet
>>> values) and also a full-fledged demo showcasing all the major features
>>> would be interesting as well. It depends on your inclination really, I feel
>>> like you prefer progressing on the editor? Do you still plan to write a
>>> small report by the end of the GSoC as well?
>>>
>>> Stéphane
>>>
>>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-22 Thread Fawad Ali
Hi Stéphane, all,
Hope all of you are in good health.

I wanted to clarify how I should make the map editor so that we are on the
same page.
What I have in mind is a map with tools for creating points, paths and
shapes. The user will be able to set basic options like the title, style
and popup content from the map editor. The user will define the xwiki space
the map items will be created in and then each map item will be created
with the given title and content. If no title is given, the map item will
be numbered according to its type e.g. Point1, Point2 if there are 2
untitled points.

What do you think of this? Please let me know so I can start working on it.

Thanks,
Fawad


On Wed, Aug 21, 2019 at 7:01 PM Fawad Ali  wrote:

> Stephane,
>
> I think the users would require an editor.
> Having to create each shape separately would be cumbersome for them.
> Especially with the case of indoor structures where potentially 10-20
> shapes would be created for each level on average.
>
> If an advance user does want to link marker icons with facet values he can
> use the same kind of images for points and attach a custom class object to
> categorize them. I don't think it should be prioritized above the editor.
>
> Best,
> Fawad
>
> On Wed, Aug 21, 2019, 5:51 PM Stéphane Laurière 
> wrote:
>
>>
>> > Stéphane,
>> > Thanks for the review.
>> >
>> > I understand that shapes should be separate objects.
>> > Then, we need a way for users to easily create the large number of
>> shapes required for each level of indoor structures.
>> > Should I create a separate shape editor that will easily generate a
>> number of shapes inside a specific space? How does that sound?
>>
>> It would be useful indeed, it seems we're reaching the point where we
>> consider doing a real map editor in addition to a map viewer. I'm just
>> wondering how it goes in terms of priorities and preferences, since having
>> a working structure for dealing with semi-advanced map styles (I have in
>> mind in particular the capacity to associate marker icons with facet
>> values) and also a full-fledged demo showcasing all the major features
>> would be interesting as well. It depends on your inclination really, I feel
>> like you prefer progressing on the editor? Do you still plan to write a
>> small report by the end of the GSoC as well?
>>
>> Stéphane
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-21 Thread Fawad Ali
Stephane,

I think the users would require an editor.
Having to create each shape separately would be cumbersome for them.
Especially with the case of indoor structures where potentially 10-20
shapes would be created for each level on average.

If an advance user does want to link marker icons with facet values he can
use the same kind of images for points and attach a custom class object to
categorize them. I don't think it should be prioritized above the editor.

Best,
Fawad

On Wed, Aug 21, 2019, 5:51 PM Stéphane Laurière  wrote:

>
> > Stéphane,
> > Thanks for the review.
> >
> > I understand that shapes should be separate objects.
> > Then, we need a way for users to easily create the large number of
> shapes required for each level of indoor structures.
> > Should I create a separate shape editor that will easily generate a
> number of shapes inside a specific space? How does that sound?
>
> It would be useful indeed, it seems we're reaching the point where we
> consider doing a real map editor in addition to a map viewer. I'm just
> wondering how it goes in terms of priorities and preferences, since having
> a working structure for dealing with semi-advanced map styles (I have in
> mind in particular the capacity to associate marker icons with facet
> values) and also a full-fledged demo showcasing all the major features
> would be interesting as well. It depends on your inclination really, I feel
> like you prefer progressing on the editor? Do you still plan to write a
> small report by the end of the GSoC as well?
>
> Stéphane
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-21 Thread Stéphane Laurière




Stéphane,
Thanks for the review.

I understand that shapes should be separate objects.
Then, we need a way for users to easily create the large number of shapes 
required for each level of indoor structures.
Should I create a separate shape editor that will easily generate a number of 
shapes inside a specific space? How does that sound?


It would be useful indeed, it seems we're reaching the point where we consider 
doing a real map editor in addition to a map viewer. I'm just wondering how it 
goes in terms of priorities and preferences, since having a working structure 
for dealing with semi-advanced map styles (I have in mind in particular the 
capacity to associate marker icons with facet values) and also a full-fledged 
demo showcasing all the major features would be interesting as well. It depends 
on your inclination really, I feel like you prefer progressing on the editor? 
Do you still plan to write a small report by the end of the GSoC as well?

Stéphane



Re: [xwiki-devs] Map Application - GSoC 19

2019-08-21 Thread Fawad Ali
Stéphane,
Thanks for the review.

I understand that shapes should be separate objects.
Then, we need a way for users to easily create the large number of shapes
required for each level of indoor structures.
Should I create a separate shape editor that will easily generate a number
of shapes inside a specific space? How does that sound?

Best,
Fawad


On Wed, Aug 21, 2019 at 4:16 PM Stéphane Laurière 
wrote:

> > Fairly simple ones like visually defining popup content and style for
> each shape separately similar to the uMap editor.
> > Something like: https://up1.xwikisas.com/#eQ9Mck57dv0U0A7kpAvumQ
> > If there are any suggestions you think should be available as options,
> let me know.
>
> I see. These options are not specific to indoor maps, right? Regarding the
> title and the content, as mentioned in my previous message, I'd go for
> using the shape's page title and content themselves, if possible.
>
> Stéphane
>
>
>
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-21 Thread Stéphane Laurière

Fairly simple ones like visually defining popup content and style for each 
shape separately similar to the uMap editor.
Something like: https://up1.xwikisas.com/#eQ9Mck57dv0U0A7kpAvumQ
If there are any suggestions you think should be available as options, let me 
know.


I see. These options are not specific to indoor maps, right? Regarding the 
title and the content, as mentioned in my previous message, I'd go for using 
the shape's page title and content themselves, if possible.

Stéphane






Re: [xwiki-devs] Map Application - GSoC 19

2019-08-21 Thread Stéphane Laurière






A better structure could also look like:
-
-1:Maps.Shapes.Shape1, Maps.Shapes.Shape2
0:Maps.Shapes.Shape3
1:Maps.Shapes.Shape4, Maps.Shapes.Shape5
-


Indeed, we could go this way and see how it goes. At some point, users will 
probably need a visual assistant to maintain this structure, we can address 
that later on.

Cheers

Stéphane



[xwiki-devs] Map Application - GSoC 19

2019-08-21 Thread Stéphane Laurière

Fawad, all,


Stéphane,

With the latest iteration, the ShapeClass is able to handle multiple shapes in 
a single Shape object.
Do you think that's fine or should there be separate objects for each shape?


I'd follow the same reasoning as for points and have one shape per page, 
because imho users will typically want to associate content to each shape, and 
the most suitable approach for handling content in XWiki (title, content, 
translations) is a page (image you create a map of a touristic region with 
various shapes with content to be available in various languages, that would be 
cumbersome to manage the content translations in objects rather than in pages). 
There could be special situations with several shapes attached to a single page 
though, that would be an advanced feature, for addressing the case of places 
which span across several locations, e.g. a large hospital covering several 
distinct areas in the same neighbourhood. What do you think?

Cheers

Stéphane



Best,
Fawadx




Re: [xwiki-devs] Map Application - GSoC 19

2019-08-21 Thread Fawad Ali
Stéphane,

With the latest iteration, the ShapeClass is able to handle multiple shapes
in a single Shape object.
Do you think that's fine or should there be separate objects for each shape?

Best,
Fawadx


On Wed, Aug 21, 2019 at 2:33 PM Fawad Ali  wrote:

> A better structure could also look like:
> -
> -1:Maps.Shapes.Shape1, Maps.Shapes.Shape2
> 0:Maps.Shapes.Shape3
> 1:Maps.Shapes.Shape4,  Maps.Shapes.Shape5
> -
>
> Best,
> Fawad
>
>
> On Wed, Aug 21, 2019 at 2:31 PM Fawad Ali  wrote:
>
>> Hi Stephane, all,
>> Hope you are having a great day.
>>
>>
>>> Right, that will be useful to associate shapes (and points as well?) to
>>> each level.
>>>
>>
>> Yes, points are also available within the shape editor.
>>
>> That could work indeed, but won't it be a bit cumbersome if a user has
>>> many shapes at a given level? We could also introduce a Level class and let
>>> the user associate a shape with a specific level, what do you think?
>>
>>
>> Sounds great but would that not become a two way process for the user?
>> The user will have to first create a level and then add all the levels
>> into an indoor structure. While he can do the same inside a single class.
>> Another option we can opt is to have a custom structure like custom
>> classes. (Which I think is more flexible to our needs)
>> Something like:
>> -
>> -1:Maps.Shapes.Shape1
>> -1:Maps.Shapes.Shape2
>> 0:Maps.Shapes.Shape3
>> 1:Maps.Shapes.Shape4
>> 1:Maps.Shapes.Shape5
>> -
>>
>>
>>>  Great. What specific options do you have in mind for indoor?
>>
>>
>> Fairly simple ones like visually defining popup content and style for
>> each shape separately similar to the uMap editor.
>> Something like: https://up1.xwikisas.com/#eQ9Mck57dv0U0A7kpAvumQ
>> If there are any suggestions you think should be available as options,
>> let me know.
>>
>> Peace,
>> Fawad
>>
>>
>> On Wed, Aug 21, 2019 at 1:49 PM Stéphane Laurière 
>> wrote:
>>
>>> Hi Fawad, Hi all,
>>>
>>> > Hi all,
>>> >
>>> > After much analyzing I have found a good workflow for creating indoor
>>> maps.
>>> > What I have in mind is that we treat indoor structures as map items
>>> rather than a completely separate map.
>>>
>>> This sounds like a good approach indeed imho.
>>>
>>> > The levels can be specified along with the shapes to be used for each
>>> level. Each shape will be created separately using the ShapeSheet.
>>>
>>> Right, that will be useful to associate shapes (and points as well?) to
>>> each level.
>>>
>>> > We can have a static list for indoor levels and another one for
>>> shapes. The shapes will be selected in order of the levels defined.
>>> > For example,
>>> > *Shapes List:* Shape1|Shape2}Shape3
>>> > *Levels List:* -1|0|1
>>> > In this case, level 0 will be mapped to Shape2.
>>>
>>> That could work indeed, but won't it be a bit cumbersome if a user has
>>> many shapes at a given level? We could also introduce a Level class and let
>>> the user associate a shape with a specific level, what do you think?
>>>
>>> > I am working on separately defining options for each shape so they can
>>> be better used with indoor structures.
>>>
>>> Great. What specific options do you have in mind for indoor?
>>>
>>> Cheers
>>>
>>> Stéphane
>>>
>>>
>>>
>>> > What do you think?
>>> >
>>> > Best,
>>> > Fawad
>>>
>>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-21 Thread Fawad Ali
A better structure could also look like:
-
-1:Maps.Shapes.Shape1, Maps.Shapes.Shape2
0:Maps.Shapes.Shape3
1:Maps.Shapes.Shape4,  Maps.Shapes.Shape5
-

Best,
Fawad


On Wed, Aug 21, 2019 at 2:31 PM Fawad Ali  wrote:

> Hi Stephane, all,
> Hope you are having a great day.
>
>
>> Right, that will be useful to associate shapes (and points as well?) to
>> each level.
>>
>
> Yes, points are also available within the shape editor.
>
> That could work indeed, but won't it be a bit cumbersome if a user has
>> many shapes at a given level? We could also introduce a Level class and let
>> the user associate a shape with a specific level, what do you think?
>
>
> Sounds great but would that not become a two way process for the user?
> The user will have to first create a level and then add all the levels
> into an indoor structure. While he can do the same inside a single class.
> Another option we can opt is to have a custom structure like custom
> classes. (Which I think is more flexible to our needs)
> Something like:
> -
> -1:Maps.Shapes.Shape1
> -1:Maps.Shapes.Shape2
> 0:Maps.Shapes.Shape3
> 1:Maps.Shapes.Shape4
> 1:Maps.Shapes.Shape5
> -
>
>
>>  Great. What specific options do you have in mind for indoor?
>
>
> Fairly simple ones like visually defining popup content and style for each
> shape separately similar to the uMap editor.
> Something like: https://up1.xwikisas.com/#eQ9Mck57dv0U0A7kpAvumQ
> If there are any suggestions you think should be available as options, let
> me know.
>
> Peace,
> Fawad
>
>
> On Wed, Aug 21, 2019 at 1:49 PM Stéphane Laurière 
> wrote:
>
>> Hi Fawad, Hi all,
>>
>> > Hi all,
>> >
>> > After much analyzing I have found a good workflow for creating indoor
>> maps.
>> > What I have in mind is that we treat indoor structures as map items
>> rather than a completely separate map.
>>
>> This sounds like a good approach indeed imho.
>>
>> > The levels can be specified along with the shapes to be used for each
>> level. Each shape will be created separately using the ShapeSheet.
>>
>> Right, that will be useful to associate shapes (and points as well?) to
>> each level.
>>
>> > We can have a static list for indoor levels and another one for shapes.
>> The shapes will be selected in order of the levels defined.
>> > For example,
>> > *Shapes List:* Shape1|Shape2}Shape3
>> > *Levels List:* -1|0|1
>> > In this case, level 0 will be mapped to Shape2.
>>
>> That could work indeed, but won't it be a bit cumbersome if a user has
>> many shapes at a given level? We could also introduce a Level class and let
>> the user associate a shape with a specific level, what do you think?
>>
>> > I am working on separately defining options for each shape so they can
>> be better used with indoor structures.
>>
>> Great. What specific options do you have in mind for indoor?
>>
>> Cheers
>>
>> Stéphane
>>
>>
>>
>> > What do you think?
>> >
>> > Best,
>> > Fawad
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-21 Thread Fawad Ali
Hi Stephane, all,
Hope you are having a great day.


> Right, that will be useful to associate shapes (and points as well?) to
> each level.
>

Yes, points are also available within the shape editor.

That could work indeed, but won't it be a bit cumbersome if a user has many
> shapes at a given level? We could also introduce a Level class and let the
> user associate a shape with a specific level, what do you think?


Sounds great but would that not become a two way process for the user?
The user will have to first create a level and then add all the levels into
an indoor structure. While he can do the same inside a single class.
Another option we can opt is to have a custom structure like custom
classes. (Which I think is more flexible to our needs)
Something like:
-
-1:Maps.Shapes.Shape1
-1:Maps.Shapes.Shape2
0:Maps.Shapes.Shape3
1:Maps.Shapes.Shape4
1:Maps.Shapes.Shape5
-


>  Great. What specific options do you have in mind for indoor?


Fairly simple ones like visually defining popup content and style for each
shape separately similar to the uMap editor.
Something like: https://up1.xwikisas.com/#eQ9Mck57dv0U0A7kpAvumQ
If there are any suggestions you think should be available as options, let
me know.

Peace,
Fawad


On Wed, Aug 21, 2019 at 1:49 PM Stéphane Laurière 
wrote:

> Hi Fawad, Hi all,
>
> > Hi all,
> >
> > After much analyzing I have found a good workflow for creating indoor
> maps.
> > What I have in mind is that we treat indoor structures as map items
> rather than a completely separate map.
>
> This sounds like a good approach indeed imho.
>
> > The levels can be specified along with the shapes to be used for each
> level. Each shape will be created separately using the ShapeSheet.
>
> Right, that will be useful to associate shapes (and points as well?) to
> each level.
>
> > We can have a static list for indoor levels and another one for shapes.
> The shapes will be selected in order of the levels defined.
> > For example,
> > *Shapes List:* Shape1|Shape2}Shape3
> > *Levels List:* -1|0|1
> > In this case, level 0 will be mapped to Shape2.
>
> That could work indeed, but won't it be a bit cumbersome if a user has
> many shapes at a given level? We could also introduce a Level class and let
> the user associate a shape with a specific level, what do you think?
>
> > I am working on separately defining options for each shape so they can
> be better used with indoor structures.
>
> Great. What specific options do you have in mind for indoor?
>
> Cheers
>
> Stéphane
>
>
>
> > What do you think?
> >
> > Best,
> > Fawad
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-21 Thread Stéphane Laurière

Hi Fawad, Hi all,


Hi all,

After much analyzing I have found a good workflow for creating indoor maps.
What I have in mind is that we treat indoor structures as map items rather than a completely separate map. 


This sounds like a good approach indeed imho.


The levels can be specified along with the shapes to be used for each level. 
Each shape will be created separately using the ShapeSheet.


Right, that will be useful to associate shapes (and points as well?) to each 
level.


We can have a static list for indoor levels and another one for shapes. The 
shapes will be selected in order of the levels defined.
For example,
*Shapes List:* Shape1|Shape2}Shape3
*Levels List:* -1|0|1
In this case, level 0 will be mapped to Shape2.


That could work indeed, but won't it be a bit cumbersome if a user has many 
shapes at a given level? We could also introduce a Level class and let the user 
associate a shape with a specific level, what do you think?


I am working on separately defining options for each shape so they can be 
better used with indoor structures.


Great. What specific options do you have in mind for indoor?

Cheers

Stéphane


 

What do you think?

Best,
Fawad




Re: [xwiki-devs] Map Application - GSoC 19

2019-08-20 Thread Fawad Ali
Hi all,

After much analyzing I have found a good workflow for creating indoor maps.
What I have in mind is that we treat indoor structures as map items rather
than a completely separate map. The levels can be specified along with the
shapes to be used for each level. Each shape will be created separately
using the ShapeSheet.
We can have a static list for indoor levels and another one for shapes. The
shapes will be selected in order of the levels defined.
For example,
*Shapes List:* Shape1|Shape2}Shape3
*Levels List:* -1|0|1
In this case, level 0 will be mapped to Shape2.

I am working on separately defining options for each shape so they can be
better used with indoor structures.

What do you think?

Best,
Fawad


On Tue, Aug 20, 2019 at 3:24 PM Fawad Ali  wrote:

> For now, I will move towards the implementation of leaflet-indoor as the
> base and if there is time, I will also implement the image option since it
> will be a lot useful.
>
> Best,
> Fawad
>
>
> On Tue, Aug 20, 2019 at 3:22 PM Fawad Ali  wrote:
>
>> Hi all,
>>
>> One concern in using the leaflet-indoor is that the indoor structures
>> might not physically exist.
>> For example, if an engineer prepares a model for a house and wants to
>> represent the structure in an independent environment then he will prefer
>> the image as map tiles. (
>> https://leafletjs.com/examples/crs-simple/crs-simple.html )
>>
>> Best,
>> Fawad
>>
>>
>> On Tue, Aug 20, 2019 at 1:46 PM Stéphane Laurière 
>> wrote:
>>
>>> Hi Fawad, Hi all,
>>>
>>> > Hi everyone,
>>> > Hope all of you are all right.
>>> >
>>> > I am working on the implementation of Indoor Maps. For that, there are
>>> several options for adaptation. So I need your suggestions.
>>> > The first question is how would the users be using the indoor maps?
>>> > - Would they be using images for each level?
>>> > - Would they prefer to have a normal map and add shape-like objects to
>>> it?
>>> > - Or would they like a mixture of both i.e. a normal map with images
>>> as levels?
>>> >
>>> > For a normal map with multilevel structures - we can use
>>> https://github.com/cbaines/leaflet-indoor
>>> > For using only images - we can make use of
>>> https://leafletjs.com/examples/crs-simple/crs-simple.html
>>> >
>>> > What do you think would be best considering the map's user base?
>>>
>>> Initially I thought about images since many fair organizers provide PDF
>>> plans that could be converted into images, but on second thoughts, starting
>>> primarily with shapes could be even better in terms of user experience
>>> imho. Nothing prevents from adding images in addition in the future, if
>>> some users prefer that approach, or a mix as you suggest.
>>>
>>> This kind of experience is quite inspirational in particular (it's close
>>> to the leaflet-indoor example that you pointed out):
>>>
>>>
>>> https://use.mazemap.com/#v=1&zlevel=1&left=6.8518492&right=6.8576924&top=52.2403051&bottom=52.2384279&campusid=171
>>>
>>> That's a question you may consider asking on the forum as well to gather
>>> more inputs?
>>>
>>> Cheers
>>>
>>> Stéphane
>>>
>>>
>>>
>>> > Best,
>>> > Fawad
>>> >
>>> >
>>>
>>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-20 Thread Fawad Ali
For now, I will move towards the implementation of leaflet-indoor as the
base and if there is time, I will also implement the image option since it
will be a lot useful.

Best,
Fawad


On Tue, Aug 20, 2019 at 3:22 PM Fawad Ali  wrote:

> Hi all,
>
> One concern in using the leaflet-indoor is that the indoor structures
> might not physically exist.
> For example, if an engineer prepares a model for a house and wants to
> represent the structure in an independent environment then he will prefer
> the image as map tiles. (
> https://leafletjs.com/examples/crs-simple/crs-simple.html )
>
> Best,
> Fawad
>
>
> On Tue, Aug 20, 2019 at 1:46 PM Stéphane Laurière 
> wrote:
>
>> Hi Fawad, Hi all,
>>
>> > Hi everyone,
>> > Hope all of you are all right.
>> >
>> > I am working on the implementation of Indoor Maps. For that, there are
>> several options for adaptation. So I need your suggestions.
>> > The first question is how would the users be using the indoor maps?
>> > - Would they be using images for each level?
>> > - Would they prefer to have a normal map and add shape-like objects to
>> it?
>> > - Or would they like a mixture of both i.e. a normal map with images as
>> levels?
>> >
>> > For a normal map with multilevel structures - we can use
>> https://github.com/cbaines/leaflet-indoor
>> > For using only images - we can make use of
>> https://leafletjs.com/examples/crs-simple/crs-simple.html
>> >
>> > What do you think would be best considering the map's user base?
>>
>> Initially I thought about images since many fair organizers provide PDF
>> plans that could be converted into images, but on second thoughts, starting
>> primarily with shapes could be even better in terms of user experience
>> imho. Nothing prevents from adding images in addition in the future, if
>> some users prefer that approach, or a mix as you suggest.
>>
>> This kind of experience is quite inspirational in particular (it's close
>> to the leaflet-indoor example that you pointed out):
>>
>>
>> https://use.mazemap.com/#v=1&zlevel=1&left=6.8518492&right=6.8576924&top=52.2403051&bottom=52.2384279&campusid=171
>>
>> That's a question you may consider asking on the forum as well to gather
>> more inputs?
>>
>> Cheers
>>
>> Stéphane
>>
>>
>>
>> > Best,
>> > Fawad
>> >
>> >
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-20 Thread Fawad Ali
Hi all,

One concern in using the leaflet-indoor is that the indoor structures might
not physically exist.
For example, if an engineer prepares a model for a house and wants to
represent the structure in an independent environment then he will prefer
the image as map tiles. (
https://leafletjs.com/examples/crs-simple/crs-simple.html )

Best,
Fawad


On Tue, Aug 20, 2019 at 1:46 PM Stéphane Laurière 
wrote:

> Hi Fawad, Hi all,
>
> > Hi everyone,
> > Hope all of you are all right.
> >
> > I am working on the implementation of Indoor Maps. For that, there are
> several options for adaptation. So I need your suggestions.
> > The first question is how would the users be using the indoor maps?
> > - Would they be using images for each level?
> > - Would they prefer to have a normal map and add shape-like objects to
> it?
> > - Or would they like a mixture of both i.e. a normal map with images as
> levels?
> >
> > For a normal map with multilevel structures - we can use
> https://github.com/cbaines/leaflet-indoor
> > For using only images - we can make use of
> https://leafletjs.com/examples/crs-simple/crs-simple.html
> >
> > What do you think would be best considering the map's user base?
>
> Initially I thought about images since many fair organizers provide PDF
> plans that could be converted into images, but on second thoughts, starting
> primarily with shapes could be even better in terms of user experience
> imho. Nothing prevents from adding images in addition in the future, if
> some users prefer that approach, or a mix as you suggest.
>
> This kind of experience is quite inspirational in particular (it's close
> to the leaflet-indoor example that you pointed out):
>
>
> https://use.mazemap.com/#v=1&zlevel=1&left=6.8518492&right=6.8576924&top=52.2403051&bottom=52.2384279&campusid=171
>
> That's a question you may consider asking on the forum as well to gather
> more inputs?
>
> Cheers
>
> Stéphane
>
>
>
> > Best,
> > Fawad
> >
> >
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-20 Thread Stéphane Laurière

Hi Fawad, Hi all,


Hi everyone,
Hope all of you are all right.

I am working on the implementation of Indoor Maps. For that, there are several 
options for adaptation. So I need your suggestions.
The first question is how would the users be using the indoor maps?
- Would they be using images for each level?
- Would they prefer to have a normal map and add shape-like objects to it?
- Or would they like a mixture of both i.e. a normal map with images as levels?

For a normal map with multilevel structures - we can use 
https://github.com/cbaines/leaflet-indoor
For using only images - we can make use of 
https://leafletjs.com/examples/crs-simple/crs-simple.html

What do you think would be best considering the map's user base?


Initially I thought about images since many fair organizers provide PDF plans 
that could be converted into images, but on second thoughts, starting primarily 
with shapes could be even better in terms of user experience imho. Nothing 
prevents from adding images in addition in the future, if some users prefer 
that approach, or a mix as you suggest.

This kind of experience is quite inspirational in particular (it's close to the 
leaflet-indoor example that you pointed out):

  
https://use.mazemap.com/#v=1&zlevel=1&left=6.8518492&right=6.8576924&top=52.2403051&bottom=52.2384279&campusid=171

That's a question you may consider asking on the forum as well to gather more 
inputs?

Cheers

Stéphane


 

Best,
Fawad






Re: [xwiki-devs] Map Application - GSoC 19

2019-08-19 Thread Fawad Ali
Hi everyone,
Hope all of you are all right.

I am working on the implementation of Indoor Maps. For that, there are
several options for adaptation. So I need your suggestions.
The first question is how would the users be using the indoor maps?
- Would they be using images for each level?
- Would they prefer to have a normal map and add shape-like objects to it?
- Or would they like a mixture of both i.e. a normal map with images as
levels?

For a normal map with multilevel structures - we can use
https://github.com/cbaines/leaflet-indoor
For using only images - we can make use of
https://leafletjs.com/examples/crs-simple/crs-simple.html

What do you think would be best considering the map's user base?

Best,
Fawad


On Fri, Aug 2, 2019 at 5:53 PM Fawad Ali  wrote:

> Hi all,
>
> I wanted to ask if it was possible to have a custom class sheet and the
> editing options of a normal page available at the same time?
> As it stands, for the PointSheet, we will have to skip the WYSIWYG editor
> for editing the page. However, one thing could be that instead of taking
> the page's content for the Point's popup, we could introduce a new class
> property popupContent and have the popup content inside that. This way, we
> can use WYSIWYG as well.
>
> Another approach could be to keep the current Point Editor and use that
> create points without any sheet.
>
> The same questions apply for the Shape Editor as well.
> What do you think?
>
> Best,
> Fawad
>
>
> On Fri, Aug 2, 2019 at 2:53 PM Fawad Ali  wrote:
>
>> Stéphane,
>>
>> Yes, sure.
>> In the meantime, I will be working on the PointSheet.
>> However, I do want to ask if the Shape Editor is necessary at this point
>> if we are going with GeoJSON. We can refer the user to http://geojson.io
>> for creating the features. What do you think?
>>
>> Best,
>> Fawad
>>
>>
>> On Fri, Aug 2, 2019 at 12:04 PM Stéphane Laurière 
>> wrote:
>>
>>> OK Fawad,
>>>
>>> Meantime since Caty is off, and since today might actually be a bit
>>> early for me I'm afraid, I'd propose we have the call on Monday 15:00 UTC
>>> on Monday if that's ok with you .
>>>
>>> Cheers
>>>
>>> Stéphane
>>>
>>>
>>> Fawad Ali:
>>> > Stéphane, Ecaterina,
>>> >
>>> > About the call, I think we should have it so that we all converge on
>>> the things to be done.
>>> > However, tomorrow (Friday), I have a call with the Pakistan's GSoC
>>> community at about 5 PM UTC. If the call will be finished in two hours I am
>>> fine with it or we could reschedule it to 2:30 PM UTC or else Monday.
>>> >
>>> > Best,
>>>
>>>
>>> --
>>> Stéphane Laurière
>>> XWiki – https://xwiki.com
>>>
>>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-02 Thread Stéphane Laurière

Fawad,

One option to do this is to use the ready-made AppWithinMinutes editors, by introducing 
an additional field for the content in a class, and filling in the custom displayer 
property value with "{{include reference='AppWithinMinutes.Content'/}}". You 
can use the same approach for editing the page title from an XWikiObject form. I could 
not find an online documentation about this feature yet, we might document it in greater 
details as it's very handy when the need arises to combine the document and the object 
approaches.

Cheers

Stéphane


Hi all,

I wanted to ask if it was possible to have a custom class sheet and the editing 
options of a normal page available at the same time?
As it stands, for the PointSheet, we will have to skip the WYSIWYG editor for 
editing the page. However, one thing could be that instead of taking the page's 
content for the Point's popup, we could introduce a new class property 
popupContent and have the popup content inside that. This way, we can use 
WYSIWYG as well.

Another approach could be to keep the current Point Editor and use that create 
points without any sheet.

The same questions apply for the Shape Editor as well.
What do you think?

Best,
Fawad





Re: [xwiki-devs] Map Application - GSoC 19

2019-08-02 Thread Fawad Ali
Hi all,

I wanted to ask if it was possible to have a custom class sheet and the
editing options of a normal page available at the same time?
As it stands, for the PointSheet, we will have to skip the WYSIWYG editor
for editing the page. However, one thing could be that instead of taking
the page's content for the Point's popup, we could introduce a new class
property popupContent and have the popup content inside that. This way, we
can use WYSIWYG as well.

Another approach could be to keep the current Point Editor and use that
create points without any sheet.

The same questions apply for the Shape Editor as well.
What do you think?

Best,
Fawad


On Fri, Aug 2, 2019 at 2:53 PM Fawad Ali  wrote:

> Stéphane,
>
> Yes, sure.
> In the meantime, I will be working on the PointSheet.
> However, I do want to ask if the Shape Editor is necessary at this point
> if we are going with GeoJSON. We can refer the user to http://geojson.io
> for creating the features. What do you think?
>
> Best,
> Fawad
>
>
> On Fri, Aug 2, 2019 at 12:04 PM Stéphane Laurière 
> wrote:
>
>> OK Fawad,
>>
>> Meantime since Caty is off, and since today might actually be a bit early
>> for me I'm afraid, I'd propose we have the call on Monday 15:00 UTC on
>> Monday if that's ok with you .
>>
>> Cheers
>>
>> Stéphane
>>
>>
>> Fawad Ali:
>> > Stéphane, Ecaterina,
>> >
>> > About the call, I think we should have it so that we all converge on
>> the things to be done.
>> > However, tomorrow (Friday), I have a call with the Pakistan's GSoC
>> community at about 5 PM UTC. If the call will be finished in two hours I am
>> fine with it or we could reschedule it to 2:30 PM UTC or else Monday.
>> >
>> > Best,
>>
>>
>> --
>> Stéphane Laurière
>> XWiki – https://xwiki.com
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-01 Thread Ecaterina Moraru (Valica)
Hi,

I am out of the country and won't have access to fast Internet in the
following 2 weeks, so I won't be able to participate in the call. Sorry.

Caty

On Thu, Aug 1, 2019 at 10:03 PM Fawad Ali  wrote:

> Stéphane, Ecaterina,
>
> About the call, I think we should have it so that we all converge on the
> things to be done.
> However, tomorrow (Friday), I have a call with the Pakistan's GSoC
> community at about 5 PM UTC. If the call will be finished in two hours I am
> fine with it or we could reschedule it to 2:30 PM UTC or else Monday.
>
> Best,
> Fawad
>
>
> On Thu, Aug 1, 2019 at 11:58 PM Fawad Ali  wrote:
>
>> Stéphane,
>>
>> Your suggestions regarding the Point Editor are also very helpful. I will
>> make a sheet for PointClass as it will be much better.
>> I will do the same with Shape Editor and ShapeClass as leaflet easily
>> converts map items to GeoJSON.
>>
>> Best,
>> Fawad
>>
>>
>> On Thu, Aug 1, 2019 at 11:54 PM Fawad Ali 
>> wrote:
>>
>>> Stéphane,
>>>
>>> I agree that GeoJSON would be a much portable and standard option. I
>>> went with the structure I implemented because I was directly working with
>>> leaflet docs.
>>> I have one concern though and that is the flexibility of GeoJSON. By
>>> flexibility I mean that it will be harder for XWiki users to get used to
>>> the GeoJSON as opposed to the "points" and "options" properties of
>>> ShapeClass. Nonetheless, I am going with the GeoJSON now.
>>>
>>> Best,
>>> Fawad
>>>
>>>
>>> On Thu, Aug 1, 2019 at 11:37 PM Stéphane Laurière 
>>> wrote:
>>>
 Fawad, Caty,

 I had mostly technical aspects in mind when proposing a call, I
 overlooked that UX and design also need to be discussed so that we make
 sure to align our views for the upcoming weeks. Let's see in a private
 channel how we can align our agenda to make this happen, if you feel like
 it. Apologies for having acted a bit in a rush.

 Cheers

 Stéphane


 > Hi all,
 >
 > The setup for shapes has been done.
 > What I have in mind now is to have a Shape Editor similar to the
 Point Editor with interactive tools to create shapes. Stephane, if you have
 anything else in mind for interactively creating shapes then please let me
 know so that we are on the same page.
 > I will work on it as fast as I can so we can move on to the
 implementation of Indoor Maps.
 >
 > Best,
 > Fawad Ali
 >
 >
 > On Tue, Jul 30, 2019 at 11:46 AM Stéphane Laurière <
 slauri...@xwiki.com > wrote:
 >
 > Hi Fawad,
 >
 > I would go for approach C as well, that is storing all shape data
 entirely in json, since most probably the shapes will either by imported
 directly from preexisting data in json or any equivalent, or drawn by hand
 on a map. I see no real use case yet for an intermediary input where part
 of the data would be entered via a form, then by hand. Query-wise, I don't
 think we will need to retrieve a huge quantity of shapes with any given
 property value that would need to break down some specific values into
 dedicated properties. In case we do some day, we could either build a
 dedicated index I would say, or fill in dedicated properties automatically
 from the json input via a listener.
 >
 > Cheers,
 >
 > Stéphane
 >
 >
 >  > Hi Stéphane, Ecaterina and everyone,
 >  > Hope you all had a wonderful weekend.
 >  >
 >  > So I am working on shapes and wanted to know how I should deal
 with the large number of options for each shape type. As expected, the
 options are different for each shape type.
 >  >
 >  > I have multiple approaches in mind for this:
 >  > *Approach A:* Using the normal properties of XClass, create
 all the options for a shape type as properties for that class. This will in
 turn increase the class size as a lot of options will exist for each shape
 type.
 >  > *Approach B:* Use a static list or array to define the value
 of each shape type option. I have tried and it seems we cannot make use of
 key value pairs in static list or any other data type in XWiki so I am not
 completely sure of the implementation using static lists.
 >  > *Approach C:* Create a single TextArea property for options in
 each shape type class. The user can pass a JSON of options in that
 TextArea. Imho I prefer this approach since JSON is a standard format and
 it will give the user freedom of which options to use.
 >  >
 >  > WDYT?
 >  >
 >  > Best,
 >  > Fawad Ali
 >


 --
 Stéphane Laurière
 XWiki – https://xwiki.com




Re: [xwiki-devs] Map Application - GSoC 19

2019-08-01 Thread Fawad Ali
Stéphane, Ecaterina,

About the call, I think we should have it so that we all converge on the
things to be done.
However, tomorrow (Friday), I have a call with the Pakistan's GSoC
community at about 5 PM UTC. If the call will be finished in two hours I am
fine with it or we could reschedule it to 2:30 PM UTC or else Monday.

Best,
Fawad


On Thu, Aug 1, 2019 at 11:58 PM Fawad Ali  wrote:

> Stéphane,
>
> Your suggestions regarding the Point Editor are also very helpful. I will
> make a sheet for PointClass as it will be much better.
> I will do the same with Shape Editor and ShapeClass as leaflet easily
> converts map items to GeoJSON.
>
> Best,
> Fawad
>
>
> On Thu, Aug 1, 2019 at 11:54 PM Fawad Ali  wrote:
>
>> Stéphane,
>>
>> I agree that GeoJSON would be a much portable and standard option. I went
>> with the structure I implemented because I was directly working with
>> leaflet docs.
>> I have one concern though and that is the flexibility of GeoJSON. By
>> flexibility I mean that it will be harder for XWiki users to get used to
>> the GeoJSON as opposed to the "points" and "options" properties of
>> ShapeClass. Nonetheless, I am going with the GeoJSON now.
>>
>> Best,
>> Fawad
>>
>>
>> On Thu, Aug 1, 2019 at 11:37 PM Stéphane Laurière 
>> wrote:
>>
>>> Fawad, Caty,
>>>
>>> I had mostly technical aspects in mind when proposing a call, I
>>> overlooked that UX and design also need to be discussed so that we make
>>> sure to align our views for the upcoming weeks. Let's see in a private
>>> channel how we can align our agenda to make this happen, if you feel like
>>> it. Apologies for having acted a bit in a rush.
>>>
>>> Cheers
>>>
>>> Stéphane
>>>
>>>
>>> > Hi all,
>>> >
>>> > The setup for shapes has been done.
>>> > What I have in mind now is to have a Shape Editor similar to the Point
>>> Editor with interactive tools to create shapes. Stephane, if you have
>>> anything else in mind for interactively creating shapes then please let me
>>> know so that we are on the same page.
>>> > I will work on it as fast as I can so we can move on to the
>>> implementation of Indoor Maps.
>>> >
>>> > Best,
>>> > Fawad Ali
>>> >
>>> >
>>> > On Tue, Jul 30, 2019 at 11:46 AM Stéphane Laurière <
>>> slauri...@xwiki.com > wrote:
>>> >
>>> > Hi Fawad,
>>> >
>>> > I would go for approach C as well, that is storing all shape data
>>> entirely in json, since most probably the shapes will either by imported
>>> directly from preexisting data in json or any equivalent, or drawn by hand
>>> on a map. I see no real use case yet for an intermediary input where part
>>> of the data would be entered via a form, then by hand. Query-wise, I don't
>>> think we will need to retrieve a huge quantity of shapes with any given
>>> property value that would need to break down some specific values into
>>> dedicated properties. In case we do some day, we could either build a
>>> dedicated index I would say, or fill in dedicated properties automatically
>>> from the json input via a listener.
>>> >
>>> > Cheers,
>>> >
>>> > Stéphane
>>> >
>>> >
>>> >  > Hi Stéphane, Ecaterina and everyone,
>>> >  > Hope you all had a wonderful weekend.
>>> >  >
>>> >  > So I am working on shapes and wanted to know how I should deal
>>> with the large number of options for each shape type. As expected, the
>>> options are different for each shape type.
>>> >  >
>>> >  > I have multiple approaches in mind for this:
>>> >  > *Approach A:* Using the normal properties of XClass, create all
>>> the options for a shape type as properties for that class. This will in
>>> turn increase the class size as a lot of options will exist for each shape
>>> type.
>>> >  > *Approach B:* Use a static list or array to define the value of
>>> each shape type option. I have tried and it seems we cannot make use of key
>>> value pairs in static list or any other data type in XWiki so I am not
>>> completely sure of the implementation using static lists.
>>> >  > *Approach C:* Create a single TextArea property for options in
>>> each shape type class. The user can pass a JSON of options in that
>>> TextArea. Imho I prefer this approach since JSON is a standard format and
>>> it will give the user freedom of which options to use.
>>> >  >
>>> >  > WDYT?
>>> >  >
>>> >  > Best,
>>> >  > Fawad Ali
>>> >
>>>
>>>
>>> --
>>> Stéphane Laurière
>>> XWiki – https://xwiki.com
>>>
>>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-01 Thread Fawad Ali
Stéphane,

Your suggestions regarding the Point Editor are also very helpful. I will
make a sheet for PointClass as it will be much better.
I will do the same with Shape Editor and ShapeClass as leaflet easily
converts map items to GeoJSON.

Best,
Fawad


On Thu, Aug 1, 2019 at 11:54 PM Fawad Ali  wrote:

> Stéphane,
>
> I agree that GeoJSON would be a much portable and standard option. I went
> with the structure I implemented because I was directly working with
> leaflet docs.
> I have one concern though and that is the flexibility of GeoJSON. By
> flexibility I mean that it will be harder for XWiki users to get used to
> the GeoJSON as opposed to the "points" and "options" properties of
> ShapeClass. Nonetheless, I am going with the GeoJSON now.
>
> Best,
> Fawad
>
>
> On Thu, Aug 1, 2019 at 11:37 PM Stéphane Laurière 
> wrote:
>
>> Fawad, Caty,
>>
>> I had mostly technical aspects in mind when proposing a call, I
>> overlooked that UX and design also need to be discussed so that we make
>> sure to align our views for the upcoming weeks. Let's see in a private
>> channel how we can align our agenda to make this happen, if you feel like
>> it. Apologies for having acted a bit in a rush.
>>
>> Cheers
>>
>> Stéphane
>>
>>
>> > Hi all,
>> >
>> > The setup for shapes has been done.
>> > What I have in mind now is to have a Shape Editor similar to the Point
>> Editor with interactive tools to create shapes. Stephane, if you have
>> anything else in mind for interactively creating shapes then please let me
>> know so that we are on the same page.
>> > I will work on it as fast as I can so we can move on to the
>> implementation of Indoor Maps.
>> >
>> > Best,
>> > Fawad Ali
>> >
>> >
>> > On Tue, Jul 30, 2019 at 11:46 AM Stéphane Laurière > > wrote:
>> >
>> > Hi Fawad,
>> >
>> > I would go for approach C as well, that is storing all shape data
>> entirely in json, since most probably the shapes will either by imported
>> directly from preexisting data in json or any equivalent, or drawn by hand
>> on a map. I see no real use case yet for an intermediary input where part
>> of the data would be entered via a form, then by hand. Query-wise, I don't
>> think we will need to retrieve a huge quantity of shapes with any given
>> property value that would need to break down some specific values into
>> dedicated properties. In case we do some day, we could either build a
>> dedicated index I would say, or fill in dedicated properties automatically
>> from the json input via a listener.
>> >
>> > Cheers,
>> >
>> > Stéphane
>> >
>> >
>> >  > Hi Stéphane, Ecaterina and everyone,
>> >  > Hope you all had a wonderful weekend.
>> >  >
>> >  > So I am working on shapes and wanted to know how I should deal
>> with the large number of options for each shape type. As expected, the
>> options are different for each shape type.
>> >  >
>> >  > I have multiple approaches in mind for this:
>> >  > *Approach A:* Using the normal properties of XClass, create all
>> the options for a shape type as properties for that class. This will in
>> turn increase the class size as a lot of options will exist for each shape
>> type.
>> >  > *Approach B:* Use a static list or array to define the value of
>> each shape type option. I have tried and it seems we cannot make use of key
>> value pairs in static list or any other data type in XWiki so I am not
>> completely sure of the implementation using static lists.
>> >  > *Approach C:* Create a single TextArea property for options in
>> each shape type class. The user can pass a JSON of options in that
>> TextArea. Imho I prefer this approach since JSON is a standard format and
>> it will give the user freedom of which options to use.
>> >  >
>> >  > WDYT?
>> >  >
>> >  > Best,
>> >  > Fawad Ali
>> >
>>
>>
>> --
>> Stéphane Laurière
>> XWiki – https://xwiki.com
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-01 Thread Fawad Ali
Stéphane,

I agree that GeoJSON would be a much portable and standard option. I went
with the structure I implemented because I was directly working with
leaflet docs.
I have one concern though and that is the flexibility of GeoJSON. By
flexibility I mean that it will be harder for XWiki users to get used to
the GeoJSON as opposed to the "points" and "options" properties of
ShapeClass. Nonetheless, I am going with the GeoJSON now.

Best,
Fawad


On Thu, Aug 1, 2019 at 11:37 PM Stéphane Laurière 
wrote:

> Fawad, Caty,
>
> I had mostly technical aspects in mind when proposing a call, I overlooked
> that UX and design also need to be discussed so that we make sure to align
> our views for the upcoming weeks. Let's see in a private channel how we can
> align our agenda to make this happen, if you feel like it. Apologies for
> having acted a bit in a rush.
>
> Cheers
>
> Stéphane
>
>
> > Hi all,
> >
> > The setup for shapes has been done.
> > What I have in mind now is to have a Shape Editor similar to the Point
> Editor with interactive tools to create shapes. Stephane, if you have
> anything else in mind for interactively creating shapes then please let me
> know so that we are on the same page.
> > I will work on it as fast as I can so we can move on to the
> implementation of Indoor Maps.
> >
> > Best,
> > Fawad Ali
> >
> >
> > On Tue, Jul 30, 2019 at 11:46 AM Stéphane Laurière  > wrote:
> >
> > Hi Fawad,
> >
> > I would go for approach C as well, that is storing all shape data
> entirely in json, since most probably the shapes will either by imported
> directly from preexisting data in json or any equivalent, or drawn by hand
> on a map. I see no real use case yet for an intermediary input where part
> of the data would be entered via a form, then by hand. Query-wise, I don't
> think we will need to retrieve a huge quantity of shapes with any given
> property value that would need to break down some specific values into
> dedicated properties. In case we do some day, we could either build a
> dedicated index I would say, or fill in dedicated properties automatically
> from the json input via a listener.
> >
> > Cheers,
> >
> > Stéphane
> >
> >
> >  > Hi Stéphane, Ecaterina and everyone,
> >  > Hope you all had a wonderful weekend.
> >  >
> >  > So I am working on shapes and wanted to know how I should deal
> with the large number of options for each shape type. As expected, the
> options are different for each shape type.
> >  >
> >  > I have multiple approaches in mind for this:
> >  > *Approach A:* Using the normal properties of XClass, create all
> the options for a shape type as properties for that class. This will in
> turn increase the class size as a lot of options will exist for each shape
> type.
> >  > *Approach B:* Use a static list or array to define the value of
> each shape type option. I have tried and it seems we cannot make use of key
> value pairs in static list or any other data type in XWiki so I am not
> completely sure of the implementation using static lists.
> >  > *Approach C:* Create a single TextArea property for options in
> each shape type class. The user can pass a JSON of options in that
> TextArea. Imho I prefer this approach since JSON is a standard format and
> it will give the user freedom of which options to use.
> >  >
> >  > WDYT?
> >  >
> >  > Best,
> >  > Fawad Ali
> >
>
>
> --
> Stéphane Laurière
> XWiki – https://xwiki.com
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-08-01 Thread Stéphane Laurière

Fawad, Caty,

I had mostly technical aspects in mind when proposing a call, I overlooked that 
UX and design also need to be discussed so that we make sure to align our views 
for the upcoming weeks. Let's see in a private channel how we can align our 
agenda to make this happen, if you feel like it. Apologies for having acted a 
bit in a rush.

Cheers

Stéphane



Hi all,

The setup for shapes has been done.
What I have in mind now is to have a Shape Editor similar to the Point Editor 
with interactive tools to create shapes. Stephane, if you have anything else in 
mind for interactively creating shapes then please let me know so that we are 
on the same page.
I will work on it as fast as I can so we can move on to the implementation of 
Indoor Maps.

Best,
Fawad Ali


On Tue, Jul 30, 2019 at 11:46 AM Stéphane Laurière mailto:slauri...@xwiki.com>> wrote:

Hi Fawad,

I would go for approach C as well, that is storing all shape data entirely 
in json, since most probably the shapes will either by imported directly from 
preexisting data in json or any equivalent, or drawn by hand on a map. I see no 
real use case yet for an intermediary input where part of the data would be 
entered via a form, then by hand. Query-wise, I don't think we will need to 
retrieve a huge quantity of shapes with any given property value that would 
need to break down some specific values into dedicated properties. In case we 
do some day, we could either build a dedicated index I would say, or fill in 
dedicated properties automatically from the json input via a listener.

Cheers,

Stéphane


 > Hi Stéphane, Ecaterina and everyone,
 > Hope you all had a wonderful weekend.
 >
 > So I am working on shapes and wanted to know how I should deal with the 
large number of options for each shape type. As expected, the options are 
different for each shape type.
 >
 > I have multiple approaches in mind for this:
 > *Approach A:* Using the normal properties of XClass, create all the 
options for a shape type as properties for that class. This will in turn increase 
the class size as a lot of options will exist for each shape type.
 > *Approach B:* Use a static list or array to define the value of each 
shape type option. I have tried and it seems we cannot make use of key value pairs 
in static list or any other data type in XWiki so I am not completely sure of the 
implementation using static lists.
 > *Approach C:* Create a single TextArea property for options in each 
shape type class. The user can pass a JSON of options in that TextArea. Imho I 
prefer this approach since JSON is a standard format and it will give the user 
freedom of which options to use.
 >
 > WDYT?
 >
 > Best,
 > Fawad Ali




--
Stéphane Laurière
XWiki – https://xwiki.com



Re: [xwiki-devs] Map Application - GSoC 19

2019-08-01 Thread Stéphane Laurière

Hi Fawad,

Thanks for the update. I had a look at the ShapeClass and I have a remark about their structure. I 
see you introduced the properties "points", "type". I'm wondering whether we 
could simply consider that the shapes are entirely represented in GeoJSON, including the style 
options, just like http://geojson.io/ behaves, eg in the example below. What would be the use case 
for storing these properties separately? I thought your previous question were about that, sorry 
for the misunderstanding.

Regarding the editors: good to see there's the point editor (I had not tried it 
yet), I have some remarks about it:
- What about setting it up by default for the PointClass objects, so that these 
points can be edited using the editor, by creating a PointSheet that uses it?
- We could introduce a TemplateProvider for points, so that creating points can 
be achieved using the standard XWiki create page, what do you think?
- What's the rationale for storing the editors in a dedicated space? I would 
either put all them in the Code space directly, or in a subspace if you really 
want to group them (I tend to avoid having too many nested spaces but that's a 
personal taste only).

I may have other remarks that I will bring up directly on Jira if that's ok 
with you.

It's good to read that you already have in mind indoor maps as it's a promising 
feature imho, on the other hand I'd say there could be also much value in 
improving the current features, I need to get my head around that and to review 
the current issues. I will do so by tomorrow, then we could set up a call at 
the end of the day, if possible for you, or on Monday. What about 3pm UTC 
tomorrow? Or Monday 3pm UTC?

Cheers

Stéphane


{
  "type": "Feature",
  "properties": {
"stroke": "#c5ce00",
"stroke-width": 2,
"stroke-opacity": 1,
"fill": "#c13d3d",
"fill-opacity": 0.5
  },
  "geometry": {
"type": "Polygon",
"coordinates": [
  [
[
  148.7109375,
  54.36775852406841
],
[
  146.9531249997,
  54.16243396806779
],
[
  170.5078125,
  6.664607562172573
],
[
  216.2109375,
  40.17887331434696
],
[
  198.9843749997,
  76.01609366420995
],
[
  148.7109375,
  54.36775852406841
]
  ]
]
  }
}


Hi all,

The setup for shapes has been done.
What I have in mind now is to have a Shape Editor similar to the Point Editor 
with interactive tools to create shapes. Stephane, if you have anything else in 
mind for interactively creating shapes then please let me know so that we are 
on the same page.
I will work on it as fast as I can so we can move on to the implementation of 
Indoor Maps.

Best,
Fawad Ali
--

Stéphane Laurière
XWiki – https://xwiki.com



Re: [xwiki-devs] Map Application - GSoC 19

2019-08-01 Thread Fawad Ali
Hi all,

The setup for shapes has been done.
What I have in mind now is to have a Shape Editor similar to the Point
Editor with interactive tools to create shapes. Stephane, if you have
anything else in mind for interactively creating shapes then please let me
know so that we are on the same page.
I will work on it as fast as I can so we can move on to the implementation
of Indoor Maps.

Best,
Fawad Ali


On Tue, Jul 30, 2019 at 11:46 AM Stéphane Laurière 
wrote:

> Hi Fawad,
>
> I would go for approach C as well, that is storing all shape data entirely
> in json, since most probably the shapes will either by imported directly
> from preexisting data in json or any equivalent, or drawn by hand on a map.
> I see no real use case yet for an intermediary input where part of the data
> would be entered via a form, then by hand. Query-wise, I don't think we
> will need to retrieve a huge quantity of shapes with any given property
> value that would need to break down some specific values into dedicated
> properties. In case we do some day, we could either build a dedicated index
> I would say, or fill in dedicated properties automatically from the json
> input via a listener.
>
> Cheers,
>
> Stéphane
>
>
> > Hi Stéphane, Ecaterina and everyone,
> > Hope you all had a wonderful weekend.
> >
> > So I am working on shapes and wanted to know how I should deal with the
> large number of options for each shape type. As expected, the options are
> different for each shape type.
> >
> > I have multiple approaches in mind for this:
> > *Approach A:* Using the normal properties of XClass, create all the
> options for a shape type as properties for that class. This will in turn
> increase the class size as a lot of options will exist for each shape type.
> > *Approach B:* Use a static list or array to define the value of each
> shape type option. I have tried and it seems we cannot make use of key
> value pairs in static list or any other data type in XWiki so I am not
> completely sure of the implementation using static lists.
> > *Approach C:* Create a single TextArea property for options in each
> shape type class. The user can pass a JSON of options in that TextArea.
> Imho I prefer this approach since JSON is a standard format and it will
> give the user freedom of which options to use.
> >
> > WDYT?
> >
> > Best,
> > Fawad Ali
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-07-29 Thread Stéphane Laurière

Hi Fawad,

I would go for approach C as well, that is storing all shape data entirely in 
json, since most probably the shapes will either by imported directly from 
preexisting data in json or any equivalent, or drawn by hand on a map. I see no 
real use case yet for an intermediary input where part of the data would be 
entered via a form, then by hand. Query-wise, I don't think we will need to 
retrieve a huge quantity of shapes with any given property value that would 
need to break down some specific values into dedicated properties. In case we 
do some day, we could either build a dedicated index I would say, or fill in 
dedicated properties automatically from the json input via a listener.

Cheers,

Stéphane



Hi Stéphane, Ecaterina and everyone,
Hope you all had a wonderful weekend.

So I am working on shapes and wanted to know how I should deal with the large 
number of options for each shape type. As expected, the options are different 
for each shape type.

I have multiple approaches in mind for this:
*Approach A:* Using the normal properties of XClass, create all the options for 
a shape type as properties for that class. This will in turn increase the class 
size as a lot of options will exist for each shape type.
*Approach B:* Use a static list or array to define the value of each shape type 
option. I have tried and it seems we cannot make use of key value pairs in 
static list or any other data type in XWiki so I am not completely sure of the 
implementation using static lists.
*Approach C:* Create a single TextArea property for options in each shape type 
class. The user can pass a JSON of options in that TextArea. Imho I prefer this 
approach since JSON is a standard format and it will give the user freedom of 
which options to use.

WDYT?

Best,
Fawad Ali




Re: [xwiki-devs] Map Application - GSoC 19

2019-07-29 Thread Fawad Ali
Hi Stéphane, Ecaterina and everyone,
Hope you all had a wonderful weekend.

So I am working on shapes and wanted to know how I should deal with the
large number of options for each shape type. As expected, the options are
different for each shape type.

I have multiple approaches in mind for this:
*Approach A:* Using the normal properties of XClass, create all the options
for a shape type as properties for that class. This will in turn increase
the class size as a lot of options will exist for each shape type.
*Approach B:* Use a static list or array to define the value of each shape
type option. I have tried and it seems we cannot make use of key value
pairs in static list or any other data type in XWiki so I am not completely
sure of the implementation using static lists.
*Approach C:* Create a single TextArea property for options in each shape
type class. The user can pass a JSON of options in that TextArea. Imho I
prefer this approach since JSON is a standard format and it will give the
user freedom of which options to use.

WDYT?

Best,
Fawad Ali


On Mon, Jul 22, 2019 at 10:25 PM Stéphane Laurière 
wrote:

> Hi Fawad, Hi all,
>
> > Hi all,
> > Hope you are doing well.
> >
> > Stephane proposed that there should be a change in the Point data
> > structure. I agree that latitude and longitude should be two distinct
> > fields but am not sure how we are going to accommodate geographical
> > addresses. Should we create a separate class for an address? But if we
> are
> > going to supply latitude and longitude to the map, we will need to
> process
> > the addresses in some way and store their lat and lng somewhere as a
> point
> > object.
> > I am going to put this on hold until we are in the clear.
>
> I just commented on this at https://jira.xwiki.org/browse/INTMAP-27
>
> > I have also added support for using custom class properties as addresses
> to
> > feed to the map as points. This feature is available in the advanced
> > options of map configuration. For now, the properties should be given in
> > the form property.ClassPath.property_name e.g.
> > property.XWiki.XWikiUsers.address_en. This is inline with how solr
> > perceives properties.
>
> That sounds great to use the same syntax as the Solr one indeed.
>
> > Does anyone have any suggestions for making it easier to query a class
> > property? I will try to remove the need for the ending "_en" or "_string"
> > part since they can prove confusing in some contexts.
>
> +1 for removing "_en" since the app could be used in wikis where English
> is not enabled. I don't have further suggestion on my end so far...
>
> > I will start moving on with the development and create a mechanism for
> > adding paths to the map.
>
> Great, I commented also at https://jira.xwiki.org/browse/INTMAP-27 as you
> probably noticed,
>
> Cheers
>
> Stéphane
>
>
> --
> Stéphane Laurière
> XWiki – https://xwiki.com
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-07-22 Thread Stéphane Laurière

Hi Fawad, Hi all,


Hi all,
Hope you are doing well.

Stephane proposed that there should be a change in the Point data
structure. I agree that latitude and longitude should be two distinct
fields but am not sure how we are going to accommodate geographical
addresses. Should we create a separate class for an address? But if we are
going to supply latitude and longitude to the map, we will need to process
the addresses in some way and store their lat and lng somewhere as a point
object.
I am going to put this on hold until we are in the clear.


I just commented on this at https://jira.xwiki.org/browse/INTMAP-27


I have also added support for using custom class properties as addresses to
feed to the map as points. This feature is available in the advanced
options of map configuration. For now, the properties should be given in
the form property.ClassPath.property_name e.g.
property.XWiki.XWikiUsers.address_en. This is inline with how solr
perceives properties.


That sounds great to use the same syntax as the Solr one indeed.


Does anyone have any suggestions for making it easier to query a class
property? I will try to remove the need for the ending "_en" or "_string"
part since they can prove confusing in some contexts.


+1 for removing "_en" since the app could be used in wikis where English is not 
enabled. I don't have further suggestion on my end so far...


I will start moving on with the development and create a mechanism for
adding paths to the map.


Great, I commented also at https://jira.xwiki.org/browse/INTMAP-27 as you 
probably noticed,

Cheers

Stéphane


--
Stéphane Laurière
XWiki – https://xwiki.com



Re: [xwiki-devs] Map Application - GSoC 19

2019-07-19 Thread Fawad Ali
Hi all,
Hope you are doing well.

Stephane proposed that there should be a change in the Point data
structure. I agree that latitude and longitude should be two distinct
fields but am not sure how we are going to accommodate geographical
addresses. Should we create a separate class for an address? But if we are
going to supply latitude and longitude to the map, we will need to process
the addresses in some way and store their lat and lng somewhere as a point
object.
I am going to put this on hold until we are in the clear.

I have also added support for using custom class properties as addresses to
feed to the map as points. This feature is available in the advanced
options of map configuration. For now, the properties should be given in
the form property.ClassPath.property_name e.g.
property.XWiki.XWikiUsers.address_en. This is inline with how solr
perceives properties.
Does anyone have any suggestions for making it easier to query a class
property? I will try to remove the need for the ending "_en" or "_string"
part since they can prove confusing in some contexts.

I will start moving on with the development and create a mechanism for
adding paths to the map.

Best,
Fawad


On Wed, Jul 17, 2019 at 12:22 PM Vincent Massol  wrote:

> Well done Fawad, congrats!
>
> A very small detail: we’re strying to have the same styles for images on
> xwiki.org and we have some guidelines linked from
> https://contrib.xwiki.org/xwiki/bin/view/Main/WebHome#HDocumenting
>
> For example for images here are the best practices:
>
> https://dev.xwiki.org/xwiki/bin/view/Community/DocGuide#HScreenshots2FImages
>
> So it would be awesome if you could use the {{image}} macro.
>
> Thanks
> -Vincent
>
> > On 16 Jul 2019, at 19:27, Fawad Ali  wrote:
> >
> > Hi all,
> > Hope you are doing wonderful today.
> >
> > I am very excited to announce that Interaction Maps Application v1.0 is
> now
> > up.
> >
> > Extension and documentation:
> >
> https://extensions.xwiki.org/xwiki/bin/view/Extension/InteractiveMapsApplication/
> > Forum post:
> > https://forum.xwiki.org/t/interactive-maps-application-v1-0-released/
> >
> > Thanks to Thomas for helping with issues in the release; Stephane for all
> > the wonderful and detailed instructions; Ecaterina for all the great help
> > and ideas; Vincent for helping with tests and other issues; and everyone
> > else who helped with the project.
> > It has been a wonderful experience so far to work with the XWiki
> community!
> > I look forward to how the complete application will turn out.
> >
> > Best,
> > Fawad
> >
> >
> > On Tue, Jul 16, 2019 at 1:31 PM Stéphane Laurière 
> > wrote:
> >
> >> Hi Fawad,
> >>
> >>> Also, I looked into it and the idea of custom class property for
> getting
> >> the location is interesting indeed. I will see how I should prioritize
> it
> >> and implement it then since we have other major features to look into.
> >>>
> >>> I would also like to ask; what do you foresee as the basic elements of
> >> the application? We have map configuration, map query, search and filter
> >> widget, markers and popups so far. Do you have anything other than this
> in
> >> mind that could be thought of as the basis of the application? I think
> we
> >> should completely stabilize the basics by the end of this week so I can
> >> work on other features like map paths, indoor maps and custom shapes.
> >>
> >> Just a quick reply about this to confirm that I think the basic elements
> >> that you mention form the core of version 1.0. I don't have much to add
> at
> >> the moment. You're right that it's important to have sound foundations
> and
> >> we should limit future modifications of the core as much as possible,
> >> however despite anticipating the best we can, we may encounter the need
> to
> >> modify it at some point, let's see...
> >>
> >> I saw you were facing issues with the release and the signing part, I
> hope
> >> we'll manage to solve them with the help of the community. Let's
> continue
> >> the discussion until we find a fix..
> >>
> >> Cheers
> >>
> >> Stéphane
> >>
> >>
> >>
> >>
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-07-17 Thread Vincent Massol
Well done Fawad, congrats!

A very small detail: we’re strying to have the same styles for images on 
xwiki.org and we have some guidelines linked from 
https://contrib.xwiki.org/xwiki/bin/view/Main/WebHome#HDocumenting

For example for images here are the best practices:
https://dev.xwiki.org/xwiki/bin/view/Community/DocGuide#HScreenshots2FImages

So it would be awesome if you could use the {{image}} macro.

Thanks
-Vincent

> On 16 Jul 2019, at 19:27, Fawad Ali  wrote:
> 
> Hi all,
> Hope you are doing wonderful today.
> 
> I am very excited to announce that Interaction Maps Application v1.0 is now
> up.
> 
> Extension and documentation:
> https://extensions.xwiki.org/xwiki/bin/view/Extension/InteractiveMapsApplication/
> Forum post:
> https://forum.xwiki.org/t/interactive-maps-application-v1-0-released/
> 
> Thanks to Thomas for helping with issues in the release; Stephane for all
> the wonderful and detailed instructions; Ecaterina for all the great help
> and ideas; Vincent for helping with tests and other issues; and everyone
> else who helped with the project.
> It has been a wonderful experience so far to work with the XWiki community!
> I look forward to how the complete application will turn out.
> 
> Best,
> Fawad
> 
> 
> On Tue, Jul 16, 2019 at 1:31 PM Stéphane Laurière 
> wrote:
> 
>> Hi Fawad,
>> 
>>> Also, I looked into it and the idea of custom class property for getting
>> the location is interesting indeed. I will see how I should prioritize it
>> and implement it then since we have other major features to look into.
>>> 
>>> I would also like to ask; what do you foresee as the basic elements of
>> the application? We have map configuration, map query, search and filter
>> widget, markers and popups so far. Do you have anything other than this in
>> mind that could be thought of as the basis of the application? I think we
>> should completely stabilize the basics by the end of this week so I can
>> work on other features like map paths, indoor maps and custom shapes.
>> 
>> Just a quick reply about this to confirm that I think the basic elements
>> that you mention form the core of version 1.0. I don't have much to add at
>> the moment. You're right that it's important to have sound foundations and
>> we should limit future modifications of the core as much as possible,
>> however despite anticipating the best we can, we may encounter the need to
>> modify it at some point, let's see...
>> 
>> I saw you were facing issues with the release and the signing part, I hope
>> we'll manage to solve them with the help of the community. Let's continue
>> the discussion until we find a fix..
>> 
>> Cheers
>> 
>> Stéphane
>> 
>> 
>> 
>> 



Re: [xwiki-devs] Map Application - GSoC 19

2019-07-16 Thread Stéphane Laurière

Hi Fawad, That's great news, congratulations for this first release!

Cheers

Stéphane


Hi all,
Hope you are doing wonderful today.

I am very excited to announce that Interaction Maps Application v1.0 is now up.

Extension and documentation: 
https://extensions.xwiki.org/xwiki/bin/view/Extension/InteractiveMapsApplication/
Forum post: 
https://forum.xwiki.org/t/interactive-maps-application-v1-0-released/

Thanks to Thomas for helping with issues in the release; Stephane for all the 
wonderful and detailed instructions; Ecaterina for all the great help and 
ideas; Vincent for helping with tests and other issues; and everyone else who 
helped with the project.
It has been a wonderful experience so far to work with the XWiki community! I 
look forward to how the complete application will turn out.

Best,
Fawad




Re: [xwiki-devs] Map Application - GSoC 19

2019-07-16 Thread Fawad Ali
Hi all,
Hope you are doing wonderful today.

I am very excited to announce that Interaction Maps Application v1.0 is now
up.

Extension and documentation:
https://extensions.xwiki.org/xwiki/bin/view/Extension/InteractiveMapsApplication/
Forum post:
https://forum.xwiki.org/t/interactive-maps-application-v1-0-released/

Thanks to Thomas for helping with issues in the release; Stephane for all
the wonderful and detailed instructions; Ecaterina for all the great help
and ideas; Vincent for helping with tests and other issues; and everyone
else who helped with the project.
It has been a wonderful experience so far to work with the XWiki community!
I look forward to how the complete application will turn out.

Best,
Fawad


On Tue, Jul 16, 2019 at 1:31 PM Stéphane Laurière 
wrote:

> Hi Fawad,
>
> > Also, I looked into it and the idea of custom class property for getting
> the location is interesting indeed. I will see how I should prioritize it
> and implement it then since we have other major features to look into.
> >
> > I would also like to ask; what do you foresee as the basic elements of
> the application? We have map configuration, map query, search and filter
> widget, markers and popups so far. Do you have anything other than this in
> mind that could be thought of as the basis of the application? I think we
> should completely stabilize the basics by the end of this week so I can
> work on other features like map paths, indoor maps and custom shapes.
>
> Just a quick reply about this to confirm that I think the basic elements
> that you mention form the core of version 1.0. I don't have much to add at
> the moment. You're right that it's important to have sound foundations and
> we should limit future modifications of the core as much as possible,
> however despite anticipating the best we can, we may encounter the need to
> modify it at some point, let's see...
>
> I saw you were facing issues with the release and the signing part, I hope
> we'll manage to solve them with the help of the community. Let's continue
> the discussion until we find a fix..
>
> Cheers
>
> Stéphane
>
>
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-07-16 Thread Stéphane Laurière

Hi Fawad,
 

Also, I looked into it and the idea of custom class property for getting the 
location is interesting indeed. I will see how I should prioritize it and 
implement it then since we have other major features to look into.

I would also like to ask; what do you foresee as the basic elements of the 
application? We have map configuration, map query, search and filter widget, 
markers and popups so far. Do you have anything other than this in mind that 
could be thought of as the basis of the application? I think we should 
completely stabilize the basics by the end of this week so I can work on other 
features like map paths, indoor maps and custom shapes.


Just a quick reply about this to confirm that I think the basic elements that 
you mention form the core of version 1.0. I don't have much to add at the 
moment. You're right that it's important to have sound foundations and we 
should limit future modifications of the core as much as possible, however 
despite anticipating the best we can, we may encounter the need to modify it at 
some point, let's see...

I saw you were facing issues with the release and the signing part, I hope 
we'll manage to solve them with the help of the community. Let's continue the 
discussion until we find a fix..

Cheers

Stéphane





Re: [xwiki-devs] Map Application - GSoC 19

2019-07-12 Thread Fawad Ali
Hi all,

For the release of the application, in addition to the issues I have fixed
so far, I will make the popups smaller and possibly shift the search
control to a better location. Is there anything else that you feel is
important for the first release? If there is please let me know. Although I
will be working on the known issues and other suggestions put forward by
Stephane after the release.

I feel like it's important that we bring the application to the users soon
so there opinions can be gathered for user oriented development in the
future. I will also prepare the complete documentation over the weekend if
I can.

Thank you for all the support and suggestions so far. Especially Stephane.

Best,
Fawad


On Fri, Jul 12, 2019 at 4:07 PM Fawad Ali  wrote:

> Hi all,
>
> I would go for small popups to start with (version 1.0), with a link to
>> the underlying XWiki page indeed. Later on, if time permits depending on
>> the priorities we decide, we could implement 1) a dynamic "more information
>> widget" that enlarges the popup dynamically, 2) a different interaction
>> mechanism that is similar to the Google Maps one. Let's add these features
>> as issues in Jira and refine the roadmap while defining the upcoming
>> versions, what do you think?
>>
>
> Stephane, as you suggest, let's go with smaller popups for now then. We
> can decide other placements later on if any.
>
> It will become a map item indeed, however, let's look closer at what
>> Airbnb is proposing: they typically manage three sheets:
>>
>> - One for the item page when displayed individually, for example:
>> https://up1.xwikisas.com/#0EcYpY5TQvlCAKuWP3AYIw
>> - One for displaying the item in a list:
>> https://up1.xwikisas.com/#yYiN8KfeKuy1BqibkgSkAA
>> - One for displaying the same item in a popup: same link, right side
>>
>> A customized class sheet would typically get used for the first display
>> as you envision it, but for the two others, which would be useful for
>> advanced maps imho, I was considering we could implement a built-in
>> mechanism allowing easy customization.
>>
>
> We could make it so that custom sheets can be used for displaying items in
> the popup. That way the user can create any sheet of his choice and use
> that. I will look into how this would be implemented.
>
> For now I am working on the issues you created so far. I will let you know
> how we could move forward from there.
>
> Thanks for your detailed suggestions, Stephane. It really helps in
> directing the application the right way. :)
>
> Best,
> Fawad
>
>
> On Thu, Jul 11, 2019 at 6:10 PM Stéphane Laurière 
> wrote:
>
>>
>> Fawad,
>>
>> > As a user, I like the Airbnb map experience with popups on top of
>> the markers, what about you?
>> >
>> >
>> > That is much like the default view of popups in Leaflet. This kind of
>> popup supports very little information, that's why I made a dedicated space
>> for popups. However, we could go with your suggestion of "view more". We
>> could either open the parent page with "view more" or fill the search
>> widget as you suggested. I would go with displaying more information in the
>> search widget. Is that fine with you?
>>
>> I would say that typical users will want to choose between displaying
>> information in a popup or over the search results panel, depending on the
>> user experience they prefer and the amount of information they want to
>> display. Typically, Google Maps and the Airbnb map have two different
>> approaches with this respect, and it would be a plus imho to implement the
>> two. Airbnb maps display popups, they are small indeed, but the image
>> slider lets the user obtain a significant amount of information. For
>> displaying more information like hotel schedule, ratings, comments, it's
>> clear that a bigger panel is useful, like what Google Maps is proposing.
>>
>> I would go for small popups to start with (version 1.0), with a link to
>> the underlying XWiki page indeed. Later on, if time permits depending on
>> the priorities we decide, we could implement 1) a dynamic "more information
>> widget" that enlarges the popup dynamically, 2) a different interaction
>> mechanism that is similar to the Google Maps one. Let's add these features
>> as issues in Jira and refine the roadmap while defining the upcoming
>> versions, what do you think?
>>
>> > Along this line, another improvement (you probably have it in mind)
>> would be to introduce one or several dedicated sheets for such contextual
>> information so that it can get easily customized by users with development
>> skills.
>> >
>> >
>> > I do not think this is required. If a developer wants a custom display
>> for the popup information, he can create a class sheet and make pages with
>> that sheet and it will become a map item after adding location object to
>> the page.
>>
>> It will become a map item indeed, however, let's look closer at what
>> Airbnb is proposing: they typically manage three sheets:
>>
>> - One for the item p

Re: [xwiki-devs] Map Application - GSoC 19

2019-07-12 Thread Fawad Ali
Hi all,

I would go for small popups to start with (version 1.0), with a link to the
> underlying XWiki page indeed. Later on, if time permits depending on the
> priorities we decide, we could implement 1) a dynamic "more information
> widget" that enlarges the popup dynamically, 2) a different interaction
> mechanism that is similar to the Google Maps one. Let's add these features
> as issues in Jira and refine the roadmap while defining the upcoming
> versions, what do you think?
>

Stephane, as you suggest, let's go with smaller popups for now then. We can
decide other placements later on if any.

It will become a map item indeed, however, let's look closer at what Airbnb
> is proposing: they typically manage three sheets:
>
> - One for the item page when displayed individually, for example:
> https://up1.xwikisas.com/#0EcYpY5TQvlCAKuWP3AYIw
> - One for displaying the item in a list:
> https://up1.xwikisas.com/#yYiN8KfeKuy1BqibkgSkAA
> - One for displaying the same item in a popup: same link, right side
>
> A customized class sheet would typically get used for the first display as
> you envision it, but for the two others, which would be useful for advanced
> maps imho, I was considering we could implement a built-in mechanism
> allowing easy customization.
>

We could make it so that custom sheets can be used for displaying items in
the popup. That way the user can create any sheet of his choice and use
that. I will look into how this would be implemented.

For now I am working on the issues you created so far. I will let you know
how we could move forward from there.

Thanks for your detailed suggestions, Stephane. It really helps in
directing the application the right way. :)

Best,
Fawad


On Thu, Jul 11, 2019 at 6:10 PM Stéphane Laurière 
wrote:

>
> Fawad,
>
> > As a user, I like the Airbnb map experience with popups on top of
> the markers, what about you?
> >
> >
> > That is much like the default view of popups in Leaflet. This kind of
> popup supports very little information, that's why I made a dedicated space
> for popups. However, we could go with your suggestion of "view more". We
> could either open the parent page with "view more" or fill the search
> widget as you suggested. I would go with displaying more information in the
> search widget. Is that fine with you?
>
> I would say that typical users will want to choose between displaying
> information in a popup or over the search results panel, depending on the
> user experience they prefer and the amount of information they want to
> display. Typically, Google Maps and the Airbnb map have two different
> approaches with this respect, and it would be a plus imho to implement the
> two. Airbnb maps display popups, they are small indeed, but the image
> slider lets the user obtain a significant amount of information. For
> displaying more information like hotel schedule, ratings, comments, it's
> clear that a bigger panel is useful, like what Google Maps is proposing.
>
> I would go for small popups to start with (version 1.0), with a link to
> the underlying XWiki page indeed. Later on, if time permits depending on
> the priorities we decide, we could implement 1) a dynamic "more information
> widget" that enlarges the popup dynamically, 2) a different interaction
> mechanism that is similar to the Google Maps one. Let's add these features
> as issues in Jira and refine the roadmap while defining the upcoming
> versions, what do you think?
>
> > Along this line, another improvement (you probably have it in mind)
> would be to introduce one or several dedicated sheets for such contextual
> information so that it can get easily customized by users with development
> skills.
> >
> >
> > I do not think this is required. If a developer wants a custom display
> for the popup information, he can create a class sheet and make pages with
> that sheet and it will become a map item after adding location object to
> the page.
>
> It will become a map item indeed, however, let's look closer at what
> Airbnb is proposing: they typically manage three sheets:
>
> - One for the item page when displayed individually, for example:
> https://up1.xwikisas.com/#0EcYpY5TQvlCAKuWP3AYIw
> - One for displaying the item in a list:
> https://up1.xwikisas.com/#yYiN8KfeKuy1BqibkgSkAA
> - One for displaying the same item in a popup: same link, right side
>
> A customized class sheet would typically get used for the first display as
> you envision it, but for the two others, which would be useful for advanced
> maps imho, I was considering we could implement a built-in mechanism
> allowing easy customization.
>
> > Ok, we need to investigate this. I have a preliminary question about
> this feature: how come that the URL does not reflect the mode status when
> hitting the full screen button the first time? I mean, if I'm not mistaken,
> when hitting the button before running any search, the URL remains
> unchanged, while the user may want to use that URL to s

Re: [xwiki-devs] Map Application - GSoC 19

2019-07-11 Thread Stéphane Laurière



Fawad,

As a user, I like the Airbnb map experience with popups on top of the markers, what about you? 



That is much like the default view of popups in Leaflet. This kind of popup supports very little 
information, that's why I made a dedicated space for popups. However, we could go with your 
suggestion of "view more". We could either open the parent page with "view 
more" or fill the search widget as you suggested. I would go with displaying more information 
in the search widget. Is that fine with you?


I would say that typical users will want to choose between displaying 
information in a popup or over the search results panel, depending on the user 
experience they prefer and the amount of information they want to display. 
Typically, Google Maps and the Airbnb map have two different approaches with 
this respect, and it would be a plus imho to implement the two. Airbnb maps 
display popups, they are small indeed, but the image slider lets the user 
obtain a significant amount of information. For displaying more information 
like hotel schedule, ratings, comments, it's clear that a bigger panel is 
useful, like what Google Maps is proposing.

I would go for small popups to start with (version 1.0), with a link to the underlying 
XWiki page indeed. Later on, if time permits depending on the priorities we decide, we 
could implement 1) a dynamic "more information widget" that enlarges the popup 
dynamically, 2) a different interaction mechanism that is similar to the Google Maps one. 
Let's add these features as issues in Jira and refine the roadmap while defining the 
upcoming versions, what do you think?


Along this line, another improvement (you probably have it in mind) would 
be to introduce one or several dedicated sheets for such contextual information 
so that it can get easily customized by users with development skills.


I do not think this is required. If a developer wants a custom display for the 
popup information, he can create a class sheet and make pages with that sheet 
and it will become a map item after adding location object to the page.


It will become a map item indeed, however, let's look closer at what Airbnb is 
proposing: they typically manage three sheets:

- One for the item page when displayed individually, for example: 
https://up1.xwikisas.com/#0EcYpY5TQvlCAKuWP3AYIw
- One for displaying the item in a list: 
https://up1.xwikisas.com/#yYiN8KfeKuy1BqibkgSkAA
- One for displaying the same item in a popup: same link, right side

A customized class sheet would typically get used for the first display as you 
envision it, but for the two others, which would be useful for advanced maps 
imho, I was considering we could implement a built-in mechanism allowing easy 
customization.


Ok, we need to investigate this. I have a preliminary question about this 
feature: how come that the URL does not reflect the mode status when hitting 
the full screen button the first time? I mean, if I'm not mistaken, when 
hitting the button before running any search, the URL remains unchanged, while 
the user may want to use that URL to share the map in full screen as is, or to 
embed it in full screen in a iframe, so shouldn't this parameter be present? Is 
there any difficulty with that? Wouldn't the facet widget reuse that URL 
afterwards? Sorry for any possible misunderstanding on my end.


I did not go with this flow because of better performance since a separate 
async request will be made for change in each state. What I am doing now is 
that I take the map state on search or other events that reload the map 
asynchronously.Thanks for your suggestion Stephane. I could update the page by 
observing a change in each state. This is a little slow because the map will 
have to be reloaded for each state but still a good option.


Ok great, looking forward to testing the new version

Cheers

Stéphane





Re: [xwiki-devs] Map Application - GSoC 19

2019-07-11 Thread Fawad Ali
>
> As a user, I like the Airbnb map experience with popups on top of the
> markers, what about you?


That is much like the default view of popups in Leaflet. This kind of popup
supports very little information, that's why I made a dedicated space for
popups. However, we could go with your suggestion of "view more". We could
either open the parent page with "view more" or fill the search widget as
you suggested. I would go with displaying more information in the search
widget. Is that fine with you?

Along this line, another improvement (you probably have it in mind) would
> be to introduce one or several dedicated sheets for such contextual
> information so that it can get easily customized by users with development
> skills.
>

I do not think this is required. If a developer wants a custom display for
the popup information, he can create a class sheet and make pages with that
sheet and it will become a map item after adding location object to the
page.

Ok, we need to investigate this. I have a preliminary question about this
> feature: how come that the URL does not reflect the mode status when
> hitting the full screen button the first time? I mean, if I'm not mistaken,
> when hitting the button before running any search, the URL remains
> unchanged, while the user may want to use that URL to share the map in full
> screen as is, or to embed it in full screen in a iframe, so shouldn't this
> parameter be present? Is there any difficulty with that? Wouldn't the facet
> widget reuse that URL afterwards? Sorry for any possible misunderstanding
> on my end.
>

I did not go with this flow because of better performance since a separate
async request will be made for change in each state. What I am doing now is
that I take the map state on search or other events that reload the map
asynchronously.Thanks for your suggestion Stephane. I could update the page
by observing a change in each state. This is a little slow because the map
will have to be reloaded for each state but still a good option.

Best,
Fawad


On Thu, Jul 11, 2019 at 3:26 PM Stéphane Laurière 
wrote:

> Hi Fawad, Hi all,
>
> > Hi all,
> >
> > However, as a user I would expect the list to be present also when
> the search input is empty, with the possibility to reduce the list by
> hitting the link "Show result items", what do you think?
> >
> >
> > By this do you mean that all the results should show in the "Show result
> items" when the search is empty? Thereby decreasing the number of result
> items when an actual search is made.
>
> Yes indeed, the number of items would then decrease either when a text
> search is made or a facet filter is checked.
>
> > Speaking of the list, that'd be great imho that the popups can be
> displayed while the list is active, so that the user can browse content via
> the list, wouldn't it?
> >
> >
> > I am not too sure where we could place them, since both the list and
> popups take a large amount of space. The popups are build to support page
> data, so they are also big. We could do it so the upper space belongs to
> the popup and the lower space belongs to the list. Though it will cramp the
> space a little imo. We could also increase the overall height of the map
> (which is 400px for now). WDYT?
>
> As a user, I like the Airbnb map experience with popups on top of the
> markers, what about you?
>
> <
> https://www.airbnb.com/s/soweto/homes?refinement_paths%5B%5D=%2Fhomes&query=soweto&click_referer=t%3ASEE_ALL%7Csid%3A8a34e891-60f3-47cd-a4e6-bb4182ff26ac%7Cst%3AMAGAZINE_HOMES&search_type=unknown&zoom=11&search_by_map=true&sw_lat=-26.439251721636115&sw_lng=27.49917114990228&ne_lat=-25.91485138495341&ne_lng=28.197489631347594&checkin=2019-07-18&checkout=2019-07-20&place_id=ChIJcWB04rGmlR4R322eHsI4CDo&s_tag=t8HDGbAs
> >
>
> The ability to highlight a marker when hovering the list is also quite
> handy.
>
> (note also the "search as I move the map feature")
>
> Imho the popups could be reasonably small by default, and later on we may
> consider various improvements such as 1) the ability to increase the popup
> side dynamically like what happens on the map below when you hit the link
> "Plus d'information" at the bottom of the panel:
> http://carte.preference-commerce.fr/cci-fr/ 2) the ability to choose
> where this contextual information should show up. For instance, for users
> having large content to get displayed, it could make sense to let the
> content replace entirely the list one, just like what Google does in this
> example (which is close to what we have at the moment, except that I
> wouldn't hide the search input, and I would add a "Back to results" link
> just like what Google does, and keep the same container so that the user
> understands better that the two panels are complementary, I find it easier
> to grasp the underlying behaviour):
>
> <
> https://www.google.com/maps/place/Ch%C3%A2teau+De+Monteton/@44.6171828,0.1365399,11z/data=!4m11!1m2!2m1!1srestaurant!3m7!1s0x12aa94fd12973be1:0x

Re: [xwiki-devs] Map Application - GSoC 19

2019-07-11 Thread Stéphane Laurière

Hi Fawad, Hi all,


Hi all,

However, as a user I would expect the list to be present also when the search input is empty, with the possibility to reduce the list by hitting the link "Show result items", what do you think? 



By this do you mean that all the results should show in the "Show result items" 
when the search is empty? Thereby decreasing the number of result items when an actual 
search is made.


Yes indeed, the number of items would then decrease either when a text search 
is made or a facet filter is checked.


Speaking of the list, that'd be great imho that the popups can be displayed 
while the list is active, so that the user can browse content via the list, 
wouldn't it?


I am not too sure where we could place them, since both the list and popups 
take a large amount of space. The popups are build to support page data, so 
they are also big. We could do it so the upper space belongs to the popup and 
the lower space belongs to the list. Though it will cramp the space a little 
imo. We could also increase the overall height of the map (which is 400px for 
now). WDYT?


As a user, I like the Airbnb map experience with popups on top of the markers, 
what about you?



The ability to highlight a marker when hovering the list is also quite handy.

(note also the "search as I move the map feature")

Imho the popups could be reasonably small by default, and later on we may consider various 
improvements such as 1) the ability to increase the popup side dynamically like what happens on the 
map below when you hit the link "Plus d'information" at the bottom of the panel: 
http://carte.preference-commerce.fr/cci-fr/ 2) the ability to choose where this contextual 
information should show up. For instance, for users having large content to get displayed, it could 
make sense to let the content replace entirely the list one, just like what Google does in this 
example (which is close to what we have at the moment, except that I wouldn't hide the search 
input, and I would add a "Back to results" link just like what Google does, and keep the 
same container so that the user understands better that the two panels are complementary, I find it 
easier to grasp the underlying behaviour):



Along this line, another improvement (you probably have it in mind) would be to 
introduce one or several dedicated sheets for such contextual information so 
that it can get easily customized by users with development skills.


  Restoring the full screen is working in most cases, that's cool, however 
if I run a search, then enter full screen, then refine the search, it seems 
that the full screen state is not preserved, is it?


That's one use case which leads to a loss of the previous map state and the one before 
that is used. Any state before the facet click is not preserved except the search widget 
and "Refine your search" area which is more or less forced. As I said before, 
the problem is that we cannot pass the state anywhere when a facet is clicked. I will 
look into cumulative onclick events but I think that's not going to work.


Ok, we need to investigate this. I have a preliminary question about this 
feature: how come that the URL does not reflect the mode status when hitting 
the full screen button the first time? I mean, if I'm not mistaken, when 
hitting the button before running any search, the URL remains unchanged, while 
the user may want to use that URL to share the map in full screen as is, or to 
embed it in full screen in a iframe, so shouldn't this parameter be present? Is 
there any difficulty with that? Wouldn't the facet widget reuse that URL 
afterwards? Sorry for any possible misunderstanding on my end.



I agree LeafletMap would be closer to what it does, but contrarily to the 
Macro Map, if I'm not mistaken, the page currently named Maps.Code.Leaflet does 
not create a JavaScript LeafletMap class, so technically it's more a 
LeafletUtils than a LeafletMap, isn't it?


You are right, it does not create any js class and since css is also inside the 
same page the name should be LeafletUtils or LeafletService. I will change it 
accordingly.


Ok cool.


Also, I looked into it and the idea of custom class property for getting the 
location is interesting indeed. I will see how I should prioritize it and 
implement it then since we have other major features t

Re: [xwiki-devs] Map Application - GSoC 19

2019-07-11 Thread Fawad Ali
Hi all,

However, as a user I would expect the list to be present also when the
> search input is empty, with the possibility to reduce the list by hitting
> the link "Show result items", what do you think?


By this do you mean that all the results should show in the "Show result
items" when the search is empty? Thereby decreasing the number of result
items when an actual search is made.

Speaking of the list, that'd be great imho that the popups can be displayed
> while the list is active, so that the user can browse content via the list,
> wouldn't it?
>

I am not too sure where we could place them, since both the list and popups
take a large amount of space. The popups are build to support page data, so
they are also big. We could do it so the upper space belongs to the popup
and the lower space belongs to the list. Though it will cramp the space a
little imo. We could also increase the overall height of the map (which is
400px for now). WDYT?

 Restoring the full screen is working in most cases, that's cool, however
> if I run a search, then enter full screen, then refine the search, it seems
> that the full screen state is not preserved, is it?
>

That's one use case which leads to a loss of the previous map state and the
one before that is used. Any state before the facet click is not preserved
except the search widget and "Refine your search" area which is more or
less forced. As I said before, the problem is that we cannot pass the state
anywhere when a facet is clicked. I will look into cumulative onclick
events but I think that's not going to work.

I agree LeafletMap would be closer to what it does, but contrarily to the
> Macro Map, if I'm not mistaken, the page currently named Maps.Code.Leaflet
> does not create a JavaScript LeafletMap class, so technically it's more a
> LeafletUtils than a LeafletMap, isn't it?
>

You are right, it does not create any js class and since css is also inside
the same page the name should be LeafletUtils or LeafletService. I will
change it accordingly.

Also, I looked into it and the idea of custom class property for getting
the location is interesting indeed. I will see how I should prioritize it
and implement it then since we have other major features to look into.

I would also like to ask; what do you foresee as the basic elements of the
application? We have map configuration, map query, search and filter
widget, markers and popups so far. Do you have anything other than this in
mind that could be thought of as the basis of the application? I think we
should completely stabilize the basics by the end of this week so I can
work on other features like map paths, indoor maps and custom shapes.

Best,
Fawad

On Thu, Jul 11, 2019 at 1:50 PM Stéphane Laurière 
wrote:

> Hi Fawad, all,
>
> > I have fixed the errors you mentioned. It appears one of the variables
> had a bad name which was causing the error.
> The error does not show anymore indeed on my end, thanks.
>
> > On the UI side, possibly as a consequence, I can't see a list of
> results anymore, and the search widget state is not restored.
> >
> >
> > The list of results is just fine on my end, I am not sure what could be
> wrong.
>
> In the meantime, I figured out that the list shows up indeed when issuing
> a query in the search input, cool. However, as a user I would expect the
> list to be present also when the search input is empty, with the
> possibility to reduce the list by hitting the link "Show result items",
> what do you think? Speaking of the list, that'd be great imho that the
> popups can be displayed while the list is active, so that the user can
> browse content via the list, wouldn't it? This should not prevent us from
> release version 1.0 though.
>
> > About the map state, it does not work well with facets. Since facets
> have a separate code we cannot apply custom code when a facet is selected
> thus limiting our ability to pass the map state through js. I tried looking
> around for related js events but could not find one through which we can
> pass the map state after a facet is clicked. Do you have anything in mind
> for this?
>
> Actually, with the new version, the facet state is restored as I would
> expect it, sorry for the confusion. Restoring the full screen is working in
> most cases, that's cool, however if I run a search, then enter full screen,
> then refine the search, it seems that the full screen state is not
> preserved, is it?
>
> A note about demos: as far as I can see, the museum map demo does not
> showcase the "country" facet by default, don't you think that'd be worth
> adding it so that the user has a simple demo with facets working with
> custom fields?
>
> > I think the name "Maps.Code.Leaflet" might be misleading for
> potential developers: this could mean this page is providing Leaflet, while
> it does not. I would suggest to choose a name that is closer to what the
> JavaScript really provides, from a functional point of view, what do you
> think?
> >

Re: [xwiki-devs] Map Application - GSoC 19

2019-07-11 Thread Stéphane Laurière

Hi Fawad, all,


I have fixed the errors you mentioned. It appears one of the variables had a 
bad name which was causing the error.

The error does not show anymore indeed on my end, thanks.

On the UI side, possibly as a consequence, I can't see a list of results anymore, and the search widget state is not restored. 



The list of results is just fine on my end, I am not sure what could be wrong. 


In the meantime, I figured out that the list shows up indeed when issuing a query in the 
search input, cool. However, as a user I would expect the list to be present also when 
the search input is empty, with the possibility to reduce the list by hitting the link 
"Show result items", what do you think? Speaking of the list, that'd be great 
imho that the popups can be displayed while the list is active, so that the user can 
browse content via the list, wouldn't it? This should not prevent us from release version 
1.0 though.


About the map state, it does not work well with facets. Since facets have a 
separate code we cannot apply custom code when a facet is selected thus 
limiting our ability to pass the map state through js. I tried looking around 
for related js events but could not find one through which we can pass the map 
state after a facet is clicked. Do you have anything in mind for this?


Actually, with the new version, the facet state is restored as I would expect 
it, sorry for the confusion. Restoring the full screen is working in most 
cases, that's cool, however if I run a search, then enter full screen, then 
refine the search, it seems that the full screen state is not preserved, is it?

A note about demos: as far as I can see, the museum map demo does not showcase the 
"country" facet by default, don't you think that'd be worth adding it so that 
the user has a simple demo with facets working with custom fields?

I think the name "Maps.Code.Leaflet" might be misleading for potential developers: this could mean this page is providing Leaflet, while it does not. I would suggest to choose a name that is closer to what the JavaScript really provides, from a functional point of view, what do you think? 



I think its fine as is. Since it is placed inside the Code space, the 
developers will immediately be able to know that all the Leaflet related code 
resides inside it. But to be on the safe side, we can rename it to LeafletMap 
as in the macro-map.


I agree LeafletMap would be closer to what it does, but contrarily to the Macro 
Map, if I'm not mistaken, the page currently named Maps.Code.Leaflet does not 
create a JavaScript LeafletMap class, so technically it's more a LeafletUtils 
than a LeafletMap, isn't it? I acknowledge I'm picky with names... I noticed 
that leaflet-main requires leaflet-commons but I'm actually wondering how to 
make sure that leaflet-commons is known from RequireJS before leaflet-main gets 
loaded. I have not faced any error in practice, but I'm wondering if you 
tackled the issue already or if we need to figure it out.


Ludovic just suggested an improvement (for the next versions): let the user 
configure which existing field could be used in an existing class for 
retrieving geographical information, that could be interesting indeed, to be 
discussed. The calendar application works this way already as far as I 
understood: it lets the user define the date / time field to be used.


Thanks Ludovic for your suggestion. I would look into the calendar application 
to have a better understanding of this and let you know my thoughts.


Ok cool.

Cheers

Stéphane



Best,
Fawad


On Wed, Jul 10, 2019 at 2:55 PM Stéphane Laurière mailto:slauri...@xwiki.com>> wrote:

Hi Fawad,

Good to hear from you again, I hope things are fine on your end as well. 
Thanks for the update. Sorry for the delay, we were traveling yesterday. 
Releasing the application soon sounds good. I'm facing a few issues though, 
they may be related to an installation issue on my side, not sure. I grabbed 
the latest code and imported as a XAR over the existing pages in my 11.x wiki 
without error, and I notice the following (I'll consider posting some Jira 
issues if needed):

- catalina.out errors (not sure if they were present with previous version):

2019-07-10 11:34:30,349 
[http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&docVersion=5.1]
 WARN  c.x.x.w.s.JsExtension          - Error at line 203, column 85: missing 
variable name. Caused by: [      var index = 0, lat = 0, lng = 0, coordinates = [], 
shift = 0, result = 0, byte = null, latitude_change, longitude_change, factor = 
Math.pow(10, Number.isInteger(precision) ? precision : 5);]
2019-07-10 11:34:30,350 
[http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&docVersion=5.1]
 WARN  c.x.x.w.s.JsExtension          - Error at line 206, column 13: identifier is 
a reserved word. Caused [...]
2019-07-10 11:35:02,841 
[http://ako:8090/xwiki-11.2/wiki/abraca/jsx/M

Re: [xwiki-devs] Map Application - GSoC 19

2019-07-10 Thread Fawad Ali
I have fixed the errors you mentioned. It appears one of the variables had
a bad name which was causing the error.

On the UI side, possibly as a consequence, I can't see a list of results
> anymore, and the search widget state is not restored.


The list of results is just fine on my end, I am not sure what could be
wrong. About the map state, it does not work well with facets. Since facets
have a separate code we cannot apply custom code when a facet is selected
thus limiting our ability to pass the map state through js. I tried looking
around for related js events but could not find one through which we can
pass the map state after a facet is clicked. Do you have anything in mind
for this?

I think the name "Maps.Code.Leaflet" might be misleading for potential
> developers: this could mean this page is providing Leaflet, while it does
> not. I would suggest to choose a name that is closer to what the JavaScript
> really provides, from a functional point of view, what do you think?


I think its fine as is. Since it is placed inside the Code space, the
developers will immediately be able to know that all the Leaflet related
code resides inside it. But to be on the safe side, we can rename it to
LeafletMap as in the macro-map.

Ludovic just suggested an improvement (for the next versions): let the user
> configure which existing field could be used in an existing class for
> retrieving geographical information, that could be interesting indeed, to
> be discussed. The calendar application works this way already as far as I
> understood: it lets the user define the date / time field to be used.


Thanks Ludovic for your suggestion. I would look into the calendar
application to have a better understanding of this and let you know my
thoughts.

Best,
Fawad


On Wed, Jul 10, 2019 at 2:55 PM Stéphane Laurière 
wrote:

> Hi Fawad,
>
> Good to hear from you again, I hope things are fine on your end as well.
> Thanks for the update. Sorry for the delay, we were traveling yesterday.
> Releasing the application soon sounds good. I'm facing a few issues though,
> they may be related to an installation issue on my side, not sure. I
> grabbed the latest code and imported as a XAR over the existing pages in my
> 11.x wiki without error, and I notice the following (I'll consider posting
> some Jira issues if needed):
>
> - catalina.out errors (not sure if they were present with previous
> version):
>
> 2019-07-10 11:34:30,349 [
> http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&docVersion=5.1]
> WARN  c.x.x.w.s.JsExtension  - Error at line 203, column 85:
> missing variable name. Caused by: [  var index = 0, lat = 0, lng = 0,
> coordinates = [], shift = 0, result = 0, byte = null, latitude_change,
> longitude_change, factor = Math.pow(10, Number.isInteger(precision) ?
> precision : 5);]
> 2019-07-10 11:34:30,350 [
> http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&docVersion=5.1]
> WARN  c.x.x.w.s.JsExtension  - Error at line 206, column 13:
> identifier is a reserved word. Caused [...]
> 2019-07-10 11:35:02,841 [
> http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&docVersion=5.1]
> ERROR c.x.x.w.s.JsExtension  - Runtime error minimizing JSX object:
> Compilation produced 8 syntax errors.
> 2019-07-10 11:35:02,841 [
> http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&docVersion=5.1]
> WARN  c.x.x.w.s.JsExtension  - Failed to compress JS extension: null
>
> - On the UI side, possibly as a consequence, I can't see a list of results
> anymore, and the search widget state is not restored.
>
> - I notice there is no default radio button checked in the search form: I
> think either "location" or "item" should be checked, to let the user know
> what's the default (I'd say "item").
>
> - I think the name "Maps.Code.Leaflet" might be misleading for potential
> developers: this could mean this page is providing Leaflet, while it does
> not. I would suggest to choose a name that is closer to what the JavaScript
> really provides, from a functional point of view, what do you think?
>
> - Ludovic just suggested an improvement (for the next versions): let the
> user configure which existing field could be used in an existing class for
> retrieving geographical information, that could be interesting indeed, to
> be discussed. The calendar application works this way already as far as I
> understood: it lets the user define the date / time field to be used.
>
> Cheers
>
> Stéphane
>
>
> Fawad Ali:
> > Hi all,
> > Hope everyone is well.
> >
> > Please review the application developed so far. I have included a UI
> test and map states. I think we should release the application as soon as
> we can so that user reviews can be gathered.
> >
> > Best,
> > Fawad
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-07-10 Thread Stéphane Laurière

Hi Fawad,

Good to hear from you again, I hope things are fine on your end as well. Thanks 
for the update. Sorry for the delay, we were traveling yesterday. Releasing the 
application soon sounds good. I'm facing a few issues though, they may be 
related to an installation issue on my side, not sure. I grabbed the latest 
code and imported as a XAR over the existing pages in my 11.x wiki without 
error, and I notice the following (I'll consider posting some Jira issues if 
needed):

- catalina.out errors (not sure if they were present with previous version):

2019-07-10 11:34:30,349 
[http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&docVersion=5.1]
 WARN  c.x.x.w.s.JsExtension  - Error at line 203, column 85: missing 
variable name. Caused by: [  var index = 0, lat = 0, lng = 0, coordinates = [], 
shift = 0, result = 0, byte = null, latitude_change, longitude_change, factor = 
Math.pow(10, Number.isInteger(precision) ? precision : 5);]
2019-07-10 11:34:30,350 
[http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&docVersion=5.1]
 WARN  c.x.x.w.s.JsExtension  - Error at line 206, column 13: identifier is 
a reserved word. Caused [...]
2019-07-10 11:35:02,841 
[http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&docVersion=5.1]
 ERROR c.x.x.w.s.JsExtension  - Runtime error minimizing JSX object: 
Compilation produced 8 syntax errors.
2019-07-10 11:35:02,841 
[http://ako:8090/xwiki-11.2/wiki/abraca/jsx/Maps/Code/Leaflet?language=en&docVersion=5.1]
 WARN  c.x.x.w.s.JsExtension  - Failed to compress JS extension: null

- On the UI side, possibly as a consequence, I can't see a list of results 
anymore, and the search widget state is not restored.

- I notice there is no default radio button checked in the search form: I think either "location" 
or "item" should be checked, to let the user know what's the default (I'd say "item").

- I think the name "Maps.Code.Leaflet" might be misleading for potential 
developers: this could mean this page is providing Leaflet, while it does not. I would 
suggest to choose a name that is closer to what the JavaScript really provides, from a 
functional point of view, what do you think?

- Ludovic just suggested an improvement (for the next versions): let the user 
configure which existing field could be used in an existing class for 
retrieving geographical information, that could be interesting indeed, to be 
discussed. The calendar application works this way already as far as I 
understood: it lets the user define the date / time field to be used.

Cheers

Stéphane


Fawad Ali:

Hi all,
Hope everyone is well.

Please review the application developed so far. I have included a UI test and 
map states. I think we should release the application as soon as we can so that 
user reviews can be gathered.

Best,
Fawad




Re: [xwiki-devs] Map Application - GSoC 19

2019-07-10 Thread Fawad Ali
Hi all,
Hope everyone is well.

Please review the application developed so far. I have included a UI test
and map states. I think we should release the application as soon as we can
so that user reviews can be gathered.

Best,
Fawad

On Mon, Jul 1, 2019, 8:26 PM Fawad Ali  wrote:

> Hi everyone,
> Hope to find you well.
>
> Their flow is actually completely in line with what I have in mind as well
>> (except I may prefer personaly to have the facet above the result list
>> items, to be discussed...)
>>
>
> That would certainly be better in my opinion.
>
> I would expect the search button to be closer to the area where the widget
>> pops in, that is on the left side in our current setup, what do you think?
>
>
> It was that way in the previous commits. But the idea of this approach is
> to have the left side completely blank with no controls. What it helps in
> is to provide a dedicated space for both the popup and search widget. If we
> place the search control on the top left, our search control is hidden when
> either popup or the search widget is enabled. And if we place the search
> widget right beside the search control (to the right of it), it will take
> unnecessary space.
> One option is to have the close icon to the right of the search widget
> popup but it still doesn't fix the problem of search control hiding when
> the marker popup is opened.
>
> Indeed, that's an issue. Regarding facets, page Main.SolrSearch behaves
>> similarly as far as I understand, and manages to keep the facets in the
>> same state visually as how they were before launching the asychronous call,
>> doesn't it? So I was thinking we could use the same approach, or is there a
>> hidden complexity? As for the search input: the input itself can be
>> retrieved from the URL, so we should be able to restore it as well, don't
>> we? Can you clarify how separating in two distinct services may help? We
>> will need to consider the other states of the map that we want to represent
>> in the URL so that specific map states can be shared easily, we could add
>> the current selection to the URL's fragment, what do you think?
>>
>
> That's exactly what I eventually had in mind besides the JSON service. For
> the JSON service, we could have a common place for retrieving any kind of
> map data, like a REST API but that was the secondary approach.
> What we could do now is utilize the URL parameters. For now, I am thinking
> of having a multiple URL parameter that can contain different states of the
> map. For example, if we have both the fullscreen and search popup enabled,
> we could have the URL parameters "?mfullscreen=true&msearchw=true" where
> mfullscreen = map full screen and msearchw = map search widget. Other
> parameters like this can be added for different states. WDYT?
>
> We came up with a possible workaround with Anca, which consists in using
>> the Velocity "evaluate" macro in order to force the usage of the current
>> Velocity context (replace "scriptPage" by "facetDisplayer"):
>>
>>#set ($script =
>> $!scriptPage.content.replaceAll('\{\{/{0,2}velocity\}\}', ''))
>>#evaluate($script)
>>
>> I gave a try to this solution and it worked fine on my end on the example
>> mentioned on the forum (not tested yet with the facetDisplayers). We need
>> to investigate further though:
>
>
> That's great, I will check it out as soon as I am able.
>
> Best,
> Fawad
>
> On Fri, Jun 28, 2019 at 3:02 PM Stéphane Laurière 
> wrote:
>
>> Hi Fawad, Caty, all,
>>
>> Apologies for the delay. Meantime, I confirm that Caty and I filled in
>> the 1st GSoC evaluation for the period, with very positive appreciations.
>> Thumbs up Fawad, and good luck with the next steps.
>>
>> Fawad Ali:
>> > Hi Caty, Stephane and all,
>> > Hope you are all well.
>> >
>> > Stephane, your suggestions regarding the filter and search are great
>> but I
>> > feel the flow of our application is more inclined towards what Ecaterina
>> > proposes. I will try implementing the mockups.
>>
>> That's very helpful to have mockups indeed to align the visions. Their
>> flow is actually completely in line with what I have in mind as well
>> (except I may prefer personaly to have the facet above the result list
>> items, to be discussed...), and I see in the latest version (of today) that
>> you made good progress toward that direction. The fullscreen widget is cool
>> and works fine. I would expect the search button to be closer to the area
>> where the widget pops in, that is on the left side in our current setup,
>> what do you think?
>>
>> > One problem we have though is that both our facets and search lead to a
>> > reload of all the content inside the page asynchronously which means any
>> > changes made through frontend are lost (like active dropdowns etc.). We
>> > need to fix this.
>> > Do you think I will have to redo both as a separate JSON service? I can
>> > think of a way for search but facets are a little confusing.
>>
>> Indeed, that's an issue. Regarding face

Re: [xwiki-devs] Map Application - GSoC 19

2019-07-01 Thread Fawad Ali
Hi everyone,
Hope to find you well.

Their flow is actually completely in line with what I have in mind as well
> (except I may prefer personaly to have the facet above the result list
> items, to be discussed...)
>

That would certainly be better in my opinion.

I would expect the search button to be closer to the area where the widget
> pops in, that is on the left side in our current setup, what do you think?


It was that way in the previous commits. But the idea of this approach is
to have the left side completely blank with no controls. What it helps in
is to provide a dedicated space for both the popup and search widget. If we
place the search control on the top left, our search control is hidden when
either popup or the search widget is enabled. And if we place the search
widget right beside the search control (to the right of it), it will take
unnecessary space.
One option is to have the close icon to the right of the search widget
popup but it still doesn't fix the problem of search control hiding when
the marker popup is opened.

Indeed, that's an issue. Regarding facets, page Main.SolrSearch behaves
> similarly as far as I understand, and manages to keep the facets in the
> same state visually as how they were before launching the asychronous call,
> doesn't it? So I was thinking we could use the same approach, or is there a
> hidden complexity? As for the search input: the input itself can be
> retrieved from the URL, so we should be able to restore it as well, don't
> we? Can you clarify how separating in two distinct services may help? We
> will need to consider the other states of the map that we want to represent
> in the URL so that specific map states can be shared easily, we could add
> the current selection to the URL's fragment, what do you think?
>

That's exactly what I eventually had in mind besides the JSON service. For
the JSON service, we could have a common place for retrieving any kind of
map data, like a REST API but that was the secondary approach.
What we could do now is utilize the URL parameters. For now, I am thinking
of having a multiple URL parameter that can contain different states of the
map. For example, if we have both the fullscreen and search popup enabled,
we could have the URL parameters "?mfullscreen=true&msearchw=true" where
mfullscreen = map full screen and msearchw = map search widget. Other
parameters like this can be added for different states. WDYT?

We came up with a possible workaround with Anca, which consists in using
> the Velocity "evaluate" macro in order to force the usage of the current
> Velocity context (replace "scriptPage" by "facetDisplayer"):
>
>#set ($script =
> $!scriptPage.content.replaceAll('\{\{/{0,2}velocity\}\}', ''))
>#evaluate($script)
>
> I gave a try to this solution and it worked fine on my end on the example
> mentioned on the forum (not tested yet with the facetDisplayers). We need
> to investigate further though:


That's great, I will check it out as soon as I am able.

Best,
Fawad

On Fri, Jun 28, 2019 at 3:02 PM Stéphane Laurière 
wrote:

> Hi Fawad, Caty, all,
>
> Apologies for the delay. Meantime, I confirm that Caty and I filled in the
> 1st GSoC evaluation for the period, with very positive appreciations.
> Thumbs up Fawad, and good luck with the next steps.
>
> Fawad Ali:
> > Hi Caty, Stephane and all,
> > Hope you are all well.
> >
> > Stephane, your suggestions regarding the filter and search are great but
> I
> > feel the flow of our application is more inclined towards what Ecaterina
> > proposes. I will try implementing the mockups.
>
> That's very helpful to have mockups indeed to align the visions. Their
> flow is actually completely in line with what I have in mind as well
> (except I may prefer personaly to have the facet above the result list
> items, to be discussed...), and I see in the latest version (of today) that
> you made good progress toward that direction. The fullscreen widget is cool
> and works fine. I would expect the search button to be closer to the area
> where the widget pops in, that is on the left side in our current setup,
> what do you think?
>
> > One problem we have though is that both our facets and search lead to a
> > reload of all the content inside the page asynchronously which means any
> > changes made through frontend are lost (like active dropdowns etc.). We
> > need to fix this.
> > Do you think I will have to redo both as a separate JSON service? I can
> > think of a way for search but facets are a little confusing.
>
> Indeed, that's an issue. Regarding facets, page Main.SolrSearch behaves
> similarly as far as I understand, and manages to keep the facets in the
> same state visually as how they were before launching the asychronous call,
> doesn't it? So I was thinking we could use the same approach, or is there a
> hidden complexity? As for the search input: the input itself can be
> retrieved from the URL, so we should be able to restore it as well, don't
> we

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-28 Thread Stéphane Laurière

Hi Fawad, Caty, all,

Apologies for the delay. Meantime, I confirm that Caty and I filled in the 1st 
GSoC evaluation for the period, with very positive appreciations. Thumbs up 
Fawad, and good luck with the next steps.

Fawad Ali:

Hi Caty, Stephane and all,
Hope you are all well.

Stephane, your suggestions regarding the filter and search are great but I
feel the flow of our application is more inclined towards what Ecaterina
proposes. I will try implementing the mockups.


That's very helpful to have mockups indeed to align the visions. Their flow is 
actually completely in line with what I have in mind as well (except I may 
prefer personaly to have the facet above the result list items, to be 
discussed...), and I see in the latest version (of today) that you made good 
progress toward that direction. The fullscreen widget is cool and works fine. I 
would expect the search button to be closer to the area where the widget pops 
in, that is on the left side in our current setup, what do you think?
 

One problem we have though is that both our facets and search lead to a
reload of all the content inside the page asynchronously which means any
changes made through frontend are lost (like active dropdowns etc.). We
need to fix this.
Do you think I will have to redo both as a separate JSON service? I can
think of a way for search but facets are a little confusing.


Indeed, that's an issue. Regarding facets, page Main.SolrSearch behaves 
similarly as far as I understand, and manages to keep the facets in the same 
state visually as how they were before launching the asychronous call, doesn't 
it? So I was thinking we could use the same approach, or is there a hidden 
complexity? As for the search input: the input itself can be retrieved from the 
URL, so we should be able to restore it as well, don't we? Can you clarify how 
separating in two distinct services may help? We will need to consider the 
other states of the map that we want to represent in the URL so that specific 
map states can be shared easily, we could add the current selection to the 
URL's fragment, what do you think?


Also, we still haven't found a way to fix the $facetDisplayer problem.
(
https://github.com/xwiki-contrib/application-interactive-maps/blob/master/application-interactive-maps-ui/src/main/resources/Maps/Code/CommonMacros.xml#L221
)
How do you think we should proceed with this?


We came up with a possible workaround with Anca, which consists in using the Velocity "evaluate" 
macro in order to force the usage of the current Velocity context (replace "scriptPage" by 
"facetDisplayer"):

  #set ($script = $!scriptPage.content.replaceAll('\{\{/{0,2}velocity\}\}', ''))
  #evaluate($script)

I gave a try to this solution and it worked fine on my end on the example 
mentioned on the forum (not tested yet with the facetDisplayers). We need to 
investigate further though:

  https://forum.xwiki.org/t/including-code-dynamically-from-a-sheet/5085/3


Regarding the tests, I will start preparing them as soon as I am done with
implementing the new search and facets UI.
However, I do have confusion as to what kind of functional tests I should
perform. I am listing some that I have in mind.
- Map is created properly
- Facets are working
- Search returns expected results
- Popup works fine
And other similar functions.
I will need some guidance as to how I should take a start since I have not
actually made tests for real applications.
After analyzing some of the tests that Vincent and Ecaterina have shared, I
think we have to perform user actions programmatically and check to see if
the output we are receiving is correct. Is that right?


I need to look more into the testing framework including the pointers and 
examples provided by Vincent and Caty, and to go through the steps you mention 
in your mail dated from 24/6, I'll get back to you on this.

Cheers

Stéphane

 

Thanks,
Fawad




Re: [xwiki-devs] Map Application - GSoC 19

2019-06-24 Thread Fawad Ali
Hi Stephane, Caty and all,
Hope you are doing great.

I have deployed a test case for map creation. I would like you to have a
look at it. It works fine upto the commented code.
There is one problem I am facing which is, during the last part, the marker
does not load up. If I restart the same XWiki instance from the target
folder and go to the page created during the test, the marker appears
perfectly. I am not sure what's wrong.
And one time I tried the test, the marker did appear during the test and
then I ran the test again without changing anything but the marker did not
show up. I am using wait but it does not seem to be the problem with
javascript. It appears that the map is not getting the rendered data from
velocity and again I am not sure why when it works perfectly if I view the
same page outside of test.

I would also like your review on the new search and fullscreen controls.

Thanks,
Fawad


On Thu, Jun 20, 2019 at 2:41 PM Ecaterina Moraru (Valica) 
wrote:

>
>
> On Wed, Jun 19, 2019 at 11:30 PM Fawad Ali 
> wrote:
>
>> Hi Caty, Stephane and all,
>> Hope you are all well.
>>
>> Stephane, your suggestions regarding the filter and search are great but
>> I feel the flow of our application is more inclined towards what Ecaterina
>> proposes. I will try implementing the mockups.
>>
>> One problem we have though is that both our facets and search lead to a
>> reload of all the content inside the page asynchronously which means any
>> changes made through frontend are lost (like active dropdowns etc.). We
>> need to fix this.
>> Do you think I will have to redo both as a separate JSON service? I can
>> think of a way for search but facets are a little confusing.
>> Also, we still haven't found a way to fix the $facetDisplayer problem.
>> (
>> https://github.com/xwiki-contrib/application-interactive-maps/blob/master/application-interactive-maps-ui/src/main/resources/Maps/Code/CommonMacros.xml#L221
>> )
>> How do you think we should proceed with this?
>>
>> Regarding the tests, I will start preparing them as soon as I am done
>> with implementing the new search and facets UI.
>> However, I do have confusion as to what kind of functional tests I should
>> perform. I am listing some that I have in mind.
>> - Map is created properly
>> - Facets are working
>> - Search returns expected results
>> - Popup works fine
>> And other similar functions.
>> I will need some guidance as to how I should take a start since I have
>> not actually made tests for real applications.
>> After analyzing some of the tests that Vincent and Ecaterina have shared,
>> I think we have to perform user actions programmatically and check to see
>> if the output we are receiving is correct. Is that right?
>>
>
> You can read more details about the tests in the documentation
> https://dev.xwiki.org/xwiki/bin/view/Community/Testing/#HSelenium2-basedFramework
> You should first start by making the setup: download the Firefox 32 (I
> know is an older version, but is the one used by our agents)
> https://dev.xwiki.org/xwiki/bin/view/Community/Testing/#HBrowserversion
> and try to run the existing tests for the applications. After you see them
> in actions it will be much easier to understand a flow of a test and the
> page objects needed. There is also this page
> https://dev.xwiki.org/xwiki/bin/view/Onboarding/TrackTests/ with some
> links. We have more tests in platform and in the main modules (if you will
> need more examples) but start simple.
>
> Having automated tests makes sure the functionality still works after
> changes and reduced the need for manual testing. If you haven't written
> tests before I'm sure you will find quite fun to see the test run live :)
>
> Thanks,
> Caty
>
>
>>
>> Thanks,
>> Fawad
>>
>>
>>
>> On Wed, Jun 19, 2019 at 9:36 PM Ecaterina Moraru (Valica) <
>> vali...@gmail.com> wrote:
>>
>>> Regarding tests, there are some contrib apps with tests:
>>>
>>> https://github.com/xwiki-contrib/application-forum/tree/master/application-forum-test
>>>
>>> https://github.com/xwiki-contrib/application-tour/tree/master/application-tour-test
>>>
>>> Good luck with your exams,
>>> Caty
>>>
>>> On Wed, Jun 19, 2019 at 7:32 PM Ecaterina Moraru (Valica) <
>>> vali...@gmail.com> wrote:
>>>
 Hi,

 How about:
 * Maximizing the app area by removing the right panels;
 * Have the map take all the available space
 https://up1.xwikisas.com/#CnVVQ4JOC1ZPzAHSSbyAaQ
   * Controls: Search, Full Screen, Zoom

 * If the user want to search
 https://up1.xwikisas.com/#UYDXywBeRfcwLX6d06NVtA
   * expand the search control: allow input and facets using an overlay

 * If the user has results
 https://up1.xwikisas.com/#LoeVbE9idboPvoG2w3dE0Q
   * display using overlay. center map on result click
   * allow further filtering through facets

 These are just ideas, maybe there are other solutions.
 Thanks,
 Caty


 On Wed, Jun 19, 2019 at 6:59 PM Stéphane La

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-20 Thread Ecaterina Moraru (Valica)
On Wed, Jun 19, 2019 at 11:30 PM Fawad Ali  wrote:

> Hi Caty, Stephane and all,
> Hope you are all well.
>
> Stephane, your suggestions regarding the filter and search are great but I
> feel the flow of our application is more inclined towards what Ecaterina
> proposes. I will try implementing the mockups.
>
> One problem we have though is that both our facets and search lead to a
> reload of all the content inside the page asynchronously which means any
> changes made through frontend are lost (like active dropdowns etc.). We
> need to fix this.
> Do you think I will have to redo both as a separate JSON service? I can
> think of a way for search but facets are a little confusing.
> Also, we still haven't found a way to fix the $facetDisplayer problem.
> (
> https://github.com/xwiki-contrib/application-interactive-maps/blob/master/application-interactive-maps-ui/src/main/resources/Maps/Code/CommonMacros.xml#L221
> )
> How do you think we should proceed with this?
>
> Regarding the tests, I will start preparing them as soon as I am done with
> implementing the new search and facets UI.
> However, I do have confusion as to what kind of functional tests I should
> perform. I am listing some that I have in mind.
> - Map is created properly
> - Facets are working
> - Search returns expected results
> - Popup works fine
> And other similar functions.
> I will need some guidance as to how I should take a start since I have not
> actually made tests for real applications.
> After analyzing some of the tests that Vincent and Ecaterina have shared,
> I think we have to perform user actions programmatically and check to see
> if the output we are receiving is correct. Is that right?
>

You can read more details about the tests in the documentation
https://dev.xwiki.org/xwiki/bin/view/Community/Testing/#HSelenium2-basedFramework
You should first start by making the setup: download the Firefox 32 (I know
is an older version, but is the one used by our agents)
https://dev.xwiki.org/xwiki/bin/view/Community/Testing/#HBrowserversion and
try to run the existing tests for the applications. After you see them in
actions it will be much easier to understand a flow of a test and the page
objects needed. There is also this page
https://dev.xwiki.org/xwiki/bin/view/Onboarding/TrackTests/ with some
links. We have more tests in platform and in the main modules (if you will
need more examples) but start simple.

Having automated tests makes sure the functionality still works after
changes and reduced the need for manual testing. If you haven't written
tests before I'm sure you will find quite fun to see the test run live :)

Thanks,
Caty


>
> Thanks,
> Fawad
>
>
>
> On Wed, Jun 19, 2019 at 9:36 PM Ecaterina Moraru (Valica) <
> vali...@gmail.com> wrote:
>
>> Regarding tests, there are some contrib apps with tests:
>>
>> https://github.com/xwiki-contrib/application-forum/tree/master/application-forum-test
>>
>> https://github.com/xwiki-contrib/application-tour/tree/master/application-tour-test
>>
>> Good luck with your exams,
>> Caty
>>
>> On Wed, Jun 19, 2019 at 7:32 PM Ecaterina Moraru (Valica) <
>> vali...@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> How about:
>>> * Maximizing the app area by removing the right panels;
>>> * Have the map take all the available space
>>> https://up1.xwikisas.com/#CnVVQ4JOC1ZPzAHSSbyAaQ
>>>   * Controls: Search, Full Screen, Zoom
>>>
>>> * If the user want to search
>>> https://up1.xwikisas.com/#UYDXywBeRfcwLX6d06NVtA
>>>   * expand the search control: allow input and facets using an overlay
>>>
>>> * If the user has results
>>> https://up1.xwikisas.com/#LoeVbE9idboPvoG2w3dE0Q
>>>   * display using overlay. center map on result click
>>>   * allow further filtering through facets
>>>
>>> These are just ideas, maybe there are other solutions.
>>> Thanks,
>>> Caty
>>>
>>>
>>> On Wed, Jun 19, 2019 at 6:59 PM Stéphane Laurière 
>>> wrote:
>>>
 Hi Fawad, hi all,

 > Hi all,
 >
 > I just gave a try to the latest code, well done with the Solr
 queries and the search integration in the user interface, that's cool!
 >
 > Thanks Stephane. :)
 >
 > Imho the most convenient UX is the following for these widgets,
 something similar to this map:
 >
 > http://carte.preference-commerce.fr/cci-fr/
 >
 > That is:
 >
 > - The facets can get activated from a button. When they get
 activated, they show up in an overlay panel on top of the map, without
 hiding the list.
 > - The list gets displayed under the search input, in an overlay
 as well, and can be completely hidden on request
 >
 >
 > Just to clarify things, the facets here refer to the "Refine your
 search" area, the search input refers to the "Search in map" text input and
 the list refers to the map item search results. Is that right?

 Yes indeed,

 > If so, I believe, given the nature of XWiki's design with widgets to
>>

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-19 Thread Fawad Ali
Hi Caty, Stephane and all,
Hope you are all well.

Stephane, your suggestions regarding the filter and search are great but I
feel the flow of our application is more inclined towards what Ecaterina
proposes. I will try implementing the mockups.

One problem we have though is that both our facets and search lead to a
reload of all the content inside the page asynchronously which means any
changes made through frontend are lost (like active dropdowns etc.). We
need to fix this.
Do you think I will have to redo both as a separate JSON service? I can
think of a way for search but facets are a little confusing.
Also, we still haven't found a way to fix the $facetDisplayer problem.
(
https://github.com/xwiki-contrib/application-interactive-maps/blob/master/application-interactive-maps-ui/src/main/resources/Maps/Code/CommonMacros.xml#L221
)
How do you think we should proceed with this?

Regarding the tests, I will start preparing them as soon as I am done with
implementing the new search and facets UI.
However, I do have confusion as to what kind of functional tests I should
perform. I am listing some that I have in mind.
- Map is created properly
- Facets are working
- Search returns expected results
- Popup works fine
And other similar functions.
I will need some guidance as to how I should take a start since I have not
actually made tests for real applications.
After analyzing some of the tests that Vincent and Ecaterina have shared, I
think we have to perform user actions programmatically and check to see if
the output we are receiving is correct. Is that right?

Thanks,
Fawad



On Wed, Jun 19, 2019 at 9:36 PM Ecaterina Moraru (Valica) 
wrote:

> Regarding tests, there are some contrib apps with tests:
>
> https://github.com/xwiki-contrib/application-forum/tree/master/application-forum-test
>
> https://github.com/xwiki-contrib/application-tour/tree/master/application-tour-test
>
> Good luck with your exams,
> Caty
>
> On Wed, Jun 19, 2019 at 7:32 PM Ecaterina Moraru (Valica) <
> vali...@gmail.com> wrote:
>
>> Hi,
>>
>> How about:
>> * Maximizing the app area by removing the right panels;
>> * Have the map take all the available space
>> https://up1.xwikisas.com/#CnVVQ4JOC1ZPzAHSSbyAaQ
>>   * Controls: Search, Full Screen, Zoom
>>
>> * If the user want to search
>> https://up1.xwikisas.com/#UYDXywBeRfcwLX6d06NVtA
>>   * expand the search control: allow input and facets using an overlay
>>
>> * If the user has results
>> https://up1.xwikisas.com/#LoeVbE9idboPvoG2w3dE0Q
>>   * display using overlay. center map on result click
>>   * allow further filtering through facets
>>
>> These are just ideas, maybe there are other solutions.
>> Thanks,
>> Caty
>>
>>
>> On Wed, Jun 19, 2019 at 6:59 PM Stéphane Laurière 
>> wrote:
>>
>>> Hi Fawad, hi all,
>>>
>>> > Hi all,
>>> >
>>> > I just gave a try to the latest code, well done with the Solr
>>> queries and the search integration in the user interface, that's cool!
>>> >
>>> > Thanks Stephane. :)
>>> >
>>> > Imho the most convenient UX is the following for these widgets,
>>> something similar to this map:
>>> >
>>> > http://carte.preference-commerce.fr/cci-fr/
>>> >
>>> > That is:
>>> >
>>> > - The facets can get activated from a button. When they get
>>> activated, they show up in an overlay panel on top of the map, without
>>> hiding the list.
>>> > - The list gets displayed under the search input, in an overlay as
>>> well, and can be completely hidden on request
>>> >
>>> >
>>> > Just to clarify things, the facets here refer to the "Refine your
>>> search" area, the search input refers to the "Search in map" text input and
>>> the list refers to the map item search results. Is that right?
>>>
>>> Yes indeed,
>>>
>>> > If so, I believe, given the nature of XWiki's design with widgets to
>>> both the right and left (for the default flavor), the space is a little
>>> cramped for overlaying anything on the map. For the implementation of full
>>> screen maps, we can overlay search and facets but for the normal view, the
>>> map will become very small.
>>> >
>>> > Here is a mockup I prepared based on my understanding of your
>>> suggestions: https://up1.xwikisas.com/#SB7B5mLNnfnUVAogWTLarw
>>> > Let me know what you think?
>>>
>>> I think it's an efficient way to layout the widgets indeed. I agree the
>>> map may look cramped in case there are panels on the left and on the right,
>>> but the user typically would have an option to hide the results, ideally.
>>> There's one change I would suggest, that would be to layout the filters
>>> either as an overlay or as a replacement of the list, and to move the
>>> filter button closer to the search input. Regarding the filter position:
>>> the Airbnb search illustrated below behaves quite nicely imho (when you hit
>>> "More filters", you get a new panel on top with all the filters), what do
>>> you think?
>>>
>>>https://up1.xwikisas.com/#zNABtIwH-Z-hSSUgFx-y4Q
>>>
>>> As for the information associate

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-19 Thread Ecaterina Moraru (Valica)
Regarding tests, there are some contrib apps with tests:
https://github.com/xwiki-contrib/application-forum/tree/master/application-forum-test
https://github.com/xwiki-contrib/application-tour/tree/master/application-tour-test

Good luck with your exams,
Caty

On Wed, Jun 19, 2019 at 7:32 PM Ecaterina Moraru (Valica) 
wrote:

> Hi,
>
> How about:
> * Maximizing the app area by removing the right panels;
> * Have the map take all the available space
> https://up1.xwikisas.com/#CnVVQ4JOC1ZPzAHSSbyAaQ
>   * Controls: Search, Full Screen, Zoom
>
> * If the user want to search
> https://up1.xwikisas.com/#UYDXywBeRfcwLX6d06NVtA
>   * expand the search control: allow input and facets using an overlay
>
> * If the user has results https://up1.xwikisas.com/#LoeVbE9idboPvoG2w3dE0Q
>   * display using overlay. center map on result click
>   * allow further filtering through facets
>
> These are just ideas, maybe there are other solutions.
> Thanks,
> Caty
>
>
> On Wed, Jun 19, 2019 at 6:59 PM Stéphane Laurière 
> wrote:
>
>> Hi Fawad, hi all,
>>
>> > Hi all,
>> >
>> > I just gave a try to the latest code, well done with the Solr
>> queries and the search integration in the user interface, that's cool!
>> >
>> > Thanks Stephane. :)
>> >
>> > Imho the most convenient UX is the following for these widgets,
>> something similar to this map:
>> >
>> > http://carte.preference-commerce.fr/cci-fr/
>> >
>> > That is:
>> >
>> > - The facets can get activated from a button. When they get
>> activated, they show up in an overlay panel on top of the map, without
>> hiding the list.
>> > - The list gets displayed under the search input, in an overlay as
>> well, and can be completely hidden on request
>> >
>> >
>> > Just to clarify things, the facets here refer to the "Refine your
>> search" area, the search input refers to the "Search in map" text input and
>> the list refers to the map item search results. Is that right?
>>
>> Yes indeed,
>>
>> > If so, I believe, given the nature of XWiki's design with widgets to
>> both the right and left (for the default flavor), the space is a little
>> cramped for overlaying anything on the map. For the implementation of full
>> screen maps, we can overlay search and facets but for the normal view, the
>> map will become very small.
>> >
>> > Here is a mockup I prepared based on my understanding of your
>> suggestions: https://up1.xwikisas.com/#SB7B5mLNnfnUVAogWTLarw
>> > Let me know what you think?
>>
>> I think it's an efficient way to layout the widgets indeed. I agree the
>> map may look cramped in case there are panels on the left and on the right,
>> but the user typically would have an option to hide the results, ideally.
>> There's one change I would suggest, that would be to layout the filters
>> either as an overlay or as a replacement of the list, and to move the
>> filter button closer to the search input. Regarding the filter position:
>> the Airbnb search illustrated below behaves quite nicely imho (when you hit
>> "More filters", you get a new panel on top with all the filters), what do
>> you think?
>>
>>https://up1.xwikisas.com/#zNABtIwH-Z-hSSUgFx-y4Q
>>
>> As for the information associated with each point or area, we have
>> several options: either place it in popups on top of the map like Airbnb,
>> or have it in the search result area, like what Google Maps proposes, or
>> display it in a lateral panel like GoGoCarto. I would opt for popups by
>> default, and if possible later on, leave the option to display it in the
>> search area in case of large content, what do you think? Ideally, the panel
>> for displaying this information would be a template that could be easily
>> styled and customized for each map?
>>
>> > I have also come up with an idea to generalize the museum maps import
>> and export you created, Stephane. We could have a standard form of wikidata
>> query with some extra custom parameters for each location like the
>> MuseumClass in the Museums' case. These extra parameter will be checked in
>> JSON and classes will be created if required so that objects can be
>> associated to each map item and then later facets can be used based upon
>> these newly created classes.
>> > WDYT?
>>
>> I think that'd be a nice feature generally speaking to ease the import of
>> Wikidata into XWiki indeed, I have a side project on which I'm considering
>> such developments as well, not sure yet about the outcome. If you feel like
>> it will be useful for generating more demo maps, I'd say that'd be good
>> indeed, but with the caveat of not digging too much in that direction for
>> not hampering the map development of course.
>>
>> > Also, due to unprecedented circumstances within college, my exams have
>> been delayed for this week and will start from next week. So I will be
>> working this whole week on the project as opposed to what I told earlier.
>>
>> Ok, thank you for letting us know.
>>
>> I'd say at this stage that'd be great to keep prog

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-19 Thread Ecaterina Moraru (Valica)
Hi,

How about:
* Maximizing the app area by removing the right panels;
* Have the map take all the available space
https://up1.xwikisas.com/#CnVVQ4JOC1ZPzAHSSbyAaQ
  * Controls: Search, Full Screen, Zoom

* If the user want to search
https://up1.xwikisas.com/#UYDXywBeRfcwLX6d06NVtA
  * expand the search control: allow input and facets using an overlay

* If the user has results https://up1.xwikisas.com/#LoeVbE9idboPvoG2w3dE0Q
  * display using overlay. center map on result click
  * allow further filtering through facets

These are just ideas, maybe there are other solutions.
Thanks,
Caty


On Wed, Jun 19, 2019 at 6:59 PM Stéphane Laurière 
wrote:

> Hi Fawad, hi all,
>
> > Hi all,
> >
> > I just gave a try to the latest code, well done with the Solr
> queries and the search integration in the user interface, that's cool!
> >
> > Thanks Stephane. :)
> >
> > Imho the most convenient UX is the following for these widgets,
> something similar to this map:
> >
> > http://carte.preference-commerce.fr/cci-fr/
> >
> > That is:
> >
> > - The facets can get activated from a button. When they get
> activated, they show up in an overlay panel on top of the map, without
> hiding the list.
> > - The list gets displayed under the search input, in an overlay as
> well, and can be completely hidden on request
> >
> >
> > Just to clarify things, the facets here refer to the "Refine your
> search" area, the search input refers to the "Search in map" text input and
> the list refers to the map item search results. Is that right?
>
> Yes indeed,
>
> > If so, I believe, given the nature of XWiki's design with widgets to
> both the right and left (for the default flavor), the space is a little
> cramped for overlaying anything on the map. For the implementation of full
> screen maps, we can overlay search and facets but for the normal view, the
> map will become very small.
> >
> > Here is a mockup I prepared based on my understanding of your
> suggestions: https://up1.xwikisas.com/#SB7B5mLNnfnUVAogWTLarw
> > Let me know what you think?
>
> I think it's an efficient way to layout the widgets indeed. I agree the
> map may look cramped in case there are panels on the left and on the right,
> but the user typically would have an option to hide the results, ideally.
> There's one change I would suggest, that would be to layout the filters
> either as an overlay or as a replacement of the list, and to move the
> filter button closer to the search input. Regarding the filter position:
> the Airbnb search illustrated below behaves quite nicely imho (when you hit
> "More filters", you get a new panel on top with all the filters), what do
> you think?
>
>https://up1.xwikisas.com/#zNABtIwH-Z-hSSUgFx-y4Q
>
> As for the information associated with each point or area, we have several
> options: either place it in popups on top of the map like Airbnb, or have
> it in the search result area, like what Google Maps proposes, or display it
> in a lateral panel like GoGoCarto. I would opt for popups by default, and
> if possible later on, leave the option to display it in the search area in
> case of large content, what do you think? Ideally, the panel for displaying
> this information would be a template that could be easily styled and
> customized for each map?
>
> > I have also come up with an idea to generalize the museum maps import
> and export you created, Stephane. We could have a standard form of wikidata
> query with some extra custom parameters for each location like the
> MuseumClass in the Museums' case. These extra parameter will be checked in
> JSON and classes will be created if required so that objects can be
> associated to each map item and then later facets can be used based upon
> these newly created classes.
> > WDYT?
>
> I think that'd be a nice feature generally speaking to ease the import of
> Wikidata into XWiki indeed, I have a side project on which I'm considering
> such developments as well, not sure yet about the outcome. If you feel like
> it will be useful for generating more demo maps, I'd say that'd be good
> indeed, but with the caveat of not digging too much in that direction for
> not hampering the map development of course.
>
> > Also, due to unprecedented circumstances within college, my exams have
> been delayed for this week and will start from next week. So I will be
> working this whole week on the project as opposed to what I told earlier.
>
> Ok, thank you for letting us know.
>
> I'd say at this stage that'd be great to keep progressing on functional
> testing automation and to finalize and release 1.0, I guess we're in tune
> but, as you did since the beginning, don't hesitate to raise questions
> about the priorities and the next steps of course.
>
> Wishing you good work days ahead,
>
> Cheers
>
> Stéphane
>
>
> > Best,
> > Fawad
> >
> >
> > On Mon, Jun 17, 2019 at 11:04 PM Stéphane Laurière  > wrote:
> >
> > Hi Fawad, Caty, all,
> >
> > 

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-19 Thread Stéphane Laurière

Hi Fawad, hi all,


Hi all,

I just gave a try to the latest code, well done with the Solr queries and the search integration in the user interface, that's cool! 


Thanks Stephane. :)

Imho the most convenient UX is the following for these widgets, something 
similar to this map:

http://carte.preference-commerce.fr/cci-fr/

That is:

- The facets can get activated from a button. When they get activated, they 
show up in an overlay panel on top of the map, without hiding the list.
- The list gets displayed under the search input, in an overlay as well, and can be completely hidden on request 



Just to clarify things, the facets here refer to the "Refine your search" area, the 
search input refers to the "Search in map" text input and the list refers to the map item 
search results. Is that right?


Yes indeed,


If so, I believe, given the nature of XWiki's design with widgets to both the 
right and left (for the default flavor), the space is a little cramped for 
overlaying anything on the map. For the implementation of full screen maps, we 
can overlay search and facets but for the normal view, the map will become very 
small.

Here is a mockup I prepared based on my understanding of your suggestions: 
https://up1.xwikisas.com/#SB7B5mLNnfnUVAogWTLarw
Let me know what you think?


I think it's an efficient way to layout the widgets indeed. I agree the map may look 
cramped in case there are panels on the left and on the right, but the user typically 
would have an option to hide the results, ideally. There's one change I would suggest, 
that would be to layout the filters either as an overlay or as a replacement of the list, 
and to move the filter button closer to the search input. Regarding the filter position: 
the Airbnb search illustrated below behaves quite nicely imho (when you hit "More 
filters", you get a new panel on top with all the filters), what do you think?

  https://up1.xwikisas.com/#zNABtIwH-Z-hSSUgFx-y4Q

As for the information associated with each point or area, we have several 
options: either place it in popups on top of the map like Airbnb, or have it in 
the search result area, like what Google Maps proposes, or display it in a 
lateral panel like GoGoCarto. I would opt for popups by default, and if 
possible later on, leave the option to display it in the search area in case of 
large content, what do you think? Ideally, the panel for displaying this 
information would be a template that could be easily styled and customized for 
each map?


I have also come up with an idea to generalize the museum maps import and 
export you created, Stephane. We could have a standard form of wikidata query 
with some extra custom parameters for each location like the MuseumClass in the 
Museums' case. These extra parameter will be checked in JSON and classes will 
be created if required so that objects can be associated to each map item and 
then later facets can be used based upon these newly created classes.
WDYT?


I think that'd be a nice feature generally speaking to ease the import of 
Wikidata into XWiki indeed, I have a side project on which I'm considering such 
developments as well, not sure yet about the outcome. If you feel like it will 
be useful for generating more demo maps, I'd say that'd be good indeed, but 
with the caveat of not digging too much in that direction for not hampering the 
map development of course.


Also, due to unprecedented circumstances within college, my exams have been 
delayed for this week and will start from next week. So I will be working this 
whole week on the project as opposed to what I told earlier.


Ok, thank you for letting us know.

I'd say at this stage that'd be great to keep progressing on functional testing 
automation and to finalize and release 1.0, I guess we're in tune but, as you 
did since the beginning, don't hesitate to raise questions about the priorities 
and the next steps of course.

Wishing you good work days ahead,

Cheers

Stéphane



Best,
Fawad


On Mon, Jun 17, 2019 at 11:04 PM Stéphane Laurière mailto:slauri...@xwiki.com>> wrote:

Hi Fawad, Caty, all,

 > Hi all,
 > Hoping that everything is going well.
 >
 > Stephane, I was able to do implement most of your suggestions except the 
search results list.

I just gave a try to the latest code, well done with the Solr queries and 
the search integration in the user interface, that's cool!

 > I am not too sure where I should place it. As per the latest build, the 
filter widget appears to the left. Do you think it is practical that we replace 
this widget with the search results when the user wants to see the search results 
and show the widget back again when the user clicks on the widget control? I am 
not too sure what approach I should choose here in terms of UX.
 > Ecaterina, your views on this would help a lot. Thanks. :)

Imho the most convenient UX is the following for these widgets, something 
similar t

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-19 Thread Vincent Massol
Hi,

> On 12 Jun 2019, at 20:46, Vincent Massol  wrote:
> 
> Hi Fawad,
> 
>> On 12 Jun 2019, at 18:37, Fawad Ali  wrote:
> 
> [snip]
> 
>> I took a look at the application-releasenotes and what I understand is
>> that there are sample demo pages instead of functional tests.
> 
> This is not 100% correct. There are both, and the demo pages are used in the 
> functional tests.
> 
> * Demo pages: 
> https://github.com/xwiki-contrib/application-releasenotes/tree/master/application-releasenotes-demo
> * Func tests: 
> https://github.com/xwiki-contrib/application-releasenotes/tree/master/application-releasenotes-test
> * Demo dep in the func test module: 
> https://github.com/xwiki-contrib/application-releasenotes/blob/master/application-releasenotes-test/application-releasenotes-test-tests/pom.xml#L43

Just realized that the release notes app is a bad example since it currently 
doesn’t contain any func test! They’re missing and a TODO.

You could check other app like the FAQ app for an example of a func test.

Sorry about that.
Thanks
-Vincent

> 
> Thanks
> -Vincent
> 
>> I personally
>> think our Interactive Maps Application aligns well with that approach and
>> we can have the same type of tests/demos. WDYT?
>> 
>> I would start preparing for a release for now and implement the tests once
>> we have coordinated on how we do it.
>> 
>> Best,
>> Fawad
>> 
>> 
>> On Fri, Jun 7, 2019 at 10:29 PM Vincent Massol  wrote:
>> 
>>> Hi,
>>> 
 On 7 Jun 2019, at 18:59, Stéphane Laurière  wrote:
 
 Fawad, Caty, all,
 
 I have a short comment about the tests:
 
> Hi Caty,
> Thanks for the review.
>  Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space
>>> is duplicated
> This space exists only for testing. It won't be there for the real
>>> application. I named them so that its easier to know which type of object
>>> pages are located in them (for myself).
>  MapTesting, Maps, Points - spaces don't have homepages. The users
>>> will navigate to them, since they are present in breadcrumb. So what is the
>>> plan? Simpler paths? or create Homepages for these types of entry?
> Since we are in the beta stage now, the whole MapTesting space exists
>>> for testing for developers. It would not be there once we have a stable
>>> version ready for release.
 
 Actually this raises a question, all the more as we also discussed the
>>> importance of having automated functional tests earlier today on #xwiki
>>> with Vincent. For automated testing, we will need sample data, and I'm
>>> wondering where we should store this sample data (and possible scripts or
>>> code for obtaining it). How do other projects deal with test data in such a
>>> context? Is the test data stored in the same repository or in a distinct
>>> one? I was looking for some Solr application test data but could not find
>>> it yet. Note that we may consider the testing area as a set of demos
>>> instead in some way, couldn't we? It would make sense to keep it (just like
>>> if it's real test data), and to provide a navigation across these pages as
>>> you suggest it, Caty.
>>> 
>>> For the Release Notes app, I also have some data for the tests. See the
>>> demo module in https://github.com/xwiki-contrib/application-releasenotes
>>> 
>>> Thanks
>>> -Vincent
>>> 
 
 Cheers
 
 Stéphane
 
 
>  Lots of pages that are not hidden. All technical pages needs to be
>>> hidden.
> Again, these pages are not technical and exist only for testing
>>> purposes.
>  A bit confusing that there are 2 search boxes for the maps, see
>>> https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA   Yes, thanks for
>>> pointing out. We need to move the search function directly inside the map.
>>> I will look into it once I am done with the facets.
 
> For the search input, its in extremely beta stage. I am still trying
>>> to figure out the macros I have borrowed from SolrSearchMacros. So it will
>>> take time for me to make a more stable version of the facets. I hope I can
>>> do that in due time. :)
>  Regarding the facets, we need some more user friendly translations
>>> and customizations for this kind of UI, see
>>> https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw As discussed earlier
>>> with Stephane, we are still having issues using the normal $facetDisplayer
>>> so we are using a workaround for testing purposes that's why it looks like
>>> this. More precisely, we are using the
>>> #displaySearchFacetValues($facetValues) macro for now.
> Best,
> Fawad
 
 
>>> 
>>> 
> 



Re: [xwiki-devs] Map Application - GSoC 19

2019-06-18 Thread Fawad Ali
Hi all,

I have prepared demos and have set up the repository after analyzing
application-releasenotes. Please check to see if the tests and demos are
working fine so we can move on to releasing the application.
https://github.com/xwiki-contrib/application-interactive-maps

Best,
Fawad


On Tue, Jun 18, 2019 at 8:25 PM Fawad Ali  wrote:

> Hi all,
>
> I just gave a try to the latest code, well done with the Solr queries and
>> the search integration in the user interface, that's cool!
>
>
> Thanks Stephane. :)
>
> Imho the most convenient UX is the following for these widgets, something
>> similar to this map:
>>
>>http://carte.preference-commerce.fr/cci-fr/
>>
>> That is:
>>
>> - The facets can get activated from a button. When they get activated,
>> they show up in an overlay panel on top of the map, without hiding the list.
>> - The list gets displayed under the search input, in an overlay as well,
>> and can be completely hidden on request
>
>
> Just to clarify things, the facets here refer to the "Refine your search"
> area, the search input refers to the "Search in map" text input and the
> list refers to the map item search results. Is that right?
> If so, I believe, given the nature of XWiki's design with widgets to both
> the right and left (for the default flavor), the space is a little cramped
> for overlaying anything on the map. For the implementation of full screen
> maps, we can overlay search and facets but for the normal view, the map
> will become very small.
>
> Here is a mockup I prepared based on my understanding of your suggestions:
> https://up1.xwikisas.com/#SB7B5mLNnfnUVAogWTLarw
> Let me know what you think?
>
> I have also come up with an idea to generalize the museum maps import and
> export you created, Stephane. We could have a standard form of wikidata
> query with some extra custom parameters for each location like the
> MuseumClass in the Museums' case. These extra parameter will be checked in
> JSON and classes will be created if required so that objects can be
> associated to each map item and then later facets can be used based upon
> these newly created classes.
> WDYT?
>
> Also, due to unprecedented circumstances within college, my exams have
> been delayed for this week and will start from next week. So I will be
> working this whole week on the project as opposed to what I told earlier.
>
> Best,
> Fawad
>
>
> On Mon, Jun 17, 2019 at 11:04 PM Stéphane Laurière 
> wrote:
>
>> Hi Fawad, Caty, all,
>>
>> > Hi all,
>> > Hoping that everything is going well.
>> >
>> > Stephane, I was able to do implement most of your suggestions except
>> the search results list.
>>
>> I just gave a try to the latest code, well done with the Solr queries and
>> the search integration in the user interface, that's cool!
>>
>> > I am not too sure where I should place it. As per the latest build, the
>> filter widget appears to the left. Do you think it is practical that we
>> replace this widget with the search results when the user wants to see the
>> search results and show the widget back again when the user clicks on the
>> widget control? I am not too sure what approach I should choose here in
>> terms of UX.
>> > Ecaterina, your views on this would help a lot. Thanks. :)
>>
>> Imho the most convenient UX is the following for these widgets, something
>> similar to this map:
>>
>>http://carte.preference-commerce.fr/cci-fr/
>>
>> That is:
>>
>> - The facets can get activated from a button. When they get activated,
>> they show up in an overlay panel on top of the map, without hiding the list.
>> - The list gets displayed under the search input, in an overlay as well,
>> and can be completely hidden on request
>>
>> It's rather close to what Google Maps proposes as well, except that the
>> facets replace the list in that case (when hitting "Autres filtres"), which
>> is a bit less convenient in my opinion, but not a big deal:
>>
>>https://www.google.com/maps/search/Restaurants/@48.865957,2.352974,16z
>>
>> What do you think?
>>
>> > Also, do you foresee the map to take full browser height and width as
>> is seen in all the examples you gave me?
>>
>> That would be a nice feature to have a button on the map to turn it
>> full-screen indeed, similarly to what happens with the XWiki text editor.
>>
>> Cheers
>>
>> Stéphane
>>
>> > Regarding the release, I will try preparing everything by tonight so
>> that it is available for your review, including the demo tests that Vincent
>> suggested.
>> >
>> > Best,
>> > Fawad
>> >
>> >
>> > On Thu, Jun 13, 2019 at 12:59 PM Stéphane Laurière > > wrote:
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-06-18 Thread Fawad Ali
Hi all,

I just gave a try to the latest code, well done with the Solr queries and
> the search integration in the user interface, that's cool!


Thanks Stephane. :)

Imho the most convenient UX is the following for these widgets, something
> similar to this map:
>
>http://carte.preference-commerce.fr/cci-fr/
>
> That is:
>
> - The facets can get activated from a button. When they get activated,
> they show up in an overlay panel on top of the map, without hiding the list.
> - The list gets displayed under the search input, in an overlay as well,
> and can be completely hidden on request


Just to clarify things, the facets here refer to the "Refine your search"
area, the search input refers to the "Search in map" text input and the
list refers to the map item search results. Is that right?
If so, I believe, given the nature of XWiki's design with widgets to both
the right and left (for the default flavor), the space is a little cramped
for overlaying anything on the map. For the implementation of full screen
maps, we can overlay search and facets but for the normal view, the map
will become very small.

Here is a mockup I prepared based on my understanding of your suggestions:
https://up1.xwikisas.com/#SB7B5mLNnfnUVAogWTLarw
Let me know what you think?

I have also come up with an idea to generalize the museum maps import and
export you created, Stephane. We could have a standard form of wikidata
query with some extra custom parameters for each location like the
MuseumClass in the Museums' case. These extra parameter will be checked in
JSON and classes will be created if required so that objects can be
associated to each map item and then later facets can be used based upon
these newly created classes.
WDYT?

Also, due to unprecedented circumstances within college, my exams have been
delayed for this week and will start from next week. So I will be working
this whole week on the project as opposed to what I told earlier.

Best,
Fawad


On Mon, Jun 17, 2019 at 11:04 PM Stéphane Laurière 
wrote:

> Hi Fawad, Caty, all,
>
> > Hi all,
> > Hoping that everything is going well.
> >
> > Stephane, I was able to do implement most of your suggestions except the
> search results list.
>
> I just gave a try to the latest code, well done with the Solr queries and
> the search integration in the user interface, that's cool!
>
> > I am not too sure where I should place it. As per the latest build, the
> filter widget appears to the left. Do you think it is practical that we
> replace this widget with the search results when the user wants to see the
> search results and show the widget back again when the user clicks on the
> widget control? I am not too sure what approach I should choose here in
> terms of UX.
> > Ecaterina, your views on this would help a lot. Thanks. :)
>
> Imho the most convenient UX is the following for these widgets, something
> similar to this map:
>
>http://carte.preference-commerce.fr/cci-fr/
>
> That is:
>
> - The facets can get activated from a button. When they get activated,
> they show up in an overlay panel on top of the map, without hiding the list.
> - The list gets displayed under the search input, in an overlay as well,
> and can be completely hidden on request
>
> It's rather close to what Google Maps proposes as well, except that the
> facets replace the list in that case (when hitting "Autres filtres"), which
> is a bit less convenient in my opinion, but not a big deal:
>
>https://www.google.com/maps/search/Restaurants/@48.865957,2.352974,16z
>
> What do you think?
>
> > Also, do you foresee the map to take full browser height and width as is
> seen in all the examples you gave me?
>
> That would be a nice feature to have a button on the map to turn it
> full-screen indeed, similarly to what happens with the XWiki text editor.
>
> Cheers
>
> Stéphane
>
> > Regarding the release, I will try preparing everything by tonight so
> that it is available for your review, including the demo tests that Vincent
> suggested.
> >
> > Best,
> > Fawad
> >
> >
> > On Thu, Jun 13, 2019 at 12:59 PM Stéphane Laurière  > wrote:
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-06-17 Thread Stéphane Laurière

Hi Fawad, Caty, all,


Hi all,
Hoping that everything is going well.

Stephane, I was able to do implement most of your suggestions except the search results list. 


I just gave a try to the latest code, well done with the Solr queries and the 
search integration in the user interface, that's cool!


I am not too sure where I should place it. As per the latest build, the filter 
widget appears to the left. Do you think it is practical that we replace this 
widget with the search results when the user wants to see the search results 
and show the widget back again when the user clicks on the widget control? I am 
not too sure what approach I should choose here in terms of UX.
Ecaterina, your views on this would help a lot. Thanks. :)


Imho the most convenient UX is the following for these widgets, something 
similar to this map:

  http://carte.preference-commerce.fr/cci-fr/

That is:

- The facets can get activated from a button. When they get activated, they 
show up in an overlay panel on top of the map, without hiding the list.
- The list gets displayed under the search input, in an overlay as well, and 
can be completely hidden on request

It's rather close to what Google Maps proposes as well, except that the facets replace 
the list in that case (when hitting "Autres filtres"), which is a bit less 
convenient in my opinion, but not a big deal:

  https://www.google.com/maps/search/Restaurants/@48.865957,2.352974,16z

What do you think?


Also, do you foresee the map to take full browser height and width as is seen 
in all the examples you gave me?


That would be a nice feature to have a button on the map to turn it full-screen 
indeed, similarly to what happens with the XWiki text editor.

Cheers

Stéphane
 

Regarding the release, I will try preparing everything by tonight so that it is 
available for your review, including the demo tests that Vincent suggested.

Best,
Fawad


On Thu, Jun 13, 2019 at 12:59 PM Stéphane Laurière mailto:slauri...@xwiki.com>> wrote:




Re: [xwiki-devs] Map Application - GSoC 19

2019-06-16 Thread Fawad Ali
Hi all,

I am still a little confused regarding tests. What I get from analyzing the
application-release-notes is that I have to make demo pages containing maps
first, then just include test (containing demo pages) and ui folders and
change the pom files to include the tests, is that correct?

Thanks,
Fawad


On Sat, Jun 15, 2019 at 5:42 PM Fawad Ali  wrote:

> Hi all,
> Hoping that everything is going well.
>
> Stephane, I was able to do implement most of your suggestions except the
> search results list. I am not too sure where I should place it. As per the
> latest build, the filter widget appears to the left. Do you think it is
> practical that we replace this widget with the search results when the user
> wants to see the search results and show the widget back again when the
> user clicks on the widget control? I am not too sure what approach I should
> choose here in terms of UX.
> Ecaterina, your views on this would help a lot. Thanks. :)
>
> Also, do you foresee the map to take full browser height and width as is
> seen in all the examples you gave me?
>
> Regarding the release, I will try preparing everything by tonight so that
> it is available for your review, including the demo tests that Vincent
> suggested.
>
> Best,
> Fawad
>
>
> On Thu, Jun 13, 2019 at 12:59 PM Stéphane Laurière 
> wrote:
>
>> Hi Fawad, Hi all,
>>
>> > Hi everyone,
>> > Hope all are well.
>> >
>> > Ecaterina, Stephane,
>> > For the search, do you think that we have to keep both the filter search
>> > and the search inside the map? I feel like its an important use case for
>> > the users to be able to search a location/place but that is not possible
>> > with the query search. One approach is to have a single form with select
>> > options if the the user wants to query the data or make a location
>> search.
>> > WDYT?
>> > Here's a categorical single search form I made about a year ago:
>> > https://jsfiddle.net/9inpachi/e428fLgr/
>>
>> Imho the ability to search for a location should be an option, because
>> not all users will need it, I think. In case it is activated, I would
>> suggest a user experience inspired by the one exposed by GoGoCarto, the one
>> of Google Maps, the CCI Map and the widget you mention indeed, that is made
>> of the following elements:
>>
>> 1) a search input
>>
>> 2) only if the location search option is activated: two radio buttons for
>> defining the scope: either the map data or a location
>>
>> 3) a panel that shows up upon explicit activation by the user for
>> displaying and applying facets (on this aspect, it differs from GoGoCarto
>> where the category filter is always present when the search widget is
>> visible)
>>
>> 4) a list of search results that show up under the search widget and that
>> can be hidden
>>
>> Examples:
>>
>> - https://abc.gogocarto.fr/annuaire#/carte/recherche/abc?cat=all
>> - http://carte.preference-commerce.fr/cci-fr
>> -
>> https://www.google.com/maps/search/museums/@48.8761955,2.3004558,13z/data=!3m1!4b1
>>
>> What do you think about this approach in terms of UX?
>>
>> >   I took a look at the application-releasenotes and what I understand is
>> > that there are sample demo pages instead of functional tests. I
>> personally
>> > think our Interactive Maps Application aligns well with that approach
>> and
>> > we can have the same type of tests/demos. WDYT?
>> >
>> > I would start preparing for a release for now and implement the tests
>> once
>> > we have coordinated on how we do it.
>>
>> That looks like a great plan.
>>
>> Cheers
>>
>> Stéphane
>>
>>
>> > Best,
>> > Fawad
>>
>>
>> --
>> Stéphane Laurière
>> XWiki – https://xwiki.com
>>
>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-06-15 Thread Fawad Ali
Hi all,
Hoping that everything is going well.

Stephane, I was able to do implement most of your suggestions except the
search results list. I am not too sure where I should place it. As per the
latest build, the filter widget appears to the left. Do you think it is
practical that we replace this widget with the search results when the user
wants to see the search results and show the widget back again when the
user clicks on the widget control? I am not too sure what approach I should
choose here in terms of UX.
Ecaterina, your views on this would help a lot. Thanks. :)

Also, do you foresee the map to take full browser height and width as is
seen in all the examples you gave me?

Regarding the release, I will try preparing everything by tonight so that
it is available for your review, including the demo tests that Vincent
suggested.

Best,
Fawad


On Thu, Jun 13, 2019 at 12:59 PM Stéphane Laurière 
wrote:

> Hi Fawad, Hi all,
>
> > Hi everyone,
> > Hope all are well.
> >
> > Ecaterina, Stephane,
> > For the search, do you think that we have to keep both the filter search
> > and the search inside the map? I feel like its an important use case for
> > the users to be able to search a location/place but that is not possible
> > with the query search. One approach is to have a single form with select
> > options if the the user wants to query the data or make a location
> search.
> > WDYT?
> > Here's a categorical single search form I made about a year ago:
> > https://jsfiddle.net/9inpachi/e428fLgr/
>
> Imho the ability to search for a location should be an option, because not
> all users will need it, I think. In case it is activated, I would suggest a
> user experience inspired by the one exposed by GoGoCarto, the one of Google
> Maps, the CCI Map and the widget you mention indeed, that is made of the
> following elements:
>
> 1) a search input
>
> 2) only if the location search option is activated: two radio buttons for
> defining the scope: either the map data or a location
>
> 3) a panel that shows up upon explicit activation by the user for
> displaying and applying facets (on this aspect, it differs from GoGoCarto
> where the category filter is always present when the search widget is
> visible)
>
> 4) a list of search results that show up under the search widget and that
> can be hidden
>
> Examples:
>
> - https://abc.gogocarto.fr/annuaire#/carte/recherche/abc?cat=all
> - http://carte.preference-commerce.fr/cci-fr
> -
> https://www.google.com/maps/search/museums/@48.8761955,2.3004558,13z/data=!3m1!4b1
>
> What do you think about this approach in terms of UX?
>
> >   I took a look at the application-releasenotes and what I understand is
> > that there are sample demo pages instead of functional tests. I
> personally
> > think our Interactive Maps Application aligns well with that approach and
> > we can have the same type of tests/demos. WDYT?
> >
> > I would start preparing for a release for now and implement the tests
> once
> > we have coordinated on how we do it.
>
> That looks like a great plan.
>
> Cheers
>
> Stéphane
>
>
> > Best,
> > Fawad
>
>
> --
> Stéphane Laurière
> XWiki – https://xwiki.com
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-06-13 Thread Stéphane Laurière

Hi Fawad, Hi all,


Hi everyone,
Hope all are well.

Ecaterina, Stephane,
For the search, do you think that we have to keep both the filter search
and the search inside the map? I feel like its an important use case for
the users to be able to search a location/place but that is not possible
with the query search. One approach is to have a single form with select
options if the the user wants to query the data or make a location search.
WDYT?
Here's a categorical single search form I made about a year ago:
https://jsfiddle.net/9inpachi/e428fLgr/


Imho the ability to search for a location should be an option, because not all 
users will need it, I think. In case it is activated, I would suggest a user 
experience inspired by the one exposed by GoGoCarto, the one of Google Maps, 
the CCI Map and the widget you mention indeed, that is made of the following 
elements:

1) a search input

2) only if the location search option is activated: two radio buttons for 
defining the scope: either the map data or a location

3) a panel that shows up upon explicit activation by the user for displaying 
and applying facets (on this aspect, it differs from GoGoCarto where the 
category filter is always present when the search widget is visible)

4) a list of search results that show up under the search widget and that can 
be hidden

Examples:

- https://abc.gogocarto.fr/annuaire#/carte/recherche/abc?cat=all
- http://carte.preference-commerce.fr/cci-fr
- 
https://www.google.com/maps/search/museums/@48.8761955,2.3004558,13z/data=!3m1!4b1

What do you think about this approach in terms of UX?
 

  I took a look at the application-releasenotes and what I understand is
that there are sample demo pages instead of functional tests. I personally
think our Interactive Maps Application aligns well with that approach and
we can have the same type of tests/demos. WDYT?

I would start preparing for a release for now and implement the tests once
we have coordinated on how we do it.


That looks like a great plan.

Cheers

Stéphane

 

Best,
Fawad



--
Stéphane Laurière
XWiki – https://xwiki.com



Re: [xwiki-devs] Map Application - GSoC 19

2019-06-12 Thread Vincent Massol
Hi Fawad,

> On 12 Jun 2019, at 18:37, Fawad Ali  wrote:

[snip]

> I took a look at the application-releasenotes and what I understand is
> that there are sample demo pages instead of functional tests.

This is not 100% correct. There are both, and the demo pages are used in the 
functional tests.

* Demo pages: 
https://github.com/xwiki-contrib/application-releasenotes/tree/master/application-releasenotes-demo
* Func tests: 
https://github.com/xwiki-contrib/application-releasenotes/tree/master/application-releasenotes-test
* Demo dep in the func test module: 
https://github.com/xwiki-contrib/application-releasenotes/blob/master/application-releasenotes-test/application-releasenotes-test-tests/pom.xml#L43

Thanks
-Vincent

> I personally
> think our Interactive Maps Application aligns well with that approach and
> we can have the same type of tests/demos. WDYT?
> 
> I would start preparing for a release for now and implement the tests once
> we have coordinated on how we do it.
> 
> Best,
> Fawad
> 
> 
> On Fri, Jun 7, 2019 at 10:29 PM Vincent Massol  wrote:
> 
>> Hi,
>> 
>>> On 7 Jun 2019, at 18:59, Stéphane Laurière  wrote:
>>> 
>>> Fawad, Caty, all,
>>> 
>>> I have a short comment about the tests:
>>> 
 Hi Caty,
 Thanks for the review.
   Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space
>> is duplicated
 This space exists only for testing. It won't be there for the real
>> application. I named them so that its easier to know which type of object
>> pages are located in them (for myself).
   MapTesting, Maps, Points - spaces don't have homepages. The users
>> will navigate to them, since they are present in breadcrumb. So what is the
>> plan? Simpler paths? or create Homepages for these types of entry?
 Since we are in the beta stage now, the whole MapTesting space exists
>> for testing for developers. It would not be there once we have a stable
>> version ready for release.
>>> 
>>> Actually this raises a question, all the more as we also discussed the
>> importance of having automated functional tests earlier today on #xwiki
>> with Vincent. For automated testing, we will need sample data, and I'm
>> wondering where we should store this sample data (and possible scripts or
>> code for obtaining it). How do other projects deal with test data in such a
>> context? Is the test data stored in the same repository or in a distinct
>> one? I was looking for some Solr application test data but could not find
>> it yet. Note that we may consider the testing area as a set of demos
>> instead in some way, couldn't we? It would make sense to keep it (just like
>> if it's real test data), and to provide a navigation across these pages as
>> you suggest it, Caty.
>> 
>> For the Release Notes app, I also have some data for the tests. See the
>> demo module in https://github.com/xwiki-contrib/application-releasenotes
>> 
>> Thanks
>> -Vincent
>> 
>>> 
>>> Cheers
>>> 
>>> Stéphane
>>> 
>>> 
   Lots of pages that are not hidden. All technical pages needs to be
>> hidden.
 Again, these pages are not technical and exist only for testing
>> purposes.
   A bit confusing that there are 2 search boxes for the maps, see
>> https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA   Yes, thanks for
>> pointing out. We need to move the search function directly inside the map.
>> I will look into it once I am done with the facets.
>>> 
 For the search input, its in extremely beta stage. I am still trying
>> to figure out the macros I have borrowed from SolrSearchMacros. So it will
>> take time for me to make a more stable version of the facets. I hope I can
>> do that in due time. :)
   Regarding the facets, we need some more user friendly translations
>> and customizations for this kind of UI, see
>> https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw As discussed earlier
>> with Stephane, we are still having issues using the normal $facetDisplayer
>> so we are using a workaround for testing purposes that's why it looks like
>> this. More precisely, we are using the
>> #displaySearchFacetValues($facetValues) macro for now.
 Best,
 Fawad
>>> 
>>> 
>> 
>> 



Re: [xwiki-devs] Map Application - GSoC 19

2019-06-12 Thread Fawad Ali
Hi everyone,
Hope all are well.

Ecaterina, Stephane,
For the search, do you think that we have to keep both the filter search
and the search inside the map? I feel like its an important use case for
the users to be able to search a location/place but that is not possible
with the query search. One approach is to have a single form with select
options if the the user wants to query the data or make a location search.
WDYT?
Here's a categorical single search form I made about a year ago:
https://jsfiddle.net/9inpachi/e428fLgr/

 I took a look at the application-releasenotes and what I understand is
that there are sample demo pages instead of functional tests. I personally
think our Interactive Maps Application aligns well with that approach and
we can have the same type of tests/demos. WDYT?

I would start preparing for a release for now and implement the tests once
we have coordinated on how we do it.

Best,
Fawad


On Fri, Jun 7, 2019 at 10:29 PM Vincent Massol  wrote:

> Hi,
>
> > On 7 Jun 2019, at 18:59, Stéphane Laurière  wrote:
> >
> > Fawad, Caty, all,
> >
> > I have a short comment about the tests:
> >
> >> Hi Caty,
> >> Thanks for the review.
> >>Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space
> is duplicated
> >> This space exists only for testing. It won't be there for the real
> application. I named them so that its easier to know which type of object
> pages are located in them (for myself).
> >>MapTesting, Maps, Points - spaces don't have homepages. The users
> will navigate to them, since they are present in breadcrumb. So what is the
> plan? Simpler paths? or create Homepages for these types of entry?
> >> Since we are in the beta stage now, the whole MapTesting space exists
> for testing for developers. It would not be there once we have a stable
> version ready for release.
> >
> > Actually this raises a question, all the more as we also discussed the
> importance of having automated functional tests earlier today on #xwiki
> with Vincent. For automated testing, we will need sample data, and I'm
> wondering where we should store this sample data (and possible scripts or
> code for obtaining it). How do other projects deal with test data in such a
> context? Is the test data stored in the same repository or in a distinct
> one? I was looking for some Solr application test data but could not find
> it yet. Note that we may consider the testing area as a set of demos
> instead in some way, couldn't we? It would make sense to keep it (just like
> if it's real test data), and to provide a navigation across these pages as
> you suggest it, Caty.
>
> For the Release Notes app, I also have some data for the tests. See the
> demo module in https://github.com/xwiki-contrib/application-releasenotes
>
> Thanks
> -Vincent
>
> >
> > Cheers
> >
> > Stéphane
> >
> >
> >>Lots of pages that are not hidden. All technical pages needs to be
> hidden.
> >> Again, these pages are not technical and exist only for testing
> purposes.
> >>A bit confusing that there are 2 search boxes for the maps, see
> https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA   Yes, thanks for
> pointing out. We need to move the search function directly inside the map.
> I will look into it once I am done with the facets.
> >
> >>  For the search input, its in extremely beta stage. I am still trying
> to figure out the macros I have borrowed from SolrSearchMacros. So it will
> take time for me to make a more stable version of the facets. I hope I can
> do that in due time. :)
> >>Regarding the facets, we need some more user friendly translations
> and customizations for this kind of UI, see
> https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw As discussed earlier
> with Stephane, we are still having issues using the normal $facetDisplayer
> so we are using a workaround for testing purposes that's why it looks like
> this. More precisely, we are using the
> #displaySearchFacetValues($facetValues) macro for now.
> >> Best,
> >> Fawad
> >
> >
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-06-07 Thread Vincent Massol
Hi,

> On 7 Jun 2019, at 18:59, Stéphane Laurière  wrote:
> 
> Fawad, Caty, all,
> 
> I have a short comment about the tests:
> 
>> Hi Caty,
>> Thanks for the review.
>>Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space is 
>> duplicated
>> This space exists only for testing. It won't be there for the real 
>> application. I named them so that its easier to know which type of object 
>> pages are located in them (for myself).
>>MapTesting, Maps, Points - spaces don't have homepages. The users will 
>> navigate to them, since they are present in breadcrumb. So what is the plan? 
>> Simpler paths? or create Homepages for these types of entry?
>> Since we are in the beta stage now, the whole MapTesting space exists for 
>> testing for developers. It would not be there once we have a stable version 
>> ready for release.
> 
> Actually this raises a question, all the more as we also discussed the 
> importance of having automated functional tests earlier today on #xwiki with 
> Vincent. For automated testing, we will need sample data, and I'm wondering 
> where we should store this sample data (and possible scripts or code for 
> obtaining it). How do other projects deal with test data in such a context? 
> Is the test data stored in the same repository or in a distinct one? I was 
> looking for some Solr application test data but could not find it yet. Note 
> that we may consider the testing area as a set of demos instead in some way, 
> couldn't we? It would make sense to keep it (just like if it's real test 
> data), and to provide a navigation across these pages as you suggest it, Caty.

For the Release Notes app, I also have some data for the tests. See the demo 
module in https://github.com/xwiki-contrib/application-releasenotes

Thanks
-Vincent

> 
> Cheers
> 
> Stéphane
> 
> 
>>Lots of pages that are not hidden. All technical pages needs to be hidden.
>> Again, these pages are not technical and exist only for testing purposes.
>>A bit confusing that there are 2 search boxes for the maps, see 
>> https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA   Yes, thanks for pointing 
>> out. We need to move the search function directly inside the map. I will 
>> look into it once I am done with the facets.
> 
>>  For the search input, its in extremely beta stage. I am still trying to 
>> figure out the macros I have borrowed from SolrSearchMacros. So it will take 
>> time for me to make a more stable version of the facets. I hope I can do 
>> that in due time. :)
>>Regarding the facets, we need some more user friendly translations and 
>> customizations for this kind of UI, see 
>> https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw As discussed earlier with 
>> Stephane, we are still having issues using the normal $facetDisplayer so we 
>> are using a workaround for testing purposes that's why it looks like this. 
>> More precisely, we are using the #displaySearchFacetValues($facetValues) 
>> macro for now.
>> Best,
>> Fawad
> 
> 



Re: [xwiki-devs] Map Application - GSoC 19

2019-06-07 Thread Fawad Ali
Hi,

Thanks for the PR Stephane! It really helps in knowing how I should do
things.

I will accept the PR now and make changes later if required. I tested it
and everything seems fine so far except for some country facets the map
goes blank (bad data handling on my part maybe).

Hoping such sample data can help developing further and think in greater
> details about real case scenarios.


It helps a lot, thanks.

When displaying such a map, that'd be great if the available facets would
> get displayed directly, without the need to enter a query in the input
> field (you probably have this in mind already as well).
>

This has been done and will be included in today's commit.

I was actually writing my custom solr configurations for the map. Now that
I know a use case, I can include better options.

Best,
Fawad


On Fri, Jun 7, 2019 at 9:59 PM Stéphane Laurière 
wrote:

> Fawad, Caty, all,
>
> I have a short comment about the tests:
>
> > Hi Caty,
> > Thanks for the review.
> >
> > Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space
> is duplicated
> >
> >
> > This space exists only for testing. It won't be there for the real
> application. I named them so that its easier to know which type of object
> pages are located in them (for myself).
> >
> > MapTesting, Maps, Points - spaces don't have homepages. The users
> will navigate to them, since they are present in breadcrumb. So what is the
> plan? Simpler paths? or create Homepages for these types of entry?
> >
> >
> > Since we are in the beta stage now, the whole MapTesting space exists
> for testing for developers. It would not be there once we have a stable
> version ready for release.
>
> Actually this raises a question, all the more as we also discussed the
> importance of having automated functional tests earlier today on #xwiki
> with Vincent. For automated testing, we will need sample data, and I'm
> wondering where we should store this sample data (and possible scripts or
> code for obtaining it). How do other projects deal with test data in such a
> context? Is the test data stored in the same repository or in a distinct
> one? I was looking for some Solr application test data but could not find
> it yet. Note that we may consider the testing area as a set of demos
> instead in some way, couldn't we? It would make sense to keep it (just like
> if it's real test data), and to provide a navigation across these pages as
> you suggest it, Caty.
>
> Cheers
>
> Stéphane
>
>
> > Lots of pages that are not hidden. All technical pages needs to be
> hidden.
> >
> >
> > Again, these pages are not technical and exist only for testing purposes.
> >
> > A bit confusing that there are 2 search boxes for the maps, see
> https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA
> >
> >
> >   Yes, thanks for pointing out. We need to move the search function
> directly inside the map. I will look into it once I am done with the facets.
>
> >   For the search input, its in extremely beta stage. I am still trying
> to figure out the macros I have borrowed from SolrSearchMacros. So it will
> take time for me to make a more stable version of the facets. I hope I can
> do that in due time. :)
> >
> > Regarding the facets, we need some more user friendly translations
> and customizations for this kind of UI, see
> https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw
> >
> > As discussed earlier with Stephane, we are still having issues using the
> normal $facetDisplayer so we are using a workaround for testing purposes
> that's why it looks like this. More precisely, we are using
> the #displaySearchFacetValues($facetValues) macro for now.
> >
> > Best,
> > Fawad
>
>
>


Re: [xwiki-devs] Map Application - GSoC 19

2019-06-07 Thread Stéphane Laurière

Fawad,


Hi all,
Hope you all are doing wonderfully.

We still have the issue for the facets rendering but its up on the forum, so I 
think we will have some fixes for it in due time (thanks to Stephane).
In the meantime, I will try making the facets more specific to the map. For now 
I am considering the following options for facets:
- Tags
- Search field (searches inside map item pages)
- Map item type (PointClass for now)
- Map item icon (?)
- Map item space
I will need some suggestions on which other options should be included.


I created the museum-map-test branch in order to progress on this path, I hope 
this helps. In particular, imho, facets will be provided typically by objects 
from different classes than the geographical ones, such as a the Museum class 
(which very basic for now, it's just to expose the idea). My suggestion would 
be to progress toward an application that works well with a single sample facet 
+ a full text input field + popups indeed + list + configurable icons and 
colors (typically one per facet value, I would say, so as for instance to 
represent all archeologia museums in a given color - even though we don't have 
that data yet, but we could use the countries all the same), and in parallel to 
gather more sample data with more facets and to progress toward having several 
configurable facets, what do you think?
 

Next, I will
-  Be working on making a dedicated space for popups inside or besides the map. 
Something similar to https://abc.gogocarto.fr 
- Make use of theme styles and colors for the map itself and the items inside
- Be making the query search asynchronous

Also, I will be working part time for the next week and I have exams the week 
after that. So I would like to let you know that I would not be available for 
the exams period for the most part. :(
I will try to finish most of the work and get the application in a stable state 
by then. :)
Ecaterina also mentioned that we release the application, I propose we do that 
next week as soon as the facets are in a stable state.


Great

Cheers

Stéphane


Thanks,
Fawad
 





Re: [xwiki-devs] Map Application - GSoC 19

2019-06-07 Thread Stéphane Laurière

Fawad, Caty, all,

I have a short comment about the tests:


Hi Caty,
Thanks for the review.

Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space is 
duplicated


This space exists only for testing. It won't be there for the real application. 
I named them so that its easier to know which type of object pages are located 
in them (for myself).

MapTesting, Maps, Points - spaces don't have homepages. The users will 
navigate to them, since they are present in breadcrumb. So what is the plan? 
Simpler paths? or create Homepages for these types of entry?


Since we are in the beta stage now, the whole MapTesting space exists for 
testing for developers. It would not be there once we have a stable version 
ready for release.


Actually this raises a question, all the more as we also discussed the 
importance of having automated functional tests earlier today on #xwiki with 
Vincent. For automated testing, we will need sample data, and I'm wondering 
where we should store this sample data (and possible scripts or code for 
obtaining it). How do other projects deal with test data in such a context? Is 
the test data stored in the same repository or in a distinct one? I was looking 
for some Solr application test data but could not find it yet. Note that we may 
consider the testing area as a set of demos instead in some way, couldn't we? 
It would make sense to keep it (just like if it's real test data), and to 
provide a navigation across these pages as you suggest it, Caty.

Cheers

Stéphane



Lots of pages that are not hidden. All technical pages needs to be hidden.


Again, these pages are not technical and exist only for testing purposes.

A bit confusing that there are 2 search boxes for the maps, see https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA 



  Yes, thanks for pointing out. We need to move the search function directly 
inside the map. I will look into it once I am done with the facets.



  For the search input, its in extremely beta stage. I am still trying to 
figure out the macros I have borrowed from SolrSearchMacros. So it will take 
time for me to make a more stable version of the facets. I hope I can do that 
in due time. :)

Regarding the facets, we need some more user friendly translations and customizations for this kind of UI, see https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw 


As discussed earlier with Stephane, we are still having issues using the normal 
$facetDisplayer so we are using a workaround for testing purposes that's why it 
looks like this. More precisely, we are using the 
#displaySearchFacetValues($facetValues) macro for now.

Best,
Fawad





[xwiki-devs] Map Application - GSoC 19

2019-06-07 Thread Stéphane Laurière

Hi Fawad, Caty, all,

I just submitted some code to the interactive-maps repository that aims at a 
sample map with real data and facets (as a pull request, just to make sure 
we're in tune first, let me know). The code consists of the following:

- A Museum class with a single "country" property (string)

- A DataImporter script for converting Wikidata exported in JSON via a SPARQL 
query (that you can find in page Museums.WebHome) into XWiki pages consisting 
of a Museum object and a Point object.

- A simple map configuration for displaying the imported data

In order to configure the facets for this map, you'll have to add the following 
code to the top of the CommonMacros (if we go this way, we'll have to make this 
configurable at each map level):

{{velocity output="false"}}
#set ($solrConfig = {
  'filterQuery': [
'type:DOCUMENT',
'class:Maps.Code.PointClass'
  ],
  'facetFields': [
'property.Maps.MapTesting.Museums.Code.MuseumClass.country_string'
  ]
})
{{/velocity}}

Here's a capture of what I get on my side when selecting the "Spain" facet:

  https://up1.xwikisas.com/#ZTkIQ8K1fXLrY5dgvp6BvA

Hoping such sample data can help developing further and think in greater 
details about real case scenarios. When displaying such a map, that'd be great 
if the available facets would get displayed directly, without the need to enter 
a query in the input field (you probably have this in mind already as well).

Cheers

Stéphane



Re: [xwiki-devs] Map Application - GSoC 19

2019-06-07 Thread Fawad Ali
Hi Caty,
Thanks for the review.


> Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space is
> duplicated
>

This space exists only for testing. It won't be there for the real
application. I named them so that its easier to know which type of object
pages are located in them (for myself).

MapTesting, Maps, Points - spaces don't have homepages. The users will
> navigate to them, since they are present in breadcrumb. So what is the
> plan? Simpler paths? or create Homepages for these types of entry?
>

Since we are in the beta stage now, the whole MapTesting space exists for
testing for developers. It would not be there once we have a stable version
ready for release.

Lots of pages that are not hidden. All technical pages needs to be
> hidden.
>

Again, these pages are not technical and exist only for testing purposes.

A bit confusing that there are 2 search boxes for the maps, see
> https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA


 Yes, thanks for pointing out. We need to move the search function directly
inside the map. I will look into it once I am done with the facets.

 For the search input, its in extremely beta stage. I am still trying to
figure out the macros I have borrowed from SolrSearchMacros. So it will
take time for me to make a more stable version of the facets. I hope I can
do that in due time. :)

Regarding the facets, we need some more user friendly translations and
> customizations for this kind of UI, see
> https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw


As discussed earlier with Stephane, we are still having issues using the
normal $facetDisplayer so we are using a workaround for testing purposes
that's why it looks like this. More precisely, we are using
the #displaySearchFacetValues($facetValues) macro for now.

Best,
Fawad


On Fri, Jun 7, 2019 at 5:18 PM Ecaterina Moraru (Valica) 
wrote:

> Hi,
>
> On Fri, Jun 7, 2019 at 2:01 PM Fawad Ali  wrote:
>
>> Hi all,
>> Hope you all are doing wonderfully.
>>
>> We still have the issue for the facets rendering but its up on the forum,
>> so I think we will have some fixes for it in due time (thanks to Stephane).
>> In the meantime, I will try making the facets more specific to the map.
>> For now I am considering the following options for facets:
>> - Tags
>> - Search field (searches inside map item pages)
>> - Map item type (PointClass for now)
>> - Map item icon (?)
>> - Map item space
>> I will need some suggestions on which other options should be included.
>>
>> Next, I will
>> -  Be working on making a dedicated space for popups inside or besides
>> the map. Something similar to https://abc.gogocarto.fr
>> - Make use of theme styles and colors for the map itself and the items
>> inside
>> - Be making the query search asynchronous
>>
>> Also, I will be working part time for the next week and I have exams the
>> week after that. So I would like to let you know that I would not be
>> available for the exams period for the most part. :(
>> I will try to finish most of the work and get the application in a stable
>> state by then. :)
>> Ecaterina also mentioned that we release the application, I propose we do
>> that next week as soon as the facets are in a stable state.
>>
>
> That would be great in order for people to faster install it and test it.
> You could also request feedback on the forum if you want.
> When releasing you also need to write the documentation for the existing
> features, mentioning how to use them, etc. + list the fixed issues.
>
> I managed to get the maps working. Thanks for your help.
> Some comments on the current state:
> - Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space is
> duplicated
> - MapTesting, Maps, Points - spaces don't have homepages. The users will
> navigate to them, since they are present in breadcrumb. So what is the
> plan? Simpler paths? or create Homepages for these types of entry?
> - Lots of pages that are not hidden. All technical pages needs to be
> hidden.
> - A bit confusing that there are 2 search boxes for the maps, see
> https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA
> - The Search input is not really working. It kind of works (with a strange
> reload effect) for queries like "Paris" or "Moscow", but if you enter
> anything else it defaults on Paris. If that search is supposed to filter
> only the existing points than the placeholder should state that somehow +
> treat the non existing point with a "No point of interest found" or
> something. Also when it doesn't find the location, the search facets area
> is empty, so kind of hard for an user to recover it's track.
> - Regarding the facets, we need some more user friendly translations and
> customizations for this kind of UI, see
> https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw
>
> Thanks,
> Caty
>
>
>> Thanks,
>> Fawad
>>
>>
>> On Thu, Jun 6, 2019 at 6:42 PM Ecaterina Moraru (Valica) <
>> vali...@gmail.com> wrote:
>>
>>> That most likely is the problem, since I've just imported the XAR, 

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-07 Thread Ecaterina Moraru (Valica)
Hi,

On Fri, Jun 7, 2019 at 2:01 PM Fawad Ali  wrote:

> Hi all,
> Hope you all are doing wonderfully.
>
> We still have the issue for the facets rendering but its up on the forum,
> so I think we will have some fixes for it in due time (thanks to Stephane).
> In the meantime, I will try making the facets more specific to the map.
> For now I am considering the following options for facets:
> - Tags
> - Search field (searches inside map item pages)
> - Map item type (PointClass for now)
> - Map item icon (?)
> - Map item space
> I will need some suggestions on which other options should be included.
>
> Next, I will
> -  Be working on making a dedicated space for popups inside or besides the
> map. Something similar to https://abc.gogocarto.fr
> - Make use of theme styles and colors for the map itself and the items
> inside
> - Be making the query search asynchronous
>
> Also, I will be working part time for the next week and I have exams the
> week after that. So I would like to let you know that I would not be
> available for the exams period for the most part. :(
> I will try to finish most of the work and get the application in a stable
> state by then. :)
> Ecaterina also mentioned that we release the application, I propose we do
> that next week as soon as the facets are in a stable state.
>

That would be great in order for people to faster install it and test it.
You could also request feedback on the forum if you want.
When releasing you also need to write the documentation for the existing
features, mentioning how to use them, etc. + list the fixed issues.

I managed to get the maps working. Thanks for your help.
Some comments on the current state:
- Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space is
duplicated
- MapTesting, Maps, Points - spaces don't have homepages. The users will
navigate to them, since they are present in breadcrumb. So what is the
plan? Simpler paths? or create Homepages for these types of entry?
- Lots of pages that are not hidden. All technical pages needs to be
hidden.
- A bit confusing that there are 2 search boxes for the maps, see
https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA
- The Search input is not really working. It kind of works (with a strange
reload effect) for queries like "Paris" or "Moscow", but if you enter
anything else it defaults on Paris. If that search is supposed to filter
only the existing points than the placeholder should state that somehow +
treat the non existing point with a "No point of interest found" or
something. Also when it doesn't find the location, the search facets area
is empty, so kind of hard for an user to recover it's track.
- Regarding the facets, we need some more user friendly translations and
customizations for this kind of UI, see
https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw

Thanks,
Caty


> Thanks,
> Fawad
>
>
> On Thu, Jun 6, 2019 at 6:42 PM Ecaterina Moraru (Valica) <
> vali...@gmail.com> wrote:
>
>> That most likely is the problem, since I've just imported the XAR, no
>> real install. I will try like that, thanks for helping.
>>
>> Caty
>>
>> On Thu, Jun 6, 2019 at 1:03 PM Fawad Ali  wrote:
>>
>>> Hi Caty,
>>>
>>> The last thing to be wary of is to have the Leaflet dependency installed.
>>> If I remove my Leaflet webjar, I get this set of errors.
>>>
>>> GET
>>> http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.css
>>> net::ERR_ABORTED 404 (Not Found)
>>> require.min.js?r=1:34 GET
>>> http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1
>>> net::ERR_ABORTED 404 (Not Found)
>>> require.min.js?r=1:7 Uncaught Error: Script error for "leaflet", needed
>>> by: leafletSearch
>>> http://requirejs.org/docs/errors.html#scripterror
>>> at F (require.min.js?r=1:7)
>>> at HTMLScriptElement.onScriptError (require.min.js?r=1:30)
>>>
>>> I think Its the same problem your side.
>>> For installing Leaflet, search for Map Macro in extensions, from its
>>> dependencies tab in details go to Leaflet and install it.
>>> That ought to work. :)
>>>
>>> Best,
>>> Fawad
>>>
>>>
>>> On Thu, Jun 6, 2019 at 2:24 PM Ecaterina Moraru (Valica) <
>>> vali...@gmail.com> wrote:
>>>
 Hi Fawad,

 I still have the issue: no maps loaded, leaflet.css error in console.
 Tested with the most recent snapshot of 11.5 and with the build from
 https://github.com/xwiki-contrib/application-interactive-maps
 I have the same problem with Firefox, Chrome, Safari and Opera. I'm on
 Mac.
 https://up1.xwikisas.com/#mXONZtF2qcMeftvnyJOSjw
 The script from “
 http://localhost:8084/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1”
 was loaded even though its MIME type (“text/html”) is not a valid
 JavaScript MIME type.

 Also Maps.MapTesting.Points.Islamabad.WebHome page seems to have error
 when importing (with the "Replace the page history with the history
 from the package" option)
 https://up1.xwikisas.com/#ag8AIsPHgcFYqVod2RMJQQ

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-07 Thread Fawad Ali
Hi all,
Hope you all are doing wonderfully.

We still have the issue for the facets rendering but its up on the forum,
so I think we will have some fixes for it in due time (thanks to Stephane).
In the meantime, I will try making the facets more specific to the map. For
now I am considering the following options for facets:
- Tags
- Search field (searches inside map item pages)
- Map item type (PointClass for now)
- Map item icon (?)
- Map item space
I will need some suggestions on which other options should be included.

Next, I will
-  Be working on making a dedicated space for popups inside or besides the
map. Something similar to https://abc.gogocarto.fr
- Make use of theme styles and colors for the map itself and the items
inside
- Be making the query search asynchronous

Also, I will be working part time for the next week and I have exams the
week after that. So I would like to let you know that I would not be
available for the exams period for the most part. :(
I will try to finish most of the work and get the application in a stable
state by then. :)
Ecaterina also mentioned that we release the application, I propose we do
that next week as soon as the facets are in a stable state.

Thanks,
Fawad


On Thu, Jun 6, 2019 at 6:42 PM Ecaterina Moraru (Valica) 
wrote:

> That most likely is the problem, since I've just imported the XAR, no real
> install. I will try like that, thanks for helping.
>
> Caty
>
> On Thu, Jun 6, 2019 at 1:03 PM Fawad Ali  wrote:
>
>> Hi Caty,
>>
>> The last thing to be wary of is to have the Leaflet dependency installed.
>> If I remove my Leaflet webjar, I get this set of errors.
>>
>> GET
>> http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.css
>> net::ERR_ABORTED 404 (Not Found)
>> require.min.js?r=1:34 GET
>> http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1
>> net::ERR_ABORTED 404 (Not Found)
>> require.min.js?r=1:7 Uncaught Error: Script error for "leaflet", needed
>> by: leafletSearch
>> http://requirejs.org/docs/errors.html#scripterror
>> at F (require.min.js?r=1:7)
>> at HTMLScriptElement.onScriptError (require.min.js?r=1:30)
>>
>> I think Its the same problem your side.
>> For installing Leaflet, search for Map Macro in extensions, from its
>> dependencies tab in details go to Leaflet and install it.
>> That ought to work. :)
>>
>> Best,
>> Fawad
>>
>>
>> On Thu, Jun 6, 2019 at 2:24 PM Ecaterina Moraru (Valica) <
>> vali...@gmail.com> wrote:
>>
>>> Hi Fawad,
>>>
>>> I still have the issue: no maps loaded, leaflet.css error in console.
>>> Tested with the most recent snapshot of 11.5 and with the build from
>>> https://github.com/xwiki-contrib/application-interactive-maps
>>> I have the same problem with Firefox, Chrome, Safari and Opera. I'm on
>>> Mac.
>>> https://up1.xwikisas.com/#mXONZtF2qcMeftvnyJOSjw
>>> The script from “
>>> http://localhost:8084/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1”
>>> was loaded even though its MIME type (“text/html”) is not a valid
>>> JavaScript MIME type.
>>>
>>> Also Maps.MapTesting.Points.Islamabad.WebHome page seems to have error
>>> when importing (with the "Replace the page history with the history
>>> from the package" option)
>>> https://up1.xwikisas.com/#ag8AIsPHgcFYqVod2RMJQQ
>>>
>>> Thanks,
>>> Caty
>>>
>>>
>>> On Wed, Jun 5, 2019 at 8:50 PM Fawad Ali 
>>> wrote:
>>>
 I just built and imported the application from my own repo (
 https://github.com/9inpachi/interactive-maps-new) and everything seems
 fine.

 There was that error in the more earlier builds but it was fixed, may
 be some of the source files (especially Leaflet.xml) are old?
 Try building the source files anew with "mvn clean install". May be
 that will help.

 Thanks,
 Fawad

 On Wed, Jun 5, 2019, 10:37 PM Fawad Ali >>>
> We have shifted the repo to xwiki-contrib again. You may try that. I
> will also check my own repo for any errors ASAP.
>
> Best,
> Fawad
>
> On Wed, Jun 5, 2019, 10:35 PM Ecaterina Moraru (Valica) <
> vali...@gmail.com wrote:
>
>> I've used the latest build from
>> https://github.com/9inpachi/interactive-maps-new
>> and I have the error both on 11.4-rc-1 and some 11.4-snapshot.
>>
>> Thanks,
>> Caty
>>
>> On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali 
>> wrote:
>>
>>> Hi,
>>>
>>> Caty, do you have the error with the latest git repo as well?
>>> Actually the leaflet-commons require leaflet but the functions are
>>> not actually called anywhere without the leaflet dependency used in 
>>> require.
>>>
>>> There is no error on my or Stephane side.
>>> I have the 11.3-rc version of XWiki.
>>> You can try Ctrl+F5 for a complete new load of the resources.
>>>
>>> Best,
>>> Fawad
>>>
>>> On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica) <
>>> vali...@gmail.com wrote:
>>>
 Hi,

>>>

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-06 Thread Ecaterina Moraru (Valica)
That most likely is the problem, since I've just imported the XAR, no real
install. I will try like that, thanks for helping.

Caty

On Thu, Jun 6, 2019 at 1:03 PM Fawad Ali  wrote:

> Hi Caty,
>
> The last thing to be wary of is to have the Leaflet dependency installed.
> If I remove my Leaflet webjar, I get this set of errors.
>
> GET http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.css
> net::ERR_ABORTED 404 (Not Found)
> require.min.js?r=1:34 GET
> http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1
> net::ERR_ABORTED 404 (Not Found)
> require.min.js?r=1:7 Uncaught Error: Script error for "leaflet", needed
> by: leafletSearch
> http://requirejs.org/docs/errors.html#scripterror
> at F (require.min.js?r=1:7)
> at HTMLScriptElement.onScriptError (require.min.js?r=1:30)
>
> I think Its the same problem your side.
> For installing Leaflet, search for Map Macro in extensions, from its
> dependencies tab in details go to Leaflet and install it.
> That ought to work. :)
>
> Best,
> Fawad
>
>
> On Thu, Jun 6, 2019 at 2:24 PM Ecaterina Moraru (Valica) <
> vali...@gmail.com> wrote:
>
>> Hi Fawad,
>>
>> I still have the issue: no maps loaded, leaflet.css error in console.
>> Tested with the most recent snapshot of 11.5 and with the build from
>> https://github.com/xwiki-contrib/application-interactive-maps
>> I have the same problem with Firefox, Chrome, Safari and Opera. I'm on
>> Mac.
>> https://up1.xwikisas.com/#mXONZtF2qcMeftvnyJOSjw
>> The script from “
>> http://localhost:8084/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1”
>> was loaded even though its MIME type (“text/html”) is not a valid
>> JavaScript MIME type.
>>
>> Also Maps.MapTesting.Points.Islamabad.WebHome page seems to have error
>> when importing (with the "Replace the page history with the history from
>> the package" option) https://up1.xwikisas.com/#ag8AIsPHgcFYqVod2RMJQQ
>>
>> Thanks,
>> Caty
>>
>>
>> On Wed, Jun 5, 2019 at 8:50 PM Fawad Ali  wrote:
>>
>>> I just built and imported the application from my own repo (
>>> https://github.com/9inpachi/interactive-maps-new) and everything seems
>>> fine.
>>>
>>> There was that error in the more earlier builds but it was fixed, may be
>>> some of the source files (especially Leaflet.xml) are old?
>>> Try building the source files anew with "mvn clean install". May be that
>>> will help.
>>>
>>> Thanks,
>>> Fawad
>>>
>>> On Wed, Jun 5, 2019, 10:37 PM Fawad Ali >>
 We have shifted the repo to xwiki-contrib again. You may try that. I
 will also check my own repo for any errors ASAP.

 Best,
 Fawad

 On Wed, Jun 5, 2019, 10:35 PM Ecaterina Moraru (Valica) <
 vali...@gmail.com wrote:

> I've used the latest build from
> https://github.com/9inpachi/interactive-maps-new
> and I have the error both on 11.4-rc-1 and some 11.4-snapshot.
>
> Thanks,
> Caty
>
> On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali 
> wrote:
>
>> Hi,
>>
>> Caty, do you have the error with the latest git repo as well?
>> Actually the leaflet-commons require leaflet but the functions are
>> not actually called anywhere without the leaflet dependency used in 
>> require.
>>
>> There is no error on my or Stephane side.
>> I have the 11.3-rc version of XWiki.
>> You can try Ctrl+F5 for a complete new load of the resources.
>>
>> Best,
>> Fawad
>>
>> On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica) <
>> vali...@gmail.com wrote:
>>
>>> Hi,
>>>
>>> Some notes:
>>> - We don't have guidelines regarding the singular / plural thing.
>>> I'm glad that on the new sources we don't have the Maps/Map anymore. I'm
>>> fine with Maps. In practice we have a mix of singular (like Diagram,
>>> Calendar, Meeting) and plural (like Ideas, Forums). I prefer the plural
>>> version, although in practice I think we have more with singular. There 
>>> was
>>> a tentative old draft for having such guidelines
>>> https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines
>>> but we didn't worked on it for some time.
>>>
>>> - Regarding the new Git repository. Since you've committed the
>>> initial commits in issues, you should do a release with the initial
>>> version, and than just release a new version for the 
>>> interactive-maps-new .
>>> It's normal in an application's development flow that changes happen,
>>> that's why versioning schemes are all about.
>>>
>>> - I still have the error I've mentioned before :
>>> Uncaught Error: Script error for "leaflet", needed by: leafletSearch
>>> http://requirejs.org/docs/errors.html#scripterror
>>> at F (require.min.js?r=1:7)
>>> at HTMLScriptElement.onScriptError (require.min.js?r=1:30)
>>>
>>> leaflet.css:1 Failed to load resource: the server responded with a
>>> status of 404 (Not Found)
>>

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-06 Thread Fawad Ali
Hi Caty,

The last thing to be wary of is to have the Leaflet dependency installed.
If I remove my Leaflet webjar, I get this set of errors.

GET http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.css
net::ERR_ABORTED 404 (Not Found)
require.min.js?r=1:34 GET
http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1
net::ERR_ABORTED 404 (Not Found)
require.min.js?r=1:7 Uncaught Error: Script error for "leaflet", needed by:
leafletSearch
http://requirejs.org/docs/errors.html#scripterror
at F (require.min.js?r=1:7)
at HTMLScriptElement.onScriptError (require.min.js?r=1:30)

I think Its the same problem your side.
For installing Leaflet, search for Map Macro in extensions, from its
dependencies tab in details go to Leaflet and install it.
That ought to work. :)

Best,
Fawad


On Thu, Jun 6, 2019 at 2:24 PM Ecaterina Moraru (Valica) 
wrote:

> Hi Fawad,
>
> I still have the issue: no maps loaded, leaflet.css error in console.
> Tested with the most recent snapshot of 11.5 and with the build from
> https://github.com/xwiki-contrib/application-interactive-maps
> I have the same problem with Firefox, Chrome, Safari and Opera. I'm on
> Mac.
> https://up1.xwikisas.com/#mXONZtF2qcMeftvnyJOSjw
> The script from “
> http://localhost:8084/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1”
> was loaded even though its MIME type (“text/html”) is not a valid
> JavaScript MIME type.
>
> Also Maps.MapTesting.Points.Islamabad.WebHome page seems to have error
> when importing (with the "Replace the page history with the history from
> the package" option) https://up1.xwikisas.com/#ag8AIsPHgcFYqVod2RMJQQ
>
> Thanks,
> Caty
>
>
> On Wed, Jun 5, 2019 at 8:50 PM Fawad Ali  wrote:
>
>> I just built and imported the application from my own repo (
>> https://github.com/9inpachi/interactive-maps-new) and everything seems
>> fine.
>>
>> There was that error in the more earlier builds but it was fixed, may be
>> some of the source files (especially Leaflet.xml) are old?
>> Try building the source files anew with "mvn clean install". May be that
>> will help.
>>
>> Thanks,
>> Fawad
>>
>> On Wed, Jun 5, 2019, 10:37 PM Fawad Ali >
>>> We have shifted the repo to xwiki-contrib again. You may try that. I
>>> will also check my own repo for any errors ASAP.
>>>
>>> Best,
>>> Fawad
>>>
>>> On Wed, Jun 5, 2019, 10:35 PM Ecaterina Moraru (Valica) <
>>> vali...@gmail.com wrote:
>>>
 I've used the latest build from
 https://github.com/9inpachi/interactive-maps-new
 and I have the error both on 11.4-rc-1 and some 11.4-snapshot.

 Thanks,
 Caty

 On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali 
 wrote:

> Hi,
>
> Caty, do you have the error with the latest git repo as well?
> Actually the leaflet-commons require leaflet but the functions are not
> actually called anywhere without the leaflet dependency used in require.
>
> There is no error on my or Stephane side.
> I have the 11.3-rc version of XWiki.
> You can try Ctrl+F5 for a complete new load of the resources.
>
> Best,
> Fawad
>
> On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica) <
> vali...@gmail.com wrote:
>
>> Hi,
>>
>> Some notes:
>> - We don't have guidelines regarding the singular / plural thing. I'm
>> glad that on the new sources we don't have the Maps/Map anymore. I'm fine
>> with Maps. In practice we have a mix of singular (like Diagram, Calendar,
>> Meeting) and plural (like Ideas, Forums). I prefer the plural version,
>> although in practice I think we have more with singular. There was a
>> tentative old draft for having such guidelines
>> https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines
>> but we didn't worked on it for some time.
>>
>> - Regarding the new Git repository. Since you've committed the
>> initial commits in issues, you should do a release with the initial
>> version, and than just release a new version for the 
>> interactive-maps-new .
>> It's normal in an application's development flow that changes happen,
>> that's why versioning schemes are all about.
>>
>> - I still have the error I've mentioned before :
>> Uncaught Error: Script error for "leaflet", needed by: leafletSearch
>> http://requirejs.org/docs/errors.html#scripterror
>> at F (require.min.js?r=1:7)
>> at HTMLScriptElement.onScriptError (require.min.js?r=1:30)
>>
>> leaflet.css:1 Failed to load resource: the server responded with a
>> status of 404 (Not Found)
>>
>> so I cannot actually test the build, since I don't see the maps. I
>> have this both on Chrome and Firefox. Do I need to do something?
>>
>> Thanks,
>> Caty
>>
>> On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali 
>> wrote:
>>
>>> Also, I forgot to mention it before but we will need a better and
>>> more expressive way to show 

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-06 Thread Ecaterina Moraru (Valica)
Hi Fawad,

I still have the issue: no maps loaded, leaflet.css error in console.
Tested with the most recent snapshot of 11.5 and with the build from
https://github.com/xwiki-contrib/application-interactive-maps
I have the same problem with Firefox, Chrome, Safari and Opera. I'm on Mac.
https://up1.xwikisas.com/#mXONZtF2qcMeftvnyJOSjw
The script from “
http://localhost:8084/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1”
was loaded even though its MIME type (“text/html”) is not a valid
JavaScript MIME type.

Also Maps.MapTesting.Points.Islamabad.WebHome page seems to have error when
importing (with the "Replace the page history with the history from the
package" option) https://up1.xwikisas.com/#ag8AIsPHgcFYqVod2RMJQQ

Thanks,
Caty


On Wed, Jun 5, 2019 at 8:50 PM Fawad Ali  wrote:

> I just built and imported the application from my own repo (
> https://github.com/9inpachi/interactive-maps-new) and everything seems
> fine.
>
> There was that error in the more earlier builds but it was fixed, may be
> some of the source files (especially Leaflet.xml) are old?
> Try building the source files anew with "mvn clean install". May be that
> will help.
>
> Thanks,
> Fawad
>
> On Wed, Jun 5, 2019, 10:37 PM Fawad Ali 
>> We have shifted the repo to xwiki-contrib again. You may try that. I will
>> also check my own repo for any errors ASAP.
>>
>> Best,
>> Fawad
>>
>> On Wed, Jun 5, 2019, 10:35 PM Ecaterina Moraru (Valica) <
>> vali...@gmail.com wrote:
>>
>>> I've used the latest build from
>>> https://github.com/9inpachi/interactive-maps-new
>>> and I have the error both on 11.4-rc-1 and some 11.4-snapshot.
>>>
>>> Thanks,
>>> Caty
>>>
>>> On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali 
>>> wrote:
>>>
 Hi,

 Caty, do you have the error with the latest git repo as well?
 Actually the leaflet-commons require leaflet but the functions are not
 actually called anywhere without the leaflet dependency used in require.

 There is no error on my or Stephane side.
 I have the 11.3-rc version of XWiki.
 You can try Ctrl+F5 for a complete new load of the resources.

 Best,
 Fawad

 On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica) <
 vali...@gmail.com wrote:

> Hi,
>
> Some notes:
> - We don't have guidelines regarding the singular / plural thing. I'm
> glad that on the new sources we don't have the Maps/Map anymore. I'm fine
> with Maps. In practice we have a mix of singular (like Diagram, Calendar,
> Meeting) and plural (like Ideas, Forums). I prefer the plural version,
> although in practice I think we have more with singular. There was a
> tentative old draft for having such guidelines
> https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines
> but we didn't worked on it for some time.
>
> - Regarding the new Git repository. Since you've committed the initial
> commits in issues, you should do a release with the initial version, and
> than just release a new version for the interactive-maps-new . It's normal
> in an application's development flow that changes happen, that's why
> versioning schemes are all about.
>
> - I still have the error I've mentioned before :
> Uncaught Error: Script error for "leaflet", needed by: leafletSearch
> http://requirejs.org/docs/errors.html#scripterror
> at F (require.min.js?r=1:7)
> at HTMLScriptElement.onScriptError (require.min.js?r=1:30)
>
> leaflet.css:1 Failed to load resource: the server responded with a
> status of 404 (Not Found)
>
> so I cannot actually test the build, since I don't see the maps. I
> have this both on Chrome and Firefox. Do I need to do something?
>
> Thanks,
> Caty
>
> On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali 
> wrote:
>
>> Also, I forgot to mention it before but we will need a better and
>> more expressive way to show popups. We need something that can accomodate
>> sufficient amount of text with a scroll if the information exceeds the 
>> page.
>> I will prepare a mockup for this once I am done with some of the next
>> steps.
>>
>> And I think we should use the colortheme colors for our map controls
>> and consequently for the popups. I will update you on that as well.
>>
>> Best,
>> Fawad
>>
>>
>> On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali 
>> wrote:
>>
>>> Hi Stephane, Caty and all,
>>> Hope you are doing fine.
>>>
>>> I am glad you brought up the topic of custom marker icon. I am well
>>> aware of the issue. Actually there are two problems with custom markers.
>>> - The icon offset
>>> - The document attachment
>>>
>>> For the icon offset, when I tried to fix it initially it seemed that
>>> I can overcome the offset either by height or width which means that the
>>> offset still exists from a single side so I had that p

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-05 Thread Fawad Ali
I just built and imported the application from my own repo (
https://github.com/9inpachi/interactive-maps-new) and everything seems fine.

There was that error in the more earlier builds but it was fixed, may be
some of the source files (especially Leaflet.xml) are old?
Try building the source files anew with "mvn clean install". May be that
will help.

Thanks,
Fawad

On Wed, Jun 5, 2019, 10:37 PM Fawad Ali  We have shifted the repo to xwiki-contrib again. You may try that. I will
> also check my own repo for any errors ASAP.
>
> Best,
> Fawad
>
> On Wed, Jun 5, 2019, 10:35 PM Ecaterina Moraru (Valica)  wrote:
>
>> I've used the latest build from
>> https://github.com/9inpachi/interactive-maps-new
>> and I have the error both on 11.4-rc-1 and some 11.4-snapshot.
>>
>> Thanks,
>> Caty
>>
>> On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali  wrote:
>>
>>> Hi,
>>>
>>> Caty, do you have the error with the latest git repo as well?
>>> Actually the leaflet-commons require leaflet but the functions are not
>>> actually called anywhere without the leaflet dependency used in require.
>>>
>>> There is no error on my or Stephane side.
>>> I have the 11.3-rc version of XWiki.
>>> You can try Ctrl+F5 for a complete new load of the resources.
>>>
>>> Best,
>>> Fawad
>>>
>>> On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica) <
>>> vali...@gmail.com wrote:
>>>
 Hi,

 Some notes:
 - We don't have guidelines regarding the singular / plural thing. I'm
 glad that on the new sources we don't have the Maps/Map anymore. I'm fine
 with Maps. In practice we have a mix of singular (like Diagram, Calendar,
 Meeting) and plural (like Ideas, Forums). I prefer the plural version,
 although in practice I think we have more with singular. There was a
 tentative old draft for having such guidelines
 https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines
 but we didn't worked on it for some time.

 - Regarding the new Git repository. Since you've committed the initial
 commits in issues, you should do a release with the initial version, and
 than just release a new version for the interactive-maps-new . It's normal
 in an application's development flow that changes happen, that's why
 versioning schemes are all about.

 - I still have the error I've mentioned before :
 Uncaught Error: Script error for "leaflet", needed by: leafletSearch
 http://requirejs.org/docs/errors.html#scripterror
 at F (require.min.js?r=1:7)
 at HTMLScriptElement.onScriptError (require.min.js?r=1:30)

 leaflet.css:1 Failed to load resource: the server responded with a
 status of 404 (Not Found)

 so I cannot actually test the build, since I don't see the maps. I have
 this both on Chrome and Firefox. Do I need to do something?

 Thanks,
 Caty

 On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali 
 wrote:

> Also, I forgot to mention it before but we will need a better and more
> expressive way to show popups. We need something that can accomodate
> sufficient amount of text with a scroll if the information exceeds the 
> page.
> I will prepare a mockup for this once I am done with some of the next
> steps.
>
> And I think we should use the colortheme colors for our map controls
> and consequently for the popups. I will update you on that as well.
>
> Best,
> Fawad
>
>
> On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali 
> wrote:
>
>> Hi Stephane, Caty and all,
>> Hope you are doing fine.
>>
>> I am glad you brought up the topic of custom marker icon. I am well
>> aware of the issue. Actually there are two problems with custom markers.
>> - The icon offset
>> - The document attachment
>>
>> For the icon offset, when I tried to fix it initially it seemed that
>> I can overcome the offset either by height or width which means that the
>> offset still exists from a single side so I had that postponed since I
>> thought solr query tasks take priority.
>>
>> For the attachment, for now I am getting the first attachment (0th
>> index) from the Point page which is not very reliable. For example if we
>> have images on the page, it could be that the marker takes one of the
>> attachments even if the user did not want a custom icon or an image
>> different from what the user wanted to choose is selected as the marker
>> icon.
>>
>> What I have in mind is that we define categories for marker icons
>> dynamically.
>> We could make a separate dedicated page "MarkerIcons" and attach
>> multiple images to it. Then these images could appear in a list as one of
>> the properties in the Point object where we can choose the icon from. 
>> WDYT?
>>
>> Thanks,
>> Fawad
>>
>> On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière > wrote:
>>
>>> Fawad, 

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-05 Thread Fawad Ali
We have shifted the repo to xwiki-contrib again. You may try that. I will
also check my own repo for any errors ASAP.

Best,
Fawad

On Wed, Jun 5, 2019, 10:35 PM Ecaterina Moraru (Valica)  I've used the latest build from
> https://github.com/9inpachi/interactive-maps-new
> and I have the error both on 11.4-rc-1 and some 11.4-snapshot.
>
> Thanks,
> Caty
>
> On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali  wrote:
>
>> Hi,
>>
>> Caty, do you have the error with the latest git repo as well?
>> Actually the leaflet-commons require leaflet but the functions are not
>> actually called anywhere without the leaflet dependency used in require.
>>
>> There is no error on my or Stephane side.
>> I have the 11.3-rc version of XWiki.
>> You can try Ctrl+F5 for a complete new load of the resources.
>>
>> Best,
>> Fawad
>>
>> On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica) <
>> vali...@gmail.com wrote:
>>
>>> Hi,
>>>
>>> Some notes:
>>> - We don't have guidelines regarding the singular / plural thing. I'm
>>> glad that on the new sources we don't have the Maps/Map anymore. I'm fine
>>> with Maps. In practice we have a mix of singular (like Diagram, Calendar,
>>> Meeting) and plural (like Ideas, Forums). I prefer the plural version,
>>> although in practice I think we have more with singular. There was a
>>> tentative old draft for having such guidelines
>>> https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines
>>> but we didn't worked on it for some time.
>>>
>>> - Regarding the new Git repository. Since you've committed the initial
>>> commits in issues, you should do a release with the initial version, and
>>> than just release a new version for the interactive-maps-new . It's normal
>>> in an application's development flow that changes happen, that's why
>>> versioning schemes are all about.
>>>
>>> - I still have the error I've mentioned before :
>>> Uncaught Error: Script error for "leaflet", needed by: leafletSearch
>>> http://requirejs.org/docs/errors.html#scripterror
>>> at F (require.min.js?r=1:7)
>>> at HTMLScriptElement.onScriptError (require.min.js?r=1:30)
>>>
>>> leaflet.css:1 Failed to load resource: the server responded with a
>>> status of 404 (Not Found)
>>>
>>> so I cannot actually test the build, since I don't see the maps. I have
>>> this both on Chrome and Firefox. Do I need to do something?
>>>
>>> Thanks,
>>> Caty
>>>
>>> On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali 
>>> wrote:
>>>
 Also, I forgot to mention it before but we will need a better and more
 expressive way to show popups. We need something that can accomodate
 sufficient amount of text with a scroll if the information exceeds the 
 page.
 I will prepare a mockup for this once I am done with some of the next
 steps.

 And I think we should use the colortheme colors for our map controls
 and consequently for the popups. I will update you on that as well.

 Best,
 Fawad


 On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali 
 wrote:

> Hi Stephane, Caty and all,
> Hope you are doing fine.
>
> I am glad you brought up the topic of custom marker icon. I am well
> aware of the issue. Actually there are two problems with custom markers.
> - The icon offset
> - The document attachment
>
> For the icon offset, when I tried to fix it initially it seemed that I
> can overcome the offset either by height or width which means that the
> offset still exists from a single side so I had that postponed since I
> thought solr query tasks take priority.
>
> For the attachment, for now I am getting the first attachment (0th
> index) from the Point page which is not very reliable. For example if we
> have images on the page, it could be that the marker takes one of the
> attachments even if the user did not want a custom icon or an image
> different from what the user wanted to choose is selected as the marker
> icon.
>
> What I have in mind is that we define categories for marker icons
> dynamically.
> We could make a separate dedicated page "MarkerIcons" and attach
> multiple images to it. Then these images could appear in a list as one of
> the properties in the Point object where we can choose the icon from. 
> WDYT?
>
> Thanks,
> Fawad
>
> On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière  wrote:
>
>> Fawad, Thanks for letting us know, I could install the new app
>> version, I confirm that all the changes you added to the progress file
>> (very handy) work for me, and the refactoring is ok. I noticed a minor
>> issue that you're certainly aware of already: it seems there's a small
>> offset between the custom marker position (with the Islamabad point) and
>> the popup position.
>>
>> Talk to you soon,
>>
>> Stéphane
>>
>>
>> Fawad Ali:
>> > Hi all,
>> >
>> > Thanks for the detailed re

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-05 Thread Ecaterina Moraru (Valica)
I've used the latest build from
https://github.com/9inpachi/interactive-maps-new
and I have the error both on 11.4-rc-1 and some 11.4-snapshot.

Thanks,
Caty

On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali  wrote:

> Hi,
>
> Caty, do you have the error with the latest git repo as well?
> Actually the leaflet-commons require leaflet but the functions are not
> actually called anywhere without the leaflet dependency used in require.
>
> There is no error on my or Stephane side.
> I have the 11.3-rc version of XWiki.
> You can try Ctrl+F5 for a complete new load of the resources.
>
> Best,
> Fawad
>
> On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica)  wrote:
>
>> Hi,
>>
>> Some notes:
>> - We don't have guidelines regarding the singular / plural thing. I'm
>> glad that on the new sources we don't have the Maps/Map anymore. I'm fine
>> with Maps. In practice we have a mix of singular (like Diagram, Calendar,
>> Meeting) and plural (like Ideas, Forums). I prefer the plural version,
>> although in practice I think we have more with singular. There was a
>> tentative old draft for having such guidelines
>> https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines
>> but we didn't worked on it for some time.
>>
>> - Regarding the new Git repository. Since you've committed the initial
>> commits in issues, you should do a release with the initial version, and
>> than just release a new version for the interactive-maps-new . It's normal
>> in an application's development flow that changes happen, that's why
>> versioning schemes are all about.
>>
>> - I still have the error I've mentioned before :
>> Uncaught Error: Script error for "leaflet", needed by: leafletSearch
>> http://requirejs.org/docs/errors.html#scripterror
>> at F (require.min.js?r=1:7)
>> at HTMLScriptElement.onScriptError (require.min.js?r=1:30)
>>
>> leaflet.css:1 Failed to load resource: the server responded with a status
>> of 404 (Not Found)
>>
>> so I cannot actually test the build, since I don't see the maps. I have
>> this both on Chrome and Firefox. Do I need to do something?
>>
>> Thanks,
>> Caty
>>
>> On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali  wrote:
>>
>>> Also, I forgot to mention it before but we will need a better and more
>>> expressive way to show popups. We need something that can accomodate
>>> sufficient amount of text with a scroll if the information exceeds the page.
>>> I will prepare a mockup for this once I am done with some of the next
>>> steps.
>>>
>>> And I think we should use the colortheme colors for our map controls and
>>> consequently for the popups. I will update you on that as well.
>>>
>>> Best,
>>> Fawad
>>>
>>>
>>> On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali 
>>> wrote:
>>>
 Hi Stephane, Caty and all,
 Hope you are doing fine.

 I am glad you brought up the topic of custom marker icon. I am well
 aware of the issue. Actually there are two problems with custom markers.
 - The icon offset
 - The document attachment

 For the icon offset, when I tried to fix it initially it seemed that I
 can overcome the offset either by height or width which means that the
 offset still exists from a single side so I had that postponed since I
 thought solr query tasks take priority.

 For the attachment, for now I am getting the first attachment (0th
 index) from the Point page which is not very reliable. For example if we
 have images on the page, it could be that the marker takes one of the
 attachments even if the user did not want a custom icon or an image
 different from what the user wanted to choose is selected as the marker
 icon.

 What I have in mind is that we define categories for marker icons
 dynamically.
 We could make a separate dedicated page "MarkerIcons" and attach
 multiple images to it. Then these images could appear in a list as one of
 the properties in the Point object where we can choose the icon from. WDYT?

 Thanks,
 Fawad

 On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière >>> wrote:

> Fawad, Thanks for letting us know, I could install the new app
> version, I confirm that all the changes you added to the progress file
> (very handy) work for me, and the refactoring is ok. I noticed a minor
> issue that you're certainly aware of already: it seems there's a small
> offset between the custom marker position (with the Islamabad point) and
> the popup position.
>
> Talk to you soon,
>
> Stéphane
>
>
> Fawad Ali:
> > Hi all,
> >
> > Thanks for the detailed review, Stephane. I have made the changes
> you suggested with some next steps also done.
> >
> > Furthermore, I will make changes to the application space once we
> have confirmed response from Caty or other developers.
> > I have started to work on the other next steps and will provide with
> updates soon.
> >
> > The ori

Re: [xwiki-devs] Map Application - GSoC 19

2019-06-05 Thread Fawad Ali
Hi,

Caty, do you have the error with the latest git repo as well?
Actually the leaflet-commons require leaflet but the functions are not
actually called anywhere without the leaflet dependency used in require.

There is no error on my or Stephane side.
I have the 11.3-rc version of XWiki.
You can try Ctrl+F5 for a complete new load of the resources.

Best,
Fawad

On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica)  Hi,
>
> Some notes:
> - We don't have guidelines regarding the singular / plural thing. I'm glad
> that on the new sources we don't have the Maps/Map anymore. I'm fine with
> Maps. In practice we have a mix of singular (like Diagram, Calendar,
> Meeting) and plural (like Ideas, Forums). I prefer the plural version,
> although in practice I think we have more with singular. There was a
> tentative old draft for having such guidelines
> https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines
> but we didn't worked on it for some time.
>
> - Regarding the new Git repository. Since you've committed the initial
> commits in issues, you should do a release with the initial version, and
> than just release a new version for the interactive-maps-new . It's normal
> in an application's development flow that changes happen, that's why
> versioning schemes are all about.
>
> - I still have the error I've mentioned before :
> Uncaught Error: Script error for "leaflet", needed by: leafletSearch
> http://requirejs.org/docs/errors.html#scripterror
> at F (require.min.js?r=1:7)
> at HTMLScriptElement.onScriptError (require.min.js?r=1:30)
>
> leaflet.css:1 Failed to load resource: the server responded with a status
> of 404 (Not Found)
>
> so I cannot actually test the build, since I don't see the maps. I have
> this both on Chrome and Firefox. Do I need to do something?
>
> Thanks,
> Caty
>
> On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali  wrote:
>
>> Also, I forgot to mention it before but we will need a better and more
>> expressive way to show popups. We need something that can accomodate
>> sufficient amount of text with a scroll if the information exceeds the page.
>> I will prepare a mockup for this once I am done with some of the next
>> steps.
>>
>> And I think we should use the colortheme colors for our map controls and
>> consequently for the popups. I will update you on that as well.
>>
>> Best,
>> Fawad
>>
>>
>> On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali  wrote:
>>
>>> Hi Stephane, Caty and all,
>>> Hope you are doing fine.
>>>
>>> I am glad you brought up the topic of custom marker icon. I am well
>>> aware of the issue. Actually there are two problems with custom markers.
>>> - The icon offset
>>> - The document attachment
>>>
>>> For the icon offset, when I tried to fix it initially it seemed that I
>>> can overcome the offset either by height or width which means that the
>>> offset still exists from a single side so I had that postponed since I
>>> thought solr query tasks take priority.
>>>
>>> For the attachment, for now I am getting the first attachment (0th
>>> index) from the Point page which is not very reliable. For example if we
>>> have images on the page, it could be that the marker takes one of the
>>> attachments even if the user did not want a custom icon or an image
>>> different from what the user wanted to choose is selected as the marker
>>> icon.
>>>
>>> What I have in mind is that we define categories for marker icons
>>> dynamically.
>>> We could make a separate dedicated page "MarkerIcons" and attach
>>> multiple images to it. Then these images could appear in a list as one of
>>> the properties in the Point object where we can choose the icon from. WDYT?
>>>
>>> Thanks,
>>> Fawad
>>>
>>> On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière >> wrote:
>>>
 Fawad, Thanks for letting us know, I could install the new app version,
 I confirm that all the changes you added to the progress file (very handy)
 work for me, and the refactoring is ok. I noticed a minor issue that you're
 certainly aware of already: it seems there's a small offset between the
 custom marker position (with the Islamabad point) and the popup position.

 Talk to you soon,

 Stéphane


 Fawad Ali:
 > Hi all,
 >
 > Thanks for the detailed review, Stephane. I have made the changes you
 suggested with some next steps also done.
 >
 > Furthermore, I will make changes to the application space once we
 have confirmed response from Caty or other developers.
 > I have started to work on the other next steps and will provide with
 updates soon.
 >
 > The original github repo is also updated, so future updates will be
 available at
 https://github.com/xwiki-contrib/application-interactive-maps.
 >
 > Thanks,
 > Fawad


 --
 Stéphane Laurière
 XWiki – https://xwiki.com





Re: [xwiki-devs] Map Application - GSoC 19

2019-06-05 Thread Ecaterina Moraru (Valica)
Hi,

Some notes:
- We don't have guidelines regarding the singular / plural thing. I'm glad
that on the new sources we don't have the Maps/Map anymore. I'm fine with
Maps. In practice we have a mix of singular (like Diagram, Calendar,
Meeting) and plural (like Ideas, Forums). I prefer the plural version,
although in practice I think we have more with singular. There was a
tentative old draft for having such guidelines
https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines  but
we didn't worked on it for some time.

- Regarding the new Git repository. Since you've committed the initial
commits in issues, you should do a release with the initial version, and
than just release a new version for the interactive-maps-new . It's normal
in an application's development flow that changes happen, that's why
versioning schemes are all about.

- I still have the error I've mentioned before :
Uncaught Error: Script error for "leaflet", needed by: leafletSearch
http://requirejs.org/docs/errors.html#scripterror
at F (require.min.js?r=1:7)
at HTMLScriptElement.onScriptError (require.min.js?r=1:30)

leaflet.css:1 Failed to load resource: the server responded with a status
of 404 (Not Found)

so I cannot actually test the build, since I don't see the maps. I have
this both on Chrome and Firefox. Do I need to do something?

Thanks,
Caty

On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali  wrote:

> Also, I forgot to mention it before but we will need a better and more
> expressive way to show popups. We need something that can accomodate
> sufficient amount of text with a scroll if the information exceeds the page.
> I will prepare a mockup for this once I am done with some of the next
> steps.
>
> And I think we should use the colortheme colors for our map controls and
> consequently for the popups. I will update you on that as well.
>
> Best,
> Fawad
>
>
> On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali  wrote:
>
>> Hi Stephane, Caty and all,
>> Hope you are doing fine.
>>
>> I am glad you brought up the topic of custom marker icon. I am well aware
>> of the issue. Actually there are two problems with custom markers.
>> - The icon offset
>> - The document attachment
>>
>> For the icon offset, when I tried to fix it initially it seemed that I
>> can overcome the offset either by height or width which means that the
>> offset still exists from a single side so I had that postponed since I
>> thought solr query tasks take priority.
>>
>> For the attachment, for now I am getting the first attachment (0th index)
>> from the Point page which is not very reliable. For example if we have
>> images on the page, it could be that the marker takes one of the
>> attachments even if the user did not want a custom icon or an image
>> different from what the user wanted to choose is selected as the marker
>> icon.
>>
>> What I have in mind is that we define categories for marker icons
>> dynamically.
>> We could make a separate dedicated page "MarkerIcons" and attach multiple
>> images to it. Then these images could appear in a list as one of the
>> properties in the Point object where we can choose the icon from. WDYT?
>>
>> Thanks,
>> Fawad
>>
>> On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière > wrote:
>>
>>> Fawad, Thanks for letting us know, I could install the new app version,
>>> I confirm that all the changes you added to the progress file (very handy)
>>> work for me, and the refactoring is ok. I noticed a minor issue that you're
>>> certainly aware of already: it seems there's a small offset between the
>>> custom marker position (with the Islamabad point) and the popup position.
>>>
>>> Talk to you soon,
>>>
>>> Stéphane
>>>
>>>
>>> Fawad Ali:
>>> > Hi all,
>>> >
>>> > Thanks for the detailed review, Stephane. I have made the changes you
>>> suggested with some next steps also done.
>>> >
>>> > Furthermore, I will make changes to the application space once we have
>>> confirmed response from Caty or other developers.
>>> > I have started to work on the other next steps and will provide with
>>> updates soon.
>>> >
>>> > The original github repo is also updated, so future updates will be
>>> available at
>>> https://github.com/xwiki-contrib/application-interactive-maps.
>>> >
>>> > Thanks,
>>> > Fawad
>>>
>>>
>>> --
>>> Stéphane Laurière
>>> XWiki – https://xwiki.com
>>>
>>>
>>>


Re: [xwiki-devs] Map Application - GSoC 19

2019-06-04 Thread Fawad Ali
Also, I forgot to mention it before but we will need a better and more
expressive way to show popups. We need something that can accomodate
sufficient amount of text with a scroll if the information exceeds the page.
I will prepare a mockup for this once I am done with some of the next steps.

And I think we should use the colortheme colors for our map controls and
consequently for the popups. I will update you on that as well.

Best,
Fawad


On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali  wrote:

> Hi Stephane, Caty and all,
> Hope you are doing fine.
>
> I am glad you brought up the topic of custom marker icon. I am well aware
> of the issue. Actually there are two problems with custom markers.
> - The icon offset
> - The document attachment
>
> For the icon offset, when I tried to fix it initially it seemed that I can
> overcome the offset either by height or width which means that the offset
> still exists from a single side so I had that postponed since I thought
> solr query tasks take priority.
>
> For the attachment, for now I am getting the first attachment (0th index)
> from the Point page which is not very reliable. For example if we have
> images on the page, it could be that the marker takes one of the
> attachments even if the user did not want a custom icon or an image
> different from what the user wanted to choose is selected as the marker
> icon.
>
> What I have in mind is that we define categories for marker icons
> dynamically.
> We could make a separate dedicated page "MarkerIcons" and attach multiple
> images to it. Then these images could appear in a list as one of the
> properties in the Point object where we can choose the icon from. WDYT?
>
> Thanks,
> Fawad
>
> On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière  wrote:
>
>> Fawad, Thanks for letting us know, I could install the new app version, I
>> confirm that all the changes you added to the progress file (very handy)
>> work for me, and the refactoring is ok. I noticed a minor issue that you're
>> certainly aware of already: it seems there's a small offset between the
>> custom marker position (with the Islamabad point) and the popup position.
>>
>> Talk to you soon,
>>
>> Stéphane
>>
>>
>> Fawad Ali:
>> > Hi all,
>> >
>> > Thanks for the detailed review, Stephane. I have made the changes you
>> suggested with some next steps also done.
>> >
>> > Furthermore, I will make changes to the application space once we have
>> confirmed response from Caty or other developers.
>> > I have started to work on the other next steps and will provide with
>> updates soon.
>> >
>> > The original github repo is also updated, so future updates will be
>> available at
>> https://github.com/xwiki-contrib/application-interactive-maps.
>> >
>> > Thanks,
>> > Fawad
>>
>>
>> --
>> Stéphane Laurière
>> XWiki – https://xwiki.com
>>
>>
>>


  1   2   >