[Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2010-03-17 Thread Lars Helge Øverland
** Changed in: dhis2 Status: Triaged = Fix Committed -- Date text field needs validation rule in data entry screen https://bugs.launchpad.net/bugs/430657 You received this bug notification because you are a member of DHIS 2 developers, which is subscribed to DHIS. Status in DHIS 2 -

[Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2010-03-11 Thread Thu Tran
** Changed in: dhis2 Status: Confirmed = Fix Committed -- Date text field needs validation rule in data entry screen https://bugs.launchpad.net/bugs/430657 You received this bug notification because you are a member of DHIS 2 developers, which is subscribed to DHIS. Status in DHIS 2 -

[Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2010-03-11 Thread Lars Helge Øverland
** Changed in: dhis2 Status: Fix Committed = Triaged -- Date text field needs validation rule in data entry screen https://bugs.launchpad.net/bugs/430657 You received this bug notification because you are a member of DHIS 2 developers, which is subscribed to DHIS. Status in DHIS 2 -

[Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2010-03-10 Thread Lars Helge Øverland
** Changed in: dhis2 Assignee: Lars Helge Øverland (larshelge) = Thu Tran (tran-hispvietnam) -- Date text field needs validation rule in data entry screen https://bugs.launchpad.net/bugs/430657 You received this bug notification because you are a member of DHIS 2 developers, which is

Re: [Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-12-23 Thread Bob Jolliffe
2009/12/23 Lars Helge Øverland larshe...@gmail.com On Wed, Dec 23, 2009 at 4:01 AM, Hieu Dang Duy hieu.hispviet...@gmail.com wrote: Dear Saptarshi, I'm not good at about security, I also knew that using javascript it's really not safe in web application. By the way, I have a small idea

Re: [Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-12-23 Thread Jason Pickering
Well, usually this would be the case, that there would be validation at the database level, but given the database agnostic nature of DHIS, I have no idea how or if this can be done. I would think that the period -MM-YY value should actually be stored as a real date type. Currently, I think

Re: [Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-12-23 Thread Viet Nguyen
Hi, I don't think a validation in model layer is a good idea. Because a validator have to throw back to the view layer the error messages. If we validate at model layer, then for validating, a parameter have to go from view layer, through the controller to the model layer. Then if there would be

Re: [Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-12-23 Thread Saptarshi Purkayastha
It's an well accepted pattern in data driven application (like ours), validation should be done ideally at the model layer... and when I raised the point of not doing it in JavaScript, I meant not doing that as default. By default doing the validation in model layer and then second for better UI,

Re: [Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-12-23 Thread Lars Helge Øverland
On Wed, Dec 23, 2009 at 5:42 PM, Bob Jolliffe bobjolli...@gmail.com wrote: As always there is not a single right and wrong answer here. There are some things (usually different things) that might need to be validated at different levels of the application. But things which might make a mess

Re: [Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-12-23 Thread Viet Nguyen
Hi, As always there is not a single right and wrong answer here. There are some things (usually different things) that might need to be validated at different levels of the application. But things which might make a mess of the model should be validated by the model (or the service layer as I

Re: [Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-12-23 Thread Viet Nguyen
Hi Saptarshi, It's an well accepted pattern in data driven application (like ours), validation should be done ideally at the model layer... and when I raised the point of not doing it in JavaScript, I meant not doing that as default. By default doing the validation in model layer and then

Re: [Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-12-22 Thread Saptarshi Purkayastha
I dont think it is good to validate through javascript unless it is a very simple thing and not really data saving related. In DHIS2, we have this clientside validation without any server validation. The STQC guys have found only few, but as a pattern we lack that in our design. Im sure the

Re: [Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-12-22 Thread Lars Helge Øverland
On Wed, Dec 23, 2009 at 4:01 AM, Hieu Dang Duy hieu.hispviet...@gmail.comwrote: Dear Saptarshi, I'm not good at about security, I also knew that using javascript it's really not safe in web application. By the way, I have a small idea about this issue that. Not surely, have any

[Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-11-28 Thread Lars Helge Øverland
** Changed in: dhis2 Assignee: (unassigned) = Lars Helge Øverland (larshelge) -- Date text field needs validation rule in data entry screen https://bugs.launchpad.net/bugs/430657 You received this bug notification because you are a member of DHIS 2 developers, which is subscribed to DHIS.

[Dhis2-devs] [Bug 430657] Re: Date text field needs validation rule in data entry screen

2009-11-27 Thread Lars Helge Øverland
** Summary changed: - Date text field needs validation rule in form area or data entry screen + Date text field needs validation rule in data entry screen -- Date text field needs validation rule in data entry screen https://bugs.launchpad.net/bugs/430657 You received this bug notification