Re: [Dhis2-devs-core] Paging total being wrong on empty result?

2015-01-16 Thread Bob Jolliffe
Not really (I don't think). That commit was related to pageSize to prevent the while loop immediately below entering into an infinite cycle. The current behaviour of the pager in the xample you give seems semantically correct to me. The pager has returned a page. And only 1 amongst 1. There

Re: [Dhis2-devs-core] Paging total being wrong on empty result?

2015-01-16 Thread Mark Polak
I agree with you Bob except that the “total” represents the number of results in the resultset. Which is 0 in this case and therefore that is incorrect. The page and pageCount are different depending on how you define a “page”. But i agree with your view on that matter. Kind regards, Mark

Re: [Dhis2-devs-core] Paging total being wrong on empty result?

2015-01-16 Thread Bob Jolliffe
I agree with you too Mark. The total should be zero. Morten does this total equate to the pageSize in that page count calculation loop? In which case we shouldn't set it to 1, but just not enter the loop at all. On 16 January 2015 at 12:53, Mark Polak mar...@ifi.uio.no wrote: I agree with

Re: [Dhis2-devs-core] Paging total being wrong on empty result?

2015-01-16 Thread Morten Olav Hansen
Yes, setting it to 0 will have this effect On Fri Jan 16 2015 at 11:31:53 AM Morten Olav Hansen morte...@gmail.com wrote: Hi Mark I think it has been like this since the first time we introduced the pager element.. I agree its a bit weird Total should be 0 of course, do we still want to

Re: [Dhis2-devs-core] Paging total being wrong on empty result?

2015-01-16 Thread Morten Olav Hansen
This should be fixed now On Fri Jan 16 2015 at 7:56:45 PM Bob Jolliffe bobjolli...@gmail.com wrote: I agree with you too Mark. The total should be zero. Morten does this total equate to the pageSize in that page count calculation loop? In which case we shouldn't set it to 1, but just not

Re: [Dhis2-devs-core] Paging total being wrong on empty result?

2015-01-15 Thread Morten Olav Hansen
Hi Mark I think it has been like this since the first time we introduced the pager element.. I agree its a bit weird Total should be 0 of course, do we still want to see pageCount = 1 ? even if there is no results? or would that be pagecount = 0 ? On Thu Jan 15 2015 at 10:44:43 PM Mark Polak