Re: Formal review of dtoh

2015-03-24 Thread Adam D. Ruppe via Digitalmars-d
On Thursday, 19 March 2015 at 11:51:59 UTC, John Colvin wrote: Adam, have you considered sprucing this up for review? Not possible right now, my schedule is already overloaded (I'm working two full-time jobs in addition to a variety of little things). I'm also not really up with all the

Re: Formal review of dtoh

2015-03-24 Thread John Colvin via Digitalmars-d
On Tuesday, 24 March 2015 at 18:48:11 UTC, Adam D. Ruppe wrote: On Thursday, 19 March 2015 at 11:51:59 UTC, John Colvin wrote: Adam, have you considered sprucing this up for review? Not possible right now, my schedule is already overloaded (I'm working two full-time jobs in addition to a

Re: Formal review of dtoh

2015-03-19 Thread John Colvin via Digitalmars-d
On Tuesday, 25 March 2014 at 20:38:40 UTC, Jacob Carlborg wrote: This is the formal review of Adam D. Ruppe's tool dtoh for inclusion in the tools repository [1]. Dtoh is a tool used to convert D modules to C/C++ headers. This allows to use D libraries in C/C++ code. This review might be a

Re: Formal review of dtoh

2014-04-08 Thread Jacob Carlborg
On 2014-03-25 21:38, Jacob Carlborg wrote: This is the formal review of Adam D. Ruppe's tool dtoh for inclusion in the tools repository [1]. The formal review of dtoh has now ended. I won't continue with voting since this the tool got very few reviews and in general doesn't feel ready

Re: Formal review of dtoh

2014-04-08 Thread Jacob Carlborg
On 2014-03-27 12:27, Dicebot wrote: Right now it does not really look in shape for a formal review. Documentation is missing. Tool itself does not have help output and throws exception on plain ./dtoh call. I see quite a lot of FIXME and idea comments in its source code. Missing internal DDOC

Re: Formal review of dtoh

2014-04-04 Thread Dicebot
On Thursday, 27 March 2014 at 18:28:28 UTC, Dicebot wrote: On Thursday, 27 March 2014 at 13:25:14 UTC, Adam D. Ruppe wrote: That's what I was hoping it could be pulled, with the note that it is super experimental, so maybe people will try to use it and file some bugs as to what really sucks.

Re: Formal review of dtoh

2014-03-27 Thread Dicebot
Right now it does not really look in shape for a formal review. Documentation is missing. Tool itself does not have help output and throws exception on plain ./dtoh call. I see quite a lot of FIXME and idea comments in its source code. Missing internal DDOC comments at least for basic

Re: Formal review of dtoh

2014-03-27 Thread Adam D. Ruppe
On Wednesday, 26 March 2014 at 15:33:47 UTC, Andrea Fontana wrote: Is there any usage example? You make the json with dmd -X yourfile.d yourotherfiles.d Then run the json through the thingy with ./dtoh yourfile.json It'll make .h files for the extern(C) and extern(C++) pieces of the D files

Re: Formal review of dtoh

2014-03-27 Thread Dicebot
On Thursday, 27 March 2014 at 13:25:14 UTC, Adam D. Ruppe wrote: That's what I was hoping it could be pulled, with the note that it is super experimental, so maybe people will try to use it and file some bugs as to what really sucks. The whole approach might need to be abandoned in favor of a

Re: Formal review of dtoh

2014-03-27 Thread Chris Williams
On Tuesday, 25 March 2014 at 20:38:40 UTC, Jacob Carlborg wrote: Code: https://github.com/adamdruppe/tools/blob/dtoh/dtoh.d The author might consider using an associative array of functions to handle the various keywords, rather than switches. I would suggest adding a jsonutils.d or

Re: Formal review of dtoh

2014-03-26 Thread Andrea Fontana
On Tuesday, 25 March 2014 at 20:38:40 UTC, Jacob Carlborg wrote: This is the formal review of Adam D. Ruppe's tool dtoh for inclusion in the tools repository [1]. Dtoh is a tool used to convert D modules to C/C++ headers. This allows to use D libraries in C/C++ code. This review might be a

Re: Formal review of dtoh

2014-03-26 Thread Jacob Carlborg
On 2014-03-26 16:33, Andrea Fontana wrote: At least it shouldn't give error if called without any params but give some info :) Is there any usage example? Not that I have seen. Perhaps we should require some documentation. -- /Jacob Carlborg

Formal review of dtoh

2014-03-25 Thread Jacob Carlborg
See: http://forum.dlang.org/thread/lgspgg$2i8l$1...@digitalmars.com -- /Jacob Carlborg

Formal review of dtoh

2014-03-25 Thread Jacob Carlborg
This is the formal review of Adam D. Ruppe's tool dtoh for inclusion in the tools repository [1]. Dtoh is a tool used to convert D modules to C/C++ headers. This allows to use D libraries in C/C++ code. This review might be a bit special since this is the first time a tool is reviewed.