Re: Phobos addition formal review: std.experimental.allocator

2015-06-22 Thread Andrei Alexandrescu via Digitalmars-d
On 6/21/15 4:47 AM, Dicebot wrote: 6. Usage of ternary is not always clear / justified. In `IAllocator` it is explained and makes sense but there are things like http://erdani.com/d/phobos-prerelease/std_experimental_allocator_bitmapped_block.html (Ternary empty() - Returns true iff no memory is

Re: Phobos addition formal review: std.experimental.allocator

2015-06-22 Thread Andrei Alexandrescu via Digitalmars-d
On 6/13/15 4:16 PM, ZombineDev wrote: On Saturday, 13 June 2015 at 15:48:31 UTC, Andrei Alexandrescu wrote: On 6/13/15 3:14 AM, Dicebot wrote: Andrei, have you considered creating additional std.allocator.impl package and moving actual allocators there? Or, probably, the other way around with

Re: Phobos addition formal review: std.experimental.allocator

2015-06-22 Thread Matthias Bentrup via Digitalmars-d
Can I use these allocators in @nogc code too ?

Re: Phobos addition formal review: std.experimental.allocator

2015-06-22 Thread Andrei Alexandrescu via Digitalmars-d
On 6/21/15 4:47 AM, Dicebot wrote: 1. I have already mentioned that there is neither module structure overview in `package.d` nor actual module structure. This is still the case for http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html Improved:

Re: Phobos addition formal review: std.experimental.allocator

2015-06-21 Thread Dicebot via Digitalmars-d
Ok, as there has not been much attention here in last days, I will put a short summary of my own. In general, I believe this is extremely high quality proposal and Andrei stands up to his reputation. The very design seems to fit with D idiomatics and it may change completely how people think

Re: Phobos addition formal review: std.experimental.allocator

2015-06-21 Thread Andrei Alexandrescu via Digitalmars-d
On 6/21/15 4:47 AM, Dicebot wrote: 1. I have already mentioned that there is neither module structure overview in `package.d` nor actual module structure. This is still the case for http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html 2. `IAllocator` is defined inside

Re: Phobos addition formal review: std.experimental.allocator

2015-06-20 Thread bitwise via Digitalmars-d
asks to let it into Phobos http://wiki.dlang.org/Review/std.experimental.allocator Docs: http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html Code: https://github.com/andralex/phobos/tree/allocator/std/experimental/allocator I think IAllocator, theAllocator and it are really

Re: Phobos addition formal review: std.experimental.allocator

2015-06-19 Thread Dicebot via Digitalmars-d
Bringing back to first page.

Re: Phobos addition formal review: std.experimental.allocator

2015-06-17 Thread Jacob Carlborg via Digitalmars-d
On 2015-06-16 22:29, Andrei Alexandrescu wrote: https://github.com/D-Programming-Language/phobos/commit/319f3297418c515a6d2e52e6e52d0f3f5895f587 changes .it to .instance for all allocators. -- Andrei Awesome, thanks. -- /Jacob Carlborg

Re: Phobos addition formal review: std.experimental.allocator

2015-06-16 Thread Andrei Alexandrescu via Digitalmars-d
On Saturday, 13 June 2015 at 19:08:26 UTC, Jacob Carlborg wrote: On 2015-06-12 13:06, Dicebot wrote: The legendary allocator package by Andrei Alexandrescu has arrived at your doorsteps and kindly asks to let it into Phobos http://wiki.dlang.org/Review/std.experimental.allocator Docs: http

Re: Phobos addition formal review: std.experimental.allocator

2015-06-15 Thread Brian Schott via Digitalmars-d
On Sunday, 14 June 2015 at 22:47:59 UTC, Brian Schott wrote: Not yet, but while looking for one I found that this code triggers an assertion in Region.expand() Running the above code with GCAllocator substituted for NullAllocator causes an InvalidMemoryOperationError after all 100 iterations

Re: Phobos addition formal review: std.experimental.allocator

2015-06-14 Thread Brian Schott via Digitalmars-d
On Sunday, 14 June 2015 at 00:24:51 UTC, Andrei Alexandrescu wrote: So we have: * 1 request to change names; * 3 requests to wank around the directory structure; * 0 of everything else. Sigh. Andrei How about this: AllocatorList.allocate() calls AllocatorList.owns(), but only if you

Re: Phobos addition formal review: std.experimental.allocator

2015-06-14 Thread Andrei Alexandrescu via Digitalmars-d
On 6/14/15 4:00 AM, Brian Schott wrote: On Sunday, 14 June 2015 at 00:24:51 UTC, Andrei Alexandrescu wrote: So we have: * 1 request to change names; * 3 requests to wank around the directory structure; * 0 of everything else. Sigh. Andrei How about this: AllocatorList.allocate() calls

Re: Phobos addition formal review: std.experimental.allocator

2015-06-14 Thread Jacob Carlborg via Digitalmars-d
On 2015-06-14 02:24, Andrei Alexandrescu wrote: * 1 request to change names; * 3 requests to wank around the directory structure; * 0 of everything else. Sigh. These are things that are easy to see right away, without looking deep inside the code. You can interpret this as: 1. Either

Re: Phobos addition formal review: std.experimental.allocator

2015-06-14 Thread Dicebot via Digitalmars-d
On Sunday, 14 June 2015 at 00:24:51 UTC, Andrei Alexandrescu wrote: So we have: * 1 request to change names; * 3 requests to wank around the directory structure; * 0 of everything else. Sigh. That is to be expected and intended for formal Phobos review. Implementation is not of much

Re: Phobos addition formal review: std.experimental.allocator

2015-06-14 Thread HaraldZealot via Digitalmars-d
So we have: * 1 request to change names; * 3 requests to wank around the directory structure; * 0 of everything else. Sigh. Andrei Yesterday I have found an error in documentation and have left a comment about it on github PR. And I only start to read the documentation, so I think there

Re: Phobos addition formal review: std.experimental.allocator

2015-06-14 Thread Andrei Alexandrescu via Digitalmars-d
On 6/13/15 11:49 PM, Dicebot wrote: On Sunday, 14 June 2015 at 00:24:51 UTC, Andrei Alexandrescu wrote: So we have: * 1 request to change names; * 3 requests to wank around the directory structure; * 0 of everything else. Sigh. That is to be expected and intended for formal Phobos review.

Re: Phobos addition formal review: std.experimental.allocator

2015-06-14 Thread Brian Schott via Digitalmars-d
On Sunday, 14 June 2015 at 14:30:00 UTC, Andrei Alexandrescu wrote: Interesting. Do you have a repro for this? Thanks! -- Andrei Not yet, but while looking for one I found that this code triggers an assertion in Region.expand() ``` module test; import std.experimental.allocator; import

Re: Phobos addition formal review: std.experimental.allocator

2015-06-13 Thread Andrei Alexandrescu via Digitalmars-d
On 6/13/15 4:16 PM, ZombineDev wrote: On Saturday, 13 June 2015 at 15:48:31 UTC, Andrei Alexandrescu wrote: On 6/13/15 3:14 AM, Dicebot wrote: Andrei, have you considered creating additional std.allocator.impl package and moving actual allocators there? Or, probably, the other way around with

Re: Phobos addition formal review: std.experimental.allocator

2015-06-13 Thread ZombineDev via Digitalmars-d
On Saturday, 13 June 2015 at 15:48:31 UTC, Andrei Alexandrescu wrote: On 6/13/15 3:14 AM, Dicebot wrote: Andrei, have you considered creating additional std.allocator.impl package and moving actual allocators there? Or, probably, the other way around with std.allocator.core Existing flat

Re: Phobos addition formal review: std.experimental.allocator

2015-06-13 Thread weaselcat via Digitalmars-d
On Sunday, 14 June 2015 at 00:24:51 UTC, Andrei Alexandrescu wrote: On 6/13/15 4:16 PM, ZombineDev wrote: On Saturday, 13 June 2015 at 15:48:31 UTC, Andrei Alexandrescu wrote: On 6/13/15 3:14 AM, Dicebot wrote: Andrei, have you considered creating additional std.allocator.impl package and

Re: Phobos addition formal review: std.experimental.allocator

2015-06-13 Thread Andrei Alexandrescu via Digitalmars-d
On 6/13/15 3:14 AM, Dicebot wrote: Andrei, have you considered creating additional std.allocator.impl package and moving actual allocators there? Or, probably, the other way around with std.allocator.core Existing flat hierarchy does not hint about internal structure in any way. It's good

Re: Phobos addition formal review: std.experimental.allocator

2015-06-13 Thread Dicebot via Digitalmars-d
On Saturday, 13 June 2015 at 15:48:31 UTC, Andrei Alexandrescu wrote: On 6/13/15 3:14 AM, Dicebot wrote: Andrei, have you considered creating additional std.allocator.impl package and moving actual allocators there? Or, probably, the other way around with std.allocator.core Existing flat

Re: Phobos addition formal review: std.experimental.allocator

2015-06-13 Thread Andrei Alexandrescu via Digitalmars-d
On 6/13/15 10:24 AM, Dicebot wrote: On Saturday, 13 June 2015 at 15:48:31 UTC, Andrei Alexandrescu wrote: On 6/13/15 3:14 AM, Dicebot wrote: Andrei, have you considered creating additional std.allocator.impl package and moving actual allocators there? Or, probably, the other way around with

Re: Phobos addition formal review: std.experimental.allocator

2015-06-13 Thread Dicebot via Digitalmars-d
Andrei, have you considered creating additional std.allocator.impl package and moving actual allocators there? Or, probably, the other way around with std.allocator.core Existing flat hierarchy does not hint about internal structure in any way.

Re: Phobos addition formal review: std.experimental.allocator

2015-06-13 Thread Jacob Carlborg via Digitalmars-d
On 2015-06-12 13:06, Dicebot wrote: The legendary allocator package by Andrei Alexandrescu has arrived at your doorsteps and kindly asks to let it into Phobos http://wiki.dlang.org/Review/std.experimental.allocator Docs: http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html

Re: Phobos addition formal review: std.experimental.allocator

2015-06-13 Thread Tofu Ninja via Digitalmars-d
On Saturday, 13 June 2015 at 15:48:31 UTC, Andrei Alexandrescu wrote: On 6/13/15 3:14 AM, Dicebot wrote: Andrei, have you considered creating additional std.allocator.impl package and moving actual allocators there? Or, probably, the other way around with std.allocator.core Existing flat

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Dicebot via Digitalmars-d
Also wanted to apologize for authors of any other Phobos proposals - I did intend to step down from review manager role but this specific package is of huge personal interest to me, thus the exception has been made.

Call for reviewers : std.experimental.allocator

2015-06-12 Thread Dicebot via Digitalmars-d-announce
Formal review process for std.experimental.allocator has started, please check http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Andrea Fontana via Digitalmars-d
On Friday, 12 June 2015 at 11:06:43 UTC, Dicebot wrote: The legendary allocator package by Andrei Alexandrescu has arrived at your doorsteps and kindly asks to let it into Phobos http://wiki.dlang.org/Review/std.experimental.allocator Docs: http://erdani.com/d/phobos-prerelease

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Baz via Digitalmars-d
On Friday, 12 June 2015 at 19:19:55 UTC, Andrei Alexandrescu wrote: On 6/12/15 11:23 AM, Baz wrote: On Friday, 12 June 2015 at 11:09:01 UTC, Dicebot wrote: Small tip for reviewers: there are quite many modules in proposed package but majority is actual allocator implementation. I'd suggest

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Andrei Alexandrescu via Digitalmars-d
On 6/12/15 11:23 AM, Baz wrote: On Friday, 12 June 2015 at 11:09:01 UTC, Dicebot wrote: Small tip for reviewers: there are quite many modules in proposed package but majority is actual allocator implementation. I'd suggest to start investigating sources/documentation starting from

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Andrei Alexandrescu via Digitalmars-d
On 6/12/15 4:07 PM, Tofu Ninja wrote: Are there any plans to have new and delete call out to theAllocator or processAllocator? In the future we may rig things that way. -- Andrei

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Tofu Ninja via Digitalmars-d
On Friday, 12 June 2015 at 15:54:27 UTC, Andrei Alexandrescu wrote: On 6/12/15 8:54 AM, Andrei Alexandrescu wrote: * A dynamicaly-typed layer that allows the user to swap allocators at runtime. This is embodied in IAllocator, CAllocatorImpl, theAllocator, and processAllocator. Forgot to

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Dicebot via Digitalmars-d
Small tip for reviewers: there are quite many modules in proposed package but majority is actual allocator implementation. I'd suggest to start investigating sources/documentation starting from http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html and

Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Dicebot via Digitalmars-d
The legendary allocator package by Andrei Alexandrescu has arrived at your doorsteps and kindly asks to let it into Phobos http://wiki.dlang.org/Review/std.experimental.allocator Docs: http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html Code: https://github.com/andralex

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Andrei Alexandrescu via Digitalmars-d
/std_experimental_allocator.html and http://erdani.com/d/phobos-prerelease/std_experimental_allocator_building_blocks.html while using http://erdani.com/d/phobos-prerelease/std_experimental_allocator_showcase.html as reference for highlight examples. A few more words on that: Think of std.experimental.allocator as a three

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Andrei Alexandrescu via Digitalmars-d
On 6/12/15 8:54 AM, Andrei Alexandrescu wrote: * A dynamicaly-typed layer that allows the user to swap allocators at runtime. This is embodied in IAllocator, CAllocatorImpl, theAllocator, and processAllocator. Forgot to mention - the entry point for this layer is also

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Andrei Alexandrescu via Digitalmars-d
On 6/12/15 7:31 AM, Jacob Carlborg wrote: On 2015-06-12 13:06, Dicebot wrote: The legendary allocator package by Andrei Alexandrescu has arrived at your doorsteps and kindly asks to let it into Phobos http://wiki.dlang.org/Review/std.experimental.allocator Docs: http://erdani.com/d/phobos

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Jacob Carlborg via Digitalmars-d
On 2015-06-12 13:06, Dicebot wrote: The legendary allocator package by Andrei Alexandrescu has arrived at your doorsteps and kindly asks to let it into Phobos http://wiki.dlang.org/Review/std.experimental.allocator Docs: http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html

Re: Phobos addition formal review: std.experimental.allocator

2015-06-12 Thread Baz via Digitalmars-d
On Friday, 12 June 2015 at 11:09:01 UTC, Dicebot wrote: Small tip for reviewers: there are quite many modules in proposed package but majority is actual allocator implementation. I'd suggest to start investigating sources/documentation starting from

<    1   2   3   4