On 1/13/16 12:19 AM, H. S. Teoh via Digitalmars-d wrote:
On Tue, Jan 12, 2016 at 02:03:57PM -0500, Andrei Alexandrescu via Digitalmars-d
wrote:
On 01/12/2016 08:42 AM, Martin Drašar via Digitalmars-d wrote:
Wouldn't it be sufficient to mandate usage of dfmt with proper
settings before
On Wed, Jan 13, 2016 at 07:53:45AM +, Brian Schott via Digitalmars-d wrote:
> On Wednesday, 13 January 2016 at 05:19:36 UTC, H. S. Teoh wrote:
> >There are also some (smaller) examples in std.range, such as in
> >transposed(), where nested arrays are formatted like matrices in
> >order to make
On Wed, Jan 13, 2016 at 08:47:19AM -0500, Andrei Alexandrescu via Digitalmars-d
wrote:
> On 1/13/16 12:19 AM, H. S. Teoh via Digitalmars-d wrote:
> >On Tue, Jan 12, 2016 at 02:03:57PM -0500, Andrei Alexandrescu via
> >Digitalmars-d wrote:
> >>On 01/12/2016 08:42 AM, Martin Drašar via
On Tue, Jan 12, 2016 at 02:03:57PM -0500, Andrei Alexandrescu via Digitalmars-d
wrote:
> On 01/12/2016 08:42 AM, Martin Drašar via Digitalmars-d wrote:
> >Wouldn't it be sufficient to mandate usage of dfmt with proper
> >settings before submitting a PR?
>
> That would suffice at least in the
On Wednesday, 13 January 2016 at 05:19:36 UTC, H. S. Teoh wrote:
There are also some (smaller) examples in std.range, such as in
transposed(), where nested arrays are formatted like matrices
in order
to make it clear what the function is trying to do. I'm almost
certain
dfmt (or any mechanical
Related to https://github.com/D-Programming-Language/dlang.org/pull/1191:
A friend who is in the GNU community told me a while ago they have a
mechanical style checker that people can run against their proposed
patches to make sure the patches have a style consistent with the one
enforced by
Dne 12.1.2016 v 14:34 Andrei Alexandrescu via Digitalmars-d napsal(a):
> Related to https://github.com/D-Programming-Language/dlang.org/pull/1191:
>
> A friend who is in the GNU community told me a while ago they have a
> mechanical style checker that people can run against their proposed
>
On 13/01/16 2:34 AM, Andrei Alexandrescu wrote:
Related to https://github.com/D-Programming-Language/dlang.org/pull/1191:
A friend who is in the GNU community told me a while ago they have a
mechanical style checker that people can run against their proposed
patches to make sure the patches
On Tuesday, 12 January 2016 at 13:34:25 UTC, Andrei Alexandrescu
wrote:
[...]
I realize that dfmt may need some upgrades first, but isn't it
about time to just suck it up and dfmt the whole of phobos and
druntime?
It will mess with the "git blame", true - but it will do so
*once* and end
On Tuesday, 12 January 2016 at 21:04:33 UTC, Jacob Carlborg wrote:
On 2016-01-12 15:53, Adam D. Ruppe wrote:
I'm not sure if git supports this but I think it should be
done fully
automatically. Not even something the user runs, just when
they open the
pull request, it reformats the code.
On 2016-01-12 15:53, Adam D. Ruppe wrote:
I'm not sure if git supports this but I think it should be done fully
automatically. Not even something the user runs, just when they open the
pull request, it reformats the code.
The hook/tool would need to do a commit with the changes. How would
On Tuesday, 12 January 2016 at 13:34:25 UTC, Andrei Alexandrescu
wrote:
Related to
https://github.com/D-Programming-Language/dlang.org/pull/1191:
A friend who is in the GNU community told me a while ago they
have a mechanical style checker that people can run against
their proposed patches
On Tuesday, 12 January 2016 at 13:34:25 UTC, Andrei Alexandrescu
wrote:
Similarly, I think it would help us to release a tool in the
tools/ repo that analyzes a would-be Phobos pull request and
ensures it's styled the same way as most of Phobos
I'm not sure if git supports this but I think
On Tuesday, 12 January 2016 at 18:25:48 UTC, tsbockman wrote:
On Tuesday, 12 January 2016 at 13:34:25 UTC, Andrei
Alexandrescu wrote:
[...]
I realize that dfmt may need some upgrades first, but isn't it
about time to just suck it up and dfmt the whole of phobos and
druntime?
It will mess
On Tuesday, 12 January 2016 at 17:22:16 UTC, Walter Bright wrote:
On 1/12/2016 6:53 AM, Adam D. Ruppe wrote:
I'm pretty sure dfmt is up to the task in 99% of cases already.
The last 1% always takes 99% of the dev time :-(
But in this case, the 1% doesn't actually have to be fixed
(although
On 01/12/2016 01:25 PM, tsbockman wrote:
On Tuesday, 12 January 2016 at 13:34:25 UTC, Andrei Alexandrescu wrote:
[...]
I realize that dfmt may need some upgrades first, but isn't it about
time to just suck it up and dfmt the whole of phobos and druntime?
It will mess with the "git blame",
On 01/12/2016 08:42 AM, Martin Drašar via Digitalmars-d wrote:
Wouldn't it be sufficient to mandate usage of dfmt with proper settings
before submitting a PR?
That would suffice at least in the beginning. We also need to put dfmt
in tools, again a project that's been in limbo for a long time.
I think using dfmt for this is a good idea. If there any problems
with dfmt which would prevent it from being used on Phobos, the
problems can be patched and then that would strengthen dfmt.
On 1/12/2016 6:53 AM, Adam D. Ruppe wrote:
I'm pretty sure dfmt is up to the task in 99% of cases already.
The last 1% always takes 99% of the dev time :-(
19 matches
Mail list logo
