REG2.080.1][DIP1000] pure factory functions stopped working
Issue 17635 - [REG 2.066.0] cannot convert unique immutable(int)** to
immutable
Immutable parameters are not needed for strong purity. Const is enough.
Mutability in the return type is an additional condition on top of strong
p
---
@aG0aep6G created dlang/dmd pull request #12890 "fix issues 22130, 17635 - pure
factory functions" fixing this issue:
- fix issues 22130, 17635 - pure factory functions
Issue 22130 - [REG2.080.1][DIP1000] pure factory functions stopped working
Issue 17635 - [REG 2.066.0] cannot conv
https://issues.dlang.org/show_bug.cgi?id=17635
ag0aep6g changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://issues.dlang.org/show_bug.cgi?id=17635
ag0aep6g changed:
What|Removed |Added
See Also||https://issues.dlang.org/sh
|
https://issues.dlang.org/show_bug.cgi?id=17635
--- Comment #11 from ag0aep6g ---
(In reply to RazvanN from comment #10)
> I am closing this, please file the new test case as a new bug report.
https://issues.dlang.org/show_bug.cgi?id=21660
--
https://issues.dlang.org/show_bug.cgi?id=17635
RazvanN changed:
What|Removed |Added
Status|REOPENED|RESOLVED
CC|
https://issues.dlang.org/show_bug.cgi?id=17635
ag0ae...@gmail.com changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
immutable(int)** to
immutable
https://github.com/dlang/dmd/commit/0615ca3302da7393067a6e0c9d8ca61ab65062a6
Merge pull request #7179 from WalterBright/fix17635
fix Issue 17635 - [REG 2.066.0] cannot convert unique immutable(int)*…
merged-on-behalf-of: Andrei Alexandrescu <andra...@users.noreply.github.com>
--
https://issues.dlang.org/show_bug.cgi?id=17635
github-bugzi...@puremagic.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://issues.dlang.org/show_bug.cgi?id=17635
--- Comment #7 from Walter Bright ---
The trouble with the getIndirection() is that passing a type:
int*
and:
struct S { int* p; }
behave differently. The first passes 'int' to traverseIndirections(), losing
the *,
https://issues.dlang.org/show_bug.cgi?id=17635
--- Comment #6 from David Nadlinger ---
(In reply to David Nadlinger from comment #5)
> After a quick glance, I'm not sure whether this is indeed what is at fault
> here. If it was indeed getIndirection() that was at fault,
https://issues.dlang.org/show_bug.cgi?id=17635
David Nadlinger changed:
What|Removed |Added
CC||c...@klickverbot.at
https://issues.dlang.org/show_bug.cgi?id=17635
--- Comment #4 from Walter Bright ---
Bug introduced by:
https://github.com/dlang/dmd/commit/f3b5817a3542f4fa4eb4a6e70658854e0d8e4aa3#diff-43282ebf5a2de5fdbcb3b5083ddf949dR3127
--
https://issues.dlang.org/show_bug.cgi?id=17635
--- Comment #3 from Walter Bright ---
I found one of the problems in getIndirection() in func.d:
extern (C++) Type getIndirection(Type t)
{
t = t.baseElemOf();
if (t.ty == Tarray || t.ty == Tpointer)
https://issues.dlang.org/show_bug.cgi?id=17635
Walter Bright changed:
What|Removed |Added
CC|
https://issues.dlang.org/show_bug.cgi?id=17635
Vladimir Panteleev changed:
What|Removed |Added
Hardware|x86_64 |All
16 matches
Mail list logo