[Issue 20440] Associative arrays of BigInt does not support require or get function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20440

Nathan S.  changed:

   What|Removed |Added

 CC||n8sh.second...@hotmail.com

--- Comment #5 from Nathan S.  ---
Adjusting title to be more general. Also it seems that `get` currently works
with BigInt.

--

[Issue 20440] Associative arrays of BigInt does not support require or get function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20440

--- Comment #4 from Dlang Bot  ---
@n8sh created dlang/druntime pull request #2869 "Fix Issue 20440 - Associative
arrays of BigInt does not support require or get function" fixing this issue:

- Fix Issue 20440 - Associative arrays of BigInt does not support require or
get function

  Applies to any type with a custom opAssign that doesn't return a ref to self

https://github.com/dlang/druntime/pull/2869

--

[Issue 20440] Associative arrays of BigInt does not support require or get function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20440

berni44  changed:

   What|Removed |Added

 CC||bugzi...@d-ecke.de
  Component|phobos  |druntime

--

[Issue 20440] Associative arrays of BigInt does not support require or get function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20440

Simen Kjaeraas  changed:

   What|Removed |Added

 CC||simen.kja...@gmail.com

--- Comment #3 from Simen Kjaeraas  ---
The fix in PR 7312 only fixes this for BigInt specifically. If we are not going
to require that opAssign return ref for every type, this should be fixed in
druntime instead.

In other words: this is a bug in require(), not in BigInt.

--

[Issue 20440] Associative arrays of BigInt does not support require or get function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20440

Dlang Bot  changed:

   What|Removed |Added

   Keywords||pull

--- Comment #2 from Dlang Bot  ---
@GoaLitiuM created dlang/phobos pull request #7312 "Fix Issue 20440 -
Associative arrays of BigInt does not support require or get function" fixing
this issue:

- Fix Issue 20440 - Associative arrays of BigInt does not support require or
get function

https://github.com/dlang/phobos/pull/7312

--

[Issue 20440] Associative arrays of BigInt does not support require or get function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20440

mipri  changed:

   What|Removed |Added

 CC||mi...@minimaltype.com

--- Comment #1 from mipri  ---
with v2.086.1, either of the following permits the test case to compile:

in phobos/std/bigint.d, add a 'ref' to the following return type:

/// Assignment from another BigInt.
BigInt opAssign(T:BigInt)(T x) pure @nogc

in druntime/import/object.d, change the last line of require from

return found ? *p : (*p = value);

to

if (!found) *p = value;
return *p;

--