[Issue 5547] Improve assert to give information on values given to it when it fails

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=5547

Sobirari Muhomori  changed:

   What|Removed |Added

   See Also||https://issues.dlang.org/sh
   ||ow_bug.cgi?id=15889

--

[Issue 5547] Improve assert to give information on values given to it when it fails

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=5547

Andrei Alexandrescu and...@erdani.com changed:

   What|Removed |Added

Version|unspecified |D2

--

[Issue 5547] Improve assert to give information on values given to it when it fails

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5547


Walter Bright bugzi...@digitalmars.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||bugzi...@digitalmars.com
 Resolution||WONTFIX


--- Comment #6 from Walter Bright bugzi...@digitalmars.com 2012-09-05 
15:35:51 PDT ---
As I commented on the pull request:

I have two problems with this:
 1.
Currently, there are so many unittests in Phobos that the compiler sometimes
runs out of memory. This will add a lot more and may push a lot more over the
edge.

 2.
I am not too happy about the dependencies on specific library names and
functionality.



On further reflection, I think that this is more properly the domain of a
library template, such as

testEqual(arg1, arg2);

std.math.approxEqual can easily be extended to print its args on failure.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 5547] Improve assert to give information on values given to it when it fails

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5547



--- Comment #7 from Jonathan M Davis jmdavisp...@gmx.com 2012-09-05 15:45:23 
PDT ---
 On further reflection, I think that this is more properly the domain of a
library template

I'm fine with having a helper function that does this, but the whole reason
that this enhancement was created in the first place was because enough folks
in the newsgroup thought that that it should be built into assert rather than
creating a new function to do it.

Though it should be noted that the library function does tend to cause memory
issues as well, since you end up with a lot of different instantiations for it.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 5547] Improve assert to give information on values given to it when it fails

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5547


bearophile_h...@eml.cc changed:

   What|Removed |Added

 CC||bearophile_h...@eml.cc


--- Comment #8 from bearophile_h...@eml.cc 2012-09-05 16:07:28 PDT ---
(In reply to comment #6)

 Currently, there are so many unittests in Phobos that the compiler sometimes
 runs out of memory. This will add a lot more and may push a lot more over the
 edge.

A large program written by D users risks having the same amount of unit-tests,
so this is a general problem, not just of Phobos.

So maybe the right solution is not to keep assert() dumb, but to find ways to
compile unit-tests using much less memory.

I think this idea also goes well with compiling unit-tests more independently
from each other, to give the user a simple summary of what tests have failed.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 5547] Improve assert to give information on values given to it when it fails

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5547



--- Comment #5 from github-bugzi...@puremagic.com 2012-07-08 13:46:35 PDT ---
Commits pushed to master at https://github.com/D-Programming-Language/druntime

https://github.com/D-Programming-Language/druntime/commit/17db389925581804a3d6d8a10191772077b9713c
Bug 5547: assertPred (the druntime part)

https://github.com/D-Programming-Language/druntime/commit/ce783fff516d21c253edfecb40982c833add3e4b
Merge pull request #41 from kennytm/bug5547_assertPred

Bug 5547: assertPred (the druntime part)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 5547] Improve assert to give information on values given to it when it fails

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5547


kenn...@gmail.com changed:

   What|Removed |Added

   Keywords|patch   |pull


--- Comment #4 from kenn...@gmail.com 2012-02-16 15:10:22 PST ---
Updated pull requests for 2.058. (The IDs are still the same).

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 5547] Improve assert to give information on values given to it when it fails

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5547


kenn...@gmail.com changed:

   What|Removed |Added

   Keywords||patch
 CC||kenn...@gmail.com


--- Comment #3 from kenn...@gmail.com 2011-07-18 08:17:14 PDT ---
DMD pull #263
https://github.com/D-Programming-Language/dmd/pull/263
druntime pull #41
https://github.com/D-Programming-Language/druntime/pull/41
Phobos pull #149
https://github.com/D-Programming-Language/phobos/pull/149

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 5547] Improve assert to give information on values given to it when it fails

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5547



--- Comment #2 from Steven Schveighoffer schvei...@yahoo.com 2011-02-08 
10:57:27 PST ---
Is it too difficult for this to apply only inside unit tests?  I mean literally
within unit test blocks.  This means asserts triggered in non-unit test blocks
will not report the extra info, even if called from a unit test block.  But I
believe this is equivalent to the original proposal of assertPred (which would
only be used inside unittest blocks).

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---