[Issue 7992] std.algorithm.find breaks in certain circumstances
http://d.puremagic.com/issues/show_bug.cgi?id=7992 Jonathan M Davis jmdavisp...@gmx.com changed: What|Removed |Added Status|NEW |RESOLVED CC||jmdavisp...@gmx.com Resolution||FIXED -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 7992] std.algorithm.find breaks in certain circumstances
http://d.puremagic.com/issues/show_bug.cgi?id=7992 --- Comment #4 from github-bugzi...@puremagic.com 2012-10-13 14:41:24 PDT --- Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/01a690654afa50aeb1101abc734de86afbc1b552 Add unittest for issue 7992. https://github.com/D-Programming-Language/phobos/commit/350d960f879a773296c7e553a88b0cdcf1e7a886 Merge pull request #852 from quickfur/issue7992 FIx issue 7992 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 7992] std.algorithm.find breaks in certain circumstances
http://d.puremagic.com/issues/show_bug.cgi?id=7992 hst...@quickfur.ath.cx changed: What|Removed |Added CC||hst...@quickfur.ath.cx --- Comment #2 from hst...@quickfur.ath.cx 2012-10-09 20:55:47 PDT --- OK, something is very broken in simpleMindedFind(). When both haystack and needle have the length property, estimateNeedleLength is set to false, and estimatedNeedleLength is set to 0. Therefore, haystackTooShort() is always false. So in the searching loop, the if(haystackTooShort()) is skipped, and it falls straight through to the for(auto h=haystack.save;...) loop. But here, if h.empty is true, then because estimateNeedleLength is false, this goes straight to continue searching, which calls popFront() on an empty range. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 7992] std.algorithm.find breaks in certain circumstances
http://d.puremagic.com/issues/show_bug.cgi?id=7992 --- Comment #3 from hst...@quickfur.ath.cx 2012-10-09 21:31:44 PDT --- https://github.com/D-Programming-Language/phobos/pull/852 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 7992] std.algorithm.find breaks in certain circumstances
http://d.puremagic.com/issues/show_bug.cgi?id=7992
--- Comment #1 from William Moore nyphb...@gmail.com 2012-04-26 15:00:48 PDT
---
Note: the structure definition is incorrect, it should be:
struct omgstring {
string data;
// Start hasLength functions
@property {
size_t length() const {return data.length;}
void length(size_t len) {data.length = len;}
}
// End hasLength functions
// Start InputRange functions
bool empty() const {return data.empty();}
dchar front() const {return data.front();}
void popFront() {data.popFront();}
// End InputRange functions
// Start ForwardRange functions (implies InputRange)
omgstring save() {return this;}
// End ForwardRange functions
}
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
