[Issue 20990] Optimizer should move cold branches to the end of the function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20990

Dlang Bot  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Dlang Bot  ---
dlang/dmd pull request #11374 "fix Issue 20990 - Optimizer should move cold
branches to the end of t…" was merged into master:

- f1b5b1d676b4385b7790bbb0d4a316dd3cc2f92e by Walter Bright:
  fix Issue 20990 - Optimizer should move cold branches to the end of the
function

https://github.com/dlang/dmd/pull/11374

--

[Issue 20990] Optimizer should move cold branches to the end of the function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20990

Dlang Bot  changed:

   What|Removed |Added

   Keywords||pull

--- Comment #4 from Dlang Bot  ---
@WalterBright created dlang/dmd pull request #11374 "fix Issue 20990 -
Optimizer should move cold branches to the end of t…" fixing this issue:

- fix Issue 20990 - Optimizer should move cold branches to the end of the
function

https://github.com/dlang/dmd/pull/11374

--

[Issue 20990] Optimizer should move cold branches to the end of the function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20990

--- Comment #3 from Walter Bright  ---
(In reply to Iain Buclaw from comment #2)
> Everything that follows the assert should also be considered cold too.

Actually, it is not just cold, it is dead and doesn't make it to the
executable.

> Though hopefully "unreachable" warnings/errors would occur before that point.

It does if warnings are enabled (-w switch).

--

[Issue 20990] Optimizer should move cold branches to the end of the function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20990

Iain Buclaw  changed:

   What|Removed |Added

 CC||ibuc...@gdcproject.org

--- Comment #2 from Iain Buclaw  ---
(In reply to Walter Bright from comment #1)
> (In reply to Walter Bright from comment #0)
> > assert is a cold branch, and DMD move the assert to the end for the example:
> 
> I meant it does "not move" the assert.

Everything that follows the assert should also be considered cold too.  Though
hopefully "unreachable" warnings/errors would occur before that point.

--

[Issue 20990] Optimizer should move cold branches to the end of the function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20990

--- Comment #1 from Walter Bright  ---
(In reply to Walter Bright from comment #0)
> assert is a cold branch, and DMD move the assert to the end for the example:

I meant it does "not move" the assert.

--

[Issue 20990] Optimizer should move cold branches to the end of the function

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=20990

Walter Bright  changed:

   What|Removed |Added

   Keywords||performance

--