[Issue 4796] std.array.appender changes broke dmd unit test runnable/untag.d

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=4796

Andrei Alexandrescu  changed:

   What|Removed |Added

  Component|dstress |tools

--

[Issue 4796] std.array.appender changes broke dmd unit test runnable/untag.d

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=4796


Brad Roberts  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED


--- Comment #4 from Brad Roberts  2010-09-03 22:22:44 PDT 
---
Fix committed in dmd r658.

Quibbling about which component it should be assigned to is really petty. 
Change in phobos caused the dmd test suite to fail.  That's what was important.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 4796] std.array.appender changes broke dmd unit test runnable/untag.d

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=4796


Don  changed:

   What|Removed |Added

  Component|DMD |dstress
 AssignedTo|nob...@puremagic.com|thomas-dl...@kuehne.cn


--- Comment #3 from Don  2010-09-03 11:40:54 PDT ---
(In reply to comment #2)
> Changing bug component to dmd, since this is a dmd test issue, not a phobos 
> issue.

It's not a dmd bug. Might as well use the dstress component for this! (Can we
rename that tag?)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 4796] std.array.appender changes broke dmd unit test runnable/untag.d

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=4796


Steven Schveighoffer  changed:

   What|Removed |Added

 CC||schvei...@yahoo.com
  Component|Phobos  |DMD


--- Comment #2 from Steven Schveighoffer  2010-09-03 
08:13:42 PDT ---
Don is correct, I changed the interface of appender to be safer (not use
pointers to most likely stack variables).  Changing bug component to dmd, since
this is a dmd test issue, not a phobos issue.

Here is a patch.  I tried to test it but I get the ominous "no object.d error" 
I have no patience to try and understand what your test harnesses are doing, so
I'll let you figure out if this works or not:

Index: runnable/untag.d
===
--- runnable/untag.d(revision 657)
+++ runnable/untag.d(working copy)
@@ -101,9 +101,9 @@
 "Could not find closing tag: "~txt);
 }
 } else {
-string code;
-findConsume(txt, ';', appender(&code));
-switch (code) {
+auto app = appender!string();
+findConsume(txt, ';', app);
+switch (app.data) {
 case "#160;": case "#32;": case "reg;": case "nbsp;":
 writeChar(' ');
 break;
@@ -120,7 +120,7 @@
 writeChar('"');
 break;
 default:
-throw new Exception(text("Unknown code: &", code));
+throw new Exception(text("Unknown code: &", app.data));
 break;
 }
 }

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 4796] std.array.appender changes broke dmd unit test runnable/untag.d

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=4796


Don  changed:

   What|Removed |Added

 CC||clugd...@yahoo.com.au


--- Comment #1 from Don  2010-09-03 04:00:31 PDT ---
It's because appender() no longer takes a pointer.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---