[Issue 8730] writeln stops on a nul character, even if passed a D string
https://issues.dlang.org/show_bug.cgi?id=8730 --- Comment #11 from github-bugzi...@puremagic.com --- Commit pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/4f81791438d283edbe508125bbc13ff00e959dd2 Merge pull request #2334 from quickfur/issue8730 std.stdio.writeln should write strings with embedded nulls correctly --
[Issue 8730] writeln stops on a nul character, even if passed a D string
https://issues.dlang.org/show_bug.cgi?id=8730 hst...@quickfur.ath.cx changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from hst...@quickfur.ath.cx --- Verified fixed in git HEAD. --
[Issue 8730] writeln stops on a nul character, even if passed a D string
https://issues.dlang.org/show_bug.cgi?id=8730 hst...@quickfur.ath.cx changed: What|Removed |Added Keywords||pull CC||hst...@quickfur.ath.cx --- Comment #10 from hst...@quickfur.ath.cx --- Wow, has this trivial bug really been around for 2 years?! Anyway, here's the fix: https://github.com/D-Programming-Language/phobos/pull/2334 --
[Issue 8730] writeln stops on a nul character, even if passed a D string
https://issues.dlang.org/show_bug.cgi?id=8730 bearophile_h...@eml.cc changed: What|Removed |Added CC||bearophile_h...@eml.cc --- Comment #9 from bearophile_h...@eml.cc --- *** Issue 13065 has been marked as a duplicate of this issue. *** --
[Issue 8730] writeln stops on a nul character, even if passed a D string
https://d.puremagic.com/issues/show_bug.cgi?id=8730
--- Comment #8 from Musashi Tamura yuri.musashi.miwa.tam...@gmail.com
2013-12-16 03:13:29 PST ---
This problem is only in std.stdio.writeln.
std.stdio.File.writeln doesn't have it.
// abc.d
import std.stdio;
void main() {
writeln(test\0gone); // output test\n
stdout.writeln(test\0gone); // output test\0gone\n
}
$ rdmd abc | od -a
000 t e s t nl t e s t nul g o n e nl
017
--
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
[Issue 8730] writeln stops on a nul character, even if passed a D string
https://d.puremagic.com/issues/show_bug.cgi?id=8730 Musashi Tamura yuri.musashi.miwa.tam...@gmail.com changed: What|Removed |Added CC||yuri.musashi.miwa.tamura@gm ||ail.com --- Comment #6 from Musashi Tamura yuri.musashi.miwa.tam...@gmail.com 2013-12-15 03:53:31 PST --- write(test\0gone\n); write(test\0gone, '\n'); writeln(test\0gon, e); All of the above code outputs NUL. I expect writeln(test\0gone) has the same behavior. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 8730] writeln stops on a nul character, even if passed a D string
https://d.puremagic.com/issues/show_bug.cgi?id=8730 monarchdo...@gmail.com changed: What|Removed |Added CC||monarchdo...@gmail.com --- Comment #7 from monarchdo...@gmail.com 2013-12-15 10:25:36 PST --- Has anybody done anything to fix this? If not, then IMO, it's simply invalid. I think this is just an OS output issue: When printing a null character to console, the console seizes to print for the current line. For example, on windows, writeln(test\0gone); prints test Yet writeln(test\0gone\n); prints test gone and writeln(test\0gon, 'e'); prints test gone Weird, right? So I decided to simply print to file, and check what is actually being *passed* to the stream (NOT what the console prints). Sure enough, everything is correctly placed in the stream, null and all. Conclusion = Output stream is the one to blame; D passes everything correctly to the stream. Gonna see how this behaves on linux next. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 8730] writeln stops on a nul character, even if passed a D string
http://d.puremagic.com/issues/show_bug.cgi?id=8730 --- Comment #2 from Adam D. Ruppe destructiona...@gmail.com 2012-10-09 19:24:49 PDT --- (In reply to comment #1) The specialization is probably to blame. I think 'args[0].length' probably sets the max limit rather than min, but I don't know enough about fprintf internals. :) Yeah, you're right. The man page for printf says the maximum number of characters to be printed from a string for s and S conversions. I'm not sure what is best here. I really think it should work, but the specialization has got to be there for a reason too. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 8730] writeln stops on a nul character, even if passed a D string
http://d.puremagic.com/issues/show_bug.cgi?id=8730 --- Comment #3 from Andrej Mitrovic andrej.mitrov...@gmail.com 2012-10-09 19:38:15 PDT --- (In reply to comment #2) (In reply to comment #1) The specialization is probably to blame. I think 'args[0].length' probably sets the max limit rather than min, but I don't know enough about fprintf internals. :) Yeah, you're right. The man page for printf says the maximum number of characters to be printed from a string for s and S conversions. I'm not sure what is best here. I really think it should work, but the specialization has got to be there for a reason too. It could me off guard just recently. E.g. git uses two strings separated by nul in it's object format, and when I've tried to print out the contents as a char[] using writeln it would only print out a small portion of it, even though printing it as a byte[] would print much more. Anyway this *is* a bug. We can't have it both ways: writeln(bla\0bla); // bla writefln(%s, bla\0bla); // bla[NUL]bla -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 8730] writeln stops on a nul character, even if passed a D string
http://d.puremagic.com/issues/show_bug.cgi?id=8730 Brad Roberts bra...@puremagic.com changed: What|Removed |Added CC||bra...@puremagic.com --- Comment #4 from Brad Roberts bra...@puremagic.com 2012-10-09 20:33:42 PDT --- Shouldn't this be trivial to fix: Replace: fprintf(.stdout.p.handle, %.*s\n, cast(int) args[0].length, args[0].ptr) with: fwrite(args[0].ptr, 1, args[0].length, .stdout.p.handle) -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 8730] writeln stops on a nul character, even if passed a D string
http://d.puremagic.com/issues/show_bug.cgi?id=8730 --- Comment #5 from Brad Roberts bra...@puremagic.com 2012-10-09 20:36:53 PDT --- oops, followed by the same code as in the length == 0 code to get the \n. At which point it's questionable that specialization is all that special. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 8730] writeln stops on a nul character, even if passed a D string
http://d.puremagic.com/issues/show_bug.cgi?id=8730
Andrej Mitrovic andrej.mitrov...@gmail.com changed:
What|Removed |Added
CC||andrej.mitrov...@gmail.com
--- Comment #1 from Andrej Mitrovic andrej.mitrov...@gmail.com 2012-10-04
17:11:33 PDT ---
I'm just guessing, but:
void writeln(T...)(T args)
{
static if (T.length == 0)
{
enforce(fputc('\n', .stdout.p.handle) == '\n');
}
else static if (T.length == 1
is(typeof(args[0]) : const(char)[])
!is(typeof(args[0]) == enum) !is(typeof(args[0]) ==
typeof(null))
!isAggregateType!(typeof(args[0])))
{
// Specialization for strings - a very frequent case
enforce(fprintf(.stdout.p.handle, %.*s\n,
cast(int) args[0].length, args[0].ptr) = 0);
}
else
{
// Most general instance
stdout.write(args, '\n');
}
}
The specialization is probably to blame. I think 'args[0].length' probably sets
the max limit rather than min, but I don't know enough about fprintf internals.
:)
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
