Re: code review based on what I learned from D

2015-07-06 Thread Bogdan via Digitalmars-d-learn
On Sunday, 5 July 2015 at 09:46:19 UTC, ketmar wrote: On Sun, 05 Jul 2015 21:39:23 +1200, Rikki Cattermole wrote: Of course of course. Valid options in failing gracefully include resetting the data and informing the user. Also giving them an option to send a bug report to the devs. Point

Re: code review based on what I learned from D

2015-07-06 Thread ponce via Digitalmars-d-learn
On Sunday, 5 July 2015 at 06:53:36 UTC, Szabo Bogdan wrote: you don't want to crash the user app, because this will make the user unhappy. This type reasoning is always flawed. It's like saying that the Earth is flat. http://p0nce.github.io/d-idioms/#Unrecoverable-vs-recoverable-errors

Re: code review based on what I learned from D

2015-07-05 Thread Rikki Cattermole via Digitalmars-d-learn
On 5/07/2015 6:53 p.m., Szabo Bogdan wrote: Hi, Recently while I was reviewing some swift code, a colleague left me the impression that I am the one with the bad habits and these were learned while coding in D. I still think that I proposed some changes to avoid some bugs but I was told that I

code review based on what I learned from D

2015-07-05 Thread Szabo Bogdan via Digitalmars-d-learn
Hi, Recently while I was reviewing some swift code, a colleague left me the impression that I am the one with the bad habits and these were learned while coding in D. I still think that I proposed some changes to avoid some bugs but I was told that I am focusing on defensive programming and

Re: code review based on what I learned from D

2015-07-05 Thread Rikki Cattermole via Digitalmars-d-learn
On 5/07/2015 9:37 p.m., ketmar wrote: On Sun, 05 Jul 2015 19:01:59 +1200, Rikki Cattermole wrote: Failing gracefully. Not something most developers do. usually that is not related. i mean that if program entered invalid state, it may be too late to save user data. it may be even undesirable

Re: code review based on what I learned from D

2015-07-05 Thread Rikki Cattermole via Digitalmars-d-learn
On 5/07/2015 9:32 p.m., ketmar wrote: On Sun, 05 Jul 2015 06:53:34 +, Szabo Bogdan wrote: For both of these issues I was told that swift is not Java and if the situations that I described happens, you don't want to crash the user app, because this will make the user unhappy. i completely

Re: code review based on what I learned from D

2015-07-05 Thread ketmar via Digitalmars-d-learn
On Sun, 05 Jul 2015 19:01:59 +1200, Rikki Cattermole wrote: Failing gracefully. Not something most developers do. usually that is not related. i mean that if program entered invalid state, it may be too late to save user data. it may be even undesirable to do so, as the data may be already

Re: code review based on what I learned from D

2015-07-05 Thread ketmar via Digitalmars-d-learn
On Sun, 05 Jul 2015 21:39:23 +1200, Rikki Cattermole wrote: Of course of course. Valid options in failing gracefully include resetting the data and informing the user. Also giving them an option to send a bug report to the devs. Point being, having it just fail on start each time is not a

Re: code review based on what I learned from D

2015-07-05 Thread ketmar via Digitalmars-d-learn
On Sun, 05 Jul 2015 06:53:34 +, Szabo Bogdan wrote: For both of these issues I was told that swift is not Java and if the situations that I described happens, you don't want to crash the user app, because this will make the user unhappy. i completely agree. it's way better to keep going