Re: [jQuery] animate problem

2006-10-10 Thread Klaus Hartl
David Duymelinck schrieb: i know somewhere in the list there is a solution but i can't find it at the moment. I want to pass the animate hash as an option so i don't need to go into the plugin to change the animation effects. $('#test').plugin({anihide: {opacity: 'hide'}, anishow:

Re: [jQuery] animate problem

2006-10-10 Thread David Duymelinck
Klaus Hartl schreef I ran into the same problem with the tabs plugin. The original object is modified for the animation, so as a workaround I copy the object each time before passing it to animate: $.fn.test = function(options){ var anihide = $.extend({}, options.anihide); // copy

Re: [jQuery] animate problem

2006-10-10 Thread Jörn Zaefferer
Hi David! I want to pass the animate hash as an option so i don't need to go into the plugin to change the animation effects. $('#test').plugin({anihide: {opacity: 'hide'}, anishow: {opacity: 'show'}, anitime: 3000}); $.fn.test = function(options){ var anihide = options.anihide;

Re: [jQuery] animate problem

2006-10-10 Thread Klaus Hartl
i was also thinking about copying the object but in a more basic version :) var anihide = options.anihide; var anihide2 = anihide; $(img).siblings(img:visible).animate(anihide2, anitime).end().animate(anishow, anitime); ; But that didn't work and i regret to say your workaround

Re: [jQuery] animate problem

2006-10-10 Thread Brandon Aaron
If I understand the issue correctly changing this line (#318) in fx.js: this.curAnim = prop; to this; this.curAnim = jQuery.extend({}, prop); Should fix the problem. However, I have no test case to run this against. -- Brandon Aaron On 10/10/06, Klaus Hartl [EMAIL PROTECTED] wrote: i was

Re: [jQuery] animate problem

2006-10-10 Thread Klaus Hartl
Brandon Aaron schrieb: If I understand the issue correctly changing this line (#318) in fx.js: this.curAnim = prop; to this; this.curAnim = jQuery.extend({}, prop); Should fix the problem. However, I have no test case to run this against. Yes, that looks good I think. Mike once pointed

Re: [jQuery] animate problem

2006-10-10 Thread Brandon Aaron
If someone can send me a test case I'd be more than happy to commit this to SVN. -- Brandon Aaron On 10/10/06, Klaus Hartl [EMAIL PROTECTED] wrote: Brandon Aaron schrieb: If I understand the issue correctly changing this line (#318) in fx.js: this.curAnim = prop; to this; this.curAnim

Re: [jQuery] animate problem

2006-10-10 Thread Jörn Zaefferer
Brandon Aaron schrieb: If someone can send me a test case I'd be more than happy to commit this to SVN. Just add something like this to animate: @test stop(); var hash = {opacity: 'hide'}; var hashCopy = $.extend({}, hash); $('#foo').animate(hash, 'fast', function() { ok( hash.opacity ==

Re: [jQuery] animate problem

2006-10-10 Thread Brandon Aaron
Thanks Jörn! I finally took some time to play around with the test suite... good job! This is now fixed in SVN. -- Brandon Aaron On 10/10/06, Jörn Zaefferer [EMAIL PROTECTED] wrote: Brandon Aaron schrieb: If someone can send me a test case I'd be more than happy to commit this to SVN.

Re: [jQuery] animate problem

2006-10-10 Thread Jörn Zaefferer
Brandon Aaron schrieb: Thanks Jörn! I finally took some time to play around with the test suite... good job! This is now fixed in SVN. Cool. Is there a reason for not adding the test, too? The one big reason I put so much time into the test suite: By adding a test for every bug that

Re: [jQuery] animate problem

2006-10-10 Thread Brandon Aaron
To true ... wouldn't want to see it pop back up. I'll add it in. -- Brandon Aaron On 10/10/06, Jörn Zaefferer [EMAIL PROTECTED] wrote: Brandon Aaron schrieb: Thanks Jörn! I finally took some time to play around with the test suite... good job! This is now fixed in SVN. Cool. Is