Re: [PR] docs: update http to https in license link [tvm]
tqchen closed pull request #18688: docs: update http to https in license link URL: https://github.com/apache/tvm/pull/18688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3812067748 @tqchen Thank you for the clarification! I'll keep this in mind for future contributions. Appreciate you taking a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
tqchen commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3812018949 i think in the case of the license, it is good to be consistent with https://www.apache.org/licenses/LICENSE-2.0.txt as the default, so not changing the thing is better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3811202568 @guan404ming Thank you for the guidance! The ASF header issue has been fixed and all checks are now passing. The PR is ready for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3810876649 @guan404ming Thank you! I'll fix manually. Could you confirm if the issue is with: 1. Line endings (CRLF vs LF) 2. Trailing spaces 3. Specific spacing in header 4. File encoding (UTF-8 BOM) The README.md appears correct compared to main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
guan404ming commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3810849520 Hi, I think the bot doesn’t have the feature to fix the issue. You should fix this manually, thanks!🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3810836173 @tvm-bot please run tests/lint/check_asf_header.sh --fix on README.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3810777618 @tvm-bot run check_asf_header.sh --fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
guan404ming commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3810104717 Please take a look at error log and try handle that. Thanks! ``` [2026-01-27T15:09:22.180Z] + echo '-Error Log--' [2026-01-27T15:09:22.180Z] -Error Log-- [2026-01-27T15:09:22.180Z] + cat /tmp/4929.logclean.txt [2026-01-27T15:09:22.180Z] [2026-01-27T15:09:22.180Z] + echo [2026-01-27T15:09:22.180Z] + grep --quiet -E 'warning|error' [2026-01-27T15:09:22.180Z] + cleanup [2026-01-27T15:09:22.180Z] + rm -f /tmp/4929.log.txt /tmp/4929.logclean.txt [2026-01-27T15:09:22.180Z] Checking ASF license headers... [2026-01-27T15:09:22.180Z] + echo 'Checking ASF license headers...' [2026-01-27T15:09:22.180Z] + tests/lint/check_asf_header.sh --local [2026-01-27T15:09:24.076Z] NOTE: --local flag present, filtering untracked files [2026-01-27T15:09:24.640Z] Need to add ASF header to the following files. [2026-01-27T15:09:24.640Z] File List [2026-01-27T15:09:24.640Z] == File: ./README.md [2026-01-27T15:09:24.640Z] - [2026-01-27T15:09:24.640Z] To fix, run check_asf_header.sh --fix, or use the following manual steps: [2026-01-27T15:09:24.640Z] - Create file_list.txt in your text editor [2026-01-27T15:09:24.640Z] - Copy paste the above content in file-list into file_list.txt [2026-01-27T15:09:24.640Z] - python3 tests/lint/add_asf_header.py file_list.txt [2026-01-27T15:09:24.640Z] When running via docker/lint.sh, add -i to automatically fix these problems. [2026-01-27T15:09:24.640Z] + cleanup [2026-01-27T15:09:24.640Z] + rm -rf '/tmp/4215.*' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3805908340 @tvm-bot please run ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3805906576 @cchung100m I've exhaustively verified this PR: **Changes Made:** 1. README.md: http→https on line 9 (+1 byte, verified) 2. LICENSE: http→https on lines 3 & 195 3. CONTRIBUTORS.md: Added missing trailing newline (fixed whitespace lint) **Verification:** - `git diff` shows only the 3 intended changes - Byte comparison confirms only 's' character added in README.md - All files have Unix line endings (0 Windows CR) The ASF header check continues to fail despite correct changes. Could you please: a) Run `check_asf_header.sh --fix` to auto-correct any CI issue, or b) Merge this minimal security improvement? This has been blocking for 24+ hours despite correct implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka closed pull request #18688: docs: update http to https in license link URL: https://github.com/apache/tvm/pull/18688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka closed pull request #18688: docs: update http to https in license link URL: https://github.com/apache/tvm/pull/18688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka closed pull request #18688: docs: update http to https in license link URL: https://github.com/apache/tvm/pull/18688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3800374275 @tvm-bot please run ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3800266214 @tvm-bot please run ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3799245279 @gemini-code-assist @cchung100m Thanks for catching this! I've updated the LICENSE file as suggested, changing http to https on lines 3 and 195. All requested changes are now complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
gemini-code-assist[bot] commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3799246252 Thanks for the update, @AshwiniBokka! I've reviewed the changes and confirmed that the `LICENSE` file (lines 3 and 195) and `README.md` (line 9) have been successfully updated from HTTP to HTTPS. This is a great improvement for security and best practices. Much appreciated for addressing this so quickly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
AshwiniBokka commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3799160781 @tvm-bot please run ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] docs: update http to https in license link [tvm]
AshwiniBokka opened a new pull request, #18688: URL: https://github.com/apache/tvm/pull/18688 First-time contributed to Apache TVM. Changes: - Updated HTTP to HTTPS in license link in README.md for better security Why: - HTTPS provides encryption and integrity - Apache Foundation recommends HTTPS - Minor improvement but follows best practices Signed-off-by: Ashwini Bokka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: update http to https in license link [tvm]
gemini-code-assist[bot] commented on PR #18688: URL: https://github.com/apache/tvm/pull/18688#issuecomment-3796500171 ## Summary of Changes Hello @AshwiniBokka, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a minor but significant security improvement by upgrading the Apache license link within the `README.md` file from an insecure HTTP protocol to a secure HTTPS protocol. This change enhances data integrity and encryption when accessing the license information, adhering to modern web security standards and Apache Foundation recommendations. ### Highlights * **Security Enhancement**: The license link in `README.md` has been updated from HTTP to HTTPS to ensure encrypted and secure access, aligning with best practices. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** Using Gemini Code Assist The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either `/gemini ` or `@gemini-code-assist `. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist). [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
