Re: [PR] [CI] Update images to `20260213-110714-021547fe` [tvm]

2026-02-14 Thread via GitHub 


tlopex closed pull request #18775: [CI] Update images to 
`20260213-110714-021547fe`
URL: https://github.com/apache/tvm/pull/18775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [CI] Update images to `20260213-110714-021547fe` [tvm]

2026-02-13 Thread via GitHub 


mshr-h commented on PR #18775:
URL: https://github.com/apache/tvm/pull/18775#issuecomment-3901181065

   the ci error is due to the changes in setuptools which removed pkg_resources 
in 82.0.0 (released 2026‑02‑08).
   proper fix is to upgrade `pytest-rerunfailures` to newer version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [CI] Update images to `20260213-110714-021547fe` [tvm]

2026-02-13 Thread via GitHub 


yongwww commented on code in PR #18775:
URL: https://github.com/apache/tvm/pull/18775#discussion_r2804941758


##
ci/jenkins/docker-images.ini:
##
@@ -17,8 +17,8 @@
 
 # This data file is read during when Jenkins runs job to determine docker 
images.
 [jenkins]
-ci_arm: tlcpack/ci-arm:20250513-063354-70aa3797
-ci_cpu: tlcpack/ci_cpu:20250513-063354-70aa3797
-ci_gpu: tlcpack/ci-gpu:20250513-063354-70aa3797
-ci_lint: tlcpack/ci-lint:20250513-063354-70aa3797
-ci_wasm: tlcpack/ci-wasm:20250513-063354-70aa3797
+ci_arm: tlcpack/ci-arm:20260213-110714-021547fe
+ci_cpu: tlcpack/ci_cpu:20260213-110714-021547fe
+ci_gpu: tlcpack/ci-gpu:20260213-110714-021547fe
+ci_lint: tlcpack/ci-lint:20260213-110714-021547fe
+ci_wasm: tlcpack/ci-wasm:20260213-110714-021547fe

Review Comment:
   Nice to have.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [CI] Update images to `20260213-110714-021547fe` [tvm]

2026-02-13 Thread via GitHub 


gemini-code-assist[bot] commented on code in PR #18775:
URL: https://github.com/apache/tvm/pull/18775#discussion_r2804740383


##
ci/jenkins/docker-images.ini:
##
@@ -17,8 +17,8 @@
 
 # This data file is read during when Jenkins runs job to determine docker 
images.
 [jenkins]
-ci_arm: tlcpack/ci-arm:20250513-063354-70aa3797
-ci_cpu: tlcpack/ci_cpu:20250513-063354-70aa3797
-ci_gpu: tlcpack/ci-gpu:20250513-063354-70aa3797
-ci_lint: tlcpack/ci-lint:20250513-063354-70aa3797
-ci_wasm: tlcpack/ci-wasm:20250513-063354-70aa3797
+ci_arm: tlcpack/ci-arm:20260213-110714-021547fe
+ci_cpu: tlcpack/ci_cpu:20260213-110714-021547fe
+ci_gpu: tlcpack/ci-gpu:20260213-110714-021547fe
+ci_lint: tlcpack/ci-lint:20260213-110714-021547fe
+ci_wasm: tlcpack/ci-wasm:20260213-110714-021547fe

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   To improve maintainability and reduce redundancy, consider defining the 
image tag as a variable and reusing it. This would make future updates easier 
and reduce the chance of inconsistencies. For example, you could add a `ci_tag` 
variable under the `[jenkins]` section and reference it:
   
   ```ini
   ci_tag: 20260213-110714-021547fe
   ci_arm: tlcpack/ci-arm:${ci_tag}
   ci_cpu: tlcpack/ci_cpu:${ci_tag}
   ci_gpu: tlcpack/ci-gpu:${ci_tag}
   ci_lint: tlcpack/ci-lint:${ci_tag}
   ci_wasm: tlcpack/ci-wasm:${ci_tag}
   ```
   
   This change would depend on the parser for this file supporting variable 
interpolation. If that's not feasible, the current explicit approach is 
acceptable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [CI] Update images to `20260213-110714-021547fe` [tvm]

2026-02-13 Thread via GitHub 


gemini-code-assist[bot] commented on PR #18775:
URL: https://github.com/apache/tvm/pull/18775#issuecomment-3897773883

   ## Summary of Changes
   
   Hello @mshr-h, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull 
request and will post my feedback shortly. In the meantime, here's a summary to 
help you and other reviewers quickly get up to speed!
   
   This pull request focuses on a critical infrastructure update for the 
continuous integration system. It refreshes the Docker images used across 
various CI environments to a newer version. This update is essential for 
enabling support for Python 3.10 within the CI pipelines, ensuring that future 
development and testing can leverage this Python version.
   
   ### Highlights
   
   * **CI Docker Image Update**: The CI Docker images have been updated to a 
new version, `20260213-110714-021547fe`, across all configurations (ARM, CPU, 
GPU, Lint, WASM).
   * **Python 3.10 Support**: This update specifically incorporates Python 3.10 
into the CI Docker images, addressing a requirement from issue #18682.
   
   🧠 **New Feature in Public Preview:** You can now enable **Memory** to help 
**Gemini Code Assist** learn from your team's feedback. This makes future code 
reviews more consistent and personalized to your project's style. **Click 
[here](https://codeassist.google/code-review/login) to enable Memory in your 
admin console.**
   
   
   Changelog
   
   * **ci/jenkins/docker-images.ini**
   * Updated all `ci_arm`, `ci_cpu`, `ci_gpu`, `ci_lint`, and `ci_wasm` 
Docker image tags to `20260213-110714-021547fe`.
   
   
   
   Activity
   
   * No specific review comments or activities have been recorded for this pull 
request yet.
   
   
   
   Using Gemini Code Assist
   
   
   The full guide for Gemini Code Assist can be found on our [documentation 
page](https://developers.google.com/gemini-code-assist/docs/review-github-code),
 here are some quick tips.
   
   Invoking Gemini
   
   You can request assistance from Gemini at any point by creating a comment 
using either `/gemini ` or `@gemini-code-assist `. Below is a 
summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull 
request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current 
pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, 
both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   Customization
   
   To customize Gemini Code Assist for GitHub experience, repository 
maintainers can create a configuration file and/or provide a custom code review 
style guide (such as PEP-8 for Python) by creating and adding files to a 
`.gemini/` folder in the base of the repository. Detailed instructions can be 
found 
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   Limitations & Feedback
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances 
where its feedback is incorrect or counter productive. You can react with 
:thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're 
interested in giving your feedback about your experience with Gemini Code 
Assist for Github and other Google products, sign up 
[here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   
   You can also get AI-powered code generation, chat, as well as code 
reviews directly in the IDE at no cost with the [Gemini Code Assist IDE 
Extension](https://cloud.google.com/products/gemini/code-assist).
   
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), 
[Generative AI Prohibited Use 
Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of 
Service](https://policies.google.com/terms), and learn how to configure Gemini 
Code Assist in GitHub 
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
 Gemini can make mistakes, so double check it and [use code with 
caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]