Re: [PR] feat: Support direct construction of `tvm_ffi.Function` from callables [tvm-ffi]
junrushao closed pull request #448: feat: Support direct construction of `tvm_ffi.Function` from callables URL: https://github.com/apache/tvm-ffi/pull/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: Support direct construction of `tvm_ffi.Function` from callables [tvm-ffi]
tqchen commented on code in PR #448: URL: https://github.com/apache/tvm-ffi/pull/448#discussion_r2808220559 ## python/tvm_ffi/cython/function.pxi: ## @@ -889,6 +889,27 @@ cdef class Function(Object): def __cinit__(self) -> None: self.c_release_gil = _RELEASE_GIL_BY_DEFAULT +def __init__(self, func: Callable[..., Any]) -> None: +"""Initialize a Function from a Python callable. + +This constructor allows creating a `tvm_ffi.Function` directly +from a Python function or another `tvm_ffi.Function` instance. + +Parameters +-- +func : Callable[..., Any] +The Python callable to wrap. +""" +cdef TVMFFIObjectHandle chandle = NULL Review Comment: we need to hold the change for a few cutedsl releases before cutedsl get updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: Support direct construction of `tvm_ffi.Function` from callables [tvm-ffi]
tqchen commented on PR #448: URL: https://github.com/apache/tvm-ffi/pull/448#issuecomment-3902936763 we need to hold this after a few cutedsl releases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: Support direct construction of `tvm_ffi.Function` from callables [tvm-ffi]
gemini-code-assist[bot] commented on code in PR #448:
URL: https://github.com/apache/tvm-ffi/pull/448#discussion_r2808112498
##
tests/python/test_function.py:
##
@@ -153,6 +153,15 @@ def fapply(f: Any, *args: Any) -> Any:
assert fapply(add, 1, 3.3) == 4.3
+def test_pyfunc_init() -> None:
+def add(a: int, b: int) -> int:
+return a + b
+
+fadd = tvm_ffi.Function(add)
+assert isinstance(fadd, tvm_ffi.Function)
+assert fadd(1, 2) == 3
Review Comment:
The test for `tvm_ffi.Function.__init__` is a good start, but it only covers
creating a `Function` from a new Python callable. To ensure the new constructor
is fully tested, please consider adding test cases for:
1. Creating a `Function` from an existing `tvm_ffi.Function` instance.
2. Verifying that creating a `Function` from a non-callable object
correctly raises a `TypeError`.
```suggestion
# Test creating from a Python callable
fadd = tvm_ffi.Function(add)
assert isinstance(fadd, tvm_ffi.Function)
assert fadd(1, 2) == 3
# Test creating from an existing tvm_ffi.Function
fadd2 = tvm_ffi.Function(fadd)
assert isinstance(fadd2, tvm_ffi.Function)
assert fadd2(3, 4) == 7
assert fadd.same_as(fadd2)
# Test creating from a non-callable raises TypeError
with pytest.raises(TypeError):
tvm_ffi.Function(123)
```
##
python/tvm_ffi/cython/function.pxi:
##
@@ -889,6 +889,27 @@ cdef class Function(Object):
def __cinit__(self) -> None:
self.c_release_gil = _RELEASE_GIL_BY_DEFAULT
+def __init__(self, func: Callable[..., Any]) -> None:
+"""Initialize a Function from a Python callable.
+
+This constructor allows creating a `tvm_ffi.Function` directly
+from a Python function or another `tvm_ffi.Function` instance.
+
+Parameters
+--
+func : Callable[..., Any]
+The Python callable to wrap.
+"""
+cdef TVMFFIObjectHandle chandle = NULL
+if not callable(func):
+raise TypeError(f"func must be callable, got {type(func)}")
+if isinstance(func, Function):
+chandle = (func).chandle
+TVMFFIObjectIncRef(chandle)
+else:
+_convert_to_ffi_func_handle(func, &chandle)
Review Comment:
The logic for handling different types of `func` can be restructured for
better clarity and a minor efficiency gain. Since `isinstance(func, Function)`
is a more specific check than `callable(func)`, it's better to check for it
first. Using a single `if/elif/else` block makes the different cases clearer.
```
if isinstance(func, Function):
chandle = (func).chandle
TVMFFIObjectIncRef(chandle)
elif callable(func):
_convert_to_ffi_func_handle(func, &chandle)
else:
raise TypeError(f"func must be callable, got {type(func)}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] feat: Support direct construction of `tvm_ffi.Function` from callables [tvm-ffi]
gemini-code-assist[bot] commented on PR #448: URL: https://github.com/apache/tvm-ffi/pull/448#issuecomment-3902786404 ## Summary of Changes Hello @junrushao, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the `tvm_ffi.Function` class by allowing direct construction from Python callables. This change streamlines the process of wrapping Python functions for use within the TVM FFI system, making the API more intuitive and reducing the need for explicit conversion utilities. It also includes necessary type hinting and a dedicated test to ensure correctness and maintainability. ### Highlights * **Direct Function Construction**: Enabled direct initialization of `tvm_ffi.Function` objects from Python callables, simplifying API usage by allowing `tvm_ffi.Function(my_python_func)`. * **Robust Constructor Logic**: Implemented the `__init__` method with validation for callable arguments, proper handling of existing `tvm_ffi.Function` instances (with reference counting), and conversion for other callables via `_convert_to_ffi_func_handle`. * **Type Stub and Test Coverage**: Added a type stub for the new `__init__` method in `core.pyi` and a new test case in `test_function.py` to verify the functionality of direct callable wrapping. * **Re-landed Feature**: This change re-introduces functionality that was previously reverted in a prior pull request (#406). 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** Changelog * **python/tvm_ffi/core.pyi** * Added `__init__` method signature to the `Function` class. * **python/tvm_ffi/cython/function.pxi** * Implemented the `__init__` method for the `Function` class to accept a Python callable. * Added logic to validate if the input is callable. * Included logic to handle `tvm_ffi.Function` instances by incrementing their reference count. * Integrated `_convert_to_ffi_func_handle` for other callable types. * **tests/python/test_function.py** * Added `test_pyfunc_init` to verify the direct construction of `tvm_ffi.Function` from a Python function. Activity * No activity has been recorded for this pull request yet. Using Gemini Code Assist The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either `/gemini ` or `@gemini-code-assist `. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist). [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Ge
