Re: [PR] feat: add `TVMFFIAnyGetInvalidObject` C API for global invalid object singleton [tvm-ffi]
tqchen commented on code in PR #447: URL: https://github.com/apache/tvm-ffi/pull/447#discussion_r2808223711 ## include/tvm/ffi/c_api.h: ## @@ -551,6 +551,18 @@ TVM_FFI_DLL int TVMFFIObjectIncRef(TVMFFIObjectHandle obj); */ TVM_FFI_DLL int TVMFFIObjectDecRef(TVMFFIObjectHandle obj); +/*! + * \brief Get the global invalid/missing object as an owned TVMFFIAny. + * + * Returns a singleton Object that represents an "invalid" or "missing" state. + * The returned TVMFFIAny holds an owned reference to the object (i.e., the + * reference count is incremented). The caller is responsible for releasing + * it via the normal Any cleanup path. + * + * \param out The output owned TVMFFIAny. + */ +TVM_FFI_DLL void TVMFFIAnyGetInvalidObject(TVMFFIAny* out); Review Comment: does it have to be a C API, or can we have it as a packed function API? I think it is better to have it as a packed function API for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: add `TVMFFIAnyGetInvalidObject` C API for global invalid object singleton [tvm-ffi]
gemini-code-assist[bot] commented on code in PR #447:
URL: https://github.com/apache/tvm-ffi/pull/447#discussion_r2808096003
##
tests/cpp/test_base.cc:
##
@@ -29,4 +29,25 @@ TEST(Base, Version) {
EXPECT_EQ(version.patch, TVM_FFI_VERSION_PATCH);
}
+TEST(Base, InvalidObject) {
+ TVMFFIAny out;
+ out.type_index = kTVMFFINone;
+ out.zero_padding = 0;
+ out.v_int64 = 0;
Review Comment:
For better readability and conciseness, you can use value initialization for
the `TVMFFIAny` struct. This will zero-initialize all members, which is the
intended effect here.
```suggestion
TVMFFIAny out{};
```
##
tests/cpp/test_base.cc:
##
@@ -29,4 +29,25 @@ TEST(Base, Version) {
EXPECT_EQ(version.patch, TVM_FFI_VERSION_PATCH);
}
+TEST(Base, InvalidObject) {
+ TVMFFIAny out;
+ out.type_index = kTVMFFINone;
+ out.zero_padding = 0;
+ out.v_int64 = 0;
+ TVMFFIAnyGetInvalidObject(&out);
+ // Should return a valid Object
+ EXPECT_EQ(out.type_index, kTVMFFIObject);
+ EXPECT_NE(out.v_obj, nullptr);
+ // Calling again should return the same singleton
+ TVMFFIAny out2;
+ out2.type_index = kTVMFFINone;
+ out2.zero_padding = 0;
+ out2.v_int64 = 0;
Review Comment:
Similarly, you can use value initialization here for conciseness.
```suggestion
TVMFFIAny out2{};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] feat: add `TVMFFIAnyGetInvalidObject` C API for global invalid object singleton [tvm-ffi]
gemini-code-assist[bot] commented on PR #447: URL: https://github.com/apache/tvm-ffi/pull/447#issuecomment-3902771660 ## Summary of Changes Hello @junrushao, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the handling of "missing" or "invalid" object states by introducing a dedicated C API for a global singleton. This change generalizes the pattern previously specific to map operations, providing a more direct and consistent way to access this sentinel value across the FFI boundary. It simplifies Python-side integration by exposing a `MISSING` global, leading to cleaner code and improved maintainability. ### Highlights * **New C API for Invalid Object**: Introduced a new C API, TVMFFIAnyGetInvalidObject, to provide a global singleton for an "invalid" or "missing" object state, generalizing the pattern previously specific to map operations. * **Python Global MISSING Object**: Exposed this global invalid object as `MISSING` in the Cython `core` module, allowing direct and consistent Python access to this sentinel value. * **FFI Function Registry Cleanup**: Removed the `ffi.MapGetMissingObject` function from the FFI function registry, streamlining the missing object pattern and reducing redundancy. * **Python Module Integration**: Updated Python modules (`container.py`, `_ffi_api.py`, `core.pyi`) to utilize the new `MISSING` global, ensuring cleaner code and improved maintainability. * **Comprehensive Unit Testing**: Added comprehensive C++ and Python unit tests to validate the functionality and singleton property of the new invalid object API and its Python exposure. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** Changelog * **include/tvm/ffi/c_api.h** * Added declaration for `TVMFFIAnyGetInvalidObject`. * **python/tvm_ffi/_ffi_api.py** * Removed `MapGetMissingObject` from type hints and the list of exported FFI functions. * **python/tvm_ffi/container.py** * Updated the `MISSING` object import to use the new global from `tvm_ffi.core`. * **python/tvm_ffi/core.pyi** * Added a type declaration for the `MISSING` global. * **python/tvm_ffi/cython/base.pxi** * Declared the new C API function `TVMFFIAnyGetInvalidObject`. * **python/tvm_ffi/cython/core.pyx** * Implemented the `MISSING` global by calling `TVMFFIAnyGetInvalidObject` and wrapping the result. * **src/ffi/container.cc** * Removed the registration of `ffi.MapGetMissingObject`. * Implemented the `TVMFFIAnyGetInvalidObject` C API. * **tests/cpp/test_base.cc** * Added a C++ unit test to verify the `TVMFFIAnyGetInvalidObject` API returns a valid, singleton object. * **tests/python/test_container.py** * Added a Python unit test to confirm `MISSING` is a valid singleton and integrates correctly with `Map.get()`. Activity * No human activity (comments, reviews) detected on this pull request yet. Using Gemini Code Assist The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either `/gemini ` or `@gemini-code-assist `. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. Y
