Re: [Discuss-gnuradio] Submitting OOT Module Questions

2015-09-24 Thread Martin Braun
Ron's comment is very helpful, here's some more factoids: On 23.09.2015 13:55, Richard Bell wrote: > Sorry if these are obvious questions, but this is very not obvious to > me. As I understand it right now, it's not even a question of copy and > pasting files over to gr-analog, because that would

[Discuss-gnuradio] Submitting OOT Module Questions

2015-09-23 Thread Richard Bell
Hey everyone, I'm in the process of submitting my first OOT module for merge with GNU Radio base. It's a log gain AGC which converges much faster then the current AGCs when the input signal energy is low. I've read through the following link:

Re: [Discuss-gnuradio] Submitting OOT Module Questions

2015-09-23 Thread Marcus D. Leech
On 09/23/2015 02:07 PM, Dan CaJacob wrote: I like keeping the algorithm logic in comments. I can't count how many times I have optimized something, overwriting the original readable code, then come back in a few months to discover I have no idea how it works anymore. Months? Weeks for me :)

Re: [Discuss-gnuradio] Submitting OOT Module Questions

2015-09-23 Thread Tom Rondeau
On Wed, Sep 23, 2015 at 1:39 PM, Richard Bell wrote: > Hey everyone, > > I'm in the process of submitting my first OOT module for merge with GNU > Radio base. It's a log gain AGC which converges much faster then the > current AGCs when the input signal energy is low.

Re: [Discuss-gnuradio] Submitting OOT Module Questions

2015-09-23 Thread Tom Rondeau
On Wed, Sep 23, 2015 at 2:38 PM, Richard Bell wrote: > When merging my OOT module with the forked GNU Radio base, should I hand > copy the *.xml, *.h, *_impl.h, *_impl.cc, qa_*.cc and qa_*.h in the > appropriate gr-analog folder locations, or should I just dump my entire

Re: [Discuss-gnuradio] Submitting OOT Module Questions

2015-09-23 Thread Martin Braun
On 23.09.2015 10:39, Richard Bell wrote: > Hey everyone, > > I'm in the process of submitting my first OOT module for merge with GNU > Radio base. It's a log gain AGC which converges much faster then the > current AGCs when the input signal energy is low. I've read through the > following link: >

Re: [Discuss-gnuradio] Submitting OOT Module Questions

2015-09-23 Thread Dan CaJacob
I like keeping the algorithm logic in comments. I can't count how many times I have optimized something, overwriting the original readable code, then come back in a few months to discover I have no idea how it works anymore. On Wed, Sep 23, 2015 at 1:54 PM Martin Braun

Re: [Discuss-gnuradio] Submitting OOT Module Questions

2015-09-23 Thread Richard Bell
When merging my OOT module with the forked GNU Radio base, should I hand copy the *.xml, *.h, *_impl.h, *_impl.cc, qa_*.cc and qa_*.h in the appropriate gr-analog folder locations, or should I just dump my entire OOT module into the top level of the GNU Radio repo? I'm not familiar enough with

Re: [Discuss-gnuradio] Submitting OOT Module Questions

2015-09-23 Thread Ron Economos
You can take a look at my last gr-dtv commit. It's very similar to what you need to do. https://github.com/gnuradio/gnuradio/commit/b90c574e2fbf0443e1eea2ee06779c2a85f86def Files to consider: gr-dtv/grc/CMakeLists.txt gr-dtv/grc/dtv_block_tree.xml gr-dtv/lib/CMakeLists.txt

Re: [Discuss-gnuradio] Submitting OOT Module Questions

2015-09-23 Thread Richard Bell
Sorry if these are obvious questions, but this is very not obvious to me. As I understand it right now, it's not even a question of copy and pasting files over to gr-analog, because that would overwrite the code for all the other blocks, at least when it comes to swig. So let me outline what I