Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-23 Thread Sergii Stoian
On 3/22/07, Fred Kiefer [EMAIL PROTECTED] wrote: Sergii Stoian wrote: Forgot to attach files. Hi Sergii, I already commit my part of the change. Please give it a try. Looks good with one strange exception: NSPopUpButton doesn't draw responder ring although it inherits code from NSCell.

Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-23 Thread Fred Kiefer
Sergii Stoian wrote: On 3/22/07, *Fred Kiefer* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Sergii Stoian wrote: Forgot to attach files. Hi Sergii, I already commit my part of the change. Please give it a try. Looks good with one strange exception:

Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-22 Thread Fred Kiefer
Sergii Stoian wrote: Hi, Fred On 3/22/07, Fred Kiefer [EMAIL PROTECTED] wrote: I think the general idea of this patch is good, but I don't understand the details of it, which makes it hard for me to judge, if it is correct. That's why I post email before commit to SVN tree. What is the

Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-22 Thread Gregory John Casamento
Have you tested this change with Gorm to see if it breaks anything? Thanks, G. -- Gregory Casamento - Original Message From: Sergii Stoian [EMAIL PROTECTED] To: discuss-gnustep@gnu.org Sent: Wednesday, March 21, 2007 4:00:45 PM Subject: NSMatrix, NSCell, NSBrowser,NSBrowserCell

Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-22 Thread Sergii Stoian
On 3/22/07, Fred Kiefer [EMAIL PROTECTED] wrote: Sergii Stoian wrote: Hi, Fred On 3/22/07, Fred Kiefer [EMAIL PROTECTED] wrote: I think the general idea of this patch is good, but I don't understand the details of it, which makes it hard for me to judge, if it is correct. That's why I

Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-22 Thread Sergii Stoian
Forgot to attach files. NSCell.m.diff Description: Binary data NSMatrix.m.diff Description: Binary data ___ Discuss-gnustep mailing list Discuss-gnustep@gnu.org http://lists.gnu.org/mailman/listinfo/discuss-gnustep

Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-22 Thread Sergii Stoian
@gnu.org Sent: Wednesday, March 21, 2007 4:00:45 PM Subject: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch Hi, I want to propose changes to gui-trunk (patch attached). In general changes are touches NSMattrix and NSCell and is about drawing first reponder indicator (dotted frame). What

Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-22 Thread Fred Kiefer
Sergii Stoian wrote: Forgot to attach files. Hi Sergii, I already commit my part of the change. Please give it a try. I don't thing that your proposed change to setShowsFirstResponder: is correct. That way we don't have a chance to store the focus type. It will get overridden each time this

NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-21 Thread Sergii Stoian
Hi, I want to propose changes to gui-trunk (patch attached). In general changes are touches NSMattrix and NSCell and is about drawing first reponder indicator (dotted frame). What is done: - NSCell is responsible for showing first responder state; - Removed code from NSMatrix which sets

Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-21 Thread Fred Kiefer
I think the general idea of this patch is good, but I don't understand the details of it, which makes it hard for me to judge, if it is correct. What is the relation of the change to NSBrowser to the rest of the patch? I don't like hard-code numbers in the code. Why is this one needed here? If I

Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

2007-03-21 Thread Sergii Stoian
Hi, Fred On 3/22/07, Fred Kiefer [EMAIL PROTECTED] wrote: I think the general idea of this patch is good, but I don't understand the details of it, which makes it hard for me to judge, if it is correct. That's why I post email before commit to SVN tree. What is the relation of the change to