Re: Changing plugin settings results in missing migrations

2016-11-16 Thread Angelo Dini
Thanks for the report here Brian and John, as soon as I'm aware of the proper solution to this problem, I'll make sure it gets added to the checklist and in the near future to our addon best practices. Any advice is welcome. -- Message URL: https://groups.google.com/d/msg/django-cms-developer

Re: Changing plugin settings results in missing migrations

2016-11-16 Thread John-Scott
This is one of the things I'd like to see on a code review checklist so this could be caught before a release. Any field that uses 'choices' needs to have its migrations modified to point to the variable name (e.g. choices=DJANGOCMS_STYLE_CHOICES) instead of the raw values. Otherwise, 'makemig

Changing plugin settings results in missing migrations

2016-11-16 Thread Brian Rutledge
I posted this issue to djangocms-style , but it seems to me that it affects multiple plugins, so I'm re-posting the description here. I just upgraded to 2.0.0, and discovered that setting DJANGOCMS_STYLE_CHOICES and DJANGOCMS_STYLE_TEMPLATES r