Re: Changing plugin settings results in missing migrations

I'll be porting the fix to the other core addons, will try to release them around early next week. On Wednesday, 16 November 2016 20:20:12 UTC+1, Brian Rutledge wrote: > > I posted this issue to djangocms-style > , but it seems to me > that it

Re: Changing plugin settings results in missing migrations

Looks like the initial migration for djangocms-style does what John suggested for class_name and tag_type. I'm going to take a crack at a PR for this. That said, I looked through the migra

Re: Changing plugin settings results in missing migrations

Thanks for the report here Brian and John, as soon as I'm aware of the proper solution to this problem, I'll make sure it gets added to the checklist and in the near future to our addon best practices. Any advice is welcome. -- Message URL: https://groups.google.com/d/msg/django-cms-developer

Re: Changing plugin settings results in missing migrations

This is one of the things I'd like to see on a code review checklist so this could be caught before a release. Any field that uses 'choices' needs to have its migrations modified to point to the variable name (e.g. choices=DJANGOCMS_STYLE_CHOICES) instead of the raw values. Otherwise, 'makemig

Changing plugin settings results in missing migrations

I posted this issue to djangocms-style , but it seems to me that it affects multiple plugins, so I'm re-posting the description here. I just upgraded to 2.0.0, and discovered that setting DJANGOCMS_STYLE_CHOICES and DJANGOCMS_STYLE_TEMPLATES r