Fellow Report -- February 26, 2018

2018-02-25 Thread Carlton Gibson
Hi all, Last week I reviewed patches on the following tickets: https://code.djangoproject.com/ticket/27449 -- Added get_supported_language_variant to public API https://code.djangoproject.com/ticket/28755 -- django.utils.translation.check_for_language doesn't check in the app folders

Re: “Abusing BinaryField” warning about binary files in DB

2018-02-25 Thread Yo-Yo Ma
The nice thing about leaving the warning as stern as it is is that anybody who is absolutely sure that they need to store files this way isn’t going to stop because of the warning to begin with; while weaking the warning will most assuredly lead to “Django is Slow” posts by newcomers that

Re: “Abusing BinaryField” warning about binary files in DB

2018-02-25 Thread Adam Johnson
Did you know Facebook store their assets in MySQL, because it's the fastest replicated super-reliable thing to put them in? https://secure.phabricator.com/book/phabflavor/article/soon_static_resources/ (near the end of 'Caches and Serving Content') I am in favour of weakening the warning On 25

Re: “Abusing BinaryField” warning about binary files in DB

2018-02-25 Thread Tom Forbes
Hey Antonie, Personally I’m quite against changing that warning. I have only ever seen one application where the use of an in-database file is appropriate and they where using the FILESTREAM type in SQL Server

Re: “Abusing BinaryField” warning about binary files in DB

2018-02-25 Thread Curtis Maloney
On 02/26/2018 08:30 AM, Antoine Pietri wrote: Can I suggest replacing the warning by something like this?: Although you might think about storing files in the database, consider that it might be a bad design choice. This field is not a replacement for proper static files handling. That said,

“Abusing BinaryField” warning about binary files in DB

2018-02-25 Thread Antoine Pietri
Hi! In the documentation, the BinaryField has a warning called “Abusing BinaryField” that states: > Although you might think about storing files in the database, consider that > it is bad design in 99% of the cases. This field is not a replacement for > proper static files handling.