Fellow Report - July 25, 2015
Report for week ending July 25, 2015: Triaged --- https://code.djangoproject.com/ticket/25146 - Allow method_decorator to work at the class level (accepted) https://code.djangoproject.com/ticket/25151 - rename LOGIN_REDIRECT_URL to POST_LOGIN_URL (won’t fix) https://code.djangoproject.com/ticket/25147 - HTML debug page: "Switch to copy-paste" toggle not working properly (fixed) https://code.djangoproject.com/ticket/25153 - The polls tutorial shows INSTALLED_APPS in incorrect order (accepted) https://code.djangoproject.com/ticket/25152 - development server stops on SyntaxError or other Exceptions (duplicate) https://code.djangoproject.com/ticket/25155 - Move Style declaration out of the function (fixed) https://code.djangoproject.com/ticket/24527 - Using standalone templates gives confusing error message (duplicate) https://code.djangoproject.com/ticket/25159 - Remove brackets from method/function signatures in docs (created) https://code.djangoproject.com/ticket/25163 - When a user doesn't have permission to an admin page, raise 404 instead of redirecting to login (accepted) https://code.djangoproject.com/ticket/13842 - XViewMiddleware fails with django.contrib.syndication.views.Feed (fixed) https://code.djangoproject.com/ticket/25167 - Provide option to disable ajax text/plain response in technical_500_response (accepted) https://code.djangoproject.com/ticket/25170 - assertXMLEqual fails when white space is present outside XML fragment (accepted) https://code.djangoproject.com/ticket/25136 - Fixed #25161 -- Encouraged users to install the latest release in docs (fixed) https://code.djangoproject.com/ticket/25166 - Unclear statement in custom model permission documentation (fixed) Authored https://github.com/django/django/pull/5039 - Simplified MANIFEST.in Reviewed/committed -- https://github.com/django/django/pull/5012 - Refs #23622 -- Added tests to ensure ordering is retained for distinct on fields subqueries. https://github.com/django/django/pull/5028 - Fixed #24126 -- Deprecated current_app parameter to auth views. https://github.com/django/django/pull/5021 - Added PostgreSQL non-durable settings hint in docs. https://github.com/django/django/pull/5030 - Fixed #25156 -- Mentioned django.setup() in the settings overview for standalone Django use. https://github.com/django/django/pull/5036 - Fixed QuerySet.raw() regression on FK with custom db_column. https://github.com/django/django/pull/5016 - Fixed #24623 -- Fixed EmailMessage.attach_file() with text files on Python 3. Reviews of core dev work https://github.com/django/django/pull/5018 - Fixed #25141 -- Diminished GDAL dependence during geojson serialization https://github.com/django/django/pull/5032 - Fixed #22258 -- Added progress status for dumpdata when outputting to file -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/cc3ada79-06ae-42eb-b470-ccf135f3ced1%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Should migrations have their imports sorted?
I think it's been addressed in 1.9 to at least some extent. See https://github.com/django/django/commit/7f20041bca43ca33f0a9617793f2af7ab07c3fab On Saturday, July 25, 2015 at 6:54:40 PM UTC-4, Raphael Michel wrote: > > Hello, > > some time ago, Django started to use isort to make sure imports are > formatted and sorted consistently throughout the codebase. I like this > very much, so I started adopting this practice for my own codebases. > > However, today I noticed that when Django generates a migration, the > imports in the outputted python file are not necessarily sorted, > causing my checks to fail. In my case it was about these imports: > > -from django.db import models, migrations > +from django.db import migrations, models > > I had a short look at the source code, but being a novice to the > django.db subtree, I had no idea where exactly to look and I wanted to > ask here: Is this something trivial to fix or is it something that > cannot be solved without changing things very deeply? > > This is, of course, absolutely not important, if not completely > irrelevant. However, if it would be a really easy fix, it could be a > nice bonus feature. > > Cheers, > Raphael > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/a2ea5562-f151-4801-b040-6b0a6e3a0e04%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Should migrations have their imports sorted?
Hello, some time ago, Django started to use isort to make sure imports are formatted and sorted consistently throughout the codebase. I like this very much, so I started adopting this practice for my own codebases. However, today I noticed that when Django generates a migration, the imports in the outputted python file are not necessarily sorted, causing my checks to fail. In my case it was about these imports: -from django.db import models, migrations +from django.db import migrations, models I had a short look at the source code, but being a novice to the django.db subtree, I had no idea where exactly to look and I wanted to ask here: Is this something trivial to fix or is it something that cannot be solved without changing things very deeply? This is, of course, absolutely not important, if not completely irrelevant. However, if it would be a really easy fix, it could be a nice bonus feature. Cheers, Raphael -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/20150726005423.74fa6353%40kvothe. For more options, visit https://groups.google.com/d/optout. pgpyStu8Idok4.pgp Description: Digitale Signatur von OpenPGP
