Re: re-thinking middleware

2016-01-11 Thread Shai Berger
On Monday 11 January 2016 01:54:58 Raphaël Barrois wrote: > > Hi, > > I've got only one minor suggestion to the "backwards compatibility" > section of the DEP. > > > It currently states that "If the ``MIDDLEWARE`` setting is provided > > [...], the old ``MIDDLEWARE_CLASSES`` setting will be

Re: re-thinking middleware

2016-01-11 Thread Carl Meyer
On 01/10/2016 04:54 PM, Raphaël Barrois wrote: > I've got only one minor suggestion to the "backwards compatibility" > section of the DEP. > >> It currently states that "If the ``MIDDLEWARE`` setting is provided >> [...], the old ``MIDDLEWARE_CLASSES`` setting will be ignored. > > I suggest

Re: 1.8 shipping invalid .py files in the startapp template

2016-01-11 Thread Tim Graham
Seems reasonable to me. On Monday, January 11, 2016 at 10:24:18 AM UTC-5, Carl Johnson wrote: > > I think the template files should be shipped out as .py-tpl, since that's > their type (a Python template), and the resulting final files should just > have the extension renamed. Having two

Re: 1.8 shipping invalid .py files in the startapp template

2016-01-11 Thread Carl Johnson
I think the template files should be shipped out as .py-tpl, since that's their type (a Python template), and the resulting final files should just have the extension renamed. Having two extension is just confusing and leads to questions like this one about other kinds of templates. -- You

Re: re-thinking middleware

2016-01-11 Thread Tim Graham
That warning sounds like a good idea. We have a similar warning if both the old and new style template settings are defined: https://github.com/django/django/commit/24620d71f2116da31abe6c9391f7bc807ac23c0b On Sunday, January 10, 2016 at 6:57:09 PM UTC-5, Raphaël Barrois wrote: > > On Fri, 8 Jan