Re: QuerySet __contains__

2009-12-08 Thread Luke Plant
On Wednesday 09 December 2009 01:52:48 Jeremy Dunck wrote: > On Tue, Dec 8, 2009 at 7:22 PM, Luke Plant <l.plant...@cantab.net> > wrote: ... > > > However, it could be slightly more efficient in some cases, > > because the entire QuerySet._result_cache does not necess

QuerySet __contains__

2009-12-08 Thread Luke Plant
changes in Python which could produce quite different performance. Regards, Luke -- "If something is hard, it's not worth doing." (Homer Simpson) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django de

Re: smart if tag

2009-12-05 Thread Luke Plant
On Saturday 05 December 2009 20:09:21 Luke Plant wrote: > I'm not likely to able to look at this before Tuesday. If anyone > wants to look at it, I think the right approach is something like > the following: > http://effbot.org/zone/simple-top-down-parsing.htm > (without the glo

Re: smart if tag

2009-12-05 Thread Luke Plant
x y %} in this regard. (Actually, I didn't test that. Perhaps the behaviour of 'if' has changed with the smart if code). Regards, Luke -- "Idiocy: Never underestimate the power of stupid people in large groups." (despair.com) Luke Plant || http://lukeplant.me.uk/ -- You received

Re: Session/cookie based messages (#4604)

2009-12-05 Thread Luke Plant
ones do. Regards, Luke -- "Idiocy: Never underestimate the power of stupid people in large groups." (despair.com) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group

Re: #7052 - Fixing serialization for contrib.contenttypes and contrib.auth

2009-12-03 Thread Luke Plant
at ticket as well, right? Regards, Luke -- "I am going to let you move around more, just to break up the mahogany." (True Quotes From Induhviduals, Scott Adams) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups &q

Re: Session/cookie based messages (#4604)

2009-12-03 Thread Luke Plant
gt; Luke -- "I am going to let you move around more, just to break up the mahogany." (True Quotes From Induhviduals, Scott Adams) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group

Re: SMTPConnection DeprecationWarning

2009-12-03 Thread Luke Plant
move around more, just to break up the mahogany." (True Quotes From Induhviduals, Scott Adams) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django

SMTPConnection DeprecationWarning

2009-12-03 Thread Luke Plant
cated in 1.2" section of docs/releases/1.2.txt Regards, Luke -- "I am going to let you move around more, just to break up the mahogany." (True Quotes From Induhviduals, Scott Adams) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed

Re: Single lines between top level classes & functions

2009-12-01 Thread Luke Plant
code use two lines between top level classes & > functions, like PEP 8 suggests, or should the contributing guide > be updated? I had no idea it said that! I had got so used to Django's style that anything else just grated... Luke -- "Humiliation: The harder you try, the dumber

Re: Session/cookie based messages (#4604)

2009-12-01 Thread Luke Plant
miliation: The harder you try, the dumber you look." (despair.com) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroup

Re: smart if tag

2009-11-30 Thread Luke Plant
On Monday 30 November 2009 20:27:32 SmileyChris wrote: > On Dec 1, 6:08 am, Luke Plant <l.plant...@cantab.net> wrote: > > Given that the 'Null' stuff has now been removed, we could > > move back to your way to reduce the code a bit, but I'm not sure > > it is worth it. &

Re: smart if tag

2009-11-30 Thread Luke Plant
t, very little of the parsing has changed. Given that the 'Null' stuff has now been removed, we could move back to your way to reduce the code a bit, but I'm not sure it is worth it. Review would be welcome, especially as I'm ill at the moment. I'm only coding because the boredom of

Re: Composite Primary/Foreign Keys

2009-11-28 Thread Luke Plant
way I take: when he has tried me, I shall come forth as gold" (Job 23:10). Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@google

smart if tag

2009-11-28 Thread Luke Plant
s, Luke -- "He knows the way I take: when he has tried me, I shall come forth as gold" (Job 23:10). Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send

Re: Doc building piece missing?

2009-11-21 Thread Luke Plant
nged:: 1.2", our docs are set up to parse that as referring to the next version of Django, so it says "Development version". The same isn't true of 1.1.2. I don't know how this should be handled. Perhaps the easiest way is to start the tentative 1.1.2 release notes as has been don

Re: Documentation of backwards incompatible changes

2009-11-14 Thread Luke Plant
aps we could have two sections on that page — all release notes, and upgrading notes. Or, next to 'final' releases there could be an additional link to the 'backwards incompatible changes' section, along with some notes at the top explaining the page. Luke -- As Ralph Waldo Emerson once said

Documentation of backwards incompatible changes

2009-11-13 Thread Luke Plant
://docs.djangoproject.com/en/dev/internals/deprecation/ -- As Ralph Waldo Emerson once said, "I hate quotations." Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send ema

Re: CSRF changes - backwards incompatible

2009-10-31 Thread Luke Plant
ete fools. -- Douglas Adams Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@goo

Re: ImproperlyConfigured: Error importing middleware django.middleware.csrf: "No module named csrf"

2009-10-31 Thread Luke Plant
On Saturday 31 October 2009 01:04:09 vl4dt wrote: > I get this output from a newly created project with the latest > trunk: > > > Any suggestions? I suspect the python path is missing something, > also the server stops responding, just sits there and no further > requests are served. I

Re: Advocacy for Email-01 (email backends)

2009-10-30 Thread Luke Plant
nance burden to Django. Regards, Luke -- A common mistake that people make when trying to design something completely foolproof is to underestimate the ingenuity of complete fools. -- Douglas Adams Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~

Re: CSRF changes - backwards incompatible

2009-10-27 Thread Luke Plant
On Tuesday 27 October 2009 13:03:14 Luke Plant wrote: > If you have supplied custom templates to contrib views that accept > POST requests (e.g. auth login etc.), the template may need > updating. The steps needed are fully described in the docs, but in > short: > > In

Re: CSRF changes - backwards incompatible

2009-10-27 Thread Luke Plant
which don't have the CSRF token. Beyond that, I'll need more details! Luke -- Environmentalists are much too concerned with planet earth. Their geocentric attitude prevents them from seeing the greater picture -- lots of planets are much worse off than earth is. Luke Plant || http://luk

Re: CSRF changes - backwards incompatible

2009-10-27 Thread Luke Plant
ned with planet earth. Their geocentric attitude prevents them from seeing the greater picture -- lots of planets are much worse off than earth is. Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Goo

CSRF changes - backwards incompatible

2009-10-27 Thread Luke Plant
is. Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from

Buildbot failure

2009-10-26 Thread Luke Plant
anyone else? Luke -- "If we could just get everyone to close their eyes and visualise world peace for an hour, imagine how serene and quiet it would be until the looting started" -- Anon Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ Yo

Re: Django 1.2 feature voting

2009-10-24 Thread Luke Plant
t. Nonetheless, I don't think that oversight will change the plan. Python 2.4 was released nearly 5 years ago, so it's hardly unreasonable for us to drop support for 2.3. Luke -- Noise proves nothing. Often a hen who has merely laid an egg cackles as if she laid an asteroid. --

Re: default Model.all()?

2009-10-23 Thread Luke Plant
eople have little or no influence on society. -- Mark Twain Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this

Re: default Model.all()?

2009-10-22 Thread Luke Plant
thread safe. Luke -- "Some people says that if you play a Windows XP install CD backwards you will hear demon voices commanding you to worship Satan. But that's nothing. If you play it forwards it will install Windows XP." Luke Plant || http://lukeplant.me.uk/ --~--~

Re: default Model.all()?

2009-10-22 Thread Luke Plant
ys that if you play a Windows XP install CD backwards you will hear demon voices commanding you to worship Satan. But that's nothing. If you play it forwards it will install Windows XP." Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this

Re: Session/cookie based messages (#4604)

2009-10-22 Thread Luke Plant
cluding the different configurations that are allowed (with and without the messages app, for instance). I think the auth context processor should call the messages one, so that you get the same result whether you use one or the other or both. Luke -- Carpe post meridian! (I'm not a morning

Re: shortcut proposal

2009-10-16 Thread Luke Plant
recent one: You wrote: > Luke Plant wrote: > > The Django devs don't think that everything to do with view > > functions is perfect, but I for one would be against changing the > > whole way they work. The basic definition of a view function: > > > >

Re: LazyObject fix - tiny backwards incompatible change

2009-10-16 Thread Luke Plant
especially if I document it in release notes. Luke -- The probability of someone watching you is proportional to the stupidity of your action. Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to t

Re: shortcut proposal

2009-10-16 Thread Luke Plant
te on all my projects that would catch any missing imports, of course... ;-) Hmm, for me this boils down to whether I'm feeling lazy or feeling like a perfectionist, option 4) is definitely cleaner... Luke -- The probability of someone watching y

Re: shortcut proposal

2009-10-16 Thread Luke Plant
one watching you is proportional to the stupidity of your action. Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, sen

Re: Session/cookie based messages (#4604)

2009-10-16 Thread Luke Plant
er messages are not deprecated, then we do have two systems. Luke -- You meet a lot of smart guys with stupid wives, but you almost never meet a smart woman with a stupid husband. (Erica Jong) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You recei

shortcut proposal

2009-10-15 Thread Luke Plant
You meet a lot of smart guys with stupid wives, but you almost never meet a smart woman with a stupid husband. (Erica Jong) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups &quo

LazyObject fix - tiny backwards incompatible change

2009-10-15 Thread Luke Plant
ine that it will affect interactive usage at the Python prompt in a few obscure cases, if anything. But I could have missed something. Luke -- You meet a lot of smart guys with stupid wives, but you almost never meet a smart woman with a stupid husband. (Erica Jong) Luke Plant || http://lukeplant.me

Re: lazy auth context processor

2009-10-15 Thread Luke Plant
On Wednesday 14 October 2009 16:39:31 Luke Plant wrote: > On Wednesday 14 October 2009 15:54:25 Russell Keith-Magee wrote: > > > * the output of {{ user }} in a template will be different. I > > > think this is acceptable, because only things like {{ > > > user.u

Re: lazy auth context processor

2009-10-14 Thread Luke Plant
, almost all the functionality is in LazyObject anyway, which is as generic as it sounds. Luke -- "You'll be glad to know, I'm going to donate all the snot I sneeze to hospitals for mucus transfusions." (Calvin and Hobbes) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~---

Re: lazy auth context processor

2009-10-14 Thread Luke Plant
On Wednesday 14 October 2009 15:32:11 Jacob Kaplan-Moss wrote: > On Wed, Oct 14, 2009 at 7:24 AM, Luke Plant <l.plant...@cantab.net> wrote: > > I want to fix #6552 (also #12031), and I've attached a patch that > > makes the auth context processor lazy. > >

lazy auth context processor

2009-10-14 Thread Luke Plant
going to donate all the snot I sneeze to hospitals for mucus transfusions." (Calvin and Hobbes) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers&

Re: Proposal for 1.2: built-in logging with django.core.log

2009-10-10 Thread Luke Plant
or me anyway. Luke -- "Where a person wishes to attract, they should always be ignorant." (Jane Austen) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django

Re: Proposal for 1.2: built-in logging with django.core.log

2009-10-09 Thread Luke Plant
ir good judgement." -- Libbie Fudim Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@goog

Re: decorator_from_middleware change

2009-09-26 Thread Luke Plant
uld make it harder to remove. Does anyone else know if we want to expose all the arguments of CacheMiddleware in cache_page? I can easily add them if so. Regards, Luke -- "Smoking cures weight problems...eventually..." (Steven Wright) Luke Pla

Re: CSRF - next step?

2009-09-26 Thread Luke Plant
using RequestContext easier and simpler. Luke -- "Smoking cures weight problems...eventually..." (Steven Wright) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django devel

CSRF - next step?

2009-09-26 Thread Luke Plant
currently in 'extras/' which seems to be the right place. Luke -- "Smoking cures weight problems...eventually..." (Steven Wright) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to

Re: Adding signing (and signed cookies) to Django core

2009-09-25 Thread Luke Plant
art of the application was essentially allowing the user to retrieve MD5(secret_key + user_supplied_data) (might have been HMAC or SHA1), which allowed them to get past another bit of security. Luke -- "Smoking cures weight problems...eventually..." (Steven Wright) Luke Plant || http://lu

Re: Adding signing (and signed cookies) to Django core

2009-09-25 Thread Luke Plant
existing signed messages, especially persistent ones like those stored in password files etc. Luke -- "Smoking cures weight problems...eventually..." (Steven Wright) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You receive

Re: decorator_from_middleware change

2009-09-23 Thread Luke Plant
hings, should it be backported to 1.1.X or not? Luke -- "Pretension: The downside of being better than everyone else is that people tend to assume you're pretentious." (despair.com) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You r

Re: decorator_from_middleware change

2009-09-23 Thread Luke Plant
r now unsupported ways of calling it. Do you think this is enough? Luke -- "Pretension: The downside of being better than everyone else is that people tend to assume you're pretentious." (despair.com) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---

Re: CSRF proposal and patch ready for review

2009-09-23 Thread Luke Plant
On Tuesday 22 September 2009 21:24:48 Luke Plant wrote: > 2) Get the view to be exempted from the normal CSRF checks done > by the middleware. Thankfully, we already have not one but two > ways of doing this - the manual @csrf_exempt decorator on views, > and the intern

Re: decorator_from_middleware change

2009-09-22 Thread Luke Plant
uld be decorator_from_middleware_with_args of course, thanks, will fix. Luke [1] http://docs.djangoproject.com/en/dev/topics/cache/#the-per-view- cache -- "Pessimism: Every dark cloud has a silver lining, but lightning kills hundreds of people each year trying to find

Re: decorator_from_middleware change

2009-09-22 Thread Luke Plant
On Tuesday 22 September 2009 21:31:08 James Bennett wrote: > On Mon, Sep 21, 2009 at 9:04 PM, Luke Plant <l.plant...@cantab.net> wrote: > > I've committed my change [1], and also replaced _CheckLogin > > with my method [2] (it was essentially the same method,

Re: CSRF proposal and patch ready for review

2009-09-22 Thread Luke Plant
ark in my mind is what happens with multiple forms on a page (e.g. when you have a login box on every page). It might not be an issue - the target of the login box will be another view anyway - but it needs thought. Luke -- "Pessimism: Every dark cloud has a silver lining, but light

Re: CSRF proposal and patch ready for review

2009-09-22 Thread Luke Plant
On Tuesday 22 September 2009 13:12:51 Russell Keith-Magee wrote: > On Tue, Sep 22, 2009 at 10:34 AM, Luke Plant <l.plant...@cantab.net> wrote: > > I've left most of the code itself under django/contrib/csrf because: > > > > 1) backwards compatibility with peop

Re: CSRF proposal and patch ready for review

2009-09-21 Thread Luke Plant
://code.djangoproject.com/attachment/ticket/9977/csrf_template_tag_r11587_1.diff -- Parenthetical remarks (however relevant) are unnecessary Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "D

Re: decorator_from_middleware change

2009-09-21 Thread Luke Plant
On Monday 21 September 2009 20:27:50 Jacob Kaplan-Moss wrote: > On Mon, Sep 21, 2009 at 1:21 PM, Luke Plant <l.plant...@cantab.net> wrote: > > However, decorator_from_middleware is a pain, since it doesn't always > > return a an actual decorator, for "historical r

decorator_from_middleware change

2009-09-21 Thread Luke Plant
arguments-with-functions-and-methods/1288936#1288936 -- Parenthetical remarks (however relevant) are unnecessary Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django de

Re: CSRF proposal and patch ready for review

2009-09-21 Thread Luke Plant
ments (e.g. the request object), otherwise it would fail). Does anyone have a nice solution to this? Regards, Luke -- "Outside of a dog, a book is a man's best friend... inside of a dog, it's too dark to read." Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~---

Re: CSRF proposal and patch ready for review

2009-09-19 Thread Luke Plant
On Saturday 19 September 2009 16:56:52 Russell Keith-Magee wrote: > On Fri, Sep 18, 2009 at 6:09 AM, Luke Plant <l.plant...@cantab.net> wrote: > > If the target of a is internal: > > * add {% load csrf %} to the template and {% csrf_token %} to the form >

Re: CSRF proposal and patch ready for review

2009-09-19 Thread Luke Plant
dds to the upgrade cost. Regards, and thanks for taking my (lengthy) criticisms in good spirit! Luke -- OSBORN'S LAW Variables won't, constants aren't. Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because

Re: CSRF proposal and patch ready for review

2009-09-17 Thread Luke Plant
of a very deep, dark hole. That seems a familiar concept. What does it remind me of? Ah, I remember. Life." (Marvin the paranoid android) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscrib

Re: #10436 status

2009-09-16 Thread Luke Plant
gt; It was committed 6 months ago? > > http://code.djangoproject.com/changeset/10030 That would be #10463, not #10436 Luke -- "My middle name is 'Organised'! My first name is 'Poorly'." Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You

Re: CSRF proposal and patch ready for review

2009-09-15 Thread Luke Plant
til I see your proposal. Luke -- "My capacity for happiness you could fit into a matchbox without taking out the matches first." (Marvin the paranoid android) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because

Re: CSRF proposal and patch ready for review

2009-09-10 Thread Luke Plant
oss a new argument against the CsrfResponseMiddleware: http://code.djangoproject.com/ticket/9163 To me, this confirms my gut instinct (or rather, Jacob's), that post- processing the response is really nasty. Luke -- Life is complex. It has both real and imaginary components. Luke Plan

Re: proposal: decouple admin index page from INSTALLED_APPS

2009-09-04 Thread Luke Plant
don't really exist as far as Django is concerned, only 'apps'. Luke -- I teleported home one night With Ron and Sid and Meg, Ron stole Meggie's heart away And I got Sidney's leg (THHGTTG) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received

Re: CSRF proposal and patch ready for review

2009-08-31 Thread Luke Plant
full time job which is not programming related, and it would be too far for me anyway (I'm in the UK). Luke -- I never hated a man enough to give him his diamonds back. (Zsa Zsa Gabor) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You receive

Re: CSRF proposal and patch ready for review

2009-08-31 Thread Luke Plant
never hated a man enough to give him his diamonds back. (Zsa Zsa Gabor) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this

Re: CSRF proposal and patch ready for review

2009-08-31 Thread Luke Plant
SRF, we can't automatically fix it, so we can't pretend it doesn't exist. Thanks again for your feedback. Like you, I'm far from being 100% happy with this solution, but it's the lesser of two evils IMO. Regards, Luke -- "Ineptitude: If you can't learn to do something well, learn to enjoy

Re: CSRF proposal and patch ready for review

2009-08-29 Thread Luke Plant
ybody can do what I want. Once everybody accepts it, they'll be serene too." (Calvin and Hobbes) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers&

CSRF proposal and patch ready for review

2009-08-03 Thread Luke Plant
rents never had children, the chances are you won't either." Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group,

Re: Feature request: admin notifications

2009-07-29 Thread Luke Plant
though discussion will need to take place on this list at some point). Luke -- "Idiocy: Never underestimate the power of stupid people in large groups." (despair.com) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this mes

Re: Ordering of ManyToManyField using a field of the intermediate table

2009-06-30 Thread Luke Plant
an answer on the users' does not make this on-topic for developers'. Thanks, Luke -- When you're great, people often mistake candor for bragging. -- Calvin and Hobbes Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message be

Re: append_slash alternative: remove_slash

2009-06-18 Thread Luke Plant
- Environmentalists are much too concerned with planet earth. Their geocentric attitude prevents them from seeing the greater picture -- lots of planets are much worse off than earth is. Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You receive

Re: append_slash alternative: remove_slash

2009-06-16 Thread Luke Plant
that you are fighting a losing battle. Luke -- "If we could just get everyone to close their eyes and visualise world peace for an hour, imagine how serene and quiet it would be until the looting started" -- Anon Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~-

Re: History tracking for models

2009-05-13 Thread Luke Plant
be asking on the django-users list. Luke -- LORENZ'S LAW OF MECHANICAL REPAIR: After your hands become coated with grease, your nose will begin to itch. Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscri

Re: CSRF template tag patch done

2009-04-09 Thread Luke Plant
ecommended configuration, using admin_view()). Regards, Luke -- "The number you have dialled is imaginary. Please rotate your telephone by 90 degrees and try again." Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this

Re: CSRF template tag patch done

2009-04-04 Thread Luke Plant
-i '<form.*POST'" and fix the templates). And, as described above, I could have postponed it just by using CsrfResponseMiddleware instead. Regards, Luke -- "Smoking cures weight problems...eventually..." (Steven Wright) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~

Re: CSRF template tag patch done

2009-03-24 Thread Luke Plant
On Monday 23 March 2009 19:21:00 Luke Plant wrote: > Hi all, > > The patch has been added to: > > http://code.djangoproject.com/ticket/9977 I've bashed on this a lot more, and discovered (and fixed) several issues (particularly to do with what happens when sessions are first

CSRF template tag patch done

2009-03-23 Thread Luke Plant
Hi all, The patch has been added to: http://code.djangoproject.com/ticket/9977 It includes tests, docs etc - I think it is complete. Other notes are below (some of this would need to be prominently noted in the release notes). I don't know if this is too late for the beta. Since I guess

Re: Proposal: enable CSRF middleware by default

2009-03-21 Thread Luke Plant
or the (more) contentious part of this commit. That's past the deadline for the beta, though (the reason for my hasty commit in the first place), and it would still need review from other people before it goes in. Regards, Luke -- OSBORN'S LAW

Re: Proposal: enable CSRF middleware by default

2009-03-19 Thread Luke Plant
On Thursday 19 March 2009 19:18:19 Bob Thomas wrote: > On Mar 19, 2:49 pm, Luke Plant <l.plant...@cantab.net> wrote: > > The hard work isn't the template tag, it's: > > > > - tests (the existing ones are in django/contrib/csrf/tests.py) > > - documentation >

Re: Proposal: enable CSRF middleware by default

2009-03-19 Thread Luke Plant
ept. What does it remind me of? Ah, I remember. Life." (Marvin the paranoid android) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers"

Re: Proposal: enable CSRF middleware by default

2009-03-18 Thread Luke Plant
On Wednesday 18 March 2009 15:59:10 Jacob Kaplan-Moss wrote: > On Wed, Mar 18, 2009 at 8:40 AM, Luke Plant <l.plant...@cantab.net> wrote: > > I propose adding the two [CSRF] middleware (view and response) to > > the MIDDLEWARE settings [...] > > I'm a somewhat reluctan

Proposal: enable CSRF middleware by default

2009-03-18 Thread Luke Plant
fixable with 'csrf_exempt' Please let me know by Thursday evening (GMT) if there are objections. Luke -- "My middle name is 'Organised'! My first name is 'Poorly'." Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this messa

Re: CSRF / SafeForm

2009-01-05 Thread Luke Plant
settings file created by 'manage.py startproject'. Luke -- Noise proves nothing. Often a hen who has merely laid an egg cackles as if she laid an asteroid. -- Mark Twain Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received thi

Re: CSRF / SafeForm

2008-12-23 Thread Luke Plant
On Tuesday 23 December 2008 16:51:46 Bob Thomas wrote: > On Dec 3, 9:14 am, Luke Plant <l.plant...@cantab.net> wrote: > > At the moment, once you've factored everything in, I think 'view > > middleware' + template tag is the way to go, with some more > > cu

CSRF / SafeForm

2008-12-03 Thread Luke Plant
n ID might not be in request.COOKIES[SESSION_COOKIE_NAME], but in request.session.?? -- "Outside of a dog, a book is a man's best friend... inside of a dog, it's too dark to read." Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this

Re: Dropping Python 2.3 compatibility for Django 1.1

2008-11-26 Thread Luke Plant
your life is only to serve as a warning to others." (despair.com) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to t

Re: Ticket 8638: Provide setting to disable e-mail sending

2008-11-25 Thread Luke Plant
[1] http://www.lastcraft.com/fakemail.php -- "Mediocrity: It takes a lot less time, and most people don't realise until it's too late." (despair.com) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are

Re: assigning to model properties for mocking

2008-10-23 Thread Luke Plant
ng this type of thing, and found it annoying, and definitely unpythonic, as I've not come across any other python code that behaves this way. Luke -- "Doubt: In the battle between you and the world, bet on the world." (despair

Re: GET requests should not alter data?

2008-10-15 Thread Luke Plant
system. In short, there is no option but to require developers to understand HTTP. Django's position is clear, it is the same as the HTTP spec. Luke [1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1 -- "Because Your lovingkindness is better than life, My lips shall p

Re: Proposal: django.forms.SafeForm - forms with built in CSRF protection

2008-09-24 Thread Luke Plant
Hi Simon, > CSRF[1] is one of the most common web application vulnerabilities, but > continues to have very poor awareness in the developer community. > Django ships with CSRF protection in the form of middleware, but it's > off by default. I'm willing to bet most people don't turn it on. > > I

Re: Generic relations and non-integer primary keys

2008-07-16 Thread Luke Plant
S. Luke -- "Mediocrity: It takes a lot less time, and most people don't realise until it's too late." (despair.com) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups

Is it UploadedFile.chunks() or .chunk() ?

2008-07-03 Thread Luke Plant
oorly." (despair.com) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com

Re: Ticket #7591: Authenticate By Email Support

2008-07-03 Thread Luke Plant
project.com/ticket/7591 I replied on the ticket. Regards, Luke -- "Ineptitude: If you can't learn to do something well, learn to enjoy doing it poorly." (despair.com) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this messag

Re: More secure user password reset

2008-06-28 Thread Luke Plant
page, you would want to have a link to the log in screen, but I don't know how to calculate that). Regards, Luke -- "I have had a perfectly lovely evening. However, this wasn't it." (Groucho Marx) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--

Re: More secure user password reset

2008-06-28 Thread Luke Plant
he same as the last password) and updates the last_login timestamp. I'm happy to implement -- I've got the tests setup already etc, so it should be easy enough. Luke -- "I have had a perfectly lovely evening. However, this wasn't it."

Re: More secure user password reset

2008-06-27 Thread Luke Plant
evening. However, this wasn't it." (Groucho Marx) Luke Plant || http://lukeplant.me.uk/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to dj

<    1   2   3   4   5   6   7   >