Re: Automatic prefetching in querysets

2017-08-17 Thread Malcolm Box
Hi, I think there's a potential to make this opt-in, and improve the out-of-box experience. Summarising the discussion, it seems that the rough consensus is that if we were building the ORM from scratch, then this would be entirely sensible behaviour (with necessary per-QS ways to disable) -

AssertNumQueries and call stacks

2016-10-04 Thread Malcolm Box
e-line patch (and 5 lines of test code) https://github.com/mbox/django/commit/c0a5fa22770b90d3ad0fd24ee80b93bebe03fbec Can this be reconsidered for re-opening? I'm happy to improve the patch if that's needed. Cheers, Malcolm -- Malcolm Box -- You received this message because you are subscribed to

Re: Extend support for long surnames in Django Auth

2016-08-02 Thread Malcolm Box
I've opened ticket 26993 to track this - https://code.djangoproject.com/ticket/26993#ticket On Friday, 29 July 2016 12:15:43 UTC+1, Raony Guimaraes Corrêa Do Carmo Lisboa Cardenas wrote: > > Hello everyone, > > For a long time I was having problems to login to djangopackages.com > using my

Re: Extend support for long surnames in Django Auth

2016-08-02 Thread Malcolm Box
gt; Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAABi-DoVpZoTCKL9Mw-J%3DrSJhHFR1jo-WCr9gTVAa%2BBKWbsCjQ%40mail.gmail.com > <https://groups.google.com/d/msgid/django-dev

Re: Extend support for long surnames in Django Auth

2016-08-02 Thread Malcolm Box
On Monday, 1 August 2016 13:56:55 UTC+1, Aymeric Augustin wrote: > > > On 30 Jul 2016, at 23:15, Donald Stufft > wrote: > > > > See #6 of > https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/ > > > I’m aware of this article. It's a

Converting ModelAdmin system checks to run against instances rather than the class

2015-09-10 Thread Malcolm Box
Hi, Raising this here as suggested by Tim on this bug: https://code.djangoproject.com/ticket/25374, with discussion also on django users here: https://groups.google.com/forum/#!topic/django-users/lsDP5oUWOsw The underlying bug is that ModelAdmin checks are run against the class not the

Re: How to disable system check framework?

2015-09-10 Thread Malcolm Box
At the risk of re-opening this thread, I have just run into a very similar situation (see https://code.djangoproject.com/ticket/25374) and find that having the errors printed to the console is actually helpful - as I've had to silence errors to get the correct code to run, seeing if there's any

Re: Terms for database replication

2014-06-05 Thread Malcolm Box
FWIW, I think the main objection is to the word "slave", not to "master". Otherwise we'll be renaming the git branches soon... So "master" / "replica" would work. Malcolm On Thursday, 5 June 2014 16:26:07 UTC+1, Justin Holmes wrote: > > I think I agree that "primary" is a bad choice. Can you

Re: Changing development server threads type.

2014-06-05 Thread Malcolm Box
On Wednesday, 4 June 2014 17:41:53 UTC+1, Ramiro Morales wrote: > > For this particular change I'd go with what Moayad proposes but > without the backward compatibility command line switch (assuming it > actually enhance the reloadind responsiveness). > > > I've tried the 1-liner version here

Re: Feature request: ttl method for cache

2014-05-09 Thread Malcolm Box
Ticket filed and pull request for fix https://code.djangoproject.com/ticket/22606 On 9 May 2014 10:38, Malcolm Box <malc...@tellybug.com> wrote: > > On Thursday, 8 May 2014 16:59:55 UTC+1, Piotr Gosławski wrote: >> >> I was fixing my little helper function to behav

Re: Feature request: ttl method for cache

2014-05-09 Thread Malcolm Box
On Thursday, 8 May 2014 16:59:55 UTC+1, Piotr Gosławski wrote: > > I was fixing my little helper function to behave more like Sean's and I > think I've found a bug in locmem. Could you please take a look at this: > > Either I'm missing something or has_key() is not working correctly for > keys

Re: Minor feature: Make TestCase pass the testcase instance to self.client's constructor

2013-01-05 Thread Malcolm Box
On Sat, Jan 5, 2013 at 9:11 AM, Shai Berger <s...@platonix.com> wrote: > On Friday 04 January 2013, Malcolm Box wrote: > > > > The general pattern I want to implement is have a test client that makes > > assertions about all the requests made during a set of tests.

Re: Minor feature: Make TestCase pass the testcase instance to self.client's constructor

2013-01-04 Thread Malcolm Box
On Wednesday, January 2, 2013 11:58:04 PM UTC, Russell Keith-Magee wrote: > > On Thu, Jan 3, 2013 at 1:56 AM, Malcolm Box <mal...@tellybug.com > > wrote: > >> Hi, >> >> When creating self.client in TestCase, it would be very useful if the >> testcase ins

Minor feature: Make TestCase pass the testcase instance to self.client's constructor

2013-01-02 Thread Malcolm Box
Hi, When creating self.client in TestCase, it would be very useful if the testcase instance was passed to the client. I'm using a replacement client class that does various validation checks, so wants to use assert* functions on TestCase, thus takes a testcase instance as a parameter at