Re: Filebrowser functionality in contrib?

2010-07-30 Thread Tobias McNulty
On Fri, Jul 30, 2010 at 1:54 AM, shacker  wrote:

> ... except that it's not working just fine (because of this dependency
> on Grappelli).


That sounds like a problem with the 3rd party app, not something that would
be resolved by incorporating it in Django proper. That said, as Russell
suggests, it may be possible to enhance the admin in ways that make writing
third party apps like this easier.

Cheers,
Tobias
-- 
Tobias McNulty
Caktus Consulting Group, LLC
P.O. Box 1454
Carrboro, NC 27510
USA: +1 (919) 951-0052
http://www.caktusgroup.com

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.



Re: Filebrowser functionality in contrib?

2010-07-29 Thread shacker
On Jul 29, 8:09 pm, Tobias McNulty  wrote:
>
> For whatever it's worth, my sense is that there are a number of these types
> of third party apps out there, and no single one is a clear winner.

I would have to respectfully disagree - FileBrowser is far and away
the clear winner. There are no viable alternatives that I can find (if
someone can point one out, I'm all ears).

>  Furthermore, I don't really see what adding file management to contrib
> gives us (it seems to work just fine as a third party app),

... except that it's not working just fine (because of this dependency
on Grappelli).

> and I'd hate to
> see innovation stifled at this stage by including one of the implementations
> in contrib.

I definitely agree in principle about not stifling innovation. But at
the same time, one of the important jobs of a framework is to handle
tasks that are common to many web sites. I'd say that file management
falls into that category.  But I certainly won't press on this if the
developers disagree.

On Jul 29, 8:28 pm, Russell Keith-Magee 
wrote:

> That said - I *would* be interested in any proposal to improve the
> interface that contrib.admin provides so would make it easier to plug
> in external features such as a file browser. If django-filebrowser has
> become dependent on Grapelli, I presume this was to leverage some
> benefit of Grapelli that Django's native admin wasn't providing. To
> me, this points at a deficiency in Django's admin that should be
> addressed.

The author stated the reason in a ticket once but  I'm having trouble
finding it. It was along the lines of what you're saying here. I'll
post something and see if I can get details on exactly what he was
trying to overcome.

Thanks for the feedback.

Scot

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.



Re: Filebrowser functionality in contrib?

2010-07-29 Thread Russell Keith-Magee
On Fri, Jul 30, 2010 at 11:09 AM, Tobias McNulty  wrote:
> On Thu, Jul 29, 2010 at 3:32 PM, shacker  wrote:
>>
>> I've been thinking that it seems like solid file management would be a
>> good candidate for inclusion in contrib, but wanted to put feeler out
>> on this list to see whether others might agree. Would this make a good
>> 1.3 feature?
>
> -1
> For whatever it's worth, my sense is that there are a number of these types
> of third party apps out there, and no single one is a clear winner.
>  Furthermore, I don't really see what adding file management to contrib
> gives us (it seems to work just fine as a third party app), and I'd hate to
> see innovation stifled at this stage by including one of the implementations
> in contrib.

I completely agree with Tobias.

The general description for a contrib app is a "defacto standard
implementation of a common pattern". While Grapelli's filebrowser may
be very useful functionality, I don't see it meeting these criteria.

That said - I *would* be interested in any proposal to improve the
interface that contrib.admin provides so would make it easier to plug
in external features such as a file browser. If django-filebrowser has
become dependent on Grapelli, I presume this was to leverage some
benefit of Grapelli that Django's native admin wasn't providing. To
me, this points at a deficiency in Django's admin that should be
addressed.

Yours,
Russ Magee %-)

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.



Re: Filebrowser functionality in contrib?

2010-07-29 Thread Tobias McNulty
On Thu, Jul 29, 2010 at 3:32 PM, shacker  wrote:
>
> I've been thinking that it seems like solid file management would be a
> good candidate for inclusion in contrib, but wanted to put feeler out
> on this list to see whether others might agree. Would this make a good
> 1.3 feature?


-1

For whatever it's worth, my sense is that there are a number of these types
of third party apps out there, and no single one is a clear winner.
 Furthermore, I don't really see what adding file management to contrib
gives us (it seems to work just fine as a third party app), and I'd hate to
see innovation stifled at this stage by including one of the implementations
in contrib.

Tobias
-- 
Tobias McNulty
Caktus Consulting Group, LLC
P.O. Box 1454
Carrboro, NC 27510
USA: +1 (919) 951-0052
http://www.caktusgroup.com

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.