Re: Schema editor changes feedback request

2014-01-05 Thread Michael Manfre
Thanks for the feedback. I've added answers to all of your questions and a few extra comments about why I did certain things. Feel free to ask more questions on the pull request or ping me on IRC. Regards, Michael Manfre On Sun, Jan 5, 2014 at 7:13 PM, Andrew Godwin wrote:

Re: Schema editor changes feedback request

2014-01-05 Thread Andrew Godwin
I've left some comments on the PR - the overall approach is fine, and I'm in favour of things like removing quote_parameter and adding params to the deferred_sql entries - but there's a few stylistic questions and I'm worried why you've removed the maximum index name length stuff. As for not

Schema editor changes feedback request

2014-01-04 Thread Michael Manfre
I've been working on making django-mssql support the schema migration changes that will be part of Django 1.7 and have a pull request [1] that is mostly complete. Before I continue down my current path, I'd like to solicit some feedback to help ensure my changes will get merged. I am currently