Re: r15580 breaks change list result template overwrites

2011-02-20 Thread Russell Keith-Magee
On Sun, Feb 20, 2011 at 7:43 AM, Russell Keith-Magee
 wrote:
> On Sunday, February 20, 2011, Sean Brant  wrote:
>> Looks like r15580 modified the way change list rows are returned. The
>> template used to just iterate over {{ result }} but now requires
>> iteration over {{ result.row }}.  This will breaking anyones templates
>> that happen to overwrite admin/change_list_results.html. Does
>> overwriting admin templates fall into public api territory?
>
> Srrictly, contrib.admin isn't covered by our backwards compatibility
> policy at all - see the official docs for details [1].
>
> That said, we try to minimize any incompatibilities, so it may be
> worth taking a closer look to see if this can be done in a way that
> doesn't affect the template context.

FYI - I've just pushed r15593, which modifies the way list_editable is
processed so that the old context names will continue to work, while
retaining the ability to retrieve the form information necessary to
display helpful error messages for the unique_together case.

Yours,
Russ Magee %-)

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.



Re: r15580 breaks change list result template overwrites

2011-02-19 Thread Russell Keith-Magee
On Sunday, February 20, 2011, Sean Brant  wrote:
> Looks like r15580 modified the way change list rows are returned. The
> template used to just iterate over {{ result }} but now requires
> iteration over {{ result.row }}.  This will breaking anyones templates
> that happen to overwrite admin/change_list_results.html. Does
> overwriting admin templates fall into public api territory?

Srrictly, contrib.admin isn't covered by our backwards compatibility
policy at all - see the official docs for details [1].

That said, we try to minimize any incompatibilities, so it may be
worth taking a closer look to see if this can be done in a way that
doesn't affect the template context.

[1] http://docs.djangoproject.com/en/1.2/misc/api-stability/

Yours,
Russ Magee %-)

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.



r15580 breaks change list result template overwrites

2011-02-19 Thread Sean Brant
Looks like r15580 modified the way change list rows are returned. The
template used to just iterate over {{ result }} but now requires
iteration over {{ result.row }}.  This will breaking anyones templates
that happen to overwrite admin/change_list_results.html. Does
overwriting admin templates fall into public api territory?

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.