Re: How to disable system check framework?

2015-08-05 Thread Carlton Gibson
Sorry to be a pain but, could this thread be continued (if it's going to be) on Django Users? (sorry) — On Wed, Aug 5, 2015 at 3:59 PM, Marcin Nowak wrote: > Hi Aymeric, > This project is complex, as I said before, and works well with Django 1.4. > But we need

Fellow Reports -- May 2018

2018-05-15 Thread Carlton Gibson
Hi all, Calendar Week 18 -- ending 4th May. Reviewed Patches on: https://code.djangoproject.com/ticket/8936 -- Add view (read-only) permission to admin https://code.djangoproject.com/ticket/29376 -- admin improvement: Take into account `show_save_and_add_another`…

Fellow Reports -- June 2018

2018-06-18 Thread Carlton Gibson
Hi all, Calendar Week 23 -- ending 8th June. Reviewed Patches on: https://code.djangoproject.com/ticket/29301 -- Reorder management command arguments in --help output to prioritize command-specific arguments https://code.djangoproject.com/ticket/29353 -- _middleware_chain is not set for

Re: Fellow Reports -- May 2018

2018-05-30 Thread Carlton Gibson
Hi all. Calendar Week 20 -- ending 18th May. Reviewed Patches on: https://code.djangoproject.com/ticket/29408 -- ordering by field from related model does not validate if field exists https://code.djangoproject.com/ticket/28743 -- Clarify the term "deployment server" in the documentation

Re: #29433 New split template filter

2018-05-30 Thread Carlton Gibson
Hi Kamil, I'd think the preference here would be to NOT add new filters lightly — i.e. to close as wontfix — and recommend users create their own filters (or pull the logic into say a `get_context()` method) if they need this kind of thing. Slight aside: "Hi guys" may not fairly address

Django bugfix release 2.0.6

2018-06-01 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2018/jun/01/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers

Re: Fellow Reports -- May 2018

2018-06-04 Thread Carlton Gibson
Hi all, Calendar Week 22 -- ending 1st June. Reviewed Patches on: https://code.djangoproject.com/ticket/29301 -- Reorder management command arguments in --help output to prioritize command-specific arguments https://code.djangoproject.com/ticket/29419 -- Document the change in permissions

Django bugfix releases: 2.0.7 and 1.11.14

2018-07-02 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2018/jul/02/bugfix-releases/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and

Re: Fellow Reports -- June 2018

2018-07-02 Thread Carlton Gibson
Hi all, Calendar Week 25 -- ending 22nd June. Reviewed Patches on: https://code.djangoproject.com/ticket/29504 -- JSONField dictionary/object lookup using an "integer" key https://code.djangoproject.com/ticket/29503 -- Order of parameters pass to __in lookup affected by de-duplication.

Re: Fellow Reports -- April 2018

2018-05-01 Thread Carlton Gibson
Hi all, Calendar Week 17 -- ending 27th April. Reviewed Patches on: https://code.djangoproject.com/ticket/8936 -- Add view (read-only) permission to admin https://code.djangoproject.com/ticket/29353 -- _middleware_chain is not set for StaticFilesHandler

Re: Fellow Reports -- April 2018

2018-04-26 Thread Carlton Gibson
Hi all, Calendar Week 16 -- ending 20th April. Reviewed Patches on: https://code.djangoproject.com/ticket/28462 -- ModelAdmin.list_editable unusably slow and memory intensive with large datasets https://code.djangoproject.com/ticket/28600 -- Add prefetch related support to RawQuerySet

Re: improving our Contributor License Agreement process

2018-01-11 Thread Carlton Gibson
I started reviewing patches according to the check-list this morning and, for first-time contributors, I was wondering how to validate the CLA status. Tim pointed me here. There is now (what looks like) a viable third-party provider: https://cla-assistant.io Amongst others, Microsoft use

Re: improving our Contributor License Agreement process

2018-01-11 Thread Carlton Gibson
icality. I'm not a lawyer. > > On Thursday, January 11, 2018 at 9:27:17 AM UTC-5, Carlton Gibson wrote: >> >> I started reviewing patches according to the check-list this morning and, >> for first-time contributors, I was wondering how to validate the CLA >>

Re: improving our Contributor License Agreement process

2018-01-11 Thread Carlton Gibson
On Thursday, 11 January 2018 18:01:23 UTC+1, Marc Tamlyn wrote: > > But I don't think we need to enforce it for any contribution. > OK. I think that's the key. If that's the view then we can go on as is. Thanks all.  C. -- You received this message because you are subscribed to the

Fellow Report — January 19, 2018

2018-01-19 Thread Carlton Gibson
Hi All. This week I reviewed patches on: https://code.djangoproject.com/ticket/24747 -- Allowed transforms in order_by() https://code.djangoproject.com/ticket/28977 -- Change Local Memory Cache to use LRU https://code.djangoproject.com/ticket/28881 -- Documented that CommonPasswordValidator

Re: Default Authorization BackEnd Denying Permissions if Object Provided

2018-01-22 Thread Carlton Gibson
Hi Mehmet, Sorry for the slow reply. I didn't have capacity to return to this last week. > Hey Carlton ... What do you say? Well, my first thought is that I don't see any great consensus for a change here. I don't see it as **my** decision to make. This has been open a while, however,

Fellow Report -- January 26, 2018

2018-01-26 Thread Carlton Gibson
Hi All. This week I reviewed patches on: https://code.djangoproject.com/ticket/25790 -- Added option to disable column sort in admin changelist https://code.djangoproject.com/ticket/20118 -- Default authorization backend returns False when queried for object level permissions

Re: Default Authorization BackEnd Denying Permissions if ObjectProvided

2018-01-17 Thread Carlton Gibson
Hi. @Andrew: I'll look at your post anon, as it's longer. On Wednesday, 17 January 2018 20:46:27 UTC+1, Mehmet Dogan wrote: > > Can you give an example of what you mean by option 3. > Well, I don't a concrete suggestion in mind, but the general idea would be to have ModelBackend proxy to

Re: Default Authorization BackEnd Denying Permissions if Object Provided

2018-01-17 Thread Carlton Gibson
Hi Mehmet, Due to the BC issues, this is fairly in-depth. Having looked at the history, here are my initial thoughts. The initial issue here is this behaviour from `ModelBackend`: ``` user.has_perm('foo.change_bar', obj) False user.has_perm('for.change_bar') True ``` Although the

Re: Fellow Report — January 12, 2018

2018-01-16 Thread Carlton Gibson
On Wednesday, 17 January 2018 00:34:11 UTC+1, Josh Smeaton wrote: > > Welcome, and nice work! I've seen some of the reviews you've made and > you're straight into the deep end. > Thanks Josh. Too deep maybe  — but yes. I'm just happy to be able to work on Django. It's given me SO much.

Re: Default Authorization BackEnd Denying Permissions if Object Provided

2018-01-17 Thread Carlton Gibson
Hi Florian, I was hoping you'd post. You've been active on the entire (very-long) history of this issue. Can I ask for your take? Given your comment, would it be along the lines of "Close as "Won't Fix", perhaps with a review of the documentation", to point users to subclassing

Re: New contributor to Django with a ticket in mind

2018-01-14 Thread Carlton Gibson
Hi Jatin, Welcome! > Can I take this up from scratch? I think the short answer there is going to be Yes :-) The history on that ticket is long. (There's the issue over updating primary keys vs how those are handled in the Admin; either seems legitimate.) Once you have an idea it might be

Fellow Report — January 12, 2018

2018-01-12 Thread Carlton Gibson
Hi all, With help from Tim, Aymeric and Frank, I got started on the fellowship this week. (Thank you all!) I've Reviewed Patches on: https://code.djangoproject.com/ticket/24747 -- Allowed transforms in QuerySet.order_by() https://code.djangoproject.com/ticket/29002 -- Corrected cached

Fellow Report -- February 5, 2018

2018-02-05 Thread Carlton Gibson
Hi all, Last week I reviewed patches on https://code.djangoproject.com/ticket/29076 -- Changed .refresh_from_db() to clear cached relationships. https://code.djangoproject.com/ticket/29036 -- Changed SelectDateWidget's empty value https://code.djangoproject.com/ticket/29082 -- Make the test

Re: ticket 28404

2018-02-08 Thread Carlton Gibson
Hi Collin, Thanks. That's perfect.  Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Method for allowing different `MAIL FROM` or `Return-Path` and `From` headers.

2018-02-08 Thread Carlton Gibson
Hi Ian, As you describe it here, this sounds quite reasonable. It seems worth a Trac ticket. * We need `Return Path` because ... * Currently possible but ... * Either document or add new `return_path` parameter. My initial thought is that a `Note` block in the docs explaining the approach

Fellow Report -- February 12, 2018

2018-02-11 Thread Carlton Gibson
Hi all. Last week I reviewed patches etc on the following tickets: https://code.djangoproject.com/ticket/27728 -- Allowed overriding admin templatetag's templates. https://code.djangoproject.com/ticket/25790 -- Add a way to disable column sorting in the admin

Re: Connection or integration Between two Apps in djnago 2.0

2018-02-12 Thread Carlton Gibson
Hi. This list is for contributions to Django. For usage questions please post to Django Users. https://groups.google.com/forum/#!forum/django-users Thanks. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)"

Re: ticket 28404

2018-02-07 Thread Carlton Gibson
[Better Subject] Fix admin change list display of empty string values. I'll summarise; I'd like to elicit any objections. The issue is that the admin change list doesn't display the "empty value" placeholder for empty strings, which is the recommended way of handling "nullable" CharFields.

Fellow Report -- February 19, 2018

2018-02-19 Thread Carlton Gibson
Hi All, Last week I reviewed patches (etc) on: https://code.djangoproject.com/ticket/21381 -- Remove contrib.redirects dependency on contrib.sites https://code.djangoproject.com/ticket/18937 -- Use modern Python packaging metadata standard (1.2, PEP 345)

Fellow Report -- February 26, 2018

2018-02-25 Thread Carlton Gibson
Hi all, Last week I reviewed patches on the following tickets: https://code.djangoproject.com/ticket/27449 -- Added get_supported_language_variant to public API https://code.djangoproject.com/ticket/28755 -- django.utils.translation.check_for_language doesn't check in the app folders

Re: Fellow Reports -- July 2018

2018-07-30 Thread Carlton Gibson
Hi all, Calendar Week 30 -- ending 29 July. Triaged: https://code.djangoproject.com/ticket/29598 -- contrib.postgres.FloatRangeField should be renamed DecimalRangeField (Accepted) https://code.djangoproject.com/ticket/29599 -- chunk_size for InMemoryUploadedFile is not used (Invalid)

Help wanted testing proposal for the Migration Graph algorithm

2018-07-26 Thread Carlton Gibson
Hi all. Do you have a project with a slow and complicated migration history? If so, any chance you could lend a brief hand testing? See https://github.com/django/django/pull/9804 This refactors the migration graph algorithm and in principle should make it significantly faster. (More or less

Re: Fellow Reports -- July 2018

2018-07-25 Thread Carlton Gibson
Hi all, Calendar Week 28 -- ending 15th July. Reviewed: https://github.com/django/django/pull/10151 -- Add check for type of ALLOWED_HOSTS https://code.djangoproject.com/ticket/28598 -- BCC addresses are ignored in the console and file email backends

Re: HTML5 and XHTML5 documents

2018-08-17 Thread Carlton Gibson
Hi Nils. > ... and an issue (#29681), which was prematurely closed as wontfix. As per the when you already re-opened #29038 on this issue, there now needs to be a consensus here before we can (or will) consider a new ticket for this. That's not "premature" — it's just how the project

Re: Discussion: ModelForms not allowing unbounded RangeField values

2018-08-17 Thread Carlton Gibson
Hey James, Thanks for your follow-up here. I think for me the thing that's compelling is the flow you describe in comment 12 : * A user renders an unbound model form, where all model fields have defaults. * The form is pre-filled with

Fellow Reports -- August 2018

2018-08-06 Thread Carlton Gibson
Hi all, Calendar Week 31 -- ending 05 August. Triaged: https://code.djangoproject.com/ticket/29632 -- After migrating a Django project from Python 2 to 3, db migration of django.contrib.sites fails with TypeError: attribute name must be string, not bytes (needsinfo)

Re: Fellow Reports -- August 2018

2018-08-13 Thread Carlton Gibson
Hi all, Calendar Week 32 -- ending 12 August. Triaged: https://code.djangoproject.com/ticket/29649 -- admin readonly_fields with unique_together raises IntegrityError (Duplicate of #13091) https://code.djangoproject.com/ticket/29643 -- Hashing list in Q objects when using __in lookup

Re: #24483 fix breaks dynamic choices

2018-08-14 Thread Carlton Gibson
It's not clear from your OP what you mean by "dynamic choices" (I can still provide a callable; is that not "dynamic"?) Your best bet it to draw up a reproducible example (or even better a test case) of exactly the behaviour that used to work but now doesn't. I'd suggest putting that in a

Re: Help wanted testing proposal for the Migration Graph algorithm

2018-08-14 Thread Carlton Gibson
Thanks Jeff. Super. (PR is fine ) -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: HTML5 and XHTML5 documents

2018-08-23 Thread Carlton Gibson
Hi Nils. Tim's original advice still stands: > Have you tried creating custom widget templates for XHTML? > https://docs.djangoproject.com/en/stable/ref/forms/renderers/ Once you have widget templates in place, if there are particular issues you are facing we can consider them but the

Re: Help wanted testing proposal for the Migration Graph algorithm

2018-08-20 Thread Carlton Gibson
Making the script less noisy here I commented out the actual work. (So it didn't function as a test.) (No comment. ) Corrected version: ``` import sys from django.db import connection from django.db.migrations.loader import MigrationLoader loader = MigrationLoader(connection) backwards =

Re: GDPR and parent domain cookies

2018-08-27 Thread Carlton Gibson
Hi Vasili and Micheal. I misread `SafeExceptionReporterFilter` as implementing the key `ExceptionReporter` method. I totally agree with the assessment. Have reopened and Accepted on that basis. Good work! Thank you! Carlton -- You received this message because you are subscribed to the

Re: The behavior of QueryDict.get(_key_, _default=None_)

2018-07-19 Thread Carlton Gibson
Hi Philip. This is unlikely(!!!) to be changed. As it says on the ticket, it's considered a feature, not a bug. The usual case is to need a single value from the query string, so `[]` and `get()` both return scalars. `getList()` exists specifically for the case where you do want multiple

Re: Django bugfix release: 2.1.1

2018-09-01 Thread Carlton Gibson
, Carlton On Saturday, 1 September 2018 17:30:46 UTC+2, Paulo Maciel wrote: > > pip install Django==2.1.1 > Could not find a version that satisfies the requirement Django==2.1.1 > > Em sexta-feira, 31 de agosto de 2018 05:52:28 UTC-3, Carlton Gibson > escreveu: >>

Re: Fellow Reports -- August 2018

2018-09-02 Thread Carlton Gibson
Hi all, Calendar Week 35 -- ending 31 August. Triaged: https://code.djangoproject.com/ticket/29723 -- Backwards-incompatible change of has_add_permission in 2.1 (Accepted.) https://code.djangoproject.com/ticket/29714 -- Option to hide cookies in error reports (Accepted.)

Re: Django bugfix release: 2.1.1

2018-09-02 Thread Carlton Gibson
Cool. Thanks Adam! -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To

Adjusting MRO of the CBVs

2018-09-06 Thread Carlton Gibson
There's a ticket adjusting the MRO of DeleteView. https://code.djangoproject.com/ticket/29735 I'm closing this as `wontfix`: * It's nice in theory but... * not worth the breaking change. I'm posting here because I'm half-inclined to a Someday/Maybe (any least): surely, improving the

Fellow Reports -- September 2018

2018-09-10 Thread Carlton Gibson
Hi all, Calendar Week 36 -- ending 09 September. Triaged: https://code.djangoproject.com/ticket/29741 -- There is no way to validate a ModelAdmin against it's inline formsets (Invalid) https://code.djangoproject.com/ticket/29739 -- BaseModelFormSet ignores excess rows in initial when extra

Re: Passing initial data to model formsets - a suggested improvement

2018-09-10 Thread Carlton Gibson
Hi Mark. What I'm not sure about here is how things have changed from Carl's original observation in the comment you link. On Thursday, 6 September 2018 13:53:05 UTC+2, Mark Gensler wrote: > > https://code.djangoproject.com/ticket/16995#comment:1 > > ... if it's an improvement at all, it's

Django bugfix release: 2.1.1

2018-08-31 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2018/aug/31/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Re: Help wanted testing proposal for the Migration Graph algorithm

2018-08-30 Thread Carlton Gibson
Hi Dan. Super! On Tuesday, 28 August 2018 17:28:32 UTC+2, d...@thread.com wrote: > > I've run it on our codebase with ~1100 migrations and ~380 apps. > Yes! This is what I was looking for. > There were no exceptions thrown - the script completed cleanly, although I > haven't actually

Re: Fellow Reports -- August 2018

2018-08-30 Thread Carlton Gibson
Hi all, Calendar Week 33 -- ending 19 August. Triaged: https://code.djangoproject.com/ticket/29672 -- Returns an empty model field that is filled with a trigger in the database. (Invalid) https://code.djangoproject.com/ticket/29656 -- Range Fields do not support blank values via ModelForm

Re: MariaDB, official support

2018-07-05 Thread Carlton Gibson
This seems a bit more pressing now: 2.0.7 broke MariaDB compatibility. https://code.djangoproject.com/ticket/29544 I'm sure that can be fixed. But we're in a tricky position now. Claude has marked the ticket as a Release Blocker, which is understandable, but I can't see how we can both

Fellow Reports -- July 2018

2018-07-11 Thread Carlton Gibson
Hi all, Calendar Week 27 -- ending 6th July. Reviewed: https://code.djangoproject.com/ticket/28540 -- Document changes to file upload permissions in Django 1.11 https://code.djangoproject.com/ticket/29544 -- Add a MariaDB database backend Triaged:

Re: Jenkins resources

2018-07-12 Thread Carlton Gibson
Hi Matt, The Jenkins configuration is not public I'm afraid. I'm one of the Django Fellows. If you wanted to invite me to your VSTS project I would be happy to review and offer pointers as you did the actual work, assuming that would help? The main thing would be setting up the grid of

Re: Cast with AutoField results in a 'type does not exist' error in PostgreSQL 10.1

2018-07-12 Thread Carlton Gibson
Hi Andrew, Reading the description, it seems like you may have hit a bug. Could you possibly put this into an actual test case and open a PR (plus Trac ticket) with that assuming the test fails? With code in hand it's much easier to assess (and fix). Thanks. Kind Regards, Carlton --

Re: Jenkins resources

2018-07-12 Thread Carlton Gibson
Hi Matt, The settings files from the django-box project are here: https://github.com/django/django-box/tree/master/roles/djangodata/files If you look in each, you'll see they basically just redefine the connection details for the 'default' and 'other' DB. (There's not much more to it really.)

Re: About #8500 and #27728

2018-01-20 Thread Carlton Gibson
Hi Raffaele, Thanks for both your effort and your patience. There are around 60 patches needing review (or just reviewed or being improved or...) at the moment, so it can take a while to get to. I will look at this issue on Monday. Please don't loose heart.  Kind Regards, Carlton On

Re: About #8500 and #27728

2018-01-22 Thread Carlton Gibson
Hi Raffaele, I took a look at both these PRs — they both seem like good wins to me. I've commented briefly on the issues. Here I would just ask if people using the Admin have capacity to review that would be great. (If not I'm inclined to push these forwards.) *

Re: Default Authorization BackEnd Denying Permissions if ObjectProvided

2018-01-24 Thread Carlton Gibson
Hi Mehmet On Tuesday, 23 January 2018 15:05:06 UTC+1, Mehmet Dogan wrote: > > Do you think what Florian or I sent is a good example to include in the > docs for the way #1? > Yes. I was just looking for where. Candidates: *

Fellow Report -- March 12, 2018

2018-03-12 Thread Carlton Gibson
Hi All, Last week I reviewed patches on the following issues: https://code.djangoproject.com/ticket/28574 -- Add Queryset.explain() method https://github.com/django/django/pull/9752 -- Minor fixes to improve install.txt's clarity https://code.djangoproject.com/ticket/29180 -- makemigrations

Re: Improving usefulness of management command help output via reordering options

2018-04-06 Thread Carlton Gibson
Hi David. Your suggestion seems sensible, good even. (To me at least. ) If you'd be happy to do the work for it then a Trac ticket + PR would be the way to go. (Assuming there are no objections.) Kind Regards, Carlton On Friday, 6 April 2018 01:24:12 UTC+2, David Foster wrote: > >

Re: Should ModelChoiceIterator cache its QuerySet?

2018-04-10 Thread Carlton Gibson
Hi François, Thank you for a good write-up of the issue. Having looked at this from each direction I can't see a way of squaring all the desires here. I see the possibility of an inconsistency between the __len__() and __iter__() calls. This would certainly be nice to avoid but I'm not sure

Design Decision: GFK Reverse Lookups

2018-04-10 Thread Carlton Gibson
Hi All. https://github.com/django/django/pull/9748 adds the ability to perform simple queries on a generic foreign key: TaggedItem.objects.filter(content_object=object_instance) You still can't do anything more complex, such as: TaggedItem.objects.get(content_object__name='Diamond')

Fellow Reports -- April 2018

2018-04-18 Thread Carlton Gibson
Hi All, Calendar Week 14 — ending 6th April. I reviewed patched on: https://code.djangoproject.com/ticket/28462 -- ModelAdmin.list_editable unusably slow and memory intensive with large datasets https://code.djangoproject.com/ticket/27991 -- Add 'obj' kwarg to

Fellow Report -- April 1, 2018

2018-04-01 Thread Carlton Gibson
Hi All. Week ending 23/3 I reviewed patches on: https://code.djangoproject.com/ticket/29173 -- Document that Model.save() doesn't refresh fields from the database https://code.djangoproject.com/ticket/28574 -- Add Queryset.explain() method https://code.djangoproject.com/ticket/23406 -- Allow

Fellow Report -- March 19, 2018

2018-03-19 Thread Carlton Gibson
Hi all. Last week I reviewed patches on: https://code.djangoproject.com/ticket/23406 -- Migrations not found when only .pyc files are available (e.g. in a frozen environment) https://code.djangoproject.com/ticket/28184 -- FileField storage param should allow a callable

Fellow Report -- March 5, 2018

2018-03-05 Thread Carlton Gibson
Hi all, Last week I reviewed patches (etc) on: https://code.djangoproject.com/ticket/18620 -- Prefer current Site when checking M2M in "shortcut"/"view_on_site" redirect https://code.djangoproject.com/ticket/3461 -- DatabaseWrapper should pass through args and kwargs to underlying database

Widening participation (Thoughts from DjangoCon)

2018-10-26 Thread Carlton Gibson
Hi All. OK, so last week I was at DjangoCon US in San Diego. (Thank you if you organised that! Hi! if we met and chatted.) I gave a talk ("Your web framework needs you!") inspired by the discussion on the DSF list and

Re: Python string formatting

2018-10-31 Thread Carlton Gibson
We had a bit of a discussion of this on Python 2 docs have got this re format(): > This method of string formatting is the new standard in Python 3, and should be preferred to the % formatting described in String Formatting Operations in new code.

Re: Python string formatting

2018-10-31 Thread Carlton Gibson
Sorry, I typed that up and forgot to paste the link  On Wednesday, 31 October 2018 20:14:14 UTC+1, Carlton Gibson wrote: > > We had a bit of a discussion of this on > https://code.djangoproject.com/ticket/29623 -- You received this message because you are subscribed to the Goog

Re: race condition on making directories when multiple files are uploaded to the same folder

2018-11-01 Thread Carlton Gibson
Yep. Coming up shortly... On Thursday, 1 November 2018 13:45:20 UTC+1, Tim Graham wrote: > > It's in a regression in Django 2.0 that will be fixed in today's 2.1.3 > release. > https://code.djangoproject.com/ticket/29890 > -- You received this message because you are subscribed to the Google

Django bugfix release: 2.1.3

2018-11-01 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2018/nov/01/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Re: Fellow Reports -- October 2018

2018-10-31 Thread Carlton Gibson
Hi all, Calendar Week 43 -- ending 28 October. Triaged: https://code.djangoproject.com/ticket/29889 -- ArrayField cannot contain JSONField; causes SQL error (needsinfo) https://code.djangoproject.com/ticket/29879 -- CSRF AJAX section should warn about the CSRF_COOKIE_HTTPONLY setting

Fellow Reports -- November 2018

2018-11-05 Thread Carlton Gibson
Hi all, Calendar Week 44 -- ending 04 November. Released: Django v2.1.3 Triaged: https://code.djangoproject.com/ticket/29917 -- admin.E130 (__name__ uniqueness) regression (needsinfo) https://code.djangoproject.com/ticket/29905 -- Can you fix ticket 26171 in 1.8.x (wontfix)

Re: Make input field remove newlines from value

2018-11-02 Thread Carlton Gibson
Hi Jakub. Definitely stripping input isn't something I'd want to add: what if I want to accept input with trailing whitespace? Rather, the approach is to transform the incoming data in your form or serialiser at the clean or validation step. See: *

Fellow Reports -- October 2018

2018-10-25 Thread Carlton Gibson
Hi all, Calendar Week 40 -- ending 07 October. Released Django versions 1.11.16, 2.0.9 and 2.1.2. Triaged: https://code.djangoproject.com/ticket/29818 -- ValueError when parsing querydata to autofill a Django admin form (needsinfo) https://code.djangoproject.com/ticket/29821 -- Add

Re: Proposal to remove ModelAdmin's collection of actions from superclasses

2018-11-05 Thread Carlton Gibson
The idea was that you could define a base admin and have the actions appear without having to redeclare them. The only question is are people actually using that? (I can't think of a third-party app that provides an admin with actions that you're meant to subclass for instance — anyone?) If

Re: Proposal to extend support for object permission

2018-11-08 Thread Carlton Gibson
Hi Tobias, Thank you for your effort here. Sorry for the slowish response: it's just a question of getting round to it. The basic issue here is people what to avoid this: if user.has_perm('foo.change_bar', obj=bar) or user.has_perm('foo.change_bar'): ... (Or they find it

Re: Proposal to extend support for object permission

2018-11-08 Thread Carlton Gibson
:55:54 UTC+1, Tobias Bengfort wrote: > > On 08/11/2018 11:43, Carlton Gibson wrote: > > My only concern thus far is bringing out the change well enough in the > > release notes and docs. > > (Split between the two PRs I'm not sure it quite does that.) > > My imp

Re: Postgres PGCrypto in Django?

2018-11-08 Thread Carlton Gibson
Hi Peter, Thanks for the follow-up here. For me, optional field-level encryption would be a cool addition. Can I solicit some opinions: * Do we think this would merit a place in `contrib.postgres` (vs the third-party package)? * Postgres buffs: any comment on the actual implementation?

Re: Extending django.contrib.auth.models Group name to be 191 character max_length

2018-11-14 Thread Carlton Gibson
(Before I start, I'm +1 but... ) Just having a quick go over the history here... * Original discussion floated a change to 100 or 150 chars. * Aymeric valued fixing the issue for 99.999% of cases. * Tom Christie wanted an "human value", not a machine one. 100 chars was suggested.

Re: easy pcikings

2018-11-04 Thread Carlton Gibson
Hi Abhith. Have a look at the Triage Workflow docs: https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/#triage-stages For each stage of the ticket's lifecycle they give you what's next. (e.g. if it's "New", can you reproduce the issue so it can move to "Accepted",

Re: Can we remove FILE_CHARSET?

2018-10-03 Thread Carlton Gibson
Thanks for the input everyone. So Jon, are you basically saying that Vasili's concern shouldn't come up? (That the whole "SQL data files" bit is misleading...?) -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)"

Re: Can we remove FILE_CHARSET?

2018-10-03 Thread Carlton Gibson
Thanks for the follow-up Jon. I'll let Vasili follow-up on his use-case if possible/relevant. TBH I'm not at all sure about the SQL data files bit, which is in part why I asked here. (Encoding issues!) > Maybe that sentence should be rephrased to "template files, static files, and

Django bugfix releases 1.11.16 and 2.0.9

2018-10-01 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2018/oct/01/bugfix-releases/ -- You received this message because you are subscribed to the Google Groups "Django developers

Django security release issued: 2.1.2

2018-10-01 Thread Carlton Gibson
Today the Django team issued 2.1.2 as part of our security process. This release address a security issue, and we encourage all users to upgrade as soon as possible: https://www.djangoproject.com/weblog/2018/oct/01/security-release/

Re: Adjusting Django's security notification policy

2018-10-03 Thread Carlton Gibson
On Sunday, 30 September 2018 06:51:41 UTC+2, James Bennett wrote: > > Does anyone else have feedback on this? I'd like to push it forward. > I don't know if this would fly but, given that pre-notification is mainly thought of for large-scale ("enterprise"?) deployments that can't realistically

Can we remove FILE_CHARSET?

2018-10-03 Thread Carlton Gibson
> FILE_CHARSET (default:'utf-8') > The character encoding used to decode any files read from disk. This includes template files and initial SQL data files. Is there anywhere where this isn't UTF-8? (Or can't be decreed to be so?) Jon has a suggestion to remove it: Ticket:

Re: Fellow Reports -- September 2018

2018-10-01 Thread Carlton Gibson
Hi all, Calendar Week 37 -- ending 16 September. Triaged: https://code.djangoproject.com/ticket/29758 -- Document testing custom error handlers (Accepted) https://code.djangoproject.com/ticket/29750 -- Add a pre-dispatch() hook for class-based views (Accepted) Reviewed:

Re: Adding a database-agnostic JSONField into Django

2018-10-04 Thread Carlton Gibson
This has come up again, with an example implementation for Oracle: https://code.djangoproject.com/ticket/29821 Anyone know of an SQLite implementation? -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.

Re: Adding a database-agnostic JSONField into Django

2018-10-04 Thread Carlton Gibson
exists: > https://www.sqlite.org/json1.html > > According to the release history (https://sqlite.org/changes.html) this > was added in version 3.9.0 (2015-10-14). > > But I have no direct experience working with it. > > On Thu, Oct 4, 2018 at 12:19 AM Carlton Gibson > wrote: &g

Re: Adjusting Django's security notification policy

2018-10-03 Thread Carlton Gibson
received > a pre-notification. And that's terrible as well. > > My 2¢ > > Markus > > On Wed, Oct 3, 2018, at 9:14 AM, Carlton Gibson wrote: >> >> On Sunday, 30 September 2018 06:51:41 UTC+2, James Bennett wrote: >>> >>> Does anyone else hav

Fellow Reports -- January 2019

2019-01-16 Thread Carlton Gibson
Hi All, Calendar Week 2 -- ending 13 January. Triaged: https://code.djangoproject.com/ticket/30097 -- InlineModelAdmin.has_add_permission() requires obj argument (Accepted) https://code.djangoproject.com/ticket/30096 -- Use case of extra() (invalid) Reviewed:

Re: status of 2.2 release blockers

2019-01-16 Thread Carlton Gibson
Hi Vaclav, I think current status is "Still work to do" there, so not really... C. On Wednesday, 16 January 2019 17:52:17 UTC+1, Václav Řehák wrote: > > Hi, > > is it possible to get this fix included in 2.2? > > https://github.com/django/django/pull/10643 - Fixed #29915 -- Support >

Re: [Looking for feedback] Make Admin raw_id_fields the default choice for FKs, or project-wide configurable

2019-01-17 Thread Carlton Gibson
On Thursday, 17 January 2019 16:14:31 UTC+1, Collin Anderson wrote: > > One problem with any of the alternatives (besides making it readonly by > default) is that it requires the other model to be registered in the admin > Off-hand I don't follow you here. Can you explain. > I hope

Re: [Looking for feedback] Make Admin raw_id_fields the default choice for FKs, or project-wide configurable

2019-01-18 Thread Carlton Gibson
> On 18 Jan 2019, at 17:20, Santiago Basulto wrote: > > Seems like everybody agrees that for large sites, it's necessary. Hang on, slow down.  Personally, I’m not sure it’s too onerous as-is. I’ve not yet seen exactly why subclassing ModelAdmin in one’s project isn’t good enough. It really

Re: [Looking for feedback] Make Admin raw_id_fields the default choice for FKs, or project-wide configurable

2019-01-19 Thread Carlton Gibson
> On 19 Jan 2019, at 11:48, Santiago Basulto wrote: > > Haha, sorry, got overly excited. What's the usual process to make these sort > of decisions in these cases? Should we ask the users list? No problem. :) We make decisions here. Say you’d have opened a Trac ticket for this, I’d have

Re: Introduction GSoC

2019-01-21 Thread Carlton Gibson
Hi Folks. First off: can we please keep it civil. Let's offer positive responses where possible. Thanks There's no harm in people asking for help: there is a contributing guide, but if folks aren't finding it, perhaps we need a bigger sign-post. So... The place to begin is here:

  1   2   3   >