Re: Post mortem on today's packaging error.

2019-02-12 Thread Carlton Gibson
Hi All, Thanks for all the comments. Cloning to a tmp folder and checking out a specific commit is both quick and easy. That's not a bad idea: it should eliminate the point of failure that occurred here. (The `git clean` step should do that too, we use the `fdx` flags to eliminate ignored

Re: Post mortem on today's packaging error.

2019-02-12 Thread Luke Plant
Hi Carlton, I have had problems in the past with `setup.py sdist` and friends actually depending on existing artefacts in build directories from previous runs. A quick google turns up this bug report - https://github.com/pypa/setuptools/issues/436 - originally filed by oh, me :-)  and

Re: Post mortem on today's packaging error.

2019-02-12 Thread Aleksi Häkli
Jazzband (https://jazzband.co/about/releases) uses an approach that builds and pushes the PyPI packages to an intermediate repository that is owned by the Jazzband organization. The Jazzband intermediate repository then allows publishing them from the Jazzband organization to PyPI via a

Re: Post mortem on today's packaging error.

2019-02-11 Thread Florian Apolloner
On Monday, February 11, 2019 at 11:01:55 PM UTC+1, Adam Johnson wrote: > > Jamesie’s suggestion to use CI is also valid but a bunch more work. I > guess the main advantage is you get a blank slate container to work in, > which a fresh checkout to a temp dir provides most of the gain for less

Re: Post mortem on today's packaging error.

2019-02-11 Thread Adam Johnson
Thanks for the detailed post mortem Carlton. Andrew’s suggested approach to do at least a checkout to a fresh directory makes sense to me. Even got checkout and clean aren’t enough to bring an exisiting checkout folder to the same state as git won’t touch files in the gitignore. Note you can do a

Re: Post mortem on today's packaging error.

2019-02-11 Thread Jamesie Pic
Hi Carlton ! Seems like you're having as much fun as I had when doing releases manually :D Just sharing some food for thought here. Nowadays I have it automated and rely on setupmeta to keep myself away from touching setup.py, and just have to push git tags : http://github.com/zsimic/setupmeta

Re: Post mortem on today's packaging error.

2019-02-11 Thread Andrew Godwin
I also ran into this several times while releasing Channels - several releases had the wrong files ship out in them due to Git weirdness. In the end, my solution was to build the release artifacts over on Travis to guarantee a fresh build environment each time, but I doubt that would work for