Re: Admin hstore widget

2016-03-08 Thread Marc Tamlyn
I wouldn't say nobody understands it, Elky in particular will have a good
working knowledge given he wrote the 1.9 skin. That doesn't mean there's a
set of rules it follows. We certainly don't follow any particular front end
standard such as BEM for class names. I'm pretty sure it's only a year ago
a completely raw JS widget was rewritten with jQuery.

On 8 March 2016 at 10:40, Curtis Maloney  wrote:

>
>
> On 08/03/16 20:47, Marc Tamlyn wrote:
>
>> Doing something better with the admin hstore is definitely something I'd
>> like to see land.
>>
>> 1. I'd like more input on the features people feel are essential.
>> Something that allows you to add/change/delete keys is all you need to
>> start with. Features like soft delete can be added later.
>>
>
> OK, well, I'll pare down the code and make a PR soon.
>
> 2. Is there a guide somewhere to styles and markup to be used in admin
>> templates?
>> No, in short. Keep it simple seems to be the best advice I can give -
>> most of the code is very old.
>>
>
> So nobody understands the HTML and CSS used in Admin?
>
> Someone must, since there are a few skins for it, and someone just redid
> our skin for 1.9...
>
> 3. I plan to pull in another icon from FA, but it appears the one we
>> currently use for "inline delete" is customised from the original.  Does
>> anyone know who made these changes and how?
>> No idea sorry.
>>
>
> I had hoped the person "git blame" showed was reading this list... oh well
>
> --
> C
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers  (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/56DEAC33.1090600%40tinbrain.net
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMwjO1EQT7UkgqcxoT2DN21a%3DB9FMTFcKLLzFVyKo6iTT611rg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Admin hstore widget

2016-03-08 Thread Curtis Maloney



On 08/03/16 20:47, Marc Tamlyn wrote:

Doing something better with the admin hstore is definitely something I'd
like to see land.

1. I'd like more input on the features people feel are essential.
Something that allows you to add/change/delete keys is all you need to
start with. Features like soft delete can be added later.


OK, well, I'll pare down the code and make a PR soon.


2. Is there a guide somewhere to styles and markup to be used in admin
templates?
No, in short. Keep it simple seems to be the best advice I can give -
most of the code is very old.


So nobody understands the HTML and CSS used in Admin?

Someone must, since there are a few skins for it, and someone just redid 
our skin for 1.9...



3. I plan to pull in another icon from FA, but it appears the one we
currently use for "inline delete" is customised from the original.  Does
anyone know who made these changes and how?
No idea sorry.


I had hoped the person "git blame" showed was reading this list... oh well

--
C

--
You received this message because you are subscribed to the Google Groups "Django 
developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/56DEAC33.1090600%40tinbrain.net.
For more options, visit https://groups.google.com/d/optout.


Re: Admin hstore widget

2016-03-08 Thread Marc Tamlyn
Doing something better with the admin hstore is definitely something I'd
like to see land.

1. I'd like more input on the features people feel are essential.
Something that allows you to add/change/delete keys is all you need to
start with. Features like soft delete can be added later.

2. Is there a guide somewhere to styles and markup to be used in admin
templates?
No, in short. Keep it simple seems to be the best advice I can give - most
of the code is very old.

3. I plan to pull in another icon from FA, but it appears the one we
currently use for "inline delete" is customised from the original.  Does
anyone know who made these changes and how?
No idea sorry.

On 7 March 2016 at 22:57, Josh Smeaton  wrote:

> I wouldn't drop it if I were you. I (think) I watched you demo the hstore
> admin field at melbdjango and it looked cool to me. If I used hstorefield
> I'd be interested in the implementation. The dev ML isn't really indicative
> of the broader django community I feel, because only a small portion of the
> community seem to participate. Deafening silence here may still lead to
> cheers elsewhere once it's available.
>
> If I were you, I'd make a small screencast/gifv of the feature in action,
> reach out to some people that you know are using contrib.postgres (starting
> with Marc), and explicitly solicit their feedback on usefulness. If you
> still don't feel there is a real desire to have in core, could you release
> it as a 3rd party project? If it requires hooks in core to support custom
> fields then push those changes through separately.
>
> My 2c :)
>
> On Tuesday, 8 March 2016 08:18:59 UTC+11, Curtis Maloney wrote:
>>
>>
>>
>> On 08/03/16 02:43, Tim Graham wrote:
>> > 1. Merging something minimal always help to get feature requests. :-)
>>
>>
>>
>> > 2. Could you be more specific about what you're looking for? All the
>> > existing documentation for style related stuff is at
>> >
>> https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/.
>>
>> > I also thought of ticket https://code.djangoproject.com/ticket/14831.
>>
>> This is no way covers the HTML or CSS structures used in admin.
>>
>> Given the deafening roar of absolutely no interest in this feature, I
>> guess I'll drop it.
>>
>> --
>> C
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/f6144212-cdde-4729-9d42-3d79397079ed%40googlegroups.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMwjO1Gboz0crk9gGV%3DO%2BW%2BxoHy4BvfR%3DjqDUXGE-9k8B%2B3OVA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Admin hstore widget

2016-03-07 Thread Josh Smeaton
I wouldn't drop it if I were you. I (think) I watched you demo the hstore 
admin field at melbdjango and it looked cool to me. If I used hstorefield 
I'd be interested in the implementation. The dev ML isn't really indicative 
of the broader django community I feel, because only a small portion of the 
community seem to participate. Deafening silence here may still lead to 
cheers elsewhere once it's available. 

If I were you, I'd make a small screencast/gifv of the feature in action, 
reach out to some people that you know are using contrib.postgres (starting 
with Marc), and explicitly solicit their feedback on usefulness. If you 
still don't feel there is a real desire to have in core, could you release 
it as a 3rd party project? If it requires hooks in core to support custom 
fields then push those changes through separately.

My 2c :)

On Tuesday, 8 March 2016 08:18:59 UTC+11, Curtis Maloney wrote:
>
>
>
> On 08/03/16 02:43, Tim Graham wrote: 
> > 1. Merging something minimal always help to get feature requests. :-) 
>
>
>
> > 2. Could you be more specific about what you're looking for? All the 
> > existing documentation for style related stuff is at 
> > 
> https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/.
>  
>
> > I also thought of ticket https://code.djangoproject.com/ticket/14831. 
>
> This is no way covers the HTML or CSS structures used in admin. 
>
> Given the deafening roar of absolutely no interest in this feature, I 
> guess I'll drop it. 
>
> -- 
> C 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/f6144212-cdde-4729-9d42-3d79397079ed%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Admin hstore widget

2016-03-07 Thread Curtis Maloney



On 08/03/16 02:43, Tim Graham wrote:

1. Merging something minimal always help to get feature requests. :-)





2. Could you be more specific about what you're looking for? All the
existing documentation for style related stuff is at
https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/.
I also thought of ticket https://code.djangoproject.com/ticket/14831.


This is no way covers the HTML or CSS structures used in admin.

Given the deafening roar of absolutely no interest in this feature, I 
guess I'll drop it.


--
C

--
You received this message because you are subscribed to the Google Groups "Django 
developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/56DDF031.10803%40tinbrain.net.
For more options, visit https://groups.google.com/d/optout.


Re: Admin hstore widget

2016-03-07 Thread Tim Graham
1. Merging something minimal always help to get feature requests. :-)

2. Could you be more specific about what you're looking for? All the 
existing documentation for style related stuff is at 
https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/.
 
I also thought of ticket https://code.djangoproject.com/ticket/14831. 

3. GitHub alias "elky" did the new admin look for 1.9: 
https://github.com/elky/django-flat-theme. I didn't verify the edits came 
in from that change, but what does "git blame" say?

On Sunday, February 7, 2016 at 6:11:46 PM UTC-5, Curtis Maloney wrote:
>
> So, I've been working on https://code.djangoproject.com/ticket/25197 
>
> I have it as part of my own project, with a view to contributing to core 
> once it's polished. 
>
> Currently it has basic functionality - a JS widget that fires on load, 
> hides the textarea, and produces a table of (name, value, actions). 
>
> It records original values for existing keys, so you can "undo" your 
> changes.  And I'm just adding detection of duplicate keys. 
>
> I also hope to add a "soft delete" so you can mark a key for deletion, 
> instead of immediately discarding it... 
>
> However, I've run into two problems: 
>
> 1. I'd like more input on the features people feel are essential. 
>
> 2. Is there a guide somewhere to styles and markup to be used in admin 
> templates? 
>
> 3. I plan to pull in another icon from FA, but it appears the one we 
> currently use for "inline delete" is customised from the original.  Does 
> anyone know who made these changes and how? 
>
> -- 
> Curtis 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/f34888a2-d0cd-49be-837f-7036e16be97b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.