Re: [Django] #27299: Document Widget.use_required_attribute()

2016-10-26 Thread Django
#27299: Document Widget.use_required_attribute()
-+-
 Reporter:  Tim Graham   |Owner:  Jon
 Type:   |  Dufresne
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jon Dufresne ):

 In [changeset:"dda9a5928a565648ca604cde066c253db8871370" dda9a592]:
 {{{
 #!CommitTicketReference repository=""
 revision="dda9a5928a565648ca604cde066c253db8871370"
 [1.10.x] Fixed #27299 -- Documented the Widget.use_required_attribute()
 method.

 Thanks Tim Graham for the review and edits.

 Backport of c74378b from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.94cdfa9b1652ccbf2860e4ed2a8b41eb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27299: Document Widget.use_required_attribute()

2016-10-26 Thread Django
#27299: Document Widget.use_required_attribute()
-+-
 Reporter:  Tim Graham   |Owner:  Jon
 Type:   |  Dufresne
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jon Dufresne ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c74378bb77db5bbeac1bd48c0cd31154f96a81d6" c74378b]:
 {{{
 #!CommitTicketReference repository=""
 revision="c74378bb77db5bbeac1bd48c0cd31154f96a81d6"
 Fixed #27299 -- Documented the Widget.use_required_attribute() method.

 Thanks Tim Graham for the review and edits.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1d908ea3e331cb91b220b894e8184b89%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField

2016-10-26 Thread Django
#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Malik A. Rumi):

 Replying to [comment:1 Tim Graham]:
 > `OneToOneField` is a subclass of `ForeignKey`, so as far as I see,
 
[https://github.com/django/django/blob/f734e2d4b2fc4391a4d097b80357724815c1d414/django/contrib/admin/checks.py#L399-L406
 a system check error] will occur. I guess the error message could be
 clarified since it confused you.
 >
 > As far as getting answers to usage questions goes, please
 [wiki:TicketClosingReasons/UseSupportChannels].

 Ok. Thx.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6d6d5a02aded239a4ce5da38812814f5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27328: return `Set-Cookie` if sessionid= None value

2016-10-26 Thread Django
#27328: return `Set-Cookie` if sessionid=  None value
-+-
 Reporter:  Ramin Farajpour  |Owner:  nobody
  Cami   |
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.sessions |  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ramin Farajpour Cami):

 Replying to [comment:35 Tim Graham]:
 > It seems like there's no use case where the current behavior causes a
 problem -- it only happens when someone is tampering with
 `document.cookie`. Is that correct?

 there is many idea on projecs django for use javascript `document.cookie`
 this is a example :

 {{{
 function Language() {
 if (getCookie('language') == 'EN') {
 document.getElementById('btn').innerHTML = getCookie('language');
 }
 }

 function setCookie(sName, sValue, oExpires, sPath, sDomain, bSecure) {
 var sCookie = sessionid+ "=" +'test';
 sCookie += "; expires=" + 'test';
 sCookie += "; path=" + 'path';
 sCookie += "; domain=" + 'domains';
 document.cookie = sCookie;
 }
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c2e5698e669d607c5f249b75964aaa1a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #27392: Remove "Tests that", "Ensures that", etc. from test docstings

2016-10-26 Thread Django
#27392: Remove "Tests that", "Ensures that", etc. from test docstings
+
   Reporter:  Tim Graham|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Documentation |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 Our policy is for test docstrings to state the expected behavior that each
 test demonstrates. Preambles such as "Tests that" or "Ensures that" aren't
 necessary.

 Good: "Horizontal and vertical filter widgets keep selected options on
 page reload."
 Bad: "Tests that horizontal and vertical...".

 For example:

 $ grep -rI "Tests that" * | wc -l
 158
 $ grep -rI "Test that" * | wc -l
 222
 $ grep -rI "Ensure that" * | wc -l
 173
 $ grep -rI "Ensures that" * | wc -l
 14

 If you spot any other similar patterns, please correct them. The policy
 should also be added to `docs/internals/contributing/writing-code/coding-
 style.txt`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.24e96db0c67243ea91185e03b04fc352%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27391: Support unittest.TestCase.debug() method

2016-10-26 Thread Django
#27391: Support unittest.TestCase.debug() method
-+-
 Reporter:  Pavel Savchenko  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  unittest | Triage Stage:  Accepted
  SimpleTestCase debug   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Adam Chainz):

 * cc: me@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.50953e5161495a0d91a0ad671628fb13%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27391: Support unittest.TestCase.debug() method

2016-10-26 Thread Django
#27391: Support unittest.TestCase.debug() method
-+-
 Reporter:  Pavel Savchenko  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  unittest | Triage Stage:  Accepted
  SimpleTestCase debug   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Pavel Savchenko):

 * has_patch:  0 => 1


Comment:

 Added test case (demonstrating usage expectations) and resolution in
 [https://github.com/django/django/pull/7436 PR 7436]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7e4f30cf91c2c27b4a50a2af6966a44e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27369: Multiple form fields can share the same widget instance

2016-10-26 Thread Django
#27369: Multiple form fields can share the same widget instance
-+-
 Reporter:  Michal Petrucha  |Owner:  Michal
 |  Petrucha
 Type:  Bug  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.40b518d56e10624537bb3ff8fc5720d8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #25619: Make runserver use HTTP 1.1

2016-10-26 Thread Django
#25619: Make runserver use HTTP 1.1
+
 Reporter:  Gerben Morsink  |Owner:  nobody
 Type:  New feature |   Status:  new
Component:  HTTP handling   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+
Changes (by Patrick Cloke):

 * cc: clokep@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.da497061f4614e39ec4098e3420f8f19%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #5897: Add Content-Length header in common middleware

2016-10-26 Thread Django
#5897: Add Content-Length header in common middleware
-+-
 Reporter:  Scott Barr   |Owner:  ccahoon
    |
 Type:  New feature  |   Status:  closed
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  Content-Length   | Triage Stage:  Ready for
  middleware |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Patrick Cloke):

 * cc: clokep@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/098.3ff5bbe4a1e7d72ecf62cf0530ee0037%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #18729: Admin changelist view defaults to `DISTINCT`, unusable on reasonably sized databases

2016-10-26 Thread Django
#18729: Admin changelist view defaults to `DISTINCT`, unusable on reasonably 
sized
databases
-+-
 Reporter:  Henrique C. Alves|Owner:  AlexMalek
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin sql distinct   | Triage Stage:  Accepted
  slow performance   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0


Comment:

 [https://github.com/django/django/pull/7422 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.443580386ff8155f6936096477ecc485%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24128: Admindocs doesn't account for template loaders

2016-10-26 Thread Django
#24128: Admindocs doesn't account for template loaders
---+
 Reporter:  Aymeric Augustin   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admindocs  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Tim Graham):

 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 [https://github.com/django/django/pull/7434 PR] without tests.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6d13e710531dbe2f43cf5ec3440fb028%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27360: Make it easier to track down the offending models for AlreadyRegistered exceptions

2016-10-26 Thread Django
#27360: Make it easier to track down the offending models for AlreadyRegistered
exceptions
-+-
 Reporter:  Ed Morley|Owner:  Quentin
 Type:   |  Fulsher
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.88ddbea1b4524e5fa531a96dee84b853%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27340: Model pre_init signal should provide an `instance` argument

2016-10-26 Thread Django
#27340: Model pre_init signal should provide an `instance` argument
-+-
 Reporter:  Ask Solem Hoel   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ask Solem Hoel):

 lol, you want an example.  Brace yourself, will probably be more difficult
 to understand, but here:

 https://github.com/robinhood/thorn/blob/master/thorn/django/signals.py#L39-L44

 we use the pre)save signal to store a snapshot of how the model looked
 like before it was changed


 With the proposed change we'd be able to avoid doing two database queries
 for every Model.save by doing this:


 @signals.pre_init.connect
 def _track_changes(instance, args, kwargs, **kwargs):
 instance._original_args = args, kwargs

 There's no other way as far as I can find, as we don't want to monkeypatch
 Model, and in any case it's very strange that the pre_init signal omits
 the instance being created.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.cc2d07408b53019f07ed28218b15b8f3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27328: return `Set-Cookie` if sessionid= None value

2016-10-26 Thread Django
#27328: return `Set-Cookie` if sessionid=  None value
-+-
 Reporter:  Ramin Farajpour  |Owner:  nobody
  Cami   |
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.sessions |  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 It seems like there's no use case where the current behavior causes a
 problem -- it only happens when someone is tampering with
 `document.cookie`. Is that correct?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.563e8edd1c00e98f41b89ce8e3253149%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #25809: PostgreSQL 9.5 BRIN Index support in contrib.postgres

2016-10-26 Thread Django
#25809: PostgreSQL 9.5 BRIN Index support in contrib.postgres
-+-
 Reporter:  Asif Saifuddin Auvi  |Owner:  Mads
 |  Jensen
 Type:  New feature  |   Status:  assigned
Component:  contrib.postgres |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  postgres, index, | Triage Stage:  Accepted
  BRIN   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mads Jensen):

 * owner:  (none) => Mads Jensen
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.af4461e2287962095bf6b1cd71544de1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27328: return `Set-Cookie` if sessionid= None value

2016-10-26 Thread Django
#27328: return `Set-Cookie` if sessionid=  None value
-+-
 Reporter:  Ramin Farajpour  |Owner:  nobody
  Cami   |
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.sessions |  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ramin Farajpour Cami):

 Hi Collin,

 because easy access to browser cookies . Transparently creates a "vitual
 cookie jar" for storing many "virtual cookies" (key-value pairs) in one
 actual cookie,

 i show to you with step 2 `sessionid=''` cookie does not expire, in
 different path browser,

 i think you should see this for help togather :

 https://drive.google.com/file/d/0B0zktfkIvV-
 LVWRscmpTSVRFQVk/view?usp=sharing

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5df61515e1d3e2b81dc5b674bd12aee9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField (was: Prepopulated Fields in Django Admin)

2016-10-26 Thread Django
#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * easy:  0 => 1
 * needs_docs:   => 0
 * type:  Bug => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 `OneToOneField` is a subclass of `ForeignKey`, so as far as I see,
 
[https://github.com/django/django/blob/f734e2d4b2fc4391a4d097b80357724815c1d414/django/contrib/admin/checks.py#L399-L406
 a system check error] will occur. I guess the error message could be
 clarified since it confused you.

 As far as getting answers to usage questions goes, please
 [wiki:TicketClosingReasons/UseSupportChannels].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.50ccc9a4f07ad40d6939da0d24d5fc2c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27380: Add the 'raw' argument with the 'm2m_changed' signal

2016-10-26 Thread Django
#27380: Add the 'raw' argument with the 'm2m_changed' signal
-+-
 Reporter:  Élie Bouttier|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.eae6deaecc41d7336a0e95da7846e823%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27334: File uploads could rename temporary files rather than copying them

2016-10-26 Thread Django
#27334: File uploads could rename temporary files rather than copying them
-+-
 Reporter:  Adam Chidlow |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  File |  Version:  1.10
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  FileField,   | Triage Stage:  Accepted
  TemporaryUploadedFile  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f734e2d4b2fc4391a4d097b80357724815c1d414" f734e2d]:
 {{{
 #!CommitTicketReference repository=""
 revision="f734e2d4b2fc4391a4d097b80357724815c1d414"
 Fixed #27334 -- Allowed FileField to move rather than copy a file.

 When a FileField is set to an instance of File that is not also an
 instance of FieldFile, pre_save() passes that object as the contents to
 Storage.save(). This allows the file to be moved rather than copied
 to the upload destination.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4519de5d746bf5cb72ee8e5d27423a1e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27328: return `Set-Cookie` if sessionid= None value

2016-10-26 Thread Django
#27328: return `Set-Cookie` if sessionid=  None value
-+-
 Reporter:  Ramin Farajpour  |Owner:  nobody
  Cami   |
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.sessions |  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Collin Anderson):

 Why are you doing step 2 at all? This doesn't seem necessary or helpful to
 me: `document.cookie="sessionid="`

 "set sessionid on cookie success from request" - That will happen in any
 case, you don't need to pre-set the cookie.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.7862efd8ee7ca28c5572b52aa268a432%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24128: Admindocs doesn't account for template loaders

2016-10-26 Thread Django
#24128: Admindocs doesn't account for template loaders
---+
 Reporter:  Aymeric Augustin   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admindocs  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Kris Avi):

 * cc: Kris Avi (added)


Comment:

 It seems it is quite fixable with something like that:

 That is probably not the most elegant solution. Tried to get loaders from
 all the engines and combine their location directories into one to send to
 enumerator.

 {{{
 ...
 pass
 else:
 # This doesn't account for template loaders (#24128).

 # Fix for #24128
 from django.template import engines
 directories = set(default_engine.dirs)#
 making set with default engine dirs parameter as initial set
 for engine in engines.all():  #
 going through all the engines
 for loader in engine.engine.template_loaders: #
 getting each template loader from engine
 directories.update(loader.get_dirs()) #
 updating set with new directories from loaders

 for index, directory in enumerate(directories):   #
 new enumerator with all dirs from default and loaders
 # for index, directory in enumerate(default_engine.dirs): #
 commented out original enumerator
 # End of fix for #24128
 template_file = os.path.join(directory, template)
 templates.append({
 ...
 }}}

 instead of

 {{{
 ...
 pass
 else:
 # This doesn't account for template loaders (#24128).
 for index, directory in enumerate(default_engine.dirs):
 template_file = os.path.join(directory, template)
 templates.append({
 ...
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.481bdf00b3c9592868265e7d09b40f11%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #25966: Implement get_user_model() that can be used in models.py

2016-10-26 Thread Django
#25966: Implement get_user_model() that can be used in models.py
+
 Reporter:  Marten Kenbeek  |Owner:  nobody
 Type:  New feature |   Status:  new
Component:  contrib.auth|  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ad27ce8da98662745c4b05a8d7f54c2c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27391: Support unittest.TestCase.debug() method

2016-10-26 Thread Django
#27391: Support unittest.TestCase.debug() method
-+-
 Reporter:  Pavel Savchenko  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  unittest | Triage Stage:  Accepted
  SimpleTestCase debug   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b5a8d53be8a6577b8f81e95dd39a378b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27391: Support unittest.TestCase.debug() method

2016-10-26 Thread Django
#27391: Support unittest.TestCase.debug() method
-+-
 Reporter:  Pavel Savchenko  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  unittest | Triage Stage:  Accepted
  SimpleTestCase debug   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Pavel Savchenko):

 As for other test runners, here's now nose2 invokes a debugger (IIRC
 pytest does something similar):
 https://github.com/nose-
 devs/nose2/blob/master/nose2/plugins/debugger.py#L41-L60

 This means that the `post_mortem` is invoked only after the exception was
 already caught in `SimpleTestCase.__call__` and, for example, the database
 was already rolled back. The test frameworks simple have no real way to
 examine the state of the application at the time of the error (but only
 "after", when it may be too late).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.87c76ff1b349f7a6c23581517f15e934%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27391: Support unittest.TestCase.debug() method

2016-10-26 Thread Django
#27391: Support unittest.TestCase.debug() method
-+-
 Reporter:  Pavel Savchenko  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  unittest | Triage Stage:
  SimpleTestCase debug   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Pavel Savchenko):

 Well, not that I know of yet, but basically, any test runner that allows
 unittests may assume "debug" can be used for exception debugging; and
 right now this cannot be done without issues when using Django's
 SimpleTestCase derivatives.

 Regardless, the patch should be fairly simple 10 line method and I can
 submit that. It's invoking the test that I'm having trouble with, how to
 invoke "debug" as part of the regular test suite...

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8435e2e1499f7245ed7b7b0bf0083cc5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27391: Support unittest.TestCase.debug() method

2016-10-26 Thread Django
#27391: Support unittest.TestCase.debug() method
-+-
 Reporter:  Pavel Savchenko  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  unittest | Triage Stage:
  SimpleTestCase debug   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * component:  Uncategorized => Testing framework
 * needs_better_patch:   => 0
 * type:  Uncategorized => New feature
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Would this have benefit outside of the usage of third-party test runners
 such as `pytest`? If so, what does it look like?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.455d86f6e593c7cc50abd50d15d7276c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #27391: Support unittest.TestCase.debug() method

2016-10-26 Thread Django
#27391: Support unittest.TestCase.debug() method
---+---
 Reporter:  Pavel  |  Owner:  nobody
  Savchenko|
 Type:  Uncategorized  | Status:  new
Component:  Uncategorized  |Version:  1.10
 Severity:  Normal |   Keywords:  unittest SimpleTestCase debug
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+---
 == Introduction ==

 The documentation for
 [https://docs.python.org/2/library/unittest.html#unittest.TestCase.debug
 unittest.TestCase.debug] states that invoking it would:

   Run the test without collecting the result. This allows exceptions
 raised by the test to be propagated to the caller, and can be used to
 support running tests under a debugger.

 In essence, `debug()` invokes the test method same as
 [https://docs.python.org/2/library/unittest.html#unittest.TestCase.run
 TestCase.run()] does, without the added functionality of catching
 exceptions and related cruft.

 == Side effects ==

 A recent change in pytest (see references below) brought to our attention
 the fact that Django does not implement a `debug` method, and performs
 important stuff in `TestCase.__call__` (besides calling `run()`), such as
 calling `_pre_startup` and `_post_teardown` methods.

 Thus, since debug() is unimplemented, running debug on a django TestCase
 (for example for debugging purposes), results unintended behavior, such as
 certain methods not being called. Most importantly `_fixture_callback` and
 `_fixture_teardown` which also perform database rollback (or call
 `flush`).

 References:
 https://github.com/pytest-dev/pytest/pull/1890
 https://github.com/pytest-dev/pytest/issues/1932
 https://github.com/pytest-dev/pytest-django/pull/406
 https://github.com/python/cpython/blob/master/Lib/unittest/case.py#L651-L658

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.c750974c71dcb0056b5724673eedbab0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27389: Cannot use QueryDict without configuring settings first

2016-10-26 Thread Django
#27389: Cannot use QueryDict without configuring settings first
-+-
 Reporter:  Jaap Roes|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jaap Roes):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 No real use case. I was just trying to use the QueryDict in simple quick
 (throwaway) python script and was surprised it didn't work standalone.

 I'll resolve it as wontfix because I cannot be bothered to write a patch
 ;-)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.df173f8ffb1742622b3e276a95e6c6d1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27389: Cannot use QueryDict without configuring settings first

2016-10-26 Thread Django
#27389: Cannot use QueryDict without configuring settings first
-+-
 Reporter:  Jaap Roes|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 We probably need a use case also.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6a9f418dbf4ab2e0a90c15e7713f2a1b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27389: Cannot use QueryDict without configuring settings first

2016-10-26 Thread Django
#27389: Cannot use QueryDict without configuring settings first
-+-
 Reporter:  Jaap Roes|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I guess it's a question of how much effort it will take and if it's
 possible to write tests.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.906bb64d407b3efa177fdd86a9e0e118%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27299: Document Widget.use_required_attribute()

2016-10-26 Thread Django
#27299: Document Widget.use_required_attribute()
-+-
 Reporter:  Tim Graham   |Owner:  Jon
 Type:   |  Dufresne
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a775daabc7a4a3e78a77139a818ed0f3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26401: Allow auth machinery to be used without installing auth app

2016-10-26 Thread Django
#26401: Allow auth machinery to be used without installing auth app
--+-
 Reporter:  Matt Johnson  |Owner:  Andrew Konoff
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:  auth  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+-
Changes (by Tim Graham):

 * keywords:  auth 1.11 => auth
 * has_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.745c265d9adaf22982bbde3927fe83ae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27390: need modify `runtest.py` parts of the document

2016-10-26 Thread Django
#27390: need modify `runtest.py` parts of the document
---+--
 Reporter:  Jeho, Sung |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:  invalid
 Keywords:  runtest.py | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Jeho, Sung):

 Replying to [comment:1 Tim Graham]:
 > Based on the error, it looks like you missed this step: `pip install -e
 /path/to/your/local/clone/django/`.

 yes, there are several solutions. but- nothing on document.
 check document and follow that sequence.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.3e672321f156eeb29af1b24625dc97a9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27390: need modify `runtest.py` parts of the document

2016-10-26 Thread Django
#27390: need modify `runtest.py` parts of the document
---+--
 Reporter:  Jeho, Sung |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:  invalid
 Keywords:  runtest.py | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Tim Graham):

 * status:  new => closed
 * needs_better_patch:   => 0
 * resolution:   => invalid
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Based on the error, it looks like you missed this step: `pip install -e
 /path/to/your/local/clone/django/`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.5001a03a6eb6c7324e890bf3a2743279%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #13327: FileField/ImageField accessor methods throw unnecessary exceptions when they are blank or null.

2016-10-26 Thread Django
#13327: FileField/ImageField accessor methods throw unnecessary exceptions when
they are blank or null.
-+-
 Reporter:  kevin.howerton@… |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  1.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Elias Nygren):

 **Some workarounds:**

 The model property:

 {{{
 @property
 def image_url(self):
 if self.image and hasattr(self.image, 'url'):
 return self.image.url
 }}}

 The Template if (bad, breaks DRY):


 {{{
 {% if person.image %}
 
 {% endif %}
 }}}

 The check (bad, breaks DRY):


 {{{
 person.profile_pic.url if person.profile_pic else ''
 }}}

 **IMHO all of the above are quite horrible compared to if we could just
 fix the root problem:**

 django/db/models/fields/files.py

 {{{
 def _require_file(self):
 if not self:
 raise ValueError("The '%s' attribute has no file associated
 with it." % self.field.name)

 @property
 def url(self):
 self._require_file()
 return self.storage.url(self.name)
 }}}

 with something equivalent to (not a working fix):

 {{{
 @property
 def url(self):
 if self:  # only pass to storage.url if there is a file
 return self.storage.url(self.name)
 return None # (or empty string?)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/082.06164c4735d892902fd77bf0e9fbd5e5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #27390: need modify `runtest.py` parts of the document

2016-10-26 Thread Django
#27390: need modify `runtest.py` parts of the document
---+
 Reporter:  Jeho, Sung |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  Documentation  |Version:  master
 Severity:  Normal |   Keywords:  runtest.py
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 see `intro/contributing/#running-django-s-test-suite-for-the-first-time`

 > Now we are ready to run the test suite. If you’re using GNU/Linux, Mac
 OS X or some other flavor of Unix, run:
 > $ ./runtests.py

 If follow this command, then you'll see:

 {{{
 (django-devel) jehos@class:/tmp/django/tests⟫ ./runtests.py
 Traceback (most recent call last):
   File "./runtests.py", line 22, in 
 from django.utils.deprecation import (
 ImportError: cannot import name 'RemovedInDjango21Warning'
 }}}

 It should be changed as follows.

 `$ PYTHONPATH=..:$PYTHONPATH ./runtests.py`

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.17a1a5fdd91718219be97c60d920cee2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27386: Readonly callable field is unconditionally wrapped inside ..., which might create invalid HTML

2016-10-26 Thread Django
#27386: Readonly callable field is unconditionally wrapped inside ..., 
which
might create invalid HTML
-+-
 Reporter:  Jacob Rief   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  callable field   | Triage Stage:  Accepted
  is_readonly |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jacob Rief):

 Yes, changing this could add a minor backwards compatibility problem;
 something probably not really noticeable and if, easy to fix.

 I looked at the code. We presumably should add another tag to
 ``django.contrib.admin.helpers.AdminReadonlyField.__init__`` named
 ``is_callable`` which is ``True`` for callable fields. Then in the
 templates, we'd have to add another ``{% if field.is_callable %}`` and
 only wrap the content inside ``..`` it that's false.

 If this proposal is accepted, I will implement it right now.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.178c6adb29e4332ef328c4fd944301a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27362: Omitting default_app_config in __init__.py happens too easily.

2016-10-26 Thread Django
#27362: Omitting default_app_config in __init__.py happens too easily.
-+-
 Reporter:  Thomas Güttler   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  1.10
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Thomas Güttler):

 We use this test to unsure that the same error does happen again:

 {{{

 def test_app_config_registered(self):
 for app_config in apps.get_app_configs():
 if not app_config.__module__=='django.apps.config':
 # This app has an own AppConfig class registered: ok
 continue
 apps_module_path='%s.apps' % app_config.name
 try:
 import_module(apps_module_path)
 except ImportError:
 # No module called "apps": ok
 continue
 raise AssertionError('%s exists, but the registry
 (apps.get_app_configs()) contains the base class. Please use dotted python
 path to AppConfig in INSTALLED_APPS or use default_app_config in
 __init__.py' %
  (apps_module_path))

 }}}

 I  guess this can't be integrated into django.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4b3d4cfc7dd16d150054ff07cb0498ff%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #27389: Cannot use QueryDict without configuring settings first

2016-10-26 Thread Django
#27389: Cannot use QueryDict without configuring settings first
--+
 Reporter:  Jaap Roes |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  HTTP handling |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 This is not really a bug, but I was surprised by this behaviour:

 {{{
 >>> from django.http import QueryDict
 >>> q = QueryDict('a=1=2=3=4=5')
 Traceback (most recent call last):
   File "", line 1, in 
   File "/path/to/lib/python3.4/site-packages/django/http/request.py", line
 377, in __init__
 encoding = settings.DEFAULT_CHARSET
   File "/path/to/lib/python3.4/site-packages/django/conf/__init__.py",
 line 53, in __getattr__
 self._setup(name)
   File "/path/to/lib/python3.4/site-packages/django/conf/__init__.py",
 line 39, in _setup
 % (desc, ENVIRONMENT_VARIABLE))
 django.core.exceptions.ImproperlyConfigured: Requested setting
 DEFAULT_CHARSET, but settings are not configured. You must either define
 the environment variable DJANGO_SETTINGS_MODULE or call
 settings.configure() before accessing settings.
 }}}

 The `QueryDict` implementation relies on two Django settings
 `DEFAULT_CHARSET` and `DATA_UPLOAD_MAX_NUMBER_FIELDS`, both have sane
 defaults (`'utf-8'` and `1000`) and are probably rarely overruled in user
 settings. Would it be acceptable to just use these values if settings
 aren't configured?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.c777e5dec8b8ff8d64a57b7099647b47%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.