Re: [Django] #18485: Document behavior of PostgreSQL/Oracle when manually setting autoincrementing fields

[Django]

#18485: Document behavior of PostgreSQL/Oracle when manually setting
autoincrementing fields
-+-
 Reporter:  greg.nicholas@…  |Owner:  François
 Type:   |  Freitag
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql oracle| Triage Stage:  Accepted
  autofield  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by François Freitag):

 * owner:  nobody => François Freitag
 * status:  new => assigned
 * has_patch:  0 => 1
 * version:  1.4 => master


Comment:

 [https://github.com/django/django/pull/8652 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/081.cc4d23bec60706084b17975938fb6595%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25809: PostgreSQL 9.5 BRIN Index support in contrib.postgres

[Django]

#25809: PostgreSQL 9.5 BRIN Index support in contrib.postgres
-+-
 Reporter:  Asif Saifuddin Auvi  |Owner:  Mads
 |  Jensen
 Type:  New feature  |   Status:  closed
Component:  contrib.postgres |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  postgres, index, | Triage Stage:  Ready for
  BRIN, db-indexes   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"d1d73480019fc3754b335878be07f00b5321a065" d1d7348]:
 {{{
 #!CommitTicketReference repository=""
 revision="d1d73480019fc3754b335878be07f00b5321a065"
 Refs #25809 -- Removed BrinIndex.__repr__().

 In retrospect, implementing a __repr__() for index subclasses doesn't
 seem worthwhile.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9d61f84ea6c081e40e01e12caf48dab6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28176: Expose real (i.e. not converted to string) value in widget option context

[Django]

#28176: Expose real (i.e. not converted to string) value in widget option 
context
+
 Reporter:  Moritz Sichert  |Owner:  nobody
 Type:  New feature |   Status:  closed
Component:  Forms   |  Version:  master
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"221e6e18177516ac4ac95e40c344b93d14dd607b" 221e6e1]:
 {{{
 #!CommitTicketReference repository=""
 revision="221e6e18177516ac4ac95e40c344b93d14dd607b"
 Fixed #28176 -- Restored the uncasted option value in ChoiceWidget
 template context.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.dbd8a98ff6784ba3a64ff5445d9f707e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28176: Expose real (i.e. not converted to string) value in widget option context

[Django]

#28176: Expose real (i.e. not converted to string) value in widget option 
context
+
 Reporter:  Moritz Sichert  |Owner:  nobody
 Type:  New feature |   Status:  closed
Component:  Forms   |  Version:  master
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by Tim Graham ):

 In [changeset:"a3b1319d5863600981e71fbaa452d7104715a9e7" a3b1319]:
 {{{
 #!CommitTicketReference repository=""
 revision="a3b1319d5863600981e71fbaa452d7104715a9e7"
 [1.11.x] Fixed #28176 -- Restored the uncasted option value in
 ChoiceWidget template context.

 Backport of 221e6e18177516ac4ac95e40c344b93d14dd607b from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.1103dfe6faeb3267405b7576dbe15282%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28320: Parallel testing: Please implement a signal or call checks after test DB creation but before cloning it.

[Django]

#28320: Parallel testing: Please implement a signal or call checks after test DB
creation but before cloning it.
-+-
 Reporter:  László Károlyi   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Testing framework|  Version:  1.11
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by László Károlyi):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Replying to [comment:2 Tim Graham]:
 > Can we close this ticket then?

 I think so, yes. Thx, closing.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.37c8353e9a7df37b19d39360fdfff7bc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28305: AlterField migration tries to alter column that still has a foreign key contraint

[Django]

#28305: AlterField migration tries to alter column that still has a foreign key
contraint
-+-
 Reporter:  Andreas Backx|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:  mysql,   | Triage Stage:  Accepted
  onetoonefield, utf8mb4, foreign|
  key|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.ed8dece5828d18c4a5d923906ea7da17%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28320: Parallel testing: Please implement a signal or call checks after test DB creation but before cloning it.

[Django]

#28320: Parallel testing: Please implement a signal or call checks after test DB
creation but before cloning it.
-+-
 Reporter:  László Károlyi   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Testing framework|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 #15610 and #16281 might be related to the contenttypes issue. Can we close
 this ticket then? If there's some issue with contenttypes, it's likely
 more clear to open a separate ticket about that.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0319f14575a7b7ed18bb3b67d892dfda%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27745: Improve code coverage for django/contrib/contenttypes

[Django]

#27745: Improve code coverage for django/contrib/contenttypes
--+
 Reporter:  Anton Samarchyan  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  contrib.contenttypes  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 If needed, code coverage can be improved further without a ticket.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0a56d3476af60ca6b0558994aef69a30%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25530: Deferred SQL operations fail when a referenced table or column is renamed or deleted during the same migration

[Django]

#25530: Deferred SQL operations fail when a referenced table or column is 
renamed
or deleted during the same migration
-+-
 Reporter:  Simon Philips|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.4cdb6f182f67df416fc4493527b95a02%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28303: IntegerField & NumberInput widget localize max_value when rendering form field

[Django]

#28303: IntegerField & NumberInput widget localize max_value when rendering form
field
-+
 Reporter:  Richard Owen |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.11
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Tim Graham ):

 In [changeset:"f0ec88fb63f39db38ab027477167f9d7a7ea151c" f0ec88fb]:
 {{{
 #!CommitTicketReference repository=""
 revision="f0ec88fb63f39db38ab027477167f9d7a7ea151c"
 [1.11.x] Fixed #28303 -- Prevented localization of attribute values in the
 DTL attrs.html widget template.

 Backport of 3b050fd0d0b8dbf499bdb44ce12fa926298c0bd0 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.0b8b30744552d5aea688327556607d7f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25530: Deferred SQL operations fail when a referenced table or column is renamed or deleted during the same migration

[Django]

#25530: Deferred SQL operations fail when a referenced table or column is 
renamed
or deleted during the same migration
---+--
 Reporter:  Simon Philips  |Owner:  Simon Charette
 Type:  Bug|   Status:  assigned
Component:  Migrations |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Simon Charette):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.56cdc87b6f111de5faafd40cb13e6f6b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28320: Parallel testing: Please implement a signal or call checks after test DB creation but before cloning it.

[Django]

#28320: Parallel testing: Please implement a signal or call checks after test DB
creation but before cloning it.
-+-
 Reporter:  László Károlyi   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Testing framework|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by László Károlyi):

 Update:

 It seems I managed to consistently insert the needed data into the DB
 before it gets cloned by subclassing the testrunner and running checks
 before `setup_databases()` runs. But that brought another problem I
 discovered, and which maybe could be fixed.

 So the first part I'm doing at startup is, I update my own permission
 models, which subclass the original django `Permission` model. Formerly, I
 had a function that would give a `ContentType` model of
 `django.contrib.auth`:
 {{{#!python
 def _get_perm_contenttype(app_label: str, model_name: str):
 """
 Return a `ContentType`.
 """
 from django.contrib.contenttypes.models import ContentType
 return ContentType.objects.get_for_model(
 apps.get_model(app_label=app_label, model_name=model_name))
 }}}

 Because `ContentType.objects.get_for_model()` caches, and because the
 nature of the parallel testing, that cached result sometimes brought
 models with wrong `ID`s, and I got constraint violations because no such
 IDs existed in my DB.

 I fixed my code by not using `get_for_model()`, and using `get()` instead.
 I'm just leaving this information here for your consideration.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3f631739ad79b81ae61f4eea61e1b96a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28320: Parallel testing: Please implement a signal or call checks after test DB creation but before cloning it.

[Django]

#28320: Parallel testing: Please implement a signal or call checks after test DB
creation but before cloning it.
+
   Reporter:  László Károlyi|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Testing framework |Version:  1.11
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Hi,

 I tried to reach someone on IRC, but actually it's better to document my
 issue here, maybe there will be a solution to it eventually.

 I'm trying to use the new and shiny parallel testing functionality of
 Django 1.11, and I've run into problems with it.

 So I have functionality implemented on `check` and the `post_migrate`
 signal, where I conditionally insert stuff into the DB that can't be
 inserted by fixtures, and also conditionally modify DB fields that can't
 be done from the ORM. (the latter is basically changing collation on a
 column)

 It seems that the post_migrate signal is run randomly before and after the
 test creation, and checks are only run *after* the DB is cloned, so I
 don't have a sufficient point where I can have my logic run.

 Monkey-patching has shown that the best solution would be to run
 `call_command('check')`
 [https://github.com/django/django/blob/master/django/test/utils.py#L178
 here], so basically after `create_test_db` but before `clone_test_db`.

 I can quickly add that, but I'm not sure how it could be tested, and what
 implications it would have, so I'm asking you guys, if you think it's
 doable and feasible. Because of this right now, I can't use parallel
 testing.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.43e6a76188c3a571f14b5ebeac6ad931%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28316: ModelChoiceField with to_field_name doesn't select an option when editing

[Django]

#28316: ModelChoiceField with to_field_name doesn't select an option when 
editing
+
 Reporter:  László Károlyi  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Forms   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by Tim Graham):

 We don't want unrelated whitespace changes in a patch.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e273063fa2644322cfa60a9dd0215ee9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28316: ModelChoiceField with to_field_name doesn't select an option when editing

[Django]

#28316: ModelChoiceField with to_field_name doesn't select an option when 
editing
+
 Reporter:  László Károlyi  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Forms   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by László Károlyi):

 Replying to [comment:5 Tim Graham]:
 > Yes, I'll have to examine that solution in more detail but I would say
 that's more on the right track.
 >
 > The test can probably be more minimal as in
 81963b37a92ef583b9f725f1a78dd2ca97c1ab95 -- check `BoundField.value()`
 rather than rendered HTML.
 >
 > Please rebase your branch so that the unrelated commits don't appear and
 revert the unrelated blank line changes that I presume your IDE is making.

 OK, I'll get that done in the upcoming days. Are the new lines such a big
 problem? It's PEP8 enforced by Anaconda/ST3.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.fa21fd3e4daf70067e199e903ed57bdc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28316: ModelChoiceField with to_field_name doesn't select an option when editing

[Django]

#28316: ModelChoiceField with to_field_name doesn't select an option when 
editing
+
 Reporter:  László Károlyi  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Forms   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by Tim Graham):

 Yes, I'll have to examine that solution in more detail but I would say
 that's more on the right track.

 The test can probably be more minimal as in
 81963b37a92ef583b9f725f1a78dd2ca97c1ab95 -- check `BoundField.value()`
 rather than rendered HTML.

 Please rebase your branch so that the unrelated commits don't appear and
 revert the unrelated blank line changes that I presume your IDE is making.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.78c85153d2a74db17cd698933381447f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28316: ModelChoiceField with to_field_name doesn't select an option when editing

[Django]

#28316: ModelChoiceField with to_field_name doesn't select an option when 
editing
+
 Reporter:  László Károlyi  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Forms   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by László Károlyi):

 Replying to [comment:3 Tim Graham]:
 > You might look at #17657 which was a fix for `to_field_name` and
 `ModelMultipleChoiceField`. In that case, I think
 `ModelMultipleChoiceField._check_values()` is doing the conversion from
 initial pk values to `to_field_name` values. A proper fix most likely lies
 in `ModelChoiceField` rather than `BoundField`; the latter shouldn't have
 knowledge of specific fields.

 Just took a look at it, it's doing basically the same what I implemented
 in `ModelChoiceField.value()`.

 For me it really doesn't matter where the underlying logic is, as long as
 it works. Do you want me to uncomment the logic in `ModelChoiceField` and
 update the pull request?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3ebe8ce566cf9f955ab4a09c0183b3b7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28316: ModelChoiceField with to_field_name doesn't select an option when editing (was: ModelChoiceField with to_field_name fails to render a widget properly)

[Django]

#28316: ModelChoiceField with to_field_name doesn't select an option when 
editing
+
 Reporter:  László Károlyi  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Forms   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 You might look at #17657 which was a fix for `to_field_name` and
 `ModelMultipleChoiceField`. In that case, I think
 `ModelMultipleChoiceField._check_values()` is doing the conversion from
 initial pk values to `to_field_name` values. A proper fix most likely lies
 in `ModelChoiceField` rather than `BoundField`; the latter shouldn't have
 knowledge of specific fields.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2da14ef6c6f4617227167b9b901bdd23%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28319: Make TextField with choices use a Select widget

[Django]

#28319: Make TextField with choices use a Select widget
-+-
 Reporter:  Maciej Jaworski  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"dc63ad7ac09ef694f19ae1d7496367614889e6fd" dc63ad7a]:
 {{{
 #!CommitTicketReference repository=""
 revision="dc63ad7ac09ef694f19ae1d7496367614889e6fd"
 Fixed #28319 -- Made TextField with choices use a Select widget.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.85adf149820235589a1d008383cc5cb4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28309: Migration bug in related_name for ManyToManyField with self

[Django]

#28309: Migration bug in related_name for ManyToManyField with self
-+-
 Reporter:  Ahmed Mohamed|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  1.11
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  ManyToManyField  | Triage Stage:
  self   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => needsinfo


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.dd39cec36eccb2a66b294277ea0336df%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28319: Make TextField with choices use a Select widget (was: TextField form widget is being overridden when choices are specified.)

[Django]

#28319: Make TextField with choices use a Select widget
-+-
 Reporter:  Maciej Jaworski  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * component:  Database layer (models, ORM) => Forms
 * stage:  Unreviewed => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9c3954f45e46cf51797ba81912fa5f0c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28303: IntegerField & NumberInput widget localize max_value when rendering form field

[Django]

#28303: IntegerField & NumberInput widget localize max_value when rendering form
field
-+
 Reporter:  Richard Owen |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.11
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by GitHub ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"3b050fd0d0b8dbf499bdb44ce12fa926298c0bd0" 3b050fd]:
 {{{
 #!CommitTicketReference repository=""
 revision="3b050fd0d0b8dbf499bdb44ce12fa926298c0bd0"
 Fixed #28303 -- Prevented localization of attribute values in the DTL
 attrs.html widget template.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.3e55072acdad064ae836009ea5764945%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28319: TextField form widget is being overridden when choices are specified.

[Django]

#28319: TextField form widget is being overridden when choices are specified.
-+-
   Reporter:  Maciej |  Owner:  nobody
  Jaworski   |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  master
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  1
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
 When choices are specified on the field the form widget should be the
 select one, for TextField some code overrides it to TextArea.

 I've created a PR with a fix:
 https://github.com/django/django/pull/8633

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.b47a59bf1848009c6a270c646a1bc8db%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.